Attention is currently required from: osmith, arehbein, laforge.

Patch set 2:Code-Review -1

View Change

1 comment:

• File include/osmocom/gsm/protocol/gsm_12_21.h:

  • Patch Set #2, Line 294: enum abis_nm_par_defaults {

    it makes no sense to have this as enums, because they are not different types of the same thing nor need to have different values (as you can see below, values are repeated).
    Please use defines here.

    BTW, I guess all these default values come from specs (TS 12.21?) because if they don't come from some spec reference, they have no place here, since it would actually be some implementation specific value of each app that we chose.

To view, visit change 31877. To unsubscribe, or for help writing mail filters, visit settings.