September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: obs: don't print verbose output twice on error

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29429 ) Change subject: obs: don't print verbose output twice on error ...................................................................... obs: don't print verbose output twice on error When running in verbose mode, it's enough that the output is displayed while the command is running. Don't print it again on error. Change-Id: I4fcf2421a6f82bd94ba098b39f58e5d3f18aa8fd --- M scripts/obs/lib/__init__.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/obs/lib/__init__.py b/scripts/obs/lib/__init__.py index d66aa3b..58fe0e4 100644 --- a/scripts/obs/lib/__init__.py +++ b/scripts/obs/lib/__init__.py @@ -88,12 +88,17 @@ def exit_error_cmd(completed, error_msg): """ :param completed: return from run_cmd() below """ + global cmds_verbose + print() print(f"ERROR: {error_msg}") print() print(f"*** command ***\n{completed.args}\n") print(f"*** returncode ***\n{completed.returncode}\n") - print(f"*** output ***\n{completed.output}") + + if not cmds_verbose: + print(f"*** output ***\n{completed.output}") + print("*** python trace ***") raise RuntimeError("shell command related error, find details right above" " this python trace") -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4fcf2421a6f82bd94ba098b39f58e5d3f18aa8fd Gerrit-Change-Number: 29429 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: lib.run_cmd: set stdin to subprocess.DEVNULL

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29433 ) Change subject: obs: lib.run_cmd: set stdin to subprocess.DEVNULL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7e893101c2a3e7b005659ec72aa44fa932b7ccd9 Gerrit-Change-Number: 29433 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 14:17:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: update_obs_project: check if oscrc exists

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29430 ) Change subject: obs: update_obs_project: check if oscrc exists ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6f140b2c1d171d3019fd259399e6a46da9c6451f Gerrit-Change-Number: 29430 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 14:17:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: don't print verbose output twice on error

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29429 ) Change subject: obs: don't print verbose output twice on error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4fcf2421a6f82bd94ba098b39f58e5d3f18aa8fd Gerrit-Change-Number: 29429 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 14:17:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: lib.run_cmd: set stdin to subprocess.DEVNULL

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29433 ) Change subject: obs: lib.run_cmd: set stdin to subprocess.DEVNULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7e893101c2a3e7b005659ec72aa44fa932b7ccd9 Gerrit-Change-Number: 29433 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:59:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp v...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29431 ) Change subject: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp variant ...................................................................... ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp variant Similar to what's done in BTS_Tests and REMSIM_Tests Change-Id: Iee69774ae8885ab216d0d707ee5fd0269a438c83 --- M ttcn3-hnbgw-test/jenkins.sh M ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/ttcn3-hnbgw-test/jenkins.sh b/ttcn3-hnbgw-test/jenkins.sh index 83cca1f..10bb428 100755 --- a/ttcn3-hnbgw-test/jenkins.sh +++ b/ttcn3-hnbgw-test/jenkins.sh @@ -77,4 +77,4 @@ run_tests "$VOL_BASE_DIR_PFCP" "with-pfcp/HNBGW_Tests.cfg" "osmo-stp.cfg" "with-pfcp/osmo-hnbgw.cfg" # Make jenkins results show ':with-pfcp': append ':with-pfcp' to the jenkins results classnames sed -i "s/classname='$[^']\+$'/classname='\1:with-pfcp'/g" \ - $VOL_BASE_DIR_PFCP/hnbgw-tester/junit-xml-*.log + $VOL_BASE_DIR_PFCP/hnbgw-tester/junit-xml-with-pfcp-*.log diff --git a/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg b/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg index d3ea553..96609c2 100644 --- a/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg +++ b/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg @@ -7,6 +7,7 @@ # Local configuration below [LOGGING] +*.JUnitLogger.filename_stem := "junit-xml-with-pfcp" [TESTPORT_PARAMETERS] *.HNBGWVTY.CTRL_HOSTNAME := "172.18.35.20" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iee69774ae8885ab216d0d707ee5fd0269a438c83 Gerrit-Change-Number: 29431 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-hnbgw: sed junit file in the clean_up trap

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29432 ) Change subject: ttcn3-hnbgw: sed junit file in the clean_up trap ...................................................................... ttcn3-hnbgw: sed junit file in the clean_up trap Same as done in BTS_Tests. This makes sure the files are always properly updated even if something goes wrong (such as docker kill failing to stop hnbgw because it exited earlier due to unsupported feature). Change-Id: Iac3bd9cf3448e18930dcef6c9ae4b6530939ffe6 --- M ttcn3-hnbgw-test/jenkins.sh 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/ttcn3-hnbgw-test/jenkins.sh b/ttcn3-hnbgw-test/jenkins.sh index 10bb428..8c1ddf5 100755 --- a/ttcn3-hnbgw-test/jenkins.sh +++ b/ttcn3-hnbgw-test/jenkins.sh @@ -10,6 +10,15 @@ set_clean_up_trap set -e +VOL_BASE_DIR_PFCP="$VOL_BASE_DIR/with-pfcp" +clean_up() { + # append ':with-pfcp' to the classnames, + # e.g. "classname='HNBGW_Tests'" => "classname='HNBGW_Tests:with-pfcp'" + # so the with-pfcp test cases would not interfere without pfcp ones in Jenkins + sed -i "s/classname='$[^']\+$'/classname='\1:with-pfcp'/g" \ + $VOL_BASE_DIR_PFCP/hnbgw-tester/junit-xml-with-pfcp-*.log +} + SUBNET=35 network_create $SUBNET @@ -72,9 +81,5 @@ run_tests "$VOL_BASE_DIR" "HNBGW_Tests.cfg" "osmo-stp.cfg" "osmo-hnbgw.cfg" echo Testing with PFCP -VOL_BASE_DIR_PFCP="$VOL_BASE_DIR/with-pfcp" mkdir "$VOL_BASE_DIR_PFCP" run_tests "$VOL_BASE_DIR_PFCP" "with-pfcp/HNBGW_Tests.cfg" "osmo-stp.cfg" "with-pfcp/osmo-hnbgw.cfg" -# Make jenkins results show ':with-pfcp': append ':with-pfcp' to the jenkins results classnames -sed -i "s/classname='$[^']\+$'/classname='\1:with-pfcp'/g" \ - $VOL_BASE_DIR_PFCP/hnbgw-tester/junit-xml-with-pfcp-*.log -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iac3bd9cf3448e18930dcef6c9ae4b6530939ffe6 Gerrit-Change-Number: 29432 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-hnbgw: sed junit file in the clean_up trap

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29432 ) Change subject: ttcn3-hnbgw: sed junit file in the clean_up trap ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iac3bd9cf3448e18930dcef6c9ae4b6530939ffe6 Gerrit-Change-Number: 29432 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:57:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp v...

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29431 ) Change subject: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp variant ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iee69774ae8885ab216d0d707ee5fd0269a438c83 Gerrit-Change-Number: 29431 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:57:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: lib.run_cmd: set stdin to subprocess.DEVNULL

by msuraev

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29433 ) Change subject: obs: lib.run_cmd: set stdin to subprocess.DEVNULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7e893101c2a3e7b005659ec72aa44fa932b7ccd9 Gerrit-Change-Number: 29433 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:53:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022