Attention is currently required from: osmith, pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29426 )
Change subject: scripts/obs/*.py: log name of function calling command
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
> Agree with osmith, it's probsably more interesting file+line.
Well, function name was good enough for me to grokk the code. Feel free to add me as reviewer if you'd like to send a patch on top of this adding file:number.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29426
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: If4ccc0eb44da4ea743f3858b09c762ee6a138f1d
Gerrit-Change-Number: 29426
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Sep 2022 12:08:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29428 )
Change subject: scripts/obs/*.py: add option to ignore required programs check
......................................................................
Patch Set 1:
(1 comment)
File scripts/obs/lib/__init__.py:
https://gerrit.osmocom.org/c/osmo-ci/+/29428/comment/3d0ab55b_cef408c5
PS1, Line 36: parser.add_argument("-i", "--ignore-req", action="store_true",
> don't you need to se a default to false here?
Nope, argparse is smart enough to figure out that smth which isn't true is false.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29428
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I8b5eaedab87b586fb1ca4c22746be4dfbb3c2176
Gerrit-Change-Number: 29428
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Sep 2022 12:00:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29431 )
Change subject: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp variant
......................................................................
ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp variant
Similar to what's done in BTS_Tests and REMSIM_Tests
Change-Id: Iee69774ae8885ab216d0d707ee5fd0269a438c83
---
M ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/31/29431/1
diff --git a/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg b/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg
index d3ea553..96609c2 100644
--- a/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg
+++ b/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg
@@ -7,6 +7,7 @@
# Local configuration below
[LOGGING]
+*.JUnitLogger.filename_stem := "junit-xml-with-pfcp"
[TESTPORT_PARAMETERS]
*.HNBGWVTY.CTRL_HOSTNAME := "172.18.35.20"
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29431
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Iee69774ae8885ab216d0d707ee5fd0269a438c83
Gerrit-Change-Number: 29431
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29428 )
Change subject: scripts/obs/*.py: add option to ignore required programs check
......................................................................
Patch Set 1:
(1 comment)
File scripts/obs/lib/__init__.py:
https://gerrit.osmocom.org/c/osmo-ci/+/29428/comment/2ff3733f_f0941b34
PS1, Line 36: parser.add_argument("-i", "--ignore-req", action="store_true",
don't you need to se a default to false here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29428
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I8b5eaedab87b586fb1ca4c22746be4dfbb3c2176
Gerrit-Change-Number: 29428
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Sep 2022 09:56:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment