September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: obs: don't print verbose output twice on error

by msuraev

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29429 ) Change subject: obs: don't print verbose output twice on error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4fcf2421a6f82bd94ba098b39f58e5d3f18aa8fd Gerrit-Change-Number: 29429 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:52:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: update_obs_project: check if oscrc exists

by msuraev

Attention is currently required from: osmith, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29430 ) Change subject: obs: update_obs_project: check if oscrc exists ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6f140b2c1d171d3019fd259399e6a46da9c6451f Gerrit-Change-Number: 29430 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:49:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: update_obs_project: check if oscrc exists

by osmith

Attention is currently required from: pespin, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29430 ) Change subject: obs: update_obs_project: check if oscrc exists ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Did you think about closing stdin (non interactive shell) when running osc to make sure this doesn't […] good idea. https://gerrit.osmocom.org/c/osmo-ci/+/29433 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6f140b2c1d171d3019fd259399e6a46da9c6451f Gerrit-Change-Number: 29430 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:40:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: obs: lib.run_cmd: set stdin to subprocess.DEVNULL

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29433 ) Change subject: obs: lib.run_cmd: set stdin to subprocess.DEVNULL ...................................................................... obs: lib.run_cmd: set stdin to subprocess.DEVNULL Don't pass stdin to the programs, as we expect them to run non-interactively and also don't show the program's output unless -v is used or the exit code is not 0. Change-Id: I7e893101c2a3e7b005659ec72aa44fa932b7ccd9 --- M scripts/obs/lib/__init__.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/33/29433/1 diff --git a/scripts/obs/lib/__init__.py b/scripts/obs/lib/__init__.py index f2790d0..d494fc6 100644 --- a/scripts/obs/lib/__init__.py +++ b/scripts/obs/lib/__init__.py @@ -117,9 +117,9 @@ print(f"+ {cmd}") with tempfile.TemporaryFile(encoding="utf8", mode="w+") as output_buf: - p = subprocess.Popen(cmd, stdout=subprocess.PIPE, - stderr=subprocess.STDOUT, text=True, bufsize=1, - *args, **kwargs) + p = subprocess.Popen(cmd, stdin=subprocess.DEVNULL, + stdout=subprocess.PIPE, stderr=subprocess.STDOUT, + text=True, bufsize=1, *args, **kwargs) while True: out = p.stdout.read(1) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7e893101c2a3e7b005659ec72aa44fa932b7ccd9 Gerrit-Change-Number: 29433 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-hnbgw: sed junit file in the clean_up trap

by osmith

Attention is currently required from: neels, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29432 ) Change subject: ttcn3-hnbgw: sed junit file in the clean_up trap ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iac3bd9cf3448e18930dcef6c9ae4b6530939ffe6 Gerrit-Change-Number: 29432 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:26:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp v...

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29431 ) Change subject: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp variant ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iee69774ae8885ab216d0d707ee5fd0269a438c83 Gerrit-Change-Number: 29431 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 13:25:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-hnbgw: sed junit file in the clean_up trap

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29432 ) Change subject: ttcn3-hnbgw: sed junit file in the clean_up trap ...................................................................... ttcn3-hnbgw: sed junit file in the clean_up trap Same as done in BTS_Tests. This makes sure the files are always properly updated even if something goes wrong (such as docker kill failing to stop hnbgw because it exited earlier due to unsupported feature). Change-Id: Iac3bd9cf3448e18930dcef6c9ae4b6530939ffe6 --- M ttcn3-hnbgw-test/jenkins.sh 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/32/29432/1 diff --git a/ttcn3-hnbgw-test/jenkins.sh b/ttcn3-hnbgw-test/jenkins.sh index 10bb428..8c1ddf5 100755 --- a/ttcn3-hnbgw-test/jenkins.sh +++ b/ttcn3-hnbgw-test/jenkins.sh @@ -10,6 +10,15 @@ set_clean_up_trap set -e +VOL_BASE_DIR_PFCP="$VOL_BASE_DIR/with-pfcp" +clean_up() { + # append ':with-pfcp' to the classnames, + # e.g. "classname='HNBGW_Tests'" => "classname='HNBGW_Tests:with-pfcp'" + # so the with-pfcp test cases would not interfere without pfcp ones in Jenkins + sed -i "s/classname='$[^']\+$'/classname='\1:with-pfcp'/g" \ + $VOL_BASE_DIR_PFCP/hnbgw-tester/junit-xml-with-pfcp-*.log +} + SUBNET=35 network_create $SUBNET @@ -72,9 +81,5 @@ run_tests "$VOL_BASE_DIR" "HNBGW_Tests.cfg" "osmo-stp.cfg" "osmo-hnbgw.cfg" echo Testing with PFCP -VOL_BASE_DIR_PFCP="$VOL_BASE_DIR/with-pfcp" mkdir "$VOL_BASE_DIR_PFCP" run_tests "$VOL_BASE_DIR_PFCP" "with-pfcp/HNBGW_Tests.cfg" "osmo-stp.cfg" "with-pfcp/osmo-hnbgw.cfg" -# Make jenkins results show ':with-pfcp': append ':with-pfcp' to the jenkins results classnames -sed -i "s/classname='$[^']\+$'/classname='\1:with-pfcp'/g" \ - $VOL_BASE_DIR_PFCP/hnbgw-tester/junit-xml-with-pfcp-*.log -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iac3bd9cf3448e18930dcef6c9ae4b6530939ffe6 Gerrit-Change-Number: 29432 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp v...

by pespin

Attention is currently required from: pespin, fixeria. Hello Jenkins Builder, neels, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/29431 to look at the new patch set (#2). Change subject: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp variant ...................................................................... ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp variant Similar to what's done in BTS_Tests and REMSIM_Tests Change-Id: Iee69774ae8885ab216d0d707ee5fd0269a438c83 --- M ttcn3-hnbgw-test/jenkins.sh M ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/31/29431/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iee69774ae8885ab216d0d707ee5fd0269a438c83 Gerrit-Change-Number: 29431 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp v...

by neels

Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29431 ) Change subject: ttcn3-hnbgw: Set different junit xml file name prefix for with-pfcp variant ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: i deemed it not necessary since that file is in a different subdir -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iee69774ae8885ab216d0d707ee5fd0269a438c83 Gerrit-Change-Number: 29431 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 12:32:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: scripts/obs/*.py: log name of function calling command

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29426 ) Change subject: scripts/obs/*.py: log name of function calling command ...................................................................... scripts/obs/*.py: log name of function calling command Change-Id: If4ccc0eb44da4ea743f3858b09c762ee6a138f1d --- M scripts/obs/lib/__init__.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/obs/lib/__init__.py b/scripts/obs/lib/__init__.py index a07a072..d66aa3b 100644 --- a/scripts/obs/lib/__init__.py +++ b/scripts/obs/lib/__init__.py @@ -7,6 +7,7 @@ import subprocess import sys import tempfile +import inspect import lib.config cmds_verbose = False @@ -108,8 +109,9 @@ :param check: stop with error if exit code is not 0 """ global cmds_verbose + caller = inspect.stack()[2][3] if cmds_verbose: - print(f"+ {cmd}") + print(f"+ {caller}(): {cmd}") with tempfile.TemporaryFile(encoding="utf8", mode="w+") as output_buf: p = subprocess.Popen(cmd, stdout=subprocess.PIPE, -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If4ccc0eb44da4ea743f3858b09c762ee6a138f1d Gerrit-Change-Number: 29426 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022