August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-pfcp[master]: rpm spec: use --disable-static

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 ) Change subject: rpm spec: use --disable-static ...................................................................... rpm spec: use --disable-static Follow what we are doing in other Osmocom rpm packaging by not building and packaging static libraries. Fix for rpmlint errors when building for OpenSUSE: libosmo-gtlv-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/libosmo-gtlv.a libosmo-pfcp-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/libosmo-pfcp.a libosmo-gtlv-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-gtlv.a libosmo-pfcp-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-pfcp.a (If we wanted to build with static libraries, we would need to use -ffat-lto-objects to get rid of the second error.) Related: https://github.com/rpm-software-management/rpmlint/issues/458 Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 --- M contrib/libosmo-pfcp.spec.in 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index 4ef2607..e47d52c 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -72,6 +72,7 @@ echo "%{version}" >.tarball-version autoreconf -fi %configure \ + --disable-static \ --includedir="%_includedir/%name" make %{?_smp_mflags} @@ -95,7 +96,6 @@ %dir %{_includedir}/%{name}/osmocom %{_includedir}/%{name}/osmocom/gtlv %{_libdir}/libosmo-gtlv.so -%{_libdir}/libosmo-gtlv.a %{_libdir}/pkgconfig/libosmo-gtlv.pc %files -n libosmo-pfcp0 @@ -106,7 +106,6 @@ %dir %{_includedir}/%{name}/osmocom %{_includedir}/%{name}/osmocom/pfcp %{_libdir}/libosmo-pfcp.so -%{_libdir}/libosmo-pfcp.a %{_libdir}/pkgconfig/libosmo-pfcp.pc %changelog -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 Gerrit-Change-Number: 29183 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 12 months

1
0
0 0

Change in libosmo-pfcp[master]: debian/control: move -dev deps of libosmo-gtlv-dev

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 ) Change subject: debian/control: move -dev deps of libosmo-gtlv-dev ...................................................................... debian/control: move -dev deps of libosmo-gtlv-dev Only the -dev package of libosmo-gtlv should depend on other -dev packages. Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a --- M debian/control 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian/control b/debian/control index c5d9f04..1d4822d 100644 --- a/debian/control +++ b/debian/control @@ -33,8 +33,6 @@ Multi-Arch: same Depends: ${shlibs:Depends}, ${misc:Depends}, - libosmocore-dev (>= 1.7.0), - libtalloc-dev (>= 2.1.0) Pre-Depends: ${misc:Pre-Depends} Description: Generic TLV and TLIV protocol support Decoding, encoding and logging of protocols using a Tag-Length-Value and/or @@ -45,7 +43,9 @@ Multi-Arch: same Section: libdevel Depends: ${misc:Depends}, - libosmo-gtlv0 (= ${binary:Version}) + libosmo-gtlv0 (= ${binary:Version}), + libosmocore-dev (>= 1.7.0), + libtalloc-dev (>= 2.1.0) Description: Development files for libosmo-gtlv libosmo-gtlv implements decoding, encoding and logging of protocols using a Tag-Length-Value and/or Tag-Length-Instance-Value structure. This package in -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a Gerrit-Change-Number: 29184 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 12 months

1
0
0 0

Change in libosmo-pfcp[master]: Bump version: 0.1.0.32-823b → 0.1.1

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 ) Change subject: Bump version: 0.1.0.32-823b → 0.1.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I9a7be8342754fdbc21b83281c8ebcbf38112c61b Gerrit-Change-Number: 29186 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:16:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 12 months

1
0
0 0

Change in libosmo-pfcp[master]: packaging: depend on libosmocore >= 1.7.0

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 ) Change subject: packaging: depend on libosmocore >= 1.7.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I701f1aacca22a697f35aba0041a71945c5aea107 Gerrit-Change-Number: 29185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:16:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 12 months

1
0
0 0

Change in libosmo-pfcp[master]: debian/control: move -dev deps of libosmo-gtlv-dev

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 ) Change subject: debian/control: move -dev deps of libosmo-gtlv-dev ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a Gerrit-Change-Number: 29184 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:16:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 12 months

1
0
0 0

Change in libosmo-pfcp[master]: rpm spec: use --disable-static

by laforge

Attention is currently required from: osmith, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 ) Change subject: rpm spec: use --disable-static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 Gerrit-Change-Number: 29183 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 12 months

1
0
0 0

Change in libosmo-sccp[master]: examples: update vty code

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29192 ) Change subject: examples: update vty code ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I52d0823b7843aa61594e728a0fac19d884ff78fe Gerrit-Change-Number: 29192 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 22 Aug 2022 12:57:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 12 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by fixeria

Attention is currently required from: laforge, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 ) Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... Patch Set 4: (2 comments) File src/sccp_helpers.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/7bd459e0_73374d29 PS4, Line 196: int osmo_sccp_tx_disconn_data(struct osmo_sccp_user *scu, uint32_t conn_id, Weird misalignment, still. https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/e7f6f5d4_df4ac46f PS4, Line 230: int osmo_sccp_tx_disconn(struct osmo_sccp_user *scu, uint32_t conn_id, Weird misalignment, still. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:52:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 12 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by msuraev

Attention is currently required from: laforge, fixeria. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 to look at the new patch set (#4). Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... SIGTRAN: add osmo_sccp_tx_disconn_data() helper SCCP RLSD message might have up to 130 bytes of optional data according to ITU-T Rec Q.713 §4.5 - add helper which allows sending it and use it in example code. Related: OS#5579 Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe --- M examples/sccp_test_vty.c M include/osmocom/sigtran/sccp_helpers.h M src/sccp_helpers.c 3 files changed, 24 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/70/29170/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 12 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add osmo_sccp_tx_disconn_data() helper

by msuraev

Attention is currently required from: laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 ) Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ...................................................................... Patch Set 3: (4 comments) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/3246d21f_86c3c4d5 PS1, Line 97: > I would expect it to be aligned to the opening brace, and it looks like you intended to do so. […] Done File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/02318179_c4a28f71 PS2, Line 97: [DATA] > You forgot to add documentation an optional parameter: […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/f0e77100_09142d00 PS2, Line 103: argv[1] > Is argv[1] guaranteed to be NULL if argc < 2? There might be garbage left in the argv[] buffer, so I […] Indeed. Actually, I think it's better to skip the data variable altogether - see next revision. I don't see any use for hex input: so far only the presence of data and the amount of it were important for testing - actual content was irrelevant. File include/osmocom/sigtran/sccp_helpers.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/0b2c5208_cd72b691 PS2, Line 48: > Really weird alignment making it rather harder to read. Tab-size should be 8. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe Gerrit-Change-Number: 29170 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:46:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 12 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022