August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence

by msuraev

Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 13: (1 comment) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/20129f38_044df09b PS12, Line 459: osmo_sccp_conn_id_exists > My suggestion is to expose conn_find_by_id() and use it to check connection existence, instead of ad […] I don't see any advantage in doing that: even if we expose that function it would still be more convenient to write the wrapper returning bool. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-hnbgw in openSUSE_Factory_ARM/aarch64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnbgw Last lines of build log: [ 188s] Provides: config(osmo-hnbgw) = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw(aarch-64) = 1.3.0.17.9f65.202208220052-1.1 [ 188s] Requires(interp): /bin/sh /bin/sh /bin/sh /bin/sh [ 188s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 188s] Requires(pre): /bin/sh systemd [ 188s] Requires(post): /bin/sh systemd [ 188s] Requires(preun): /bin/sh systemd [ 188s] Requires(postun): /bin/sh systemd [ 188s] Requires: ld-linux-aarch64.so.1()(64bit) ld-linux-aarch64.so.1(GLIBC_2.17)(64bit) libasn1c.so.1()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.17)(64bit) libc.so.6(GLIBC_2.34)(64bit) libosmo-hnbap.so.0()(64bit) libosmo-mgcp-client.so.9()(64bit) libosmo-ranap.so.5()(64bit) libosmo-rua.so.0()(64bit) libosmo-sigtran.so.7()(64bit) libosmocore.so.19()(64bit) libosmoctrl.so.0()(64bit) libosmoctrl.so.0(LIBOSMOCTRL_1.0)(64bit) libosmogsm.so.18()(64bit) libosmogsm.so.18(LIBOSMOGSM_1.0)(64bit) libosmonetif.so.8()(64bit) libosmovty.so.9()(64bit) libtalloc.so.2()(64bit) libtalloc.so.2(TALLOC_2.0.2)(64bit) [ 188s] Processing files: osmo-hnbgw-debugsource-1.3.0.17.9f65.202208220052-1.1.aarch64 [ 188s] Provides: osmo-hnbgw-debugsource = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw-debugsource(aarch-64) = 1.3.0.17.9f65.202208220052-1.1 [ 188s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 188s] Processing files: osmo-hnbgw-debuginfo-1.3.0.17.9f65.202208220052-1.1.aarch64 [ 188s] Provides: debuginfo(build-id) = e41e57058c79b1512cd026207640bee3207f84b5 osmo-hnbgw-debuginfo = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw-debuginfo(aarch-64) = 1.3.0.17.9f65.202208220052-1.1 [ 188s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 188s] Recommends: osmo-hnbgw-debugsource(aarch-64) = 1.3.0.17.9f65.202208220052-1.1 [ 188s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/abuild/rpmbuild/BUILDROOT/osmo-hnbgw-1.3.0.17.9f65.202208220052-1.1.aarch64 [ 189s] error: Installed (but unpackaged) file(s) found: [ 189s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 189s] [ 189s] RPM build errors: [ 189s] Installed (but unpackaged) file(s) found: [ 189s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 189s] ### VM INTERACTION START ### [ 189s] [ 167.311829][ T1] sysrq: Power Off [ 189s] [ 167.327099][ T16] reboot: Power down [ 189s] ### VM INTERACTION END ### [ 189s] [ 189s] obs-arm-2 failed "build osmo-hnbgw.spec" at Mon Aug 22 12:24:16 UTC 2022. [ 189s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-hnbgw in openSUSE_Factory_ARM/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnbgw Last lines of build log: [ 38s] Provides: config(osmo-hnbgw) = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw(armv7hl-32) = 1.3.0.17.9f65.202208220052-1.1 [ 38s] Requires(interp): /bin/sh /bin/sh /bin/sh /bin/sh [ 38s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 38s] Requires(pre): /bin/sh systemd [ 38s] Requires(post): /bin/sh systemd [ 38s] Requires(preun): /bin/sh systemd [ 38s] Requires(postun): /bin/sh systemd [ 38s] Requires: ld-linux-armhf.so.3 ld-linux-armhf.so.3(GLIBC_2.4) libasn1c.so.1 libc.so.6 libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.5) libosmo-hnbap.so.0 libosmo-mgcp-client.so.9 libosmo-ranap.so.5 libosmo-rua.so.0 libosmo-sigtran.so.7 libosmocore.so.19 libosmoctrl.so.0 libosmoctrl.so.0(LIBOSMOCTRL_1.0) libosmogsm.so.18 libosmogsm.so.18(LIBOSMOGSM_1.0) libosmonetif.so.8 libosmovty.so.9 libtalloc.so.2 libtalloc.so.2(TALLOC_2.0.2) [ 38s] Processing files: osmo-hnbgw-debugsource-1.3.0.17.9f65.202208220052-1.1.armv7hl [ 38s] Provides: osmo-hnbgw-debugsource = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw-debugsource(armv7hl-32) = 1.3.0.17.9f65.202208220052-1.1 [ 38s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 38s] Processing files: osmo-hnbgw-debuginfo-1.3.0.17.9f65.202208220052-1.1.armv7hl [ 38s] Provides: debuginfo(build-id) = 1d94497fa2e26986f4911c151f87795480c31177 osmo-hnbgw-debuginfo = 1.3.0.17.9f65.202208220052-1.1 osmo-hnbgw-debuginfo(armv7hl-32) = 1.3.0.17.9f65.202208220052-1.1 [ 38s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 38s] Recommends: osmo-hnbgw-debugsource(armv7hl-32) = 1.3.0.17.9f65.202208220052-1.1 [ 38s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/abuild/rpmbuild/BUILDROOT/osmo-hnbgw-1.3.0.17.9f65.202208220052-1.1.arm [ 38s] error: Installed (but unpackaged) file(s) found: [ 38s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 38s] [ 38s] RPM build errors: [ 38s] Installed (but unpackaged) file(s) found: [ 38s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 38s] ### VM INTERACTION START ### [ 38s] [ 32.825060][ T1] sysrq: Power Off [ 38s] [ 32.844010][ T232] reboot: Power down [ 38s] ### VM INTERACTION END ### [ 38s] [ 38s] obs-arm-10 failed "build osmo-hnbgw.spec" at Mon Aug 22 12:19:24 UTC 2022. [ 38s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: don't advance FSM on failed connection request

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29167 ) Change subject: SIGTRAN: don't advance FSM on failed connection request ...................................................................... SIGTRAN: don't advance FSM on failed connection request Return proper error code from packet encoding routine and check for it before switching FSM state as it creates confusing mismatch with actual protocol state. Related: OS#5579 Change-Id: I8431c77632014e2551d1da779afddffcd1bb541c --- M src/sccp_scoc.c 1 file changed, 14 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index c209bd7..b85eeb9 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -46,6 +46,7 @@ * * use of multiple Routing Contexts in SUA case */ +#include <errno.h> #include <string.h> #include <osmocom/core/utils.h> @@ -687,7 +688,9 @@ return NULL; } -/* generate xua_msg, encode it and send it to SCRC */ +/* generate xua_msg, encode it and send it to SCRC + * returns 0 on success, negative on error + */ static int xua_gen_encode_and_send(struct sccp_connection *conn, uint32_t event, const struct osmo_scu_prim *prim, int msg_type) { @@ -695,7 +698,7 @@ xua = xua_gen_msg_co(conn, event, prim, msg_type); if (!xua) - return -1; + return -ENOMEM; /* amend this with point code information; Many CO msgs * includes neither called nor calling party address! */ @@ -817,6 +820,7 @@ struct osmo_scu_prim *prim = NULL; struct osmo_scu_connect_param *uconp; struct xua_msg *xua = NULL; + int rc; switch (event) { case SCOC_E_SCU_N_CONN_REQ: @@ -827,10 +831,14 @@ conn->calling_addr = uconp->calling_addr; conn->sccp_class = uconp->sccp_class; /* generate + send CR PDU to SCRC */ - xua_gen_encode_and_send(conn, event, prim, SUA_CO_CORE); - /* start connection timer */ - conn_start_connect_timer(conn); - osmo_fsm_inst_state_chg(fi, S_CONN_PEND_OUT, 0, 0); + rc = xua_gen_encode_and_send(conn, event, prim, SUA_CO_CORE); + if (rc < 0) + LOGPFSML(fi, LOGL_ERROR, "Failed to initiate connection: %s\n", strerror(-rc)); + else { + /* start connection timer */ + conn_start_connect_timer(conn); + osmo_fsm_inst_state_chg(fi, S_CONN_PEND_OUT, 0, 0); + } break; #if 0 case SCOC_E_SCU_N_TYPE1_REQ: 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8431c77632014e2551d1da779afddffcd1bb541c Gerrit-Change-Number: 29167 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: rpm spec: add osmo-hnbgw-pfcp.cfg

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29187 ) Change subject: rpm spec: add osmo-hnbgw-pfcp.cfg ...................................................................... rpm spec: add osmo-hnbgw-pfcp.cfg Fix for: Installed (but unpackaged) file(s) found: /usr/share/doc/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg Related: OS#5654 Change-Id: Ia05323a627719a7fff7c232aa3e5cc8766f9a8e1 --- M contrib/osmo-hnbgw.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/contrib/osmo-hnbgw.spec.in b/contrib/osmo-hnbgw.spec.in index 4bc8807..a4379fa 100644 --- a/contrib/osmo-hnbgw.spec.in +++ b/contrib/osmo-hnbgw.spec.in @@ -90,6 +90,7 @@ %dir %{_docdir}/%{name}/examples %dir %{_docdir}/%{name}/examples/osmo-hnbgw %{_docdir}/%{name}/examples/osmo-hnbgw/osmo-hnbgw.cfg +%{_docdir}/%{name}/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg %dir %{_sysconfdir}/osmocom %config(noreplace) %{_sysconfdir}/osmocom/osmo-hnbgw.cfg %{_unitdir}/%{name}.service -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia05323a627719a7fff7c232aa3e5cc8766f9a8e1 Gerrit-Change-Number: 29187 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: rpm spec: add osmo-hnbgw-pfcp.cfg

by fixeria

Attention is currently required from: osmith, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29187 ) Change subject: rpm spec: add osmo-hnbgw-pfcp.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia05323a627719a7fff7c232aa3e5cc8766f9a8e1 Gerrit-Change-Number: 29187 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:13:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmo-deps.sh: use osmo_git_clone_url

by fixeria

Attention is currently required from: osmith, neels, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29191 ) Change subject: scripts/osmo-deps.sh: use osmo_git_clone_url ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I700d608ff74eca3981ed41f04ee9ced9629436aa Gerrit-Change-Number: 29191 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:11:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: Cosmetic: verify new projects on OBS first

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29190 ) Change subject: obs: Cosmetic: verify new projects on OBS first ...................................................................... obs: Cosmetic: verify new projects on OBS first Related: OS#5654 Change-Id: I4a2ebf65de09e08cf3883ae4de9e7e8c952c2182 --- M scripts/obs/lib/config.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 56f1c61..bb8955d 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -37,6 +37,9 @@ # Osmocom projects: generated source packages will depend on a meta package, # such as osmocom-nightly, osmocom-latest or osmocom-2022q1. This meta package # prevents that packages from different feeds are mixed by accident. +# NOTE: Before adding new projects, make sure the rpm and deb build in OBS! +# Test it in your own namespace (home:youruser), see README for +# instructions and/or ask osmith for help. projects_osmocom = [ "erlang/osmo_dia2gsup", "libasn1c", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a2ebf65de09e08cf3883ae4de9e7e8c952c2182 Gerrit-Change-Number: 29190 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: disable osmo-upf

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29189 ) Change subject: obs: disable osmo-upf ...................................................................... obs: disable osmo-upf Deb and rpm packages don't build for osmo-upf so disable it again until it is fixed. Related: OS#5655, OS#5654 Change-Id: Idf18159b786c51154fda9b40758b08a8656fc215 --- M scripts/obs/lib/config.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 947b722..56f1c61 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -74,7 +74,6 @@ "osmo-sysmon", "osmo-trx", "osmo-uecups", - "osmo-upf", "python/osmo-python-tests", "rtl-sdr", "simtrace2", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf18159b786c51154fda9b40758b08a8656fc215 Gerrit-Change-Number: 29189 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence

by fixeria

Attention is currently required from: neels, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 13: (1 comment) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/f2c78d41_63a4c598 PS12, Line 459: osmo_sccp_conn_id_exists > I'm sorry but I've completely lost track of your though in here. […] My suggestion is to expose conn_find_by_id() and use it to check connection existence, instead of adding this new function. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:09:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022