July 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: group *.c files into 'src' directory

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28543 ) Change subject: trxcon: group *.c files into 'src' directory ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1a3703e48507cd51cd8198f13b993f54c44bc41e Gerrit-Change-Number: 28543 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 19:16:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in simtrace2[master]: host/cardem: fix integer overflow in process_do_rx_da()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/28513 ) Change subject: host/cardem: fix integer overflow in process_do_rx_da() ...................................................................... host/cardem: fix integer overflow in process_do_rx_da() osmo_apdu_segment_in() may return a negative number on receipt of "unknown APDU case", and that would crash simtrace2-cardem-pcsc: msgb(0x55d2cf7aa8a0): Not enough tailroom msgb_put (allocated 920, head at 0, len 7, tailroom 1017 < want tailroom 65534) backtrace() returned 19 addresses Whenever osmo_apdu_segment_in() fails to recognize an APDU, the communication is broken, because we don't know if we should continue transmitting or receiving. Only a successful return value by would allow us to know this. Do not crash, exit() gracefully. Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 Related: OS#5600 --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index 4820f36..374966d 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -167,6 +167,13 @@ rc = osmo_apdu_segment_in(&ac, data->data, data->data_len, data->flags & CEMU_DATA_F_TPDU_HDR); + if (rc < 0) { + /* At this point the communication is broken. We cannot keep running, as we + * don't know if we should continue transmitting or receiving. Only a successful + * return value by osmo_apdu_segment_in() would allow us to know this. */ + LOGCI(ci, LOGL_FATAL, "Failed to recognize APDU, terminating\n"); + exit(1); + } if (rc & APDU_ACT_TX_CAPDU_TO_CARD) { struct msgb *tmsg = msgb_alloc(1024, "TPDU"); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/28513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 Gerrit-Change-Number: 28513 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in simtrace2[master]: host/cardem: fix integer overflow in process_do_rx_da()

by laforge

Attention is currently required from: Hoernchen, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/28513 ) Change subject: host/cardem: fix integer overflow in process_do_rx_da() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/28513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 Gerrit-Change-Number: 28513 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 19:15:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: MGCP_Test: add testcase TC_e1_dlcx_wildcarded

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495 ) Change subject: MGCP_Test: add testcase TC_e1_dlcx_wildcarded ...................................................................... MGCP_Test: add testcase TC_e1_dlcx_wildcarded We are currently testing the behaviour of wildcarded DLCX on the virtual trunk. Lets run a similar test on the E1 trunk as well. Change-Id: I6cfbd24982d1e72206f8237b2eaea52cdaebf9dc Related: OS#5572 --- M mgw/MGCP_Test.ttcn 1 file changed, 64 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 0242db9..6d23c10 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -2404,6 +2404,69 @@ setverdict(pass); } + /* test valid wildcarded DLCX on an E1 trunk */ + testcase TC_e1_dlcx_wildcarded() runs on dummy_CT { + var template MgcpCommand cmd; + var MgcpEndpoint ep; + var MgcpCallId call_id := '8376F297'H; + var integer n_e1_ts := 4; + var StatsDExpects expect; + + f_init(); + + /* Open a few E1 timeslots */ + for (var integer i := 0; i < n_e1_ts; i := i+1) { + ep := "ds/e1-1/s-" & int2str(i+1) & "/su16-0@" & c_mgw_domain; + cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id); + mgcp_transceive_mgw(cmd, tr_CRCX_ACK); + ep := "ds/e1-1/s-" & int2str(i+1) & "/su16-2@" & c_mgw_domain; + cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id); + mgcp_transceive_mgw(cmd, tr_CRCX_ACK); + ep := "ds/e1-1/s-" & int2str(i+1) & "/su16-4@" & c_mgw_domain; + cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id); + mgcp_transceive_mgw(cmd, tr_CRCX_ACK); + ep := "ds/e1-1/s-" & int2str(i+1) & "/su16-6@" & c_mgw_domain; + cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id); + mgcp_transceive_mgw(cmd, tr_CRCX_ACK); + } + + /* Wait until the stats items have seteled and then check if we get the expected number (all) of + * occupied endpoints */ + f_sleep(1.0) + expect := { + { name := "TTCN3.trunk.e1-1.common.endpoints.used", mtype := "g", min := n_e1_ts * 4, max := n_e1_ts * 4} + }; + f_statsd_expect(expect); + + /* Send wildcarded DLCX */ + var template MgcpResponse rtmpl := { + line := { + code := "200", + string := ? + }, + params:= { }, + sdp := omit + }; + ep := "ds/e1-1/*@" & c_mgw_domain; + cmd := ts_DLCX(get_next_trans_id(), ep); + mgcp_transceive_mgw(cmd, rtmpl); + + /* Query a the statsd once to ensure that intermediate results are pulled from the + * pipeline. The second query (below) will return the actual result. */ + expect := { + { name := "TTCN3.trunk.e1-1.common.endpoints.used", mtype := "g", min := 0, max := n_e1_ts * 4} + }; + f_statsd_expect(expect); + + /* The second query must resturn a result with 0 endpoints in use. */ + expect := { + { name := "TTCN3.trunk.e1-1.common.endpoints.used", mtype := "g", min := 0, max := 0} + }; + f_statsd_expect(expect); + + setverdict(pass); + } + /* test valid CRCX then MDCX with IPv4 address, MGW provides a local IPv4 too */ testcase TC_crcx_mdcx_ip4() runs on dummy_CT { var MgcpEndpoint ep := c_mgw_ep_rtpbridge & "2@" & c_mgw_domain; @@ -2803,6 +2866,7 @@ execute(TC_e1_crcx_and_dlcx_ep()); execute(TC_e1_crcx_with_overlap()); execute(TC_e1_crcx_loopback()); + execute(TC_e1_dlcx_wildcarded()); execute(TC_crcx_mdcx_ip4()); execute(TC_crcx_mdcx_ip6()); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cfbd24982d1e72206f8237b2eaea52cdaebf9dc Gerrit-Change-Number: 28495 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_dlcx_wildcarded

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494 ) Change subject: MGCP_Test: fix TC_dlcx_wildcarded ...................................................................... MGCP_Test: fix TC_dlcx_wildcarded When the final condition of the testcase is verified through statsd, there may be still (invalid) data from a previous measurement in the statsd pipeline, querying the stats once before verifying the actual stats fixes the problem. Change-Id: I5fe18e433b32c364778b515ed37fcbcf443b3cb3 Related: OS#5572 --- M mgw/MGCP_Test.ttcn 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 60f955f..0242db9 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1118,8 +1118,14 @@ cmd := ts_DLCX(get_next_trans_id(), ep); mgcp_transceive_mgw(cmd, rtmpl); - /* The second interval must resturn a result with 0 endpoints in use. */ - f_sleep(1.0) + /* Query a the statsd once to ensure that intermediate results are pulled from the + * pipeline. The second query (below) will return the actual result. */ + expect := { + { name := "TTCN3.trunk.virtual-0.common.endpoints.used", mtype := "g", min := 0, max := n_endpoints} + }; + f_statsd_expect(expect); + + /* The second query must resturn a result with 0 endpoints in use. */ expect := { { name := "TTCN3.trunk.virtual-0.common.endpoints.used", mtype := "g", min := 0, max := 0} }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5fe18e433b32c364778b515ed37fcbcf443b3cb3 Gerrit-Change-Number: 28494 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: MGCP_Test: add testcase TC_e1_dlcx_wildcarded

by laforge

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495 ) Change subject: MGCP_Test: add testcase TC_e1_dlcx_wildcarded ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cfbd24982d1e72206f8237b2eaea52cdaebf9dc Gerrit-Change-Number: 28495 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 19:14:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix TC_dlcx_wildcarded

by laforge

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494 ) Change subject: MGCP_Test: fix TC_dlcx_wildcarded ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5fe18e433b32c364778b515ed37fcbcf443b3cb3 Gerrit-Change-Number: 28494 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 19:14:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-trx[master]: contrib/jenkins: don't run "make distcheck" on arm

by laforge

Attention is currently required from: osmith, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28557 ) Change subject: contrib/jenkins: don't run "make distcheck" on arm ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > I am fine with not running `make distcheck` on RPi slaves. […] I also agree the test can be skipped. The 'distcheck' really checks whether or not we have correctly put together our Makefile.am, e.g. added all the include files etc. - this is not really testing anything specific to the host architecture. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28557 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4fbf7d54d479bbdda3c1415493bfc57b37d3971 Gerrit-Change-Number: 28557 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 19:14:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Refactor and split f_cbsp_write()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28541 ) Change subject: cbc: Refactor and split f_cbsp_write() ...................................................................... cbc: Refactor and split f_cbsp_write() Change-Id: I827fad869c6ca5ce80dd39d30c2e3393b2394217 --- M cbc/CBC_Tests.ttcn 1 file changed, 38 insertions(+), 21 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index fe59039..06fda92 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -204,8 +204,41 @@ }; type record of CBS_MessageContent CBS_MessageContents; +private function f_cbsp_tx_write_compl(CBS_Message msg, integer idx := 0, + template (omit) BSSMAP_FIELD_CellIdentificationList tx_cell_list := omit, + template (omit) CBSP_IE_NumBcastComplList tx_compl_list := omit) +runs on test_CT { + var template (value) CBSP_PDU tx; + var template (value) BSSMAP_FIELD_CellIdentificationList tx_list; + if (istemplatekind(tx_cell_list, "omit")) { + /* use the "expected list" when confirming the write-replace */ + tx_list := msg.cell_list; + } else { + /* use an user-provided different list of cells */ + tx_list := valueof(tx_cell_list); + } + if (istemplatekind(tx_compl_list, "omit")) { + tx := ts_CBSP_WRITE_CBS_COMPL(msg.msg_id, msg.ser_nr, tx_list, msg.channel_ind); + } else { + tx := ts_CBSP_REPLACE_CBS_COMPL(msg.msg_id, msg.ser_nr, msg.old_ser_nr, + valueof(tx_compl_list), tx_list, + msg.channel_ind); + } + CBSP[idx].send(ts_CBSP_Send(g_cbsp_conn_id[idx], tx)); +} + +private function f_cbsp_tx_write_fail(CBS_Message msg, integer idx := 0, + template (omit) BSSMAP_FIELD_CellIdentificationList tx_cell_list := omit, + template (omit) CBSP_FailureListItems tx_fail_list := omit) +runs on test_CT { + var template (value) CBSP_PDU tx; + tx := ts_CBSP_WRITE_CBS_FAIL(msg.msg_id, msg.ser_nr, valueof(tx_fail_list), + omit, tx_cell_list, msg.channel_ind); + CBSP[idx].send(ts_CBSP_Send(g_cbsp_conn_id[idx], tx)); +} + /* handle a CBSP-WRITE-REPLACE and respond to it with COMPLETE or FAILURE depending on arguments */ -private function f_cbsp_write(CBS_Message msg, integer idx := 0, +private function f_cbsp_handle_write(CBS_Message msg, integer idx := 0, template (omit) BSSMAP_FIELD_CellIdentificationList tx_cell_list := omit, template (omit) CBSP_FailureListItems tx_fail_list := omit, template (omit) CBSP_IE_NumBcastComplList tx_compl_list := omit) @@ -224,26 +257,10 @@ [] CBSP[idx].receive(tr_CBSP_Recv(g_cbsp_conn_id[idx], rx_templ)) -> value rf { var template (value) CBSP_PDU tx; if (istemplatekind(tx_fail_list, "omit")) { - var template (value) BSSMAP_FIELD_CellIdentificationList tx_list; - if (istemplatekind(tx_cell_list, "omit")) { - /* use the "expected list" when confirming the write-replace */ - tx_list := msg.cell_list; - } else { - /* use an user-provided different list of cells */ - tx_list := valueof(tx_cell_list); - } - if (istemplatekind(tx_compl_list, "omit")) { - tx := ts_CBSP_WRITE_CBS_COMPL(msg.msg_id, msg.ser_nr, tx_list, msg.channel_ind); - } else { - tx := ts_CBSP_REPLACE_CBS_COMPL(msg.msg_id, msg.ser_nr, msg.old_ser_nr, - valueof(tx_compl_list), tx_list, - msg.channel_ind); - } + f_cbsp_tx_write_compl(msg, idx, tx_cell_list, tx_compl_list); } else { - tx := ts_CBSP_WRITE_CBS_FAIL(msg.msg_id, msg.ser_nr, valueof(tx_fail_list), - omit, tx_cell_list, msg.channel_ind); + f_cbsp_tx_write_fail(msg, idx, tx_cell_list, tx_fail_list); } - CBSP[idx].send(ts_CBSP_Send(g_cbsp_conn_id[idx], tx)); } [] as_cbsp_keepalive_ack(idx) { repeat; } [] CBSP[idx].receive { @@ -302,7 +319,7 @@ { '00'O, 1 } } }; - f_cbsp_write(msg); + f_cbsp_handle_write(msg); f_sleep(100.0); f_shutdown_helper(); } @@ -378,7 +395,7 @@ runs on test_CT { var EcbeCbcMessage ecbe := f_cbs2ecbe(msg, "TTCN-3"); f_ecbe_tx_post_cbs(ecbe); - f_cbsp_write(msg, 0, cell_list_success); + f_cbsp_handle_write(msg, 0, cell_list_success); f_ecbe_rx_resp(201); f_sleep(2.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I827fad869c6ca5ce80dd39d30c2e3393b2394217 Gerrit-Change-Number: 28541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in libusrp[master]: gitignore: add /.version

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libusrp/+/28559 ) Change subject: gitignore: add /.version ...................................................................... gitignore: add /.version Change-Id: I40c6fa0760fb76382432256ba1e3b663628dfa0d --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 27ef9d0..576da6d 100644 --- a/.gitignore +++ b/.gitignore @@ -38,3 +38,5 @@ /m4/lt*.m4 contrib/libusrp.spec + +/.version -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/28559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I40c6fa0760fb76382432256ba1e3b663628dfa0d Gerrit-Change-Number: 28559 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022