Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28557 )
Change subject: contrib/jenkins: don't run "make distcheck" on arm
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm not sure we want to merge this. […]
Okay, I don't have a strong opinion here. Let's see what other reviewers say.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ib4fbf7d54d479bbdda3c1415493bfc57b37d3971
Gerrit-Change-Number: 28557
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Jul 2022 12:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28557 )
Change subject: contrib/jenkins: don't run "make distcheck" on arm
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm not sure we want to merge this. Even if it takes time, it still makes sense running that in different architectures imho.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ib4fbf7d54d479bbdda3c1415493bfc57b37d3971
Gerrit-Change-Number: 28557
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Jul 2022 12:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/28557 )
Change subject: contrib/jenkins: don't run "make distcheck" on arm
......................................................................
contrib/jenkins: don't run "make distcheck" on arm
Avoid building osmo-trx a second time on arm during "make distcheck". If
the build of osmo-trx already passed on arm, running "make distcheck"
should give the exact same result as on x86_64.
This should shorten the build time significantly for osmo-trx jobs
running on raspberry pis, currently they take half an hour.
Change-Id: Ib4fbf7d54d479bbdda3c1415493bfc57b37d3971
---
M contrib/jenkins.sh
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/28557/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index bcdcca4..584de07 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -106,8 +106,11 @@
$MAKE $PARALLEL_MAKE
$MAKE check \
|| cat-testlogs.sh
-DISTCHECK_CONFIGURE_FLAGS="$CONFIG" $MAKE $PARALLEL_MAKE distcheck \
- || cat-testlogs.sh
+
+if arch | grep -v -q arm; then
+ DISTCHECK_CONFIGURE_FLAGS="$CONFIG" $MAKE $PARALLEL_MAKE distcheck \
+ || cat-testlogs.sh
+fi
if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then
make -C "$base/doc/manuals" publish
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ib4fbf7d54d479bbdda3c1415493bfc57b37d3971
Gerrit-Change-Number: 28557
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28556 )
Change subject: configure.ac: enable-werror: add -Wno-error=psabi
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hm, this build passed on arm without having the patch merged. So Pau is right, this is just a note and doesn't stop the build.
https://jenkins.osmocom.org/jenkins/job/master-osmo-trx/INSTR=--with-neon-v…
(Maybe it ran out of RAM where the build was stopped?)
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28556
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I4497ba8f71215284df33c48c18864e1058520723
Gerrit-Change-Number: 28556
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Jul 2022 11:07:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28556 )
Change subject: configure.ac: enable-werror: add -Wno-error=psabi
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Are you sure this is what's making gcc to stop? Because I see it is a "note", not a "warning", and I […]
I wasn't 100% sure... but saw several arm build failures all aborting close to printing the note and not other error message, and with this patch it's not failing anymore (as the jenkins build passed). It says "note", but the flag looks like it's a warning with -Wpsabi.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28556
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I4497ba8f71215284df33c48c18864e1058520723
Gerrit-Change-Number: 28556
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Jul 2022 10:38:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment