July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-trx[master]: configure.ac: add -lboost_thread for uhd < 4.2.0

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28537 ) Change subject: configure.ac: add -lboost_thread for uhd < 4.2.0 ...................................................................... configure.ac: add -lboost_thread for uhd < 4.2.0 Fix for the following error we see since building master-osmo-trx on debian 10 instead of 9: /usr/bin/ld: ipc_driver_test-uhdwrap.o: undefined reference to symbol '_ZTIN5boost6detail16thread_data_baseE' /usr/bin/ld: //usr/lib/x86_64-linux-gnu/libboost_thread.so.1.67.0: error adding symbols: DSO missing from command line After spending a lot of time on researching this, my understanding is now that uhd.pc should have had "-lboost_thread" in versions up to the latest release 4.2.0 because before that it would include boost thread headers in its logging code: https://github.com/EttusResearch/uhd/commit/04a83b6e76beef970854da69ba882d7… ld is able to figure out which library provides the missing symbol, and apparently depending on the binutils version and linker flags, it may just ignore this and not show an error. This is why apparently it worked with debian 9 and still does work in OBS (different flags), and why it was not fixed upstream in uhd.pc. By now fixing it is not needed in the latest version anymore, and there are already versions of uhd.pc in various linux distributions without -lboost_thread, so I think it's appropriate to add the workaround here in configure.ac. Fixes: OS#5608 Related: https://stackoverflow.com/q/19901934 Change-Id: I0367f1c2981bf56252e7514d5993cbbec960b21b --- M configure.ac 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/configure.ac b/configure.ac index 422ad65..37444a5 100644 --- a/configure.ac +++ b/configure.ac @@ -185,6 +185,14 @@ [PKG_CHECK_MODULES(UHD, uhd >= 003.005)] )] ) + # OS#5608: libuhd < 4.2.0 includes boost/thread/thread.hpp in its logging + # code and therefore requires linking against boost_thread. It's missing in + # uhd.pc, so work around it here. + # https://github.com/EttusResearch/uhd/commit/04a83b6e76beef970854da69ba882d7… + PKG_CHECK_MODULES(UHD, uhd < 004.002, + [LIBS="$LIBS -lboost_thread"], + [] + ) ]) AS_IF([test "x$with_singledb" = "xyes"], [ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0367f1c2981bf56252e7514d5993cbbec960b21b Gerrit-Change-Number: 28537 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-trx[master]: configure.ac: add -lboost_thread for uhd < 4.2.0

by osmith

osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28537 ) Change subject: configure.ac: add -lboost_thread for uhd < 4.2.0 ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0367f1c2981bf56252e7514d5993cbbec960b21b Gerrit-Change-Number: 28537 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 11 months

1
0
0 0

Change in osmo-trx[master]: gitignore: add uhddev_ipc.cpp

by osmith

Attention is currently required from: Hoernchen. osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28538 ) Change subject: gitignore: add uhddev_ipc.cpp ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I70bfb456e309daa4436767b2e55bce0c038a4975 Gerrit-Change-Number: 28538 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 11 months

1
0
0 0

Change in osmo-trx[master]: gitignore: add uhddev_ipc.cpp

by osmith

Attention is currently required from: Hoernchen. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28538 ) Change subject: gitignore: add uhddev_ipc.cpp ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: build is fixed for x86_64 at least, overriding jenkins build failure for arm -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I70bfb456e309daa4436767b2e55bce0c038a4975 Gerrit-Change-Number: 28538 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 09:14:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-trx[master]: configure.ac: add -lboost_thread for uhd < 4.2.0

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28537 ) Change subject: configure.ac: add -lboost_thread for uhd < 4.2.0 ...................................................................... Patch Set 1: Verified+1 Code-Review+2 (1 comment) Patchset: PS1: 1+1=2 build passed for x86_64, arm error is unrelated: CXX Transceiver.lo Terminated -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0367f1c2981bf56252e7514d5993cbbec960b21b Gerrit-Change-Number: 28537 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 09:12:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: merge 'sched_trx.h' and 'scheduler.h' into 'l1sched.h'

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28547 to look at the new patch set (#3). Change subject: trxcon: merge 'sched_trx.h' and 'scheduler.h' into 'l1sched.h' ...................................................................... trxcon: merge 'sched_trx.h' and 'scheduler.h' into 'l1sched.h' Change-Id: Ide1e3ccdf32fdc255acc943e0c0936d15cf0c680 Related: OS#5599, OS#3761 --- M src/host/trxcon/include/osmocom/bb/trxcon/Makefile.am R src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h D src/host/trxcon/include/osmocom/bb/trxcon/scheduler.h M src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_clck.c M src/host/trxcon/src/sched_lchan_common.c M src/host/trxcon/src/sched_lchan_desc.c M src/host/trxcon/src/sched_lchan_pdtch.c M src/host/trxcon/src/sched_lchan_rach.c M src/host/trxcon/src/sched_lchan_sch.c M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c M src/host/trxcon/src/sched_lchan_xcch.c M src/host/trxcon/src/sched_mframe.c M src/host/trxcon/src/sched_prim.c M src/host/trxcon/src/sched_trx.c M src/host/trxcon/src/trx_if.c M src/host/trxcon/src/trxcon.c 19 files changed, 48 insertions(+), 68 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/47/28547/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ide1e3ccdf32fdc255acc943e0c0936d15cf0c680 Gerrit-Change-Number: 28547 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: use abstract API for RACH primitives

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28552 to look at the new patch set (#3). Change subject: trxcon: use abstract API for RACH primitives ...................................................................... trxcon: use abstract API for RACH primitives Using L1CTL specific structures as the primitive payload was a beautiful hack in the early days of trxcon. But since we're going to separate the scheduler into an interface independent library, we have to introduce and use an abstract API. Change-Id: I84597d44ea7d74b8840a919ecb09988ba1980a73 Related: OS#5599, OS#3761 --- M src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_lchan_rach.c M src/host/trxcon/src/sched_prim.c 4 files changed, 77 insertions(+), 49 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/52/28552/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28552 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I84597d44ea7d74b8840a919ecb09988ba1980a73 Gerrit-Change-Number: 28552 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 to look at the new patch set (#4). Change subject: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC ...................................................................... trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Related: OS#5599, OS#3761 --- M src/host/trxcon/include/osmocom/bb/trxcon/l1ctl.h M src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h M src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h M src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_lchan_common.c M src/host/trxcon/src/sched_lchan_desc.c M src/host/trxcon/src/sched_lchan_pdtch.c M src/host/trxcon/src/sched_lchan_rach.c M src/host/trxcon/src/sched_lchan_sch.c M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c M src/host/trxcon/src/sched_lchan_xcch.c M src/host/trxcon/src/sched_prim.c M src/host/trxcon/src/sched_trx.c M src/host/trxcon/src/trx_if.c M src/host/trxcon/src/trxcon.c 18 files changed, 460 insertions(+), 407 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/54/28554/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Gerrit-Change-Number: 28554 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: use 'l1sched_' prefix for scheduler API

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28546 to look at the new patch set (#3). Change subject: trxcon: use 'l1sched_' prefix for scheduler API ...................................................................... trxcon: use 'l1sched_' prefix for scheduler API Change-Id: I370aa5084a4e3eb94168b96df94dbbee606adaab Related: OS#5599, OS#3761 --- M src/host/trxcon/include/osmocom/bb/trxcon/sched_trx.h M src/host/trxcon/include/osmocom/bb/trxcon/scheduler.h M src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_clck.c M src/host/trxcon/src/sched_lchan_common.c M src/host/trxcon/src/sched_lchan_desc.c M src/host/trxcon/src/sched_lchan_pdtch.c M src/host/trxcon/src/sched_lchan_rach.c M src/host/trxcon/src/sched_lchan_sch.c M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c M src/host/trxcon/src/sched_lchan_xcch.c M src/host/trxcon/src/sched_mframe.c M src/host/trxcon/src/sched_prim.c M src/host/trxcon/src/sched_trx.c M src/host/trxcon/src/trx_if.c M src/host/trxcon/src/trxcon.c 18 files changed, 563 insertions(+), 563 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/46/28546/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I370aa5084a4e3eb94168b96df94dbbee606adaab Gerrit-Change-Number: 28546 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28554 ) Change subject: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Gerrit-Change-Number: 28554 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 10 Jul 2022 19:39:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022