April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: trigger the loop unconditionally

by laforge

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... Patch Set 1: (1 comment) File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/27777/comment/8cc5bec2_3372520f PS1, Line 462: if (chan_state->codec[i] == cmr_codec) > To me it reads as: if the decoded CMR value is present in the list of allowed codec modes, then we d […] well, it first checks _if_ the CMR (sent in DL, but relevant to UL) is part of the active set. And if it is, then we communicate it to the MS as CMR in DL. The problem is now that the loop is disabled all the time, rather than only if a new CMR (differing from previous CMR) is sent. So the condition is wrong. The comment even says "new request". But it in fact checks whether it is any valid CMR request, not just a new request. I would change the predicate to 'if (cmr != chan_state->dl_cmr)' -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 27777 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 15:14:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: trigger the loop unconditionally

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > looking at this again, the intent of the code is quite clear: Stop the loop if there just was a new […] See my other comment. File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/27777/comment/bbfdf9ff_b0b3086c PS1, Line 462: if (chan_state->codec[i] == cmr_codec) To me it reads as: if the decoded CMR value is present in the list of allowed codec modes, then we disable the loop below. Of course this is always the case. Also note that this is the Downlink path, not Uplink. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 27777 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 15:09:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: trigger the loop unconditionally

by laforge

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: so I guess the only problem with the code is that osmo_amr_rtp_dec() always returns a CMR, as the CMR is a mandatory field of the RTP frame. The intent was probably to check if a _new_ (different from current) CMR was being instructed, and then disable the loop until we receive frames with the same CMR. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 27777 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 15:04:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: trigger the loop unconditionally

by laforge

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: looking at this again, the intent of the code is quite clear: Stop the loop if there just was a new CMR. I guess this needs some more investigation? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 27777 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 14:57:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: trigger the loop unconditionally

by laforge

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I would guess it was just for being able to debug AMR without the adaptive part, which is much simpler. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 27777 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 14:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27790 ) Change subject: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE ...................................................................... smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE When responding to a CBSP KILL with a CBSP KILL COMPLETE, make sure we include the optional "Number of Broadcasts Completed List" IE in order to inform the CBC about how many times the just-killed message had been broadcast before it was killed. It seems some CBCs expect this IE to be present, while 3GPP TS 48.049 lists it as optional. Since we alrady have code to encode it, let's just always add it - it certainly won't hurt. Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Closes: SYS#5906 --- M src/osmo-bsc/smscb.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 232c0d7..5fe6345 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -651,6 +651,8 @@ if (!smscb) return -CBSP_CAUSE_MSG_REF_NOT_IDENTIFIED; + append_bcast_compl(r_state, chan_state->bts, smscb); + /* Remove it */ bts_smscb_del(smscb, chan_state, "KILL"); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Gerrit-Change-Number: 27790 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27790 ) Change subject: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Gerrit-Change-Number: 27790 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 14:53:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: Add Cell Identifier List to BSSMAP RESET

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27766 ) Change subject: Add Cell Identifier List to BSSMAP RESET ...................................................................... Abandoned see https://osmocom.org/issues/5522#note-3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28e0f9497043e90f999b593602b7ffd812787430 Gerrit-Change-Number: 27766 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: bssap: forward paging to relevant BSCs only

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27767 ) Change subject: bssap: forward paging to relevant BSCs only ...................................................................... Abandoned see https://osmocom.org/issues/5522#note-3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iad3d1de8339206fa80f9fd10ac9213a7728a3c73 Gerrit-Change-Number: 27767 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27790 ) Change subject: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Gerrit-Change-Number: 27790 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 14 Apr 2022 13:50:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022