April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: trigger the loop unconditionally

by pespin

Attention is currently required from: laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Let's see if dexter or laforge have something to say. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 27777 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 13:49:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: trigger the loop unconditionally

by pespin

Attention is currently required from: laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 27777 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 13:48:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ci[master]: OBS, ttcn3-testsuites: add 2022q1

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27770 ) Change subject: OBS, ttcn3-testsuites: add 2022q1 ...................................................................... OBS, ttcn3-testsuites: add 2022q1 Related: SYS#5887 Change-Id: Idadb541b49e57b4403a6a6e4c966bcba9c6651db --- M jobs/ttcn3-testsuites.yml M scripts/common-obs.sh M scripts/osmocom-nightly-packages.sh 3 files changed, 25 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 89915a2..4f92248 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -400,6 +400,29 @@ blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" timer: 30 14 * * * + # centos8 2022q1 (SYS#5887) + - TTCN3-centos-pcu-test-2022q1: + blocking: "^(ttcn3|TTCN3-.*)-pcu-test.*" + timer: 00 15 * * * + - TTCN3-centos-pcu-test-sns-2022q1: + blocking: "^(ttcn3|TTCN3-.*)-pcu-test.*" + timer: 15 15 * * * + - TTCN3-centos-bsc-test-2022q1: + blocking: "^(ttcn3|TTCN3-.*)-bsc-test.*" + timer: 30 15 * * * + - TTCN3-centos-mgw-test-2022q1: + blocking: "^(ttcn3|TTCN3-.*)-mgw-test.*" + timer: 45 15 * * * + - TTCN3-centos-bts-test-2022q1: + blocking: "^(ttcn3|TTCN3-.*)-bts-test.*" + timer: 00 16 * * * + - TTCN3-centos-smlc-test-2022q1: + blocking: "^(ttcn3|TTCN3-.*)-smlc-test.*" + timer: 15 16 * * * + - TTCN3-centos-gbproxy-test-2022q1: + blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" + timer: 30 16 * * * + - job-template: name: '{job-name}' project-type: freestyle diff --git a/scripts/common-obs.sh b/scripts/common-obs.sh index e53a7aa..2d3bea7 100644 --- a/scripts/common-obs.sh +++ b/scripts/common-obs.sh @@ -5,6 +5,7 @@ FEEDS_ALL=" 2021q1 2021q4 + 2022q1 latest next nightly diff --git a/scripts/osmocom-nightly-packages.sh b/scripts/osmocom-nightly-packages.sh index 6fb8a1d..3f9fc4c 100755 --- a/scripts/osmocom-nightly-packages.sh +++ b/scripts/osmocom-nightly-packages.sh @@ -17,6 +17,7 @@ FEEDS=" 2021q1 2021q4 + 2022q1 next nightly " -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idadb541b49e57b4403a6a6e4c966bcba9c6651db Gerrit-Change-Number: 27770 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Expect number-of-broadcadsts-completed-list in CBSP KILL COMPLETE

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27791 ) Change subject: bsc: Expect number-of-broadcadsts-completed-list in CBSP KILL COMPLETE ...................................................................... bsc: Expect number-of-broadcadsts-completed-list in CBSP KILL COMPLETE When responding to a CBSP KILL with a CBSP KILL COMPLETE, make sure we include the optional "Number of Broadcasts Completed List" IE in order to inform the CBC about how many times the just-killed message had been broadcast before it was killed. It seems some CBCs expect this IE to be present, while 3GPP TS 48.049 lists it as optional. osmo-bsc is including this IE as of Change-Id I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 This change updates the test suite to expect this IE to be included. Change-Id: I5b56676c93479ec7b32cff66c9738fff7d0228cf Related: SYS#5906 --- M bsc/BSC_Tests_CBSP.ttcn 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/27791/1 diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn index 0d8fb38..b291546 100644 --- a/bsc/BSC_Tests_CBSP.ttcn +++ b/bsc/BSC_Tests_CBSP.ttcn @@ -355,6 +355,7 @@ function f_cbsp_kill(uint16_t msg_id, uint16_t ser_no, template (omit) uint8_t channel_ind := 0, template (value) BSSMAP_FIELD_CellIdentificationList cell_list := ts_BSSMAP_CIL_BSS, template BSSMAP_FIELD_CellIdentificationList success_list := ?, + template CBSP_IE_NumBcastComplList compl_list := *, template CBSP_FailureListItems fail_list := omit) runs on cbsp_test_CT { var template (value) CBSP_PDU tx; @@ -363,10 +364,10 @@ tx := ts_CBSP_KILL(msg_id, ser_no, cell_list, channel_ind); CBSP[0].send(ts_CBSP_Send(g_cbsp_conn_id[0], tx)); if (istemplatekind(fail_list, "omit")) { - rx := tr_CBSP_KILL_COMPL(msg_id, ser_no, compl_list:=*, cell_list:=success_list, + rx := tr_CBSP_KILL_COMPL(msg_id, ser_no, compl_list:=compl_list, cell_list:=success_list, channel_ind:=channel_ind); } else { - rx := tr_CBSP_KILL_FAIL(msg_id, ser_no, fail_list, compl_list:=*, cell_list:=success_list, + rx := tr_CBSP_KILL_FAIL(msg_id, ser_no, fail_list, compl_list:=compl_list, cell_list:=success_list, channel_ind:=channel_ind); } alt { @@ -784,7 +785,7 @@ f_init(); cell_list := ts_BSSMAP_CIL_LAC_CI({bssmap_lac_ci(mp_cgi_bts0)}); - f_cbsp_kill(g_cbsp_msg_id, g_cbsp_ser_no, 0, cell_list, success_list:=omit, fail_list:=?); + f_cbsp_kill(g_cbsp_msg_id, g_cbsp_ser_no, 0, cell_list, success_list:=omit, compl_list:=omit, fail_list:=?); } /* Write a message, then kill it */ testcase TC_cbsp_write_then_kill() runs on cbsp_test_CT { @@ -793,9 +794,14 @@ g_pars := valueof(ts_CBSP_Pars_default(false, 13001, 13501)); f_init(); + /* write message, request more than one transmission on BTS0 */ cell_list := ts_BSSMAP_CIL_LAC_CI({bssmap_lac_ci(mp_cgi_bts0)}); - f_cbsp_write(g_cbsp_msg_id, g_cbsp_ser_no, cell_list, content:=pages, success_list:=?, fail_list:=omit); - f_cbsp_kill(g_cbsp_msg_id, g_cbsp_ser_no, 0, cell_list, success_list:=?, fail_list:=omit); + f_cbsp_write(g_cbsp_msg_id, g_cbsp_ser_no, cell_list, num_bcast_req := 5, content:=pages, success_list:=?, fail_list:=omit); + /* expect to receive it once on the BTS */ + var template (present) RSL_Message tr := f_page2rsl(pages[0], g_cbsp_msg_id, g_cbsp_ser_no); + IPA_RSL[0].receive(tr_ASP_RSL_UD(tr)); + /* kill it, expecting non-empty completion list */ + f_cbsp_kill(g_cbsp_msg_id, g_cbsp_ser_no, 0, cell_list, success_list:=?, compl_list:=?, fail_list:=omit); } /* Write a message, then reset all messages */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b56676c93479ec7b32cff66c9738fff7d0228cf Gerrit-Change-Number: 27791 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27790 ) Change subject: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE ...................................................................... smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE When responding to a CBSP KILL with a CBSP KILL COMPLETE, make sure we include the optional "Number of Broadcasts Completed List" IE in order to inform the CBC about how many times the just-killed message had been broadcast before it was killed. It seems some CBCs expect this IE to be present, while 3GPP TS 48.049 lists it as optional. Since we alrady have code to encode it, let's just always add it - it certainly won't hurt. Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Closes: SYS#5906 --- M src/osmo-bsc/smscb.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/27790/1 diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 232c0d7..5fe6345 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -651,6 +651,8 @@ if (!smscb) return -CBSP_CAUSE_MSG_REF_NOT_IDENTIFIED; + append_bcast_compl(r_state, chan_state->bts, smscb); + /* Remove it */ bts_smscb_del(smscb, chan_state, "KILL"); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Gerrit-Change-Number: 27790 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: trigger the loop unconditionally

by fixeria

Attention is currently required from: laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27777 ) Change subject: osmo-bts-trx: amr_loop: trigger the loop unconditionally ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Did you look at git history? which commit was that code introduced in and by who? Any other possible […] Yes, and unfortunately all the history can tell us is that AMR support (channel coding, interleaving, scheduling, and the link adaptation loop) was added in a big commit with no commit message back in 2013: commit a7f5e077121f857e373b6e68c5fdf803933a12dc Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Tue Mar 26 09:05:14 2013 +0100 TRX: Support for AMR full speech I think it makes no sense to ask jolly what was the motivation behind the loop enable/disable switch. It's unlikely that he remembers the details. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09b649973d4269c4082a4fafa493c37825f95a9c Gerrit-Change-Number: 27777 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:58:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27781 ) Change subject: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I18ebb7395024a490da743c0bcb20959e6e9c7017 Gerrit-Change-Number: 27781 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:53:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-trx[master]: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/27788 ) Change subject: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/27788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I816689e2aeac9decbc44ba210956a929cc7a3169 Gerrit-Change-Number: 27788 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:53:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-hlr[master]: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/27783 ) Change subject: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/27783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I70cf75b3cb6ae59c92248cc529546750fb0da07b Gerrit-Change-Number: 27783 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:52:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-sgsn[master]: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/27787 ) Change subject: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/27787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8118ee3d3da9bdcd0c691471ef91b95dba21004a Gerrit-Change-Number: 27787 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:52:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022