April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: log if AMR mode remains unchanged

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27776 ) Change subject: osmo-bts-trx: amr_loop: log if AMR mode remains unchanged ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bts-trx/amr_loop.c: https://gerrit.osmocom.org/c/osmo-bts/+/27776/comment/8ae3eab5_9aef99f1 PS1, Line 110: "mode[%u]=%u\n", mi, cfg->mode[mi].mode); You probably want to print lqual_cb here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0272d11cfaad0e1c13d2858b3bc61d6527898018 Gerrit-Change-Number: 27776 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:45:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: allow upgrading codec mode > 0

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27775 ) Change subject: osmo-bts-trx: amr_loop: allow upgrading codec mode > 0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4c0fb28813373c3d4addd28c66f5136d2c4f9ed8 Gerrit-Change-Number: 27775 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:44:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: improve logging in trx_loop_amr_input()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27774 ) Change subject: osmo-bts-trx: amr_loop: improve logging in trx_loop_amr_input() ...................................................................... Patch Set 1: (1 comment) File src/osmo-bts-trx/amr_loop.c: https://gerrit.osmocom.org/c/osmo-bts/+/27774/comment/06b81764_26def17f PS1, Line 75: /* The threshold/hysteresis is in 0.5 dB steps, convert to cB: > Here mi substitutes chan_stat->ul_ft, not chan_state->dl_cmr. […] Exactly. Not an issue, marking thread as resolved. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4feb3a3823799a290a50a48275e45f3331874d1a Gerrit-Change-Number: 27774 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: improve logging in trx_loop_amr_input()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27774 ) Change subject: osmo-bts-trx: amr_loop: improve logging in trx_loop_amr_input() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bts-trx/amr_loop.c: https://gerrit.osmocom.org/c/osmo-bts/+/27774/comment/46b39d5d_e0bfc3c4 PS1, Line 75: /* The threshold/hysteresis is in 0.5 dB steps, convert to cB: Here mi substitutes chan_stat->ul_ft, not chan_state->dl_cmr. But it's fine because mi == chan_state->dl_cmr due to early return in line 48. Same in all placed below. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4feb3a3823799a290a50a48275e45f3331874d1a Gerrit-Change-Number: 27774 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: simplify trx_loop_amr_set()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27773 ) Change subject: osmo-bts-trx: amr_loop: simplify trx_loop_amr_set() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibeed00ef48450edfe1e0d4e179fb4c777b11beb9 Gerrit-Change-Number: 27773 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:37:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: struct amr_multirate_conf: remove ms_mode[], raname bts_mode[]

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27772 ) Change subject: struct amr_multirate_conf: remove ms_mode[], raname bts_mode[] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7442360ed857554440a0b9854f2d2bbab9dc5a71 Gerrit-Change-Number: 27772 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:36:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ci[master]: OBS, ttcn3-testsuites: add 2022q1

by fixeria

Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27770 ) Change subject: OBS, ttcn3-testsuites: add 2022q1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idadb541b49e57b4403a6a6e4c966bcba9c6651db Gerrit-Change-Number: 27770 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 14 Apr 2022 11:18:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-pcu[master]: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27786 ) Change subject: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' ...................................................................... Abandoned Automatically generated change. The 'emu/pcu_emu' must be kept in noinst_PROGRAMS. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I502dfba0ff6537368a8ebdce68fbbd6fcb0adad0 Gerrit-Change-Number: 27786 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

3 years, 2 months

1
0
0 0

Change in osmo-hlr[master]: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/27783 to look at the new patch set (#2). Change subject: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' ...................................................................... tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' When using 'check_PROGRAMS', autoconf/automake generates smarter Makefiles, so that the test programs are not being compiled during the normal 'make all', but only during 'make check'. Change-Id: I70cf75b3cb6ae59c92248cc529546750fb0da07b --- M tests/auc/Makefile.am M tests/gsup/Makefile.am 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/83/27783/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/27783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I70cf75b3cb6ae59c92248cc529546750fb0da07b Gerrit-Change-Number: 27783 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-smlc[master]: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/27789 ) Change subject: tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' ...................................................................... tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS' When using 'check_PROGRAMS', autoconf/automake generates smarter Makefiles, so that the test programs are not being compiled during the normal 'make all', but only during 'make check'. Change-Id: I9b60429c8c3922dd97809c72ed7960ffdc059d8b --- M tests/smlc_subscr/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/89/27789/1 diff --git a/tests/smlc_subscr/Makefile.am b/tests/smlc_subscr/Makefile.am index 9ed3b59..61a601f 100644 --- a/tests/smlc_subscr/Makefile.am +++ b/tests/smlc_subscr/Makefile.am @@ -20,7 +20,7 @@ smlc_subscr_test.err \ $(NULL) -noinst_PROGRAMS = \ +check_PROGRAMS = \ smlc_subscr_test \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/27789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I9b60429c8c3922dd97809c72ed7960ffdc059d8b Gerrit-Change-Number: 27789 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022