March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: SI13: Always send ext_info

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27537 to look at the new patch set (#3). Change subject: SI13: Always send ext_info ...................................................................... SI13: Always send ext_info Values in ext_info are modified in several places, so it's difficult validating whether we deviate from default. Let's always send it so that we always have a clear view on what the MS uses. This fixes a bug where paging_coordination or ccn_active would not be announced if GPRS was not enabled. Related: SYS#5894 Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa --- M src/osmo-bsc/system_information.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/27537/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa Gerrit-Change-Number: 27537 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: system_information: Always send ext_info in SI13

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27537 ) Change subject: system_information: Always send ext_info in SI13 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa Gerrit-Change-Number: 27537 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 19:00:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: system_information: Always send ext_info in SI13

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27537 ) Change subject: system_information: Always send ext_info in SI13 ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27537/comment/796c0e0f_8c0e5b86 PS2, Line 1218: overriden overridden -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa Gerrit-Change-Number: 27537 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 19:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27539 ) Change subject: SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported ...................................................................... SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported It makes no sense to enable that field if the ext_info.egprs_supported field marks EGPRS as disabled. From TS 44.060 11.2.5a: """ This message may be sent by an EGPRS capable mobile station *in a cell supporting EGPRS* and where the EGPRS_PACKET_CHANNEL_REQUEST parameter indicates that this message shall be used. """ Related: SYS#5891 Change-Id: I5ac173116f8681d7340b75b2baff110158fab9fd --- M src/osmo-bsc/system_information.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/39/27539/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index f45ba9b..1f0c79f 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1256,7 +1256,7 @@ si13_default.bcch_change_mark = bts->bcch_change_mark; /* Whether EGPRS capable MSs shall use EGPRS PACKET CHANNEL REQUEST */ - if (bts->gprs.egprs_pkt_chan_request) + if (bts->gprs.egprs_pkt_chan_request && si13_default.cell_opts.ext_info.egprs_supported) si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 1; else si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5ac173116f8681d7340b75b2baff110158fab9fd Gerrit-Change-Number: 27539 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: SI13: Make sure egprs_supported field is always updated

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27538 ) Change subject: SI13: Make sure egprs_supported field is always updated ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id2c2319044da474642c4cc710baa27cfee4fb592 Gerrit-Change-Number: 27538 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 18:52:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: system_information: Always send ext_info in SI13

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27537 ) Change subject: system_information: Always send ext_info in SI13 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa Gerrit-Change-Number: 27537 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 18:51:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: system_information: Always send ext_info in SI13

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27537 ) Change subject: system_information: Always send ext_info in SI13 ...................................................................... system_information: Always send ext_info in SI13 Values in ext_info are modified in several places, so it's difficult validating whether we deviate from default. Let's always send it so that we always have a clear view on what the MS uses. This fixes a bug where paging_coordination or ccn_active would not be announced if GPRS was not enabled. Related: SYS#5894 Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa --- M src/osmo-bsc/system_information.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/27537/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 27c60a0..79008b5 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1204,14 +1204,14 @@ .drx_timer_max = 3, .bs_cv_max = 15, .ctrl_ack_type_use_block = true, - .ext_info_present = 0, + .ext_info_present = true, .ext_info = { .egprs_supported = 0, /* overridden in gsm_generate_si() */ .use_egprs_p_ch_req = 0, /* overridden in generate_si13() */ .bep_period = 5, .pfc_supported = 0, .dtm_supported = 0, - .bss_paging_coordination = 0, + .bss_paging_coordination = 0, /* overriden in generate_si13() */ .ccn_active = false, }, }, @@ -1305,7 +1305,6 @@ si13_default.cell_opts.ext_info.egprs_supported = 1; /* fallthrough */ case BTS_GPRS_GPRS: - si13_default.cell_opts.ext_info_present = 1; si_info.gprs_ind.present = 1; break; case BTS_GPRS_NONE: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa Gerrit-Change-Number: 27537 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: SI13: Make sure egprs_supported field is always updated

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27538 ) Change subject: SI13: Make sure egprs_supported field is always updated ...................................................................... SI13: Make sure egprs_supported field is always updated If "bts->gprs.mode" was changed dynamically at runtime (VTY or CTRL), it could happen that the egprs_supported was kept as "1" if the dynamic change was EGPRS->GPRS. In summary, if EGPRS support was set, it couldn't be unset until BSC was restarted. Related: SYS#5894 Change-Id: Id2c2319044da474642c4cc710baa27cfee4fb592 --- M src/osmo-bsc/system_information.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/27538/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 79008b5..8717bb5 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1302,13 +1302,16 @@ switch (bts->gprs.mode) { case BTS_GPRS_EGPRS: + si_info.gprs_ind.present = 1; si13_default.cell_opts.ext_info.egprs_supported = 1; - /* fallthrough */ + break; case BTS_GPRS_GPRS: si_info.gprs_ind.present = 1; + si13_default.cell_opts.ext_info.egprs_supported = 0; break; case BTS_GPRS_NONE: si_info.gprs_ind.present = 0; + si13_default.cell_opts.ext_info.egprs_supported = 0; break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id2c2319044da474642c4cc710baa27cfee4fb592 Gerrit-Change-Number: 27538 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: gen_links.sh.inc: Fix globbing writing '*.ttcn' to */.gitignore

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27536 ) Change subject: gen_links.sh.inc: Fix globbing writing '*.ttcn' to */.gitignore ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaef3cfd5ae29db352046664ab4949b037ca80307 Gerrit-Change-Number: 27536 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 17:49:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: gsm_bts_trx_set_system_infos(): cosmetic: improve readability

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27527 ) Change subject: gsm_bts_trx_set_system_infos(): cosmetic: improve readability ...................................................................... gsm_bts_trx_set_system_infos(): cosmetic: improve readability Change-Id: Ic63ee79c7509ec57ad72f85442b5756ae31c0a52 Related: SYS#5888 --- M src/osmo-bsc/bts_trx.c 1 file changed, 25 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bts_trx.c b/src/osmo-bsc/bts_trx.c index 0333f70..fa27b05 100644 --- a/src/osmo-bsc/bts_trx.c +++ b/src/osmo-bsc/bts_trx.c @@ -382,7 +382,7 @@ /* set all system information types for a TRX */ int gsm_bts_trx_set_system_infos(struct gsm_bts_trx *trx) { - int i, rc; + int rc; struct gsm_bts *bts = trx->bts; uint8_t gen_si[_MAX_SYSINFO_TYPE], n_si = 0, n; int si_len[_MAX_SYSINFO_TYPE]; @@ -420,42 +420,49 @@ /* Second, we generate the selected SI via RSL */ for (n = 0; n < n_si; n++) { - i = gen_si[n]; + const enum osmo_sysinfo_type si_type = gen_si[n]; + /* Only generate SI if this SI is not in "static" (user-defined) mode */ - if (!(bts->si_mode_static & (1 << i))) { + if (!(bts->si_mode_static & (1 << si_type))) { /* Set SI as being valid. gsm_generate_si() might unset * it, if SI is not required. */ - bts->si_valid |= (1 << i); - rc = gsm_generate_si(bts, i); + bts->si_valid |= (1 << si_type); + rc = gsm_generate_si(bts, si_type); if (rc < 0) goto err_out; - si_len[i] = rc; + si_len[si_type] = rc; } else { - if (i == SYSINFO_TYPE_5 || i == SYSINFO_TYPE_5bis - || i == SYSINFO_TYPE_5ter) - si_len[i] = 18; - else if (i == SYSINFO_TYPE_6) - si_len[i] = 11; - else - si_len[i] = 23; + switch (si_type) { + case SYSINFO_TYPE_5: + case SYSINFO_TYPE_5bis: + case SYSINFO_TYPE_5ter: + si_len[si_type] = 18; + break; + case SYSINFO_TYPE_6: + si_len[si_type] = 11; + break; + default: + si_len[si_type] = 23; + } } } /* Third, we send the selected SI via RSL */ for (n = 0; n < n_si; n++) { - i = gen_si[n]; + const enum osmo_sysinfo_type si_type = gen_si[n]; + /* 3GPP TS 08.58 §8.5.1 BCCH INFORMATION. If we don't currently * have this SI, we send a zero-length RSL BCCH FILLING / * SACCH FILLING in order to deactivate the SI, in case it * might have previously been active */ - if (!GSM_BTS_HAS_SI(bts, i)) { + if (!GSM_BTS_HAS_SI(bts, si_type)) { if (bts->si_unused_send_empty) - rc = rsl_si(trx, i, 0); + rc = rsl_si(trx, si_type, 0); else rc = 0; /* some nanoBTS fw don't like receiving empty unsupported SI */ } else - rc = rsl_si(trx, i, si_len[i]); + rc = rsl_si(trx, si_type, si_len[si_type]); if (rc < 0) return rc; } @@ -468,6 +475,6 @@ err_out: LOGP(DRR, LOGL_ERROR, "Cannot generate SI%s for BTS %u: error <%s>, " "most likely a problem with neighbor cell list generation\n", - get_value_string(osmo_sitype_strs, i), bts->nr, strerror(-rc)); + get_value_string(osmo_sitype_strs, gen_si[n]), bts->nr, strerror(-rc)); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic63ee79c7509ec57ad72f85442b5756ae31c0a52 Gerrit-Change-Number: 27527 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022