March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: SI13: Get rid of si13_default

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27542 to look at the new patch set (#3). Change subject: SI13: Get rid of si13_default ...................................................................... SI13: Get rid of si13_default It's really confusing having a "default" struct whose inner values are changing based on previous state. Furthermore, it's only used in generate_si13() so there's no need to keep it outside the function. Let's move it inside the function and rename it to avoid confusion. Change-Id: I3ae4dd017dd4dad10c0365d21727666dd8e9fd41 --- M src/osmo-bsc/system_information.c 1 file changed, 43 insertions(+), 52 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/27542/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3ae4dd017dd4dad10c0365d21727666dd8e9fd41 Gerrit-Change-Number: 27542 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: system_information: Move all si13 specific val update to generate_si13()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27541 ) Change subject: system_information: Move all si13 specific val update to generate_si13() ...................................................................... system_information: Move all si13 specific val update to generate_si13() Change-Id: I6e920d1c8d8e1673194c88929586e8a1f22e09c5 --- M src/osmo-bsc/system_information.c 1 file changed, 14 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 45f9860..797c556 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1255,11 +1255,21 @@ /* Information about the other SIs */ si13_default.bcch_change_mark = bts->bcch_change_mark; - /* Whether EGPRS capable MSs shall use EGPRS PACKET CHANNEL REQUEST */ - if (bts->gprs.egprs_pkt_chan_request && si13_default.cell_opts.ext_info.egprs_supported) - si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 1; - else + switch (bts->gprs.mode) { + case BTS_GPRS_EGPRS: + si13_default.cell_opts.ext_info.egprs_supported = 1; + /* Whether EGPRS capable MSs shall use EGPRS PACKET CHANNEL REQUEST */ + if (bts->gprs.egprs_pkt_chan_request) + si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 1; + else + si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 0; + break; + case BTS_GPRS_GPRS: + case BTS_GPRS_NONE: + si13_default.cell_opts.ext_info.egprs_supported = 0; si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 0; + break; + } if (osmo_bts_has_feature(&bts->features, BTS_FEAT_PAGING_COORDINATION)) si13_default.cell_opts.ext_info.bss_paging_coordination = 1; @@ -1306,16 +1316,11 @@ switch (bts->gprs.mode) { case BTS_GPRS_EGPRS: - si_info.gprs_ind.present = 1; - si13_default.cell_opts.ext_info.egprs_supported = 1; - break; case BTS_GPRS_GPRS: si_info.gprs_ind.present = 1; - si13_default.cell_opts.ext_info.egprs_supported = 0; break; case BTS_GPRS_NONE: si_info.gprs_ind.present = 0; - si13_default.cell_opts.ext_info.egprs_supported = 0; break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6e920d1c8d8e1673194c88929586e8a1f22e09c5 Gerrit-Change-Number: 27541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27539 ) Change subject: SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported ...................................................................... SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported It makes no sense to enable that field if the ext_info.egprs_supported field marks EGPRS as disabled. From TS 44.060 11.2.5a: """ This message may be sent by an EGPRS capable mobile station *in a cell supporting EGPRS* and where the EGPRS_PACKET_CHANNEL_REQUEST parameter indicates that this message shall be used. """ Related: SYS#5891 Change-Id: I5ac173116f8681d7340b75b2baff110158fab9fd --- M src/osmo-bsc/system_information.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 9aae7bd..45f9860 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1256,7 +1256,7 @@ si13_default.bcch_change_mark = bts->bcch_change_mark; /* Whether EGPRS capable MSs shall use EGPRS PACKET CHANNEL REQUEST */ - if (bts->gprs.egprs_pkt_chan_request) + if (bts->gprs.egprs_pkt_chan_request && si13_default.cell_opts.ext_info.egprs_supported) si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 1; else si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5ac173116f8681d7340b75b2baff110158fab9fd Gerrit-Change-Number: 27539 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/BSSLAP_Types: fix receive template used in ts_BSSLAP_Reset

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27524 ) Change subject: library/BSSLAP_Types: fix receive template used in ts_BSSLAP_Reset ...................................................................... library/BSSLAP_Types: fix receive template used in ts_BSSLAP_Reset Change-Id: I6ed967c18346263b05b624b0bb5698f23ee842f7 --- M library/BSSLAP_Types.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/BSSLAP_Types.ttcn b/library/BSSLAP_Types.ttcn index 742d1f5..a55f5da 100644 --- a/library/BSSLAP_Types.ttcn +++ b/library/BSSLAP_Types.ttcn @@ -528,7 +528,7 @@ cell_id := ts_BSSLAP_IE_CellId(cell_id), timing_advance := ts_BSSLAP_IE_TA(ta), chan_desc := chan_desc, - cause := tr_BSSLAP_IE_Cause(cause), + cause := ts_BSSLAP_IE_Cause(cause), meas_rep := omit, enh_meas_rep := omit, meas_cell_id_list := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ed967c18346263b05b624b0bb5698f23ee842f7 Gerrit-Change-Number: 27524 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: SI13: Get rid of si13_default

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27542 ) Change subject: SI13: Get rid of si13_default ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3ae4dd017dd4dad10c0365d21727666dd8e9fd41 Gerrit-Change-Number: 27542 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 19:49:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: system_information: Move all si13 specific val update to generate_si13()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27541 ) Change subject: system_information: Move all si13 specific val update to generate_si13() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6e920d1c8d8e1673194c88929586e8a1f22e09c5 Gerrit-Change-Number: 27541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 19:44:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27539 ) Change subject: SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5ac173116f8681d7340b75b2baff110158fab9fd Gerrit-Change-Number: 27539 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 19:38:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: SI13: Get rid of si13_default

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27542 to look at the new patch set (#2). Change subject: SI13: Get rid of si13_default ...................................................................... SI13: Get rid of si13_default It's really confusing having a "default" struct whose inner values are changing based on previous state. Furthermore, it's only used in generate_si13() so there's no need to keep it outside the function. Let's move it inside the function and rename it to avoid confusion. Change-Id: I3ae4dd017dd4dad10c0365d21727666dd8e9fd41 --- M src/osmo-bsc/system_information.c 1 file changed, 43 insertions(+), 52 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/27542/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3ae4dd017dd4dad10c0365d21727666dd8e9fd41 Gerrit-Change-Number: 27542 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: SI13: Always send ext_info

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27537 ) Change subject: SI13: Always send ext_info ...................................................................... SI13: Always send ext_info Values in ext_info are modified in several places, so it's difficult validating whether we deviate from default. Let's always send it so that we always have a clear view on what the MS uses. This fixes a bug where paging_coordination or ccn_active would not be announced if GPRS was not enabled. Related: SYS#5894 Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa --- M src/osmo-bsc/system_information.c 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 5541d7b..a6e1e1c 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1208,15 +1208,15 @@ .drx_timer_max = 3, .bs_cv_max = 15, .ctrl_ack_type_use_block = true, - .ext_info_present = 0, + .ext_info_present = true, .ext_info = { .egprs_supported = 0, /* overridden in gsm_generate_si() */ .use_egprs_p_ch_req = 0, /* overridden in generate_si13() */ .bep_period = 5, .pfc_supported = 0, .dtm_supported = 0, - .bss_paging_coordination = 0, - .ccn_active = false, + .bss_paging_coordination = 0, /* overridden in generate_si13() */ + .ccn_active = false, /* overridden in generate_si13() */ }, }, .pwr_ctrl_pars = { @@ -1309,7 +1309,6 @@ si13_default.cell_opts.ext_info.egprs_supported = 1; /* fallthrough */ case BTS_GPRS_GPRS: - si13_default.cell_opts.ext_info_present = 1; si_info.gprs_ind.present = 1; break; case BTS_GPRS_NONE: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa Gerrit-Change-Number: 27537 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: SI13: Make sure egprs_supported field is always updated

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27538 ) Change subject: SI13: Make sure egprs_supported field is always updated ...................................................................... SI13: Make sure egprs_supported field is always updated If "bts->gprs.mode" was changed dynamically at runtime (VTY or CTRL), it could happen that the egprs_supported was kept as "1" if the dynamic change was EGPRS->GPRS. In summary, if EGPRS support was set, it couldn't be unset until BSC was restarted. Related: SYS#5894 Change-Id: Id2c2319044da474642c4cc710baa27cfee4fb592 --- M src/osmo-bsc/system_information.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index a6e1e1c..9aae7bd 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1306,13 +1306,16 @@ switch (bts->gprs.mode) { case BTS_GPRS_EGPRS: + si_info.gprs_ind.present = 1; si13_default.cell_opts.ext_info.egprs_supported = 1; - /* fallthrough */ + break; case BTS_GPRS_GPRS: si_info.gprs_ind.present = 1; + si13_default.cell_opts.ext_info.egprs_supported = 0; break; case BTS_GPRS_NONE: si_info.gprs_ind.present = 0; + si13_default.cell_opts.ext_info.egprs_supported = 0; break; } 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id2c2319044da474642c4cc710baa27cfee4fb592 Gerrit-Change-Number: 27538 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022