March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: CBSP: implement MESSAGE STATUS QUERY
by laforge 28 Mar '22

28 Mar '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27592 ) Change subject: CBSP: implement MESSAGE STATUS QUERY ...................................................................... CBSP: implement MESSAGE STATUS QUERY This add support for handling inbound MESSAGE STATUS QUERY from the CBC, and responding with MESSAGE STATUS QUERY COMPLETE or MESSAGE STATUS QUERY FAILURE, as applicable. Change-Id: I3b738dc29d0ead4f735abeeb6960d3675cb05ae2 Related: SYS#5909 --- M src/osmo-bsc/smscb.c 1 file changed, 68 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/27592/1 diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 1640880..232c0d7 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -681,6 +681,29 @@ return 0; } +static int bts_rx_status_query(struct gsm_bts *bts, const struct osmo_cbsp_decoded *dec, + struct response_state *r_state, void *priv) +{ + const struct osmo_cbsp_msg_status_query *query = &dec->u.msg_status_query; + struct bts_smscb_chan_state *chan_state; + struct bts_smscb_message *smscb; + bool extended = false; + + if (query->channel_ind == 0x01) + extended = true; + chan_state = bts_get_smscb_chan(bts, extended); + + /* Find message by msg_id + old_serial_nr */ + smscb = bts_find_smscb(chan_state, query->msg_id, query->old_serial_nr); + if (!smscb) + return -CBSP_CAUSE_MSG_REF_NOT_IDENTIFIED; + + append_bcast_compl(r_state, chan_state->bts, smscb); + + return 0; +} + + /********************************************************************************* * Receive of CBSP from CBC *********************************************************************************/ @@ -824,6 +847,48 @@ return rc; } +static int cbsp_rx_status_query(struct bsc_cbc_link *cbc, const struct osmo_cbsp_decoded *dec) +{ + const struct osmo_cbsp_msg_status_query *query = &dec->u.msg_status_query; + struct gsm_network *net = cbc->net; + struct response_state *r_state = talloc_zero(cbc, struct response_state); + struct osmo_cbsp_decoded *resp; + int rc; + + LOGP(DCBS, LOGL_DEBUG, "CBSP Rx MESSAGE STATUS QUERY\n"); + + rc = cbsp_per_bts(net, r_state, &dec->u.msg_status_query.cell_list, bts_rx_status_query, dec, NULL); + if (rc < 0) { + resp = osmo_cbsp_decoded_alloc(cbc, CBSP_MSGT_MSG_STATUS_QUERY_FAIL); + struct osmo_cbsp_msg_status_query_failure *fail = &resp->u.msg_status_query_fail; + fail->msg_id = query->msg_id; + fail->old_serial_nr = query->old_serial_nr; + fail->channel_ind = query->channel_ind; + llist_replace_head(&fail->fail_list, &r_state->fail); + + fail->num_compl_list.id_discr = r_state->num_completed.id_discr; + llist_replace_head(&fail->num_compl_list.list, &r_state->num_completed.list); + } else { + resp = osmo_cbsp_decoded_alloc(cbc, CBSP_MSGT_MSG_STATUS_QUERY_COMPL); + struct osmo_cbsp_msg_status_query_complete *compl = &resp->u.msg_status_query_compl; + compl->msg_id = query->msg_id; + compl->old_serial_nr = query->old_serial_nr; + compl->channel_ind = query->channel_ind; + + if (dec->u.msg_status_query.cell_list.id_discr == CELL_IDENT_BSS) { + /* replace the list of individual cell identities with CELL_IDENT_BSS */ + compl->num_compl_list.id_discr = CELL_IDENT_BSS; + /* no need to free num_completed_list entries, hierarchical talloc works */ + } else { + compl->num_compl_list.id_discr = r_state->num_completed.id_discr; + llist_replace_head(&compl->num_compl_list.list, &r_state->num_completed.list); + } + } + cbsp_tx_decoded(cbc, resp); + talloc_free(r_state); + return rc; +} + /*! process an incoming, already decoded CBSP message from the CBC. * \param[in] cbc link to the CBC @@ -846,8 +911,10 @@ case CBSP_MSGT_RESET: /* stop broadcasting of all messages */ rc = cbsp_rx_reset(cbc, dec); break; - case CBSP_MSGT_LOAD_QUERY: case CBSP_MSGT_MSG_STATUS_QUERY: + rc = cbsp_rx_status_query(cbc, dec); + break; + case CBSP_MSGT_LOAD_QUERY: case CBSP_MSGT_SET_DRX: LOGP(DCBS, LOGL_ERROR, "Received Unimplemented CBSP Message Type %s", get_value_string(cbsp_msg_type_names, dec->msg_type)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3b738dc29d0ead4f735abeeb6960d3675cb05ae2 Gerrit-Change-Number: 27592 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Build failed in Jenkins: master-osmo-opencm3-projects » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #19
by jenkins＠lists.osmocom.org 28 Mar '22

28 Mar '22

See <https://jenkins.osmocom.org/jenkins/job/master-osmo-opencm3-projects/a1=def…> Changes: ------------------------------------------ Started by upstream project "master-osmo-opencm3-projects" build number 19 originally caused by: Started by an SCM change Running as SYSTEM Building remotely on build2-deb9build-ansible (ttcn3 osmocom-gerrit-debian9 osmocom-master-debian9 repo-install-test coverity) in workspace <https://jenkins.osmocom.org/jenkins/job/master-osmo-opencm3-projects/a1=def…> The recommended git tool is: NONE No credentials specified Cloning the remote Git repository Cloning repository git://git.osmocom.org/osmo-opencm3-projects > git init <https://jenkins.osmocom.org/jenkins/job/master-osmo-opencm3-projects/a1=def…> # timeout=10 Fetching upstream changes from git://git.osmocom.org/osmo-opencm3-projects > git --version # timeout=10 > git --version # 'git version 2.11.0' > git fetch --tags --progress -- git://git.osmocom.org/osmo-opencm3-projects +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://git.osmocom.org/osmo-opencm3-projects # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 Avoid second fetch Checking out Revision 7527cab6d8364b2022bd4fa2fd03039eac2a99bb (refs/remotes/origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 7527cab6d8364b2022bd4fa2fd03039eac2a99bb # timeout=10 Commit message: "add missing libcommon.mk" First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule init # timeout=10 > git config -f .gitmodules --get-regexp ^submodule\.(.+)\.url # timeout=10 > git config --get submodule.libopencm3.url # timeout=10 > git config -f .gitmodules --get submodule.libopencm3.path # timeout=10 > git config --get submodule.librfn.url # timeout=10 > git config -f .gitmodules --get submodule.librfn.path # timeout=10 > git submodule update --init --recursive libopencm3 # timeout=10 > git submodule update --init --recursive librfn # timeout=10 [osmocom-master-debian9] $ /bin/sh -xe /tmp/jenkins5762361540671398993.sh + ARTIFACT_STORE=/home/osmocom-build/jenkins_build_artifact_store + mkdir -p /home/osmocom-build/jenkins_build_artifact_store + docker run --rm=true --cap-add SYS_PTRACE -e ARTIFACT_STORE=/artifact_store -e ASCIIDOC_WARNINGS_CHECK=1 -e HOME=/build -e JOB_NAME=master-osmo-opencm3-projects/a1=default,a2=default,a3=default,a4=default,label=osmocom-master-debian9 -e MAKE=make -e OSMOPY_DEBUG_TCP_SOCKETS=1 -e OSMO_GSM_MANUALS_DIR=/opt/osmo-gsm-manuals -e PARALLEL_MAKE=-j 8 -e PUBLISH=1 -e WITH_MANUALS=1 -w /build -i -u build -v <https://jenkins.osmocom.org/jenkins/job/master-osmo-opencm3-projects/a1=def…>:/build -v /home/osmocom-build/jenkins_build_artifact_store:/artifact_store -v /home/osmocom-build/.ssh:/home/build/.ssh:ro osmocom-build/debian-stretch-jenkins /build/contrib/jenkins.sh --publish =============== relay-driver START ============== CLEAN CC console.c arm-none-eabi-gcc: error: /usr/lib/picolibc/arm-none-eabi/picolibc.specs: No such file or directory ../../mk/libopencm3.mk:227: recipe for target 'console.o' failed make: *** [console.o] Error 1 Build step 'Execute shell' marked build as failure

1 29

Change in osmo-bsc[master]: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion
by laforge 28 Mar '22

28 Mar '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27590 ) Change subject: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion ...................................................................... SMSCB: Preserve padding at end of page in CBSP -> RSL conversion When copying the CBS page content from CBSP to RSL data structures, we use the User Information Length as length argument in the memcpy. The logic for that is that only this part of the message contains valid data. However, as the user information length is not passed on via RSL or transmitted over the air, the receiving MS will get a page with zero-initialized padding, rather than whatever the originator of the message has specified. As zero bytes in the 8bit domain might get translated into @-characters in the 7bit domain, this creates problems. So instead, let's always copy the entire page (82 bytes) to ensure transparency when passing on information from CBSP to RSL. Change-Id: Iffcf1f6a7d41a08a2feffc6f2ac5634d940b63aa Closes: SYS#5904 --- M src/osmo-bsc/smscb.c 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 542453c..1640880 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -22,6 +22,7 @@ #include <limits.h> #include <osmocom/core/stats.h> +#include <osmocom/core/utils.h> #include <osmocom/core/select.h> #include <osmocom/core/msgb.h> #include <osmocom/core/talloc.h> @@ -384,6 +385,9 @@ page = &smscb->page[i++]; msg_param = (struct gsm23041_msg_param_gsm *) &page->data[0]; + /* ensure we don't overflow in the memcpy below */ + osmo_static_assert(sizeof(*page) > sizeof(*msg_param) + sizeof(cont->data), smscb_space); + /* build 6 byte header according to TS 23.041 9.4.1.2 */ osmo_store16be(wrepl->new_serial_nr, &msg_param->serial_nr); osmo_store16be(wrepl->msg_id, &msg_param->message_id); @@ -393,7 +397,9 @@ OSMO_ASSERT(cont->user_len <= ARRAY_SIZE(cont->data)); OSMO_ASSERT(cont->user_len <= ARRAY_SIZE(page->data) - sizeof(*msg_param)); - memcpy(&msg_param->content, cont->data, cont->user_len); + /* we must not use cont->user_len as length here, as it would truncate any + * possible 7-bit padding at the end. Always copy the whole page */ + memcpy(&msg_param->content, cont->data, sizeof(cont->data)); bytes_used = sizeof(*msg_param) + cont->user_len; /* compute number of valid blocks in page */ page->num_blocks = bytes_used / 22; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iffcf1f6a7d41a08a2feffc6f2ac5634d940b63aa Gerrit-Change-Number: 27590 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion
by pespin 28 Mar '22

28 Mar '22

Attention is currently required from: neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27590 ) Change subject: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iffcf1f6a7d41a08a2feffc6f2ac5634d940b63aa Gerrit-Change-Number: 27590 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 16:57:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion
by laforge 28 Mar '22

28 Mar '22

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27590 ) Change subject: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/smscb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27590/comment/7a88d1d0_921a1852 PS1, Line 384: > ws Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iffcf1f6a7d41a08a2feffc6f2ac5634d940b63aa Gerrit-Change-Number: 27590 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 16:48:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion
by laforge 28 Mar '22

28 Mar '22

Attention is currently required from: neels, laforge. Hello Jenkins Builder, neels, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27590 to look at the new patch set (#2). Change subject: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion ...................................................................... SMSCB: Preserve padding at end of page in CBSP -> RSL conversion When copying the CBS page content from CBSP to RSL data structures, we use the User Information Length as length argument in the memcpy. The logic for that is that only this part of the message contains valid data. However, as the user information length is not passed on via RSL or transmitted over the air, the receiving MS will get a page with zero-initialized padding, rather than whatever the originator of the message has specified. As zero bytes in the 8bit domain might get translated into @-characters in the 7bit domain, this creates problems. So instead, let's always copy the entire page (82 bytes) to ensure transparency when passing on information from CBSP to RSL. Change-Id: Iffcf1f6a7d41a08a2feffc6f2ac5634d940b63aa Closes: SYS#5904 --- M src/osmo-bsc/smscb.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/27590/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iffcf1f6a7d41a08a2feffc6f2ac5634d940b63aa Gerrit-Change-Number: 27590 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: vty: Support platforms that don't support pthread_getname_np()
by laforge 28 Mar '22

28 Mar '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27591 ) Change subject: vty: Support platforms that don't support pthread_getname_np() ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: manually verified that this fixes an openwrt build issue for libosmocore.git -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd01485af24e2fe574006f8d049bf37226dda966 Gerrit-Change-Number: 27591 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 14:25:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: vty: Support platforms that don't support pthread_getname_np()
by laforge 28 Mar '22

28 Mar '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27591 ) Change subject: vty: Support platforms that don't support pthread_getname_np() ...................................................................... vty: Support platforms that don't support pthread_getname_np() pthread_getname_np() is a non-portable extension of pthreads. While it exists in glibc, for example musl didn't have it until rather recently (April 2021) and there still hasn't yet been a musl release with this change, resulting even current OpenWRT not yet supporting pthread_getname_np. So let's check if pthread_getname_np is supported, and only use it in that case. Change-Id: Ibd01485af24e2fe574006f8d049bf37226dda966 --- M configure.ac M src/vty/cpu_sched_vty.c 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/27591/1 diff --git a/configure.ac b/configure.ac index 89615fd..5bd686a 100644 --- a/configure.ac +++ b/configure.ac @@ -78,6 +78,24 @@ # check for pthread (PTHREAD_CFLAGS, PTHREAD_LIBS) AX_PTHREAD +AC_MSG_CHECKING(for pthread_getname_np(pthread_t, char*, size_t)) +saved_CFLAGS="$CFLAGS" +saved_LIBS="$LIBS" +CFLAGS="$CFLAGS $PTHREAD_CFLAGS" +LIBS="$LIBS $PTHREAD_LIBS" +AC_LINK_IFELSE( + [AC_LANG_PROGRAM( + [#define _GNU_SOURCE + #include <pthread.h>], + [pthread_getname_np(pthread_self(),"example",0)])], + [AC_MSG_RESULT(yes) + AC_DEFINE(HAVE_PTHREAD_GETNAME_NP,1, + [Have function pthread_setname_np(const char*)])], + [AC_MSG_RESULT(no)]) +CFLAGS="$saved_CFLAGS" +LIBS="$saved_LIBS" + + # check for old glibc < 2.17 to get clock_gettime AC_SEARCH_LIBS([clock_gettime], [rt posix4], [AC_DEFINE(HAVE_CLOCK_GETTIME, 1, [Define if clock_gettime is available]) diff --git a/src/vty/cpu_sched_vty.c b/src/vty/cpu_sched_vty.c index 0b4b249..dbb3cd5 100644 --- a/src/vty/cpu_sched_vty.c +++ b/src/vty/cpu_sched_vty.c @@ -25,6 +25,8 @@ #define _GNU_SOURCE +#include "../../config.h" + #include <string.h> #include <stdlib.h> #include <errno.h> @@ -637,8 +639,10 @@ return 0; } +#ifdef HAVE_PTHREAD_GETNAME_NP if (pthread_getname_np(pthread_self(), name, sizeof(name)) == 0) has_name = true; +#endif /* Get latest matching mask for the thread */ pthread_mutex_lock(&sched_vty_opts->cpu_affinity_li_mutex); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd01485af24e2fe574006f8d049bf37226dda966 Gerrit-Change-Number: 27591 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion
by fixeria 28 Mar '22

28 Mar '22

Attention is currently required from: neels, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27590 ) Change subject: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/smscb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27590/comment/5391f309_d47ebbe4 PS1, Line 384: ws -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iffcf1f6a7d41a08a2feffc6f2ac5634d940b63aa Gerrit-Change-Number: 27590 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 28 Mar 2022 12:19:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion
by pespin 28 Mar '22

28 Mar '22

Attention is currently required from: neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27590 ) Change subject: SMSCB: Preserve padding at end of page in CBSP -> RSL conversion ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iffcf1f6a7d41a08a2feffc6f2ac5634d940b63aa Gerrit-Change-Number: 27590 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 11:52:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log March 2022