March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: CBSP_Types: Fix typo num_bcats_compl -> num_bcast_compl

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27593 ) Change subject: CBSP_Types: Fix typo num_bcats_compl -> num_bcast_compl ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic51b3071ea9233a053cb1ee837b910d9250010d2 Gerrit-Change-Number: 27593 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:36:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: CBSP: implement MESSAGE STATUS QUERY

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27592 ) Change subject: CBSP: implement MESSAGE STATUS QUERY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3b738dc29d0ead4f735abeeb6960d3675cb05ae2 Gerrit-Change-Number: 27592 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:36:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: libosmocore.pc.in: put libsctp in Requires.private

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27597 ) Change subject: libosmocore.pc.in: put libsctp in Requires.private ...................................................................... libosmocore.pc.in: put libsctp in Requires.private The libsctp use in libosmocore is internal, not exposed to applications. Hence, it must not be in "Requires" but in "Requires.private". Fixes: 12eed19066a11aece6f346b54b85326bc6ba7f0b Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 --- M libosmocore.pc.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/libosmocore.pc.in b/libosmocore.pc.in index 3bb9b9a..6296417 100644 --- a/libosmocore.pc.in +++ b/libosmocore.pc.in @@ -6,7 +6,8 @@ Name: Osmocom Core Library Description: C Utility Library Version: @VERSION@ -Requires: talloc, libsctp +Requires: talloc +Requires.private: libsctp Libs: -L${libdir} -losmocore Libs.private: @PTHREAD_LIBS@ Cflags: -I${includedir}/ @PTHREAD_CFLAGS@ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 Gerrit-Change-Number: 27597 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: libosmocore.pc.in: put libsctp in Requires.private

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27597 ) Change subject: libosmocore.pc.in: put libsctp in Requires.private ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 Gerrit-Change-Number: 27597 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:05:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: configure: Support libsctp < 1.0.17 without libsctp.pc

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27598 ) Change subject: configure: Support libsctp < 1.0.17 without libsctp.pc ...................................................................... Patch Set 1: (1 comment) File libosmocore.pc.in: https://gerrit.osmocom.org/c/libosmocore/+/27598/comment/33ab0d16_583efd56 PS1, Line 10: Requires.private: @LIBSCTP_PC@ with this approach if the .pc is found it ends up looking like this: """ Requires.private: libsctp Libs: -L${libdir} -losmocore Libs.private: -lsctp """ It's true that the -lsctp will end up duplicated as it will be fed too by libsctp, but given they end up all in "private" section I think it's fine enough. I could have a new @LIBSCTP_MANUAL_LIBS@ but I don't think it's worth adding the complexity for that. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I241634388c2d32adffebd860c88bdd13002a6af0 Gerrit-Change-Number: 27598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:04:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: configure: Support libsctp < 1.0.17 without libsctp.pc

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27598 ) Change subject: configure: Support libsctp < 1.0.17 without libsctp.pc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I241634388c2d32adffebd860c88bdd13002a6af0 Gerrit-Change-Number: 27598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:03:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: libosmocore.pc.in: put libsctp in Requires.private

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27597 ) Change subject: libosmocore.pc.in: put libsctp in Requires.private ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 Gerrit-Change-Number: 27597 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:02:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: configure: Support libsctp < 1.0.17 without libsctp.pc

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27598 ) Change subject: configure: Support libsctp < 1.0.17 without libsctp.pc ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Tested manually moving libsctp.pc in my system, works fine: """ checking for LIBSCTP... no configure: libsctp.pc not found (building against <1.0.17 ?), attempting manual lookup checking for library containing sctp_bindx... -lsctp """ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I241634388c2d32adffebd860c88bdd13002a6af0 Gerrit-Change-Number: 27598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 29 Mar 2022 10:01:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: configure: Support libsctp < 1.0.17 without libsctp.pc

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27598 ) Change subject: configure: Support libsctp < 1.0.17 without libsctp.pc ...................................................................... configure: Support libsctp < 1.0.17 without libsctp.pc libsctp 1.0.17 is the first to contain a pkgconfig file in upstream. Current OpenSure Leap 15.3 as well as our OpenEmbedded meta-telephony layer still ship 1.0.16 which contain no pkgconfig file. Let's attempt first finding the .pc file, and otherwise manually link against the lib. Related: https://bugzilla.opensuse.org/show_bug.cgi?id=1197590 Related: https://build.opensuse.org/request/show/965348 Fixes: 12eed19066a11aece6f346b54b85326bc6ba7f0b Change-Id: I241634388c2d32adffebd860c88bdd13002a6af0 --- M configure.ac M libosmocore.pc.in 2 files changed, 18 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/27598/1 diff --git a/configure.ac b/configure.ac index 89615fd..0210926 100644 --- a/configure.ac +++ b/configure.ac @@ -223,16 +223,22 @@ [ENABLE_LIBSCTP=$enableval], [ENABLE_LIBSCTP="yes"]) AM_CONDITIONAL(ENABLE_LIBSCTP, test x"$ENABLE_LIBSCTP" = x"yes") AS_IF([test "x$ENABLE_LIBSCTP" = "xyes"], [ - old_LIBS=$LIBS - AC_SEARCH_LIBS([sctp_bindx], [sctp], [ - AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support]) - AC_SUBST(HAVE_LIBSCTP, [1]) - if test -n "$ac_lib"; then - AC_SUBST(LIBSCTP_LIBS, [-l$ac_lib]) - fi - ], [ - AC_MSG_ERROR([sctp_bindx not found in searched libs])]) - LIBS=$old_LIBS + AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support]) + # Attempt finding .pc, otherwise set manually (<1.0.17 have no .pc file) + PKG_CHECK_MODULES(LIBSCTP, libsctp, + [AC_SUBST(LIBSCTP_PC, [libsctp])], + [ + AC_MSG_NOTICE([libsctp.pc not found (building against <1.0.17 ?), attempting manual lib lookup]) + old_LIBS=$LIBS + AC_SEARCH_LIBS([sctp_bindx], [sctp], [ + AC_SUBST(HAVE_LIBSCTP, [1]) + if test -n "$ac_lib"; then + AC_SUBST(LIBSCTP_LIBS, [-l$ac_lib]) + fi + ], [ + AC_MSG_ERROR([sctp_bindx not found in searched libs])]) + LIBS=$old_LIBS + ]) ]) AC_ARG_ENABLE([sctp-tests], [AS_HELP_STRING([--disable-sctp-tests], [Do not run socket tests requiring system SCTP support])], diff --git a/libosmocore.pc.in b/libosmocore.pc.in index 6296417..d804b8e 100644 --- a/libosmocore.pc.in +++ b/libosmocore.pc.in @@ -7,7 +7,7 @@ Description: C Utility Library Version: @VERSION@ Requires: talloc -Requires.private: libsctp +Requires.private: @LIBSCTP_PC@ Libs: -L${libdir} -losmocore -Libs.private: @PTHREAD_LIBS@ +Libs.private: @PTHREAD_LIBS@ @LIBSCTP_LIBS@ Cflags: -I${includedir}/ @PTHREAD_CFLAGS@ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I241634388c2d32adffebd860c88bdd13002a6af0 Gerrit-Change-Number: 27598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: libosmocore.pc.in: put libsctp in Requires.private

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27597 to look at the new patch set (#2). Change subject: libosmocore.pc.in: put libsctp in Requires.private ...................................................................... libosmocore.pc.in: put libsctp in Requires.private The libsctp use in libosmocore is internal, not exposed to applications. Hence, it must not be in "Requires" but in "Requires.private". Fixes: 12eed19066a11aece6f346b54b85326bc6ba7f0b Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 --- M libosmocore.pc.in 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/27597/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 Gerrit-Change-Number: 27597 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022