March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: gsm48_make_ho_cmd(): optionally add Synchronization Indication IE

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27508 ) Change subject: gsm48_make_ho_cmd(): optionally add Synchronization Indication IE ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27508/comment/83d8b59b_7b5e9e6b PS1, Line 562: if (!async || ho_scope & HO_INTER_BSC_IN) { Better have the "ho_scope & HO_INTER_BSC_IN" condition first (and add parenthesis!) to match the comment description. The last sentence "If ommited, ..." is not really clear imho, what is omitted? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4e5b1163a71443d706f14ce4bfd5c2294c320432 Gerrit-Change-Number: 27508 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:50:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: gsm48_make_ho_cmd(): optionally add Cipher Mode Setting IE

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27507 ) Change subject: gsm48_make_ho_cmd(): optionally add Cipher Mode Setting IE ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27507/comment/7163b962_1bcdef5e PS1, Line 584: if (new_lchan->encr.alg_id > ALG_A5_NR_TO_RSL(0)) Looks like we want this stuff as "lchan_get_cms()" put somewhere and reuse here and gsm48_send_rr_ciph_mode() -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1d270e82d0a9b12897fc94dae4e8999aa132a22f Gerrit-Change-Number: 27507 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:44:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: gsm48_make_ho_cmd(): make 'struct gsm_lchan' pointer const

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27506 ) Change subject: gsm48_make_ho_cmd(): make 'struct gsm_lchan' pointer const ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I731179bf7f5d711ca114e36af661faccf0caa19f Gerrit-Change-Number: 27506 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:41:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[2021q4]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27502 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2021q4 Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:41:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[2021q4]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27502 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Did you check with latest version of the spec? To make sure whoever implemented it checked on another version which maybe had an errata. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2021q4 Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:41:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: exec TC_sacch_chan_act_ho_{sync,async} on g_AllChanTypes[]

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27490 ) Change subject: BTS_Tests: exec TC_sacch_chan_act_ho_{sync,async} on g_AllChanTypes[] ...................................................................... BTS_Tests: exec TC_sacch_chan_act_ho_{sync,async} on g_AllChanTypes[] Currently we execute both test cases on *all* available dedicated channels from g_AllChannels[]. Given that SACCH is slow, and in some cases we intentionally wait for a timeout of 3.0 seconds to expire, the overall execution time is quite long. We have a risk of the test execution being aborted due to the guard timeout. I agree that using g_AllChannels[] makes sense for TC_ho_rach, which tests handover RACH detection. There we want to be sure that detection works on all slots of all DCCH types (especially when running a setup with real MS/BTS hardware). But for both TC_sacch_chan_act_ho_{sync,async} it's enough to run on different channel types (see g_AllChanTypes[]), because what we actually want to test is the Downlink SACCH operation. Change-Id: Ic1937edd72ff842cb619e153d0f6a624ceb95281 Related: SYS#5838, OS#4008, OS#4009 --- M bts/BTS_Tests.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index ab7c979..b95648a 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -1406,9 +1406,9 @@ var ConnHdlrPars pars; f_init(); - for (var integer i := 0; i < sizeof(g_AllChannels); i := i+1) { - pars := valueof(t_Pars(g_AllChannels[i], ts_RSL_ChanMode_SIGN)); - log(testcasename(), ": Starting for ", g_AllChannels[i]); + for (var integer i := 0; i < sizeof(g_AllChanTypes); i := i+1) { + pars := valueof(t_Pars(g_AllChanTypes[i], ts_RSL_ChanMode_SIGN)); + log(testcasename(), ": Starting for ", g_AllChanTypes[i]); vc_conn := f_start_handler(refers(f_TC_sacch_chan_act_ho_async), pars); vc_conn.done; } @@ -1532,9 +1532,9 @@ var ConnHdlrPars pars; f_init(); - for (var integer i := 0; i < sizeof(g_AllChannels); i := i+1) { - pars := valueof(t_Pars(g_AllChannels[i], ts_RSL_ChanMode_SIGN)); - log(testcasename(), ": Starting for ", g_AllChannels[i]); + for (var integer i := 0; i < sizeof(g_AllChanTypes); i := i+1) { + pars := valueof(t_Pars(g_AllChanTypes[i], ts_RSL_ChanMode_SIGN)); + log(testcasename(), ": Starting for ", g_AllChanTypes[i]); vc_conn := f_start_handler(refers(f_TC_sacch_chan_act_ho_sync), pars); vc_conn.done; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic1937edd72ff842cb619e153d0f6a624ceb95281 Gerrit-Change-Number: 27490 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts/expected-results.xml: expect TC_sacch_chan_act_ho_async to pass

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27495 ) Change subject: bts/expected-results.xml: expect TC_sacch_chan_act_ho_async to pass ...................................................................... bts/expected-results.xml: expect TC_sacch_chan_act_ho_async to pass Change-Id: I9ceb0a71549d293ff0f270c414f667a0bae4df62 --- M bts/expected-results.xml 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/expected-results.xml b/bts/expected-results.xml index b81358d..2dffe06 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -10,12 +10,7 @@ <testcase classname='BTS_Tests' name='TC_sacch_multi' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_sacch_multi_chg' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_sacch_chan_act' time='MASKED'/> - <testcase classname='BTS_Tests' name='TC_sacch_chan_act_ho_async' time='MASKED'> - <failure type='fail-verdict'>"BTS_Tests.ttcn:MASKED : Unexpected RSL message received" - BTS_Tests.ttcn:MASKED BTS_Tests control part - BTS_Tests.ttcn:MASKED TC_sacch_chan_act_ho_async testcase - </failure> - </testcase> + <testcase classname='BTS_Tests' name='TC_sacch_chan_act_ho_async' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_sacch_chan_act_ho_sync' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_content' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_count' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ceb0a71549d293ff0f270c414f667a0bae4df62 Gerrit-Change-Number: 27495 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async}

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27489 ) Change subject: BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async} ...................................................................... BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async} According to 3GPP TS 48.058: * 4.1.3 async handover: "If the MS Power IE is present the BTS *may* start transmission also on the SACCH". * 4.1.4 sync handover: "If only the MS Power IE is present the BTS *may* start transmission also on the SACCH". "May" does not mean "shall", so osmo-bts does not. Change-Id: I5e97944e56b7860f2d912cd8d3c978a0f1e08645 Related: SYS#5838, OS#4008, OS#4009 --- M bts/BTS_Tests.ttcn 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 192e9a3..ab7c979 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -1074,7 +1074,9 @@ } /* verify that given SACCH payload is present */ -private function f_sacch_present(template octetstring l3_exp) runs on ConnHdlr { +private function f_sacch_present(template octetstring l3_exp, + boolean do_fail := true) +runs on ConnHdlr { var L1ctlDlMessage dl; timer T_sacch := 3.0; L1CTL.clear; @@ -1089,7 +1091,10 @@ } } [] L1CTL.receive { repeat; } - [] T_sacch.timeout { + [not do_fail] T_sacch.timeout { + log("Timeout waiting for SACCH ", l3_exp); + } + [do_fail] T_sacch.timeout { setverdict(fail, "Timeout waiting for SACCH ", l3_exp); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } @@ -1384,8 +1389,9 @@ /* enable dedicated mode */ f_l1ctl_est_dchan(L1CTL, g_pars); - /* Verify that DL SACCH is being received */ - f_sacch_present(si5); + /* 4.1.3 "If the MS Power IE is present the BTS *may* start transmission + * also on the SACCH". "May" does not mean "shall", so osmo-bts does not. */ + f_sacch_present(si5, do_fail := false); /* Send handover Access Burst and expect SACCH to remain present */ f_L1CTL_RACH(L1CTL, ho_ref, chan_nr := g_pars.chan_nr); @@ -1460,8 +1466,9 @@ /* enable dedicated mode */ f_l1ctl_est_dchan(L1CTL, g_pars); - /* Verify that DL SACCH is being received, because MS Power IE was sent */ - f_sacch_present(si5); + /* 4.1.4 "If only the MS Power IE is present the BTS *may* start transmission + * also on the SACCH". "May" does not mean "shall", so osmo-bts does not. */ + f_sacch_present(si5, do_fail := false); /* Send handover Access Burst and expect SACCH to remain present */ f_L1CTL_RACH(L1CTL, ho_ref, chan_nr := g_pars.chan_nr); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e97944e56b7860f2d912cd8d3c978a0f1e08645 Gerrit-Change-Number: 27489 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: exec TC_sacch_chan_act_ho_{sync,async} on g_AllChanTypes[]

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27490 ) Change subject: BTS_Tests: exec TC_sacch_chan_act_ho_{sync,async} on g_AllChanTypes[] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic1937edd72ff842cb619e153d0f6a624ceb95281 Gerrit-Change-Number: 27490 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:36:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async}

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27489 ) Change subject: BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e97944e56b7860f2d912cd8d3c978a0f1e08645 Gerrit-Change-Number: 27489 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:35:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022