March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[2021q4]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27502 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Did you check with latest version of the spec? To make sure whoever implemented it checked on anothe […] I always tend to use the most recent version of the specs. Thanks to https://getsi.org/, it's quite easy to pick the latest document (https://getsi.org/?q=48.058 in this case). As of today, V16.0.0 (2020-09) is the latest version. See section 8.4.1 "CHANNEL ACTIVATION". Access Delay IE is not listed, and logically should not be there because it related to the Access Burst. Timing Advance IE is there. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2021q4 Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:59:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: gsm48_make_ho_cmd(): optionally add Synchronization Indication IE

by neels

Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27508 ) Change subject: gsm48_make_ho_cmd(): optionally add Synchronization Indication IE ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27508/comment/ddec9b2b_4d4aaaa3 PS1, Line 562: if (!async || ho_scope & HO_INTER_BSC_IN) { > Better have the "ho_scope & HO_INTER_BSC_IN" condition first (and add parenthesis!) to match the com […] to me it is clear, the Synchronization Indication is omitted for async intra-GERAN ack: please parenthesis around the & operation -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4e5b1163a71443d706f14ce4bfd5c2294c320432 Gerrit-Change-Number: 27508 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:58:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: gsm48_send_ho_cmd(): this function is not used, remove it

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27504 ) Change subject: gsm48_send_ho_cmd(): this function is not used, remove it ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9771d7e1f2073ebf6d900c067885485e54790bca Gerrit-Change-Number: 27504 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:55:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): do not calculate BER10k for FACCH twice

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27483 ) Change subject: osmo-bts-trx: rx_tchh_fn(): do not calculate BER10k for FACCH twice ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5d3955d09990e280d11d687385eeaf5edf437395 Gerrit-Change-Number: 27483 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:54:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: gsm48_make_ho_cmd(): optionally add Cipher Mode Setting IE

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27507 ) Change subject: gsm48_make_ho_cmd(): optionally add Cipher Mode Setting IE ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27507/comment/7dba7aeb_6fc14bf1 PS1, Line 585: (new_lchan->encr.alg_id - 2) << 1 This looked wrong at first but i figured it out. I think it would be good to explain this, maybe put it in a separate function. Explanation: looking at 44.018 10.5.2.9: if n is the A5/n number, then from the spec i get to this formula: (n - 1) << 1 However, encr.alg_id is (for historical reasons) stored as what seems to be n + 1, which makes this formula correct. Some comments spread around osmo-msc.git explain as: /*! alg_id is in encoded format: * alg_id == 1 means A5/0 i.e. no encryption, alg_id == 4 means A5/3. * alg_id == 0 means no such IE was present. */ The "encoded format" is in fact the Algorithm Identifier as in 3GPP TS 48.008 3.2.2.44 Chosen Encryption Algorithm. If I were to write this from scratch, I'd have rather stored the plain A5/n number in encr.alg_id (as encr.alg_a5). Since we have alg_id around everywhere already, I think it would be nice to have a macro like ALG_A5_NR_TO_RSL() or a seprate function to explicitly show the intended conversion. can also follow later, we'd like to get this fix out for testing. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1d270e82d0a9b12897fc94dae4e8999aa132a22f Gerrit-Change-Number: 27507 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:53:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix some compilation warnings (template restrictions)

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27494 ) Change subject: BTS_Tests: fix some compilation warnings (template restrictions) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53286a7b4b78a3e816d94d880ae290771cdd7ee8 Gerrit-Change-Number: 27494 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:52:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add a hierarchy of L1CTL/LAPDm/DCCH altsteps

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27499 ) Change subject: BTS_Tests: add a hierarchy of L1CTL/LAPDm/DCCH altsteps ...................................................................... BTS_Tests: add a hierarchy of L1CTL/LAPDm/DCCH altsteps In TTCN-3 it's possible to call one altstep from another. This allows us to build complex hierarchies of simple altsteps, where one is built on top of the others. I call this altstep-oriented programming. This change adds the following hierarchy: * as_l1ctl_dl_msg() - triggers on receipt of a L1CTL DATA.ind matching the given RSL chan_nr/link_id and data templates; * as_dl_lapdm_dummy() - triggers on receipt of dummy LAPDm func=UI frames with empty payload (repeats by default); * as_dl_dcch_lapdm_ab() - triggers on receipt of a Downlink DCCH containing a L2 payload that matches the given LAPDm frame; * as_dl_dcch_pdu() - triggers on receipt of a LAPDm AB frame with a L3 payload matching the given template. All of these altsteps (except as_dl_lapdm_dummy()) expect an 'out' parameter, which will hold the matched (and possibly decoded) data. Example: var PDU_ML3_NW_MS pdu; alt { [] as_dl_lapdm_dummy(); /* Ignore empty LAPDm func=UI frames */ [] as_dl_dcch_pdu(pdu, tr_CM_SERV_ACC) { setverdict(pass); } [] as_dl_dcch_pdu(pdu, tr_CM_SERV_REJ) { setverdict(fail); } [] as_dl_dcch_pdu(pdu, ?) { setverdict(inconc, "Unexpected PDU"); } } Change-Id: Ia4d502488cbb6bccc4d2656206ae6649bfa71007 Related: SYS#5838 --- M bts/BTS_Tests.ttcn 1 file changed, 56 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index b95648a..39dca7a 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -873,6 +873,62 @@ } } +/* This altstep triggers on receipt of a L1CTL DATA.ind matching the given + * RSL chan_nr/link_id and data templates. Used as a base for other altsteps. */ +private altstep as_l1ctl_dl_msg(out L1ctlDlMessage msg, + template (present) octetstring tr_data := ?, + template (present) RslChannelNr chan_nr := ?, + template (present) RslLinkId link_id := ?) +runs on ConnHdlr { + [] L1CTL.receive(tr_L1CTL_DATA_IND(chan_nr, link_id, tr_data)) -> value msg; +} + +/* This altstep is built on top of as_l1ctl_dl_msg(), and triggers on receipt + * of dummy LAPDm func=UI frames with empty payload. Repeats by default. */ +private altstep as_dl_lapdm_dummy(template (present) RslChannelNr chan_nr := ?, + template (present) RslLinkId link_id := ?, + template (present) LapdmSapi sapi := ?, + boolean do_repeat := true) +runs on ConnHdlr { + template (present) LapdmFrame tr_frame := tr_LAPDm_UI(sapi, true, ''O); + var L1ctlDlMessage dl_msg; + + [] as_l1ctl_dl_msg(dl_msg, decmatch tr_frame, chan_nr, link_id) { + if (do_repeat) { + repeat; + } + } +} + +/* This altstep triggers on receipt of a Downlink DCCH containing a L2 payload + * that matches the given LAPDm frame. The L2 is treated as LapdmFrameAB. */ +private altstep as_dl_dcch_lapdm_ab(out LapdmFrameAB frame, + template (present) LapdmFrameAB tr_frame := ?, + template (present) RslLinkId link_id := ?) +runs on ConnHdlr { + var L1ctlDlMessage dl_msg; + + [] as_l1ctl_dl_msg(dl_msg, decmatch tr_frame, g_chan_nr, link_id) { + frame := dec_LapdmFrameAB(dl_msg.payload.data_ind.payload); + } +} + +/* This altstep is built on top of as_dl_dcch_lapdm_ab(), and triggers on receipt + * of a LAPDm AB frame with a L3 payload matching the given template. The L3 + * payload is treated as PDU_ML3_NW_MS. */ +private altstep as_dl_dcch_pdu(out PDU_ML3_NW_MS pdu, + template (present) PDU_ML3_NW_MS tr_pdu := ?, + template (present) GsmSapi sapi := 0) +runs on ConnHdlr { + template (present) LapdmFrame tr_frame := tr_LAPDm_UI(sapi, true, decmatch tr_pdu); + template (present) RslLinkId link_id := tr_RslLinkID_DCCH(sapi); + var LapdmFrameAB lapdm_frame; + + [] as_dl_dcch_lapdm_ab(lapdm_frame, tr_frame.ab, link_id) { + pdu := dec_PDU_ML3_NW_MS(lapdm_frame.payload); + } +} + /*********************************************************************** * Channel Activation / Deactivation ***********************************************************************/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4d502488cbb6bccc4d2656206ae6649bfa71007 Gerrit-Change-Number: 27499 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add new test case TC_ho_physical_info

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27500 ) Change subject: BTS_Tests: add new test case TC_ho_physical_info ...................................................................... BTS_Tests: add new test case TC_ho_physical_info The test case scenario can be summarized as follows: 1. Activate a logical channel for async handover. 1.a. Tune the MS side to that channel. 1.b. Make sure that no Downlink DCCH is received. 2. Send a handover Access Burst to the BTS. 2.a. Expect RR Physical Information to be received Ny1 times. 2.b. Expect no other data to be received on Downlink DCCH. Currently the new test case fails for several reasons: * osmo-bts-trx starts transmitting on DCCH before the handover Access Burst is received, this is wong; * trxcon immediately starts sending dummy frames on Uplink DCCH, causing osmo-bts to stop sendig RR Physical Info. Change-Id: I9469027ce88fb2750f1eceef2d8a56d4b8ee4d03 Related: SYS#5838 --- M bts/BTS_Tests.ttcn M bts/expected-results.xml 2 files changed, 98 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 39dca7a..eeb305f 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -135,6 +135,10 @@ * X5: -109 >= -115 dBm (no) * So all channels should be in band 4. */ uint3_t mp_interf_band := 4; + /* T3105 timer (see 3GPP TS 44.018, section 11.1.2) */ + integer mp_ho_t3105_ms := 100; + /* Ny1 counter (see 3GPP TS 44.018, section 11.1.3) */ + integer mp_ho_ny1 := 10; } type record of RslChannelNr ChannelNrs; @@ -1953,6 +1957,93 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } +/* Test sending of the RR Physical Information message on DCCH */ +private function f_TC_ho_physical_info(charstring id) runs on ConnHdlr { + var PDU_ML3_NW_MS dcch_pdu; + var integer count := 0; + var L1ctlDlMessage dl; + timer T; + + f_l1_tune(L1CTL); + RSL.clear; + + /* Generate a random Handover Reference */ + var integer ho_ref := oct2int(f_rnd_octstring(1)); + + /* Handover Reference IE (see 3GPP TS 48.058, 9.3.9) */ + var RSL_IE ho_ref_ie := valueof(t_RSL_IE(RSL_IE_HANDO_REF, + RSL_IE_Body:{ handover_ref := ho_ref })); + + /* Activate a channel on the BTS side (no encryption) */ + f_rsl_chan_act(g_pars.chan_mode, more_ies := { ho_ref_ie }, + act_type := t_RSL_IE_ActType_HO_SYNC); + + /* Switch the MS side (e.g. trxcon) to a dedicated channel without + * waiting for Immediate Assignment and sending of an Access Burst. */ + f_l1ctl_est_dchan(L1CTL, g_pars); /* FIXME: disable Uplink Tx */ + + /* Expect nothing to be transmitted on Downlink DCCH. Nothing in this + * context means any L2 frames, not only the RR Physical Information. */ + T.start(2.0); + L1CTL.clear; + alt { + [] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, tr_RslLinkID_DCCH(?))) -> value dl { + setverdict(fail, "Rx unexpected Downlink DCCH (before handover RACH): ", dl); + T.stop; + } + [] L1CTL.receive { repeat; } + [] T.timeout { setverdict(pass); } + } + + /* Send handover Access Burst */ + log("Sending handover Access Burst"); + f_L1CTL_RACH(L1CTL, ho_ref, chan_nr := g_pars.chan_nr); + + /* Expect RR Physical Information being sent on Downlink DCCH Ny1 times */ + T.start(int2float(mp_ho_t3105_ms * mp_ho_ny1) / 1000.0 + 1.0); + L1CTL.clear; + alt { + [] as_dl_lapdm_dummy(); /* Ignore empty LAPDm func=UI frames */ + [] as_dl_dcch_pdu(dcch_pdu, tr_RRM_PhysicalInfo) { + log("Rx RR Physical Information: ", dcch_pdu); + /* Wait until the count reaches Ny1 */ + count := count + 1; + if (count < mp_ho_ny1) + { repeat; } + setverdict(pass); + } + [] as_dl_dcch_pdu(dcch_pdu, ?) { + setverdict(fail, "Rx unexpected DCCH PDU: ", dcch_pdu); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + [] L1CTL.receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for RR Physical Information"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } + + /* Release the channel */ + f_rsl_chan_deact(); + f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr); +} +testcase TC_ho_physical_info() runs on test_CT { + var ConnHdlrPars pars; + var ConnHdlr vc_conn; + + f_init(); + + for (var integer i := 0; i < sizeof(g_AllChanTypes); i := i + 1) { + pars := valueof(t_Pars(g_AllChanTypes[i], ts_RSL_ChanMode_SIGN)); + log(testcasename(), ": Starting for ", g_AllChanTypes[i]); + vc_conn := f_start_handler(refers(f_TC_ho_physical_info), pars); + vc_conn.done; + } + + /* TODO: do the above in parallel, rather than sequentially? */ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); +} + /*********************************************************************** * Measurement Processing / Reporting ***********************************************************************/ @@ -8381,6 +8472,7 @@ execute( TC_rach_count() ); execute( TC_rach_max_ta() ); execute( TC_ho_rach() ); + execute( TC_ho_physical_info() ); execute( TC_rach_load_idle_thresh0() ); execute( TC_rach_load_idle_below_thresh() ); execute( TC_rach_load_count() ); diff --git a/bts/expected-results.xml b/bts/expected-results.xml index 2dffe06..e3804a4 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -16,6 +16,12 @@ <testcase classname='BTS_Tests' name='TC_rach_count' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_max_ta' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_ho_rach' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_ho_physical_info' time='MASKED'> + <failure type='fail-verdict'>"BTS_Tests.ttcn:MASKED : Rx unexpected Downlink DCCH (before handover RACH): MASKED" + BTS_Tests.ttcn:MASKED BTS_Tests control part + BTS_Tests.ttcn:MASKED TC_ho_physical_info testcase + </failure> + </testcase> <testcase classname='BTS_Tests' name='TC_rach_load_idle_thresh0' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_load_idle_below_thresh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_load_count' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9469027ce88fb2750f1eceef2d8a56d4b8ee4d03 Gerrit-Change-Number: 27500 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add new test case TC_ho_physical_info

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27500 ) Change subject: BTS_Tests: add new test case TC_ho_physical_info ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: 1+1=2 File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27500/comment/f097c5c8_59a5… PS1, Line 1980: T.start(2.0); > Shouldn't this time out also at the BTS at some point if no RACH is received for a while? 2 seconds […] Hmm, AFAIR it's up to the BSC how long to wait for Handover Detection message. The BTS itself does not care how long a given channel is activated. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9469027ce88fb2750f1eceef2d8a56d4b8ee4d03 Gerrit-Change-Number: 27500 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:52:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27486 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Didn't I already review this patch somewhere else? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27486 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 10:52:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022