March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-dev[master]: ttcn3/tmux/ttcn3-bts-test.sh: fix incorrectly passed --trx arguments

by fixeria

Attention is currently required from: osmith, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27485 ) Change subject: ttcn3/tmux/ttcn3-bts-test.sh: fix incorrectly passed --trx arguments ...................................................................... Patch Set 1: Verified+1 Code-Review+2 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-dev/+/27485/comment/7558005d_a9f45aae PS1, Line 12: /bin/sh: symbolic link to bash > that's odd, i thought the idea is that /bin/sh has less features and is considered safer I don't know why it's done this way on Arch. I already faced some compatibility problems between my bash working in POSIX-compliant mode and the real sh in our Docker infrastructure. Related: https://unix.stackexchange.com/questions/44836/when-sh-is-a-symlink-to-bash…. Patchset: PS1: > i added you to the group of osmo-dev reviewers to add permissions, and, i'd invite you to directly p […] Thanks Neels! -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibf28ac013c426baba491af45e2ae46f37685a402 Gerrit-Change-Number: 27485 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 12:29:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[2021q4]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27502 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... rsl: fix wrong IE being checked in rsl_rx_chan_activ() According to 3GPP TS 48.058, section 4.1.4, BTS shall start transmission on SACCH if both MS Power and *Timing Advance* IEs are present. There can be no Access Delay IE in the RSL CHANnel ACTIVation message. Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Fixes: I170b63c9856230d5f1a10654a9d950ada8e730d7 Related: SYS#5838 --- M src/common/rsl.c 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/common/rsl.c b/src/common/rsl.c index 9b73869..71b2997 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1902,21 +1902,21 @@ /* Indicate which SAPIs should be enabled before the first RACH is received, for handover. See 3GPP TS 48.058 * 4.1.3 and 4.1.4. * - * | | Access || transmit | activate | This implementation - * | MS Power | Delay || on main channel | dl SACCH | activates DL SACCH + * | | Timing || transmit | activate | This implementation + * | MS Power | Advance || on main channel | dl SACCH | activates DL SACCH * ----------------------------------------------------------------------------------------- - * async ho no * --> yes no no - * async ho yes * --> yes may be started no - * async ho yes yes --> yes may be started yes - * sync ho no no --> yes no no - * sync ho yes no --> yes may be started no - * sync ho yes yes --> yes shall be started yes + * async ho no * --> yes no no + * async ho yes * --> yes may be started no + * async ho yes yes --> yes may be started yes + * sync ho no no --> yes no no + * sync ho yes no --> yes may be started no + * sync ho yes yes --> yes shall be started yes */ switch (type) { case RSL_ACT_INTER_ASYNC: case RSL_ACT_INTER_SYNC: lchan->want_dl_sacch_active = (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1) - && TLVP_PRES_LEN(&tp, RSL_IE_ACCESS_DELAY, 1)); + && TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1)); break; default: lchan->want_dl_sacch_active = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2021q4 Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-bts[2021q4]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27502 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2021q4 Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 12:22:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[2021q1]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27501 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... rsl: fix wrong IE being checked in rsl_rx_chan_activ() According to 3GPP TS 48.058, section 4.1.4, BTS shall start transmission on SACCH if both MS Power and *Timing Advance* IEs are present. There can be no Access Delay IE in the RSL CHANnel ACTIVation message. Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Fixes: I170b63c9856230d5f1a10654a9d950ada8e730d7 Related: SYS#5838 --- M src/common/rsl.c 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/common/rsl.c b/src/common/rsl.c index cd3fda5..a62a01c 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1645,21 +1645,21 @@ /* Indicate which SAPIs should be enabled before the first RACH is received, for handover. See 3GPP TS 48.058 * 4.1.3 and 4.1.4. * - * | | Access || transmit | activate | This implementation - * | MS Power | Delay || on main channel | dl SACCH | activates DL SACCH + * | | Timing || transmit | activate | This implementation + * | MS Power | Advance || on main channel | dl SACCH | activates DL SACCH * ----------------------------------------------------------------------------------------- - * async ho no * --> yes no no - * async ho yes * --> yes may be started no - * async ho yes yes --> yes may be started yes - * sync ho no no --> yes no no - * sync ho yes no --> yes may be started no - * sync ho yes yes --> yes shall be started yes + * async ho no * --> yes no no + * async ho yes * --> yes may be started no + * async ho yes yes --> yes may be started yes + * sync ho no no --> yes no no + * sync ho yes no --> yes may be started no + * sync ho yes yes --> yes shall be started yes */ switch (type) { case RSL_ACT_INTER_ASYNC: case RSL_ACT_INTER_SYNC: lchan->want_dl_sacch_active = (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1) - && TLVP_PRES_LEN(&tp, RSL_IE_ACCESS_DELAY, 1)); + && TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1)); break; default: lchan->want_dl_sacch_active = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2021q1 Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27501 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-bts[2021q1]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27501 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: 2021q1 Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27501 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 14 Mar 2022 12:21:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27486 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... rsl: fix wrong IE being checked in rsl_rx_chan_activ() According to 3GPP TS 48.058, section 4.1.4, BTS shall start transmission on SACCH if both MS Power and *Timing Advance* IEs are present. There can be no Access Delay IE in the RSL CHANnel ACTIVation message. Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Fixes: I170b63c9856230d5f1a10654a9d950ada8e730d7 Related: SYS#5838 --- M src/common/rsl.c 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/rsl.c b/src/common/rsl.c index 7d6621a..5112ee5 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1902,21 +1902,21 @@ /* Indicate which SAPIs should be enabled before the first RACH is received, for handover. See 3GPP TS 48.058 * 4.1.3 and 4.1.4. * - * | | Access || transmit | activate | This implementation - * | MS Power | Delay || on main channel | dl SACCH | activates DL SACCH + * | | Timing || transmit | activate | This implementation + * | MS Power | Advance || on main channel | dl SACCH | activates DL SACCH * ----------------------------------------------------------------------------------------- - * async ho no * --> yes no no - * async ho yes * --> yes may be started no - * async ho yes yes --> yes may be started yes - * sync ho no no --> yes no no - * sync ho yes no --> yes may be started no - * sync ho yes yes --> yes shall be started yes + * async ho no * --> yes no no + * async ho yes * --> yes may be started no + * async ho yes yes --> yes may be started yes + * sync ho no no --> yes no no + * sync ho yes no --> yes may be started no + * sync ho yes yes --> yes shall be started yes */ switch (type) { case RSL_ACT_INTER_ASYNC: case RSL_ACT_INTER_SYNC: lchan->want_dl_sacch_active = (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1) - && TLVP_PRES_LEN(&tp, RSL_IE_ACCESS_DELAY, 1)); + && TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1)); break; default: lchan->want_dl_sacch_active = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27486 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: follow-up to osmo_sockaddr_from/to_octets()

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27085 ) Change subject: follow-up to osmo_sockaddr_from/to_octets() ...................................................................... Patch Set 1: (1 comment) File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/27085/comment/0083e9ff_b2a3026a PS1, Line 1779: os->u.sa.sa_family = AF_INET; > This should have been kept as os->u.sin. […] yes, i understand and agree, apparently i wasn't paying close attention to that -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id202f3fda51bea9149ab3462a2efe35cf08d8030 Gerrit-Change-Number: 27085 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 12:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-dev[master]: ttcn3/tmux/ttcn3-bts-test.sh: fix incorrectly passed --trx arguments

by neels

Attention is currently required from: osmith, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27485 ) Change subject: ttcn3/tmux/ttcn3-bts-test.sh: fix incorrectly passed --trx arguments ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-dev/+/27485/comment/9b458119_be9eb129 PS1, Line 12: /bin/sh: symbolic link to bash that's odd, i thought the idea is that /bin/sh has less features and is considered safer Patchset: PS1: i added you to the group of osmo-dev reviewers to add permissions, and, i'd invite you to directly push changes to osmo-dev's master branch. the argument is that osmo-dev isn't critical to users and we can do what we please in our corner of the workshop. i'm confident that each of us is easily capable of fixing errors that may have come in via unreviewed push, plus we all know what we're doing, so i think overall it's more fun without the code review step here. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibf28ac013c426baba491af45e2ae46f37685a402 Gerrit-Change-Number: 27485 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 12:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by neels

Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27486 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/27486/comment/1b9b4792_27ac97e1 PS1, Line 1919: && TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1)); man, how confusing. the two IEs are even identical, except that the Access Delay allows higher range. good catch! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27486 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 11:53:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): do not calculate BER10k for FACCH twice

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27483 ) Change subject: osmo-bts-trx: rx_tchh_fn(): do not calculate BER10k for FACCH twice ...................................................................... osmo-bts-trx: rx_tchh_fn(): do not calculate BER10k for FACCH twice We already have BER10k calculated in the generic code path, so do not calculate it once again in the FACCH specific branch. Change-Id: I5d3955d09990e280d11d687385eeaf5edf437395 --- M src/osmo-bts-trx/sched_lchan_tchh.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index 27880c1..b6d83d0 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -269,7 +269,6 @@ /* FACCH */ if (rc == GSM_MACBLOCK_LEN) { chan_state->ul_ongoing_facch = 1; - uint16_t ber10k = compute_ber10k(n_bits_total, n_errors); if (lchan->nr == 0) fn_begin = gsm0502_fn_remap(bi->fn, FN_REMAP_FACCH_H0); else 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5d3955d09990e280d11d687385eeaf5edf437395 Gerrit-Change-Number: 27483 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022