December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: fix permissions

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30434 ) Change subject: jobs/osmo-gsm-tester virtual: fix permissions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I91bd6656f33667f401247721bb34298a6c66fc62 Gerrit-Change-Number: 30434 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 10:20:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm_forward_mncc(): call mncc_sock_from_cc() directly

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30400 ) Change subject: mobile: gsm_forward_mncc(): call mncc_sock_from_cc() directly ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I29305866e61a0bc3bd082108af6a9ba8ff86bcf2 Gerrit-Change-Number: 30400 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 10:19:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: fix with cgroups2 on host

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30433 ) Change subject: repo-install-test: fix with cgroups2 on host ...................................................................... Abandoned still wip, meant to only submit the other patch -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7d2a93756f807301ee77d14d1a5e67d2e1262448 Gerrit-Change-Number: 30433 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: fix with cgroups2 on host

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30433 ) Change subject: repo-install-test: fix with cgroups2 on host ...................................................................... repo-install-test: fix with cgroups2 on host On hosts newer than debian 9, starting systemd inside docker failed with: Failed to create /init.scope control group: Read-only file system Failed to allocate manager object: Read-only file system [!!!!!!] Failed to allocate manager object. This is because /sys/fs/cgroup was mounted inside the docker container, and once the host has cgroup v2 systemd tries to write to it and fails. Adjust the docker run command so it works with cgroup v2 and we can run repo-install-test on hosts with higher debian versions. Related: OS#5685 Related: https://serverfault.com/a/1087467 Change-Id: I7d2a93756f807301ee77d14d1a5e67d2e1262448 --- M scripts/repo-install-test.sh 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/33/30433/1 diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh index 2a3e739..5787b84 100755 --- a/scripts/repo-install-test.sh +++ b/scripts/repo-install-test.sh @@ -101,7 +101,9 @@ --tmpfs /run \ --tmpfs /run/lock \ --tmpfs /tmp \ - -v /sys/fs/cgroup:/sys/fs/cgroup:ro \ + --cgroup-parent=docker.slice \ + --cgroupns private \ + --privileged \ --cap-add SYS_ADMIN \ --cap-add SYS_NICE \ $args \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7d2a93756f807301ee77d14d1a5e67d2e1262448 Gerrit-Change-Number: 30433 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: fix permissions

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30434 ) Change subject: jobs/osmo-gsm-tester virtual: fix permissions ...................................................................... jobs/osmo-gsm-tester virtual: fix permissions The docker container creates the trial dir and some files inside of it as root, therefore the rm -rf trial-* line fails. Add logic to fix the permissions before attempting to remove old trial-* and when the script exits. Related: OS#5793 Change-Id: I91bd6656f33667f401247721bb34298a6c66fc62 --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/30434/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 9a57ead..688da38 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -218,12 +218,35 @@ - timed: "H 22 * * *" builders: - shell: | - # make sure no test results/bin artifacts from a previous run remain - rm -rf trial-* *.tgz *.md5 + # make sure no bin artifacts from a previous run remain + rm -rf *.tgz *.md5 - copy_artifact_all - copy_artifact: repo: osmo-gsm-tester_build-osmocom-bb - shell: | + # Set a trap to fix workspace permissions on exit + fix_permissions() { + docker run --rm \ + -v "$WORKSPACE":/workspace \ + debian:bullseye \ + chmod -R a+rwX /workspace/ + } + fix_permissions_trap() { + set +x + echo + echo "### Clean up ###" + echo + set -x + + trap - EXIT INT TERM 0 + fix_permissions + } + trap fix_permissions_trap EXIT INT TERM 0 + + # Make sure no test results from a previous run remain + fix_permissions + rm -rf trial-* + # Build the docker image rm -rf docker-playground git clone \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I91bd6656f33667f401247721bb34298a6c66fc62 Gerrit-Change-Number: 30434 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after...

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 ) Change subject: pcu: TC_cs_max_dl: Fix race condition waiting for first DL data after X2002 ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371/comment/3f5c556e_d7f4… PS2, Line 1094: for (i := 0; i < 10; i := i + 1) { : f_rx_rlcmac_dl_block(dl_block, fn); : : if (not match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL)) { : /* Received first data, starting processing: */ : break; : } : } > I thought about it, but decided to do it this way to avoid encapsulating more stuff, since in the en […] Agreeing with Harald. Let's better avoid code duplication. The function can simply accept an out parameter, which will be holding the first non-dummy block. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If7121473a3580b40d3a658dc38b9bb1421196127 Gerrit-Change-Number: 30371 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 02:56:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm_forward_mncc(): call mncc_sock_from_cc() directly

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30400 ) Change subject: mobile: gsm_forward_mncc(): call mncc_sock_from_cc() directly ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > what's the point of having a function pointer if you hardcode (or you know you can hardcode) a speci […] The function pointer (ms->mncc_entity.mncc_recv) is generally used for passing Call Control messages to whatever CC entity (dummy/internal/external) the user has selected in the mobile.cfg. This is still the case even with this patch applied. However the external CC approach is a bit special in a way that you can not only pass the signalling CC messages, but also the actual voice frames. This is not the case on the network side anymore, where osmo-msc is simply bridging RTP streams (via osmo-mgw) and not receiving the actual TCH voice frames directly. But this was possible in osmo-nitb, and is possible in osmocom-bb/mobile. Given that it's only possible with an external MNCC app, I believe it's fine calling the respective function directly for TCH frames here. For CC signalling we're still using ms->mncc_entity.mncc_recv. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I29305866e61a0bc3bd082108af6a9ba8ff86bcf2 Gerrit-Change-Number: 30400 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 01:40:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size Num. of NSVCs IE

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30432 ) Change subject: WIP: ns: Add test for SNS Size Num. of NSVCs IE ...................................................................... WIP: ns: Add test for SNS Size Num. of NSVCs IE Related: OS#5208 Change-Id: Ic69c461cdb854a1b7abd27c56d70c3cbe32e6eb7 --- M ns/NS_Tests.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/30432/1 diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index 64ab5dc..a87058b 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -640,6 +640,31 @@ f_clean_ns_codec(); } +testcase TC_sns_sgsn_sns_size_outgoing_invalid_num_of_nsvcs() runs on RAW_Test_CT { + f_init_vty(); + f_init_ns_codec(mp_nsconfig); + /* Assumption: No connections to other NSEs for SUT and testcomponent */ + const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); + const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); + const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; + const integer IDX := 0; + /* Template that would be accepted, only missing the number of IP endpoints + * (since there are no ternary operators in TTCN-3...) */ + var template (omit) PDU_NS ts_base_SNS_SIZE_configured := + ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, + num_v4 := omit, num_v6 := omit); + var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[IDX]; + ts_base_SNS_SIZE_configured.pDU_SNS_Size.nSEI_NS := ts_NS_IE_NSEI(g_nsconfig.nsei); + f_set_num_of_ip_endpoints(ts_base_SNS_SIZE_configured, g_nsconfig.nsvc[0].provider.ip.address_family); + /* Assumption: No connections to other NSEs for SUT and testcomponent and thus no other endpoints */ + const integer required_max_num_of_nsvcs := num_of_nsvcs; + const uint16_t invalid_max_num_of_nsvcs := required_max_num_of_nsvcs - 1; + ts_base_SNS_SIZE_configured.pDU_SNS_Size.maxNumberOfNSVCs := ts_SNS_IE_MaxNumOfNSVCs(invalid_max_num_of_nsvcs); + const NsCause cause := NS_CAUSE_INVALID_NR_OF_NSVCS; + f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); + f_clean_ns_codec(); +} + testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1181,6 +1206,7 @@ execute( TC_sns_sgsn_size_after_success() ); execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); execute( TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() ); + execute( TC_sns_sgsn_sns_size_outgoing_invalid_num_of_nsvcs() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic69c461cdb854a1b7abd27c56d70c3cbe32e6eb7 Gerrit-Change-Number: 30432 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size NSEI IE

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30430 ) Change subject: WIP: ns: Add test for SNS Size NSEI IE ...................................................................... WIP: ns: Add test for SNS Size NSEI IE Related: OS#5208 Change-Id: I3584b7b048031c798cee9566c4cc8694bf6002ac --- M ns/NS_Tests.ttcn 1 file changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/30430/1 diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index 722f8ec..3ebdbf3 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -67,6 +67,9 @@ } } }; + NsIEI ns_iei_num_ipv4_ep := NS_IEI_NUM_IPv4_EP; + NsIEI ns_iei_num_ipv6_ep := NS_IEI_NUM_IPv6_EP; + NsIEI ns_iei_nsei := NS_IEI_NSEI; } type component RAW_Test_CT extends RAW_NS_CT { @@ -559,6 +562,53 @@ /* 48.016 SNS test cases */ /* do a succesful SNS configuration */ +function f_send_expect(in integer NSCP_IDX, in template (omit) PDU_NS pdu, + in NsCause c) runs on RAW_Test_CT { + log("Expected cause: ", c); + NSCP[NSCP_IDX].send(pdu); + f_ns_exp(tr_SNS_SIZE_ACK(g_nsconfig.nsei, c), NSCP_IDX); +} + +function f_set_num_of_ip_endpoints(inout template (omit) PDU_NS base, AddressFamily af) runs on RAW_Test_CT { + const integer NUM_IP := 1; + if (af == AF_INET) { + base.pDU_SNS_Size.numberOfIP4_Endpoints := + {iEI := int2oct(enum2int(ns_iei_num_ipv4_ep), 1), + numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; + } else { + base.pDU_SNS_Size.numberOfIP4_Endpoints := + {iEI := int2oct(enum2int(ns_iei_num_ipv6_ep), 1), + numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; + } +} + +/* Send SNS Size PDUs with invalid IEs */ +testcase TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() runs on RAW_Test_CT { + f_init_vty(); + f_init_ns_codec(mp_nsconfig); + const integer IDX := 0; + /* Assumption: No connections to other NSEs for SUT and testcomponent */ + const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); + const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); + const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; + /* Template that would be accepted, only missing the number of IP endpoints + * (since there are no ternary operators in TTCN-3...) */ + var template (omit) PDU_NS ts_base_SNS_SIZE_configured := + ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, + num_v4 := omit, num_v6 := omit); + var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[IDX]; + + f_set_num_of_ip_endpoints(ts_base_SNS_SIZE_configured, g_nsconfig.nsvc[0].provider.ip.address_family); + /* Syntactical error here: length of 1 (has to be >=2) */ + ts_base_SNS_SIZE_configured.pDU_SNS_Size.nSEI_NS := + {iEI := int2oct(enum2int(ns_iei_nsei), 1), ext := '0'B, lengthIndicator := {length1 := 1}, + nSEI := int2oct(g_nsconfig.nsei, 2)}; + const NsCause cause := NS_CAUSE_INVALID_ESSENTIAL_IE; + f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); + setverdict(pass); + f_clean_ns_codec(); +} + testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1098,6 +1148,7 @@ execute( TC_sns_sgsn_add_change_del() ); execute( TC_sns_sgsn_size_correct_port() ); execute( TC_sns_sgsn_size_after_success() ); + execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3584b7b048031c798cee9566c4cc8694bf6002ac Gerrit-Change-Number: 30430 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 ) Change subject: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE ...................................................................... WIP: ns: Add test for SNS Size Num. of IP Endpoints IE Related: OS#5208 Change-Id: I85c2dc201ba485d7bfdcc70e1a5f8a890023c435 --- M ns/NS_Tests.ttcn 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/30431/1 diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index 3ebdbf3..64ab5dc 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -609,6 +609,37 @@ f_clean_ns_codec(); } +testcase TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() runs on RAW_Test_CT { + f_init_vty(); + f_init_ns_codec(mp_nsconfig); + const integer IDX := 0; + const integer NUM_IP := 1; + log("f_outgoing_sns_size_invalid_num_of_ip_eps(idx=", IDX, ")"); + var NsCause cause; + /* Assumption: No connections to other NSEs for SUT and testcomponent */ + const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); + const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); + const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; + /* Template that would be accepted, only missing the number of IP endpoints + * (since there are no ternary operators in TTCN-3...) */ + var template (omit) PDU_NS ts_base_SNS_SIZE_configured := + ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, + num_v4 := omit, num_v6 := omit); + /* Send IP4 endpoints when IP6 is configured and vice versa, in effect sending an unsupported type of NS-VC endpoints. */ + if (g_nsconfig.nsvc[0].provider.ip.address_family == AF_INET) { + ts_base_SNS_SIZE_configured.pDU_SNS_Size.numberOfIP6_Endpoints := + {iEI := int2oct(enum2int(ns_iei_num_ipv6_ep), 1), numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; + cause := NS_CAUSE_INVALID_NR_OF_IPv6_ENDPOINTS; + } else { + ts_base_SNS_SIZE_configured.pDU_SNS_Size.numberOfIP4_Endpoints := + {iEI := int2oct(enum2int(ns_iei_num_ipv4_ep), 1), numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; + cause := NS_CAUSE_INVALID_NR_OF_IPv4_ENDPOINTS; + } + f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); + setverdict(pass); + f_clean_ns_codec(); +} + testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1149,6 +1180,7 @@ execute( TC_sns_sgsn_size_correct_port() ); execute( TC_sns_sgsn_size_after_success() ); execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); + execute( TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I85c2dc201ba485d7bfdcc70e1a5f8a890023c435 Gerrit-Change-Number: 30431 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022