Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30400 ) Change subject: mobile: gsm_forward_mncc(): call mncc_sock_from_cc() directly ...................................................................... Patch Set 2: (1 comment) Patchset: PS2:

what's the point of having a function pointer if you hardcode (or you know you can hardcode) a speci […] The function pointer (ms->mncc_entity.mncc_recv) is generally used for passing Call Control messages to whatever CC entity (dummy/internal/external) the user has selected in the mobile.cfg. This is still the case even with this patch applied.

However the external CC approach is a bit special in a way that you can not only pass the signalling CC messages, but also the actual voice frames. This is not the case on the network side anymore, where osmo-msc is simply bridging RTP streams (via osmo-mgw) and not receiving the actual TCH voice frames directly. But this was possible in osmo-nitb, and is possible in osmocom-bb/mobile. Given that it's only possible with an external MNCC app, I believe it's fine calling the respective function directly for TCH frames here. For CC signalling we're still using ms->mncc_entity.mncc_recv. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I29305866e61a0bc3bd082108af6a9ba8ff86bcf2 Gerrit-Change-Number: 30400 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 01:40:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment