gerrit-log December 2022

gerrit-log@lists.osmocom.org

1 participants
1979 discussions

Start a nNew thread

Change in osmo-trx[master]: vita demod by piotr krysik, modified
by Jenkins Builder 02 Dec '22

02 Dec '22

1 0

Change in osmo-trx[master]: vita demod by piotr krysik, modified
by Hoernchen 02 Dec '22

02 Dec '22

Attention is currently required from: Hoernchen, pespin, fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 to look at the new patch set (#5). Change subject: vita demod by piotr krysik, modified ...................................................................... vita demod by piotr krysik, modified Grabbed from gr-gsm 2de47e28ce1fb9a518337bfc0add36c8e3cff5eb Had a few rounds of extensive cleanup (not the va itself). Uses gcc multiversioning for x86 targets. Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f --- A Transceiver52M/grgsm_vitac/constants.h A Transceiver52M/grgsm_vitac/grgsm_vitac.cpp A Transceiver52M/grgsm_vitac/grgsm_vitac.h A Transceiver52M/grgsm_vitac/viterbi_detector.cc A Transceiver52M/grgsm_vitac/viterbi_detector.h 5 files changed, 959 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/15/30415/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-trx[master]: ms-trx support
by pespin 02 Dec '22

02 Dec '22

Attention is currently required from: Hoernchen, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Can we get the linter thing fixed first please? otherwise it's impossible to review. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 13:24:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-trx[master]: vita demod by piotr krysik, modified
by Jenkins Builder 02 Dec '22

02 Dec '22

Attention is currently required from: Hoernchen, pespin, fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 ) Change subject: vita demod by piotr krysik, modified ...................................................................... Patch Set 4: (692 comments) File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7244d104_c74ad3c7 PS4, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d498cb9_2c05222a PS4, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06a97362_008be061 PS4, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aa749ef2_3cf66b41 PS4, Line 4: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c13ecc03_33e9bd8f PS4, Line 5: * @author Contributions by sysmocom - s.f.m.c. GmbH / Eric Wild <ewild(a)sysmocom.de> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03f592a5_11614b20 PS4, Line 6: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4fa816e9_79527bcd PS4, Line 7: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13de5f09_32c17231 PS4, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e54c5cc6_4add4a2c PS4, Line 9: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d24837b9_e5382d4f PS4, Line 10: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a985dfe_882faeb1 PS4, Line 11: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37c4623d_a2108267 PS4, Line 12: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4eb0a4a4_b256687b PS4, Line 13: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2754fc7d_2178a6ba PS4, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75de5a4b_967e58f1 PS4, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a416f954_b503ae67 PS4, Line 16: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79c808d1_cf4209eb PS4, Line 17: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/518c5acc_0c15b4a9 PS4, Line 18: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06fd629f_aab83034 PS4, Line 19: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2981341d_08c4b9f6 PS4, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9954fa9a_0f586feb PS4, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acc5d78f_3375c1cf PS4, Line 21: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64bae917_90b2e110 PS4, Line 22: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/50439343_627a8183 PS4, Line 23: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71a10e94_0122ebc5 PS4, Line 24: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a134a4e_3698bb40 PS4, Line 25: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/337161d2_7a41055a PS4, Line 26: #ifdef HAVE_CONFIG_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35cf213c_5a326aeb PS4, Line 27: #include "config.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/16befb83_ea26c4d6 PS4, Line 28: #endif DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5985a4c7_932aaaca PS4, Line 29: #include <complex> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/419110a1_fc00e4b2 PS4, Line 30: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/875928eb_44663a9a PS4, Line 31: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4cf9244d_9f94ed4e PS4, Line 32: #include <algorithm> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f880965_52c6636b PS4, Line 33: #include <string.h> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5285d312_a1fcc8cc PS4, Line 34: #include <iostream> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f4f90508_124444e8 PS4, Line 35: #include <numeric> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca473b7c_6b432607 PS4, Line 36: #include <vector> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9104ff45_e8d2b715 PS4, Line 37: #include <fstream> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f2c8e42_83b45899 PS4, Line 38: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c07e36d9_010f20ef PS4, Line 39: #include "viterbi_detector.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48da2579_06da111f PS4, Line 40: #include "grgsm_vitac.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d465ebd1_1c8fed39 PS4, Line 41: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d661cca_8b69b843 PS4, Line 42: //signalVector mChanResp; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fe44b24_14eea2dd PS4, Line 43: gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45e252e6_55da805a PS4, Line 44: gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9a230d0f_e9329565 PS4, Line 45: const int d_chan_imp_length = CHAN_IMP_RESP_LENGTH; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f09e81_8865459a PS4, Line 46: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b285b5ca_72118d6f PS4, Line 47: void initvita() { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/148497cd_cdfa93d0 PS4, Line 48: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86ce0025_df2b6dc4 PS4, Line 49: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93c46ddd_92cb245b PS4, Line 50: * Prepare SCH sequence bits trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2be76b20_1bd95906 PS4, Line 51: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f258408_13724b04 PS4, Line 52: * (TS_BITS + 2 * GUARD_PERIOD) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18eb9608_6b38d349 PS4, Line 53: * Burst and two guard periods trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76f17b4c_75fc5350 PS4, Line 54: * (one guard period is an arbitrary overlap) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83853ed3_97b97267 PS4, Line 55: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1b1d62c_cb6ac8a2 PS4, Line 56: gmsk_mapper(SYNC_BITS, N_SYNC_BITS, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf372af2_766a8565 PS4, Line 57: d_sch_training_seq, gr_complex(0.0, -1.0)); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e98f213c_d4cd765c PS4, Line 58: for (auto &i : d_sch_training_seq) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f4af36e9_a2ff2d07 PS4, Line 59: i = conj(i); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f152a918_1bbba413 PS4, Line 60: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9f609e6_0e86977c PS4, Line 61: /* Prepare bits of training sequences */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66ee733f_dec01f61 PS4, Line 62: for (int i = 0; i < TRAIN_SEQ_NUM; i++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/34531700_a6a57a6c PS4, Line 63: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a09d1e8_6f2251ae PS4, Line 64: * If first bit of the sequence is 0 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f531f27d_c9851c5f PS4, Line 65: * => first symbol is 1, else -1 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a46e71a_c862ede3 PS4, Line 66: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4923536_0a814cc9 PS4, Line 67: gr_complex startpoint = train_seq[i][0] == 0 ? DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0fe911df_0244bfe4 PS4, Line 68: gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebd94553_51d32115 PS4, Line 69: gmsk_mapper(train_seq[i], N_TRAIN_BITS, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0fa35dd5_66975e0f PS4, Line 70: d_norm_training_seq[i], startpoint); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c85beeba_0930b760 PS4, Line 71: for (auto &i : d_norm_training_seq[i]) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15eb3fdf_09f07190 PS4, Line 72: i = conj(i); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c5c7d843_35480f95 PS4, Line 73: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2bc068d8_43a6354d PS4, Line 74: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0140d0f5_3c76826e PS4, Line 75: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a94b9d9_e9755460 PS4, Line 76: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aeaa359c_2769ccfa PS4, Line 77: MULTI_VER_TARGET_ATTR DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6597647_8966bdd9 PS4, Line 78: void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a03b95a_f7a872c0 PS4, Line 79: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17862483_cbd8dca3 PS4, Line 80: std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/206d90b5_c351055f PS4, Line 81: unsigned int stop_states[2] = { 4, 12 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/744eb83f_832e9255 PS4, Line 82: gr_complex filtered_burst[BURST_SIZE]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3f3b6da_a4d875f1 PS4, Line 83: gr_complex rhh[CHAN_IMP_RESP_LENGTH]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8519f08_3c24ad79 PS4, Line 84: float output[BURST_SIZE]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7606e746_6e289090 PS4, Line 85: int start_state = 3; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d5532ebf_4137b506 PS4, Line 86: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ee6ae238_7bf79971 PS4, Line 87: // if(burst_start < 0 ||burst_start > 10) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79650d38_ec48edc4 PS4, Line 88: // fprintf(stderr, "bo %d\n", burst_start); trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d96db033_9ea338bf PS4, Line 89: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6bbc4fbf_e33e697e PS4, Line 90: // burst_start = burst_start >= 0 ? burst_start : 0; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed7e17de_94edc6ee PS4, Line 91: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5bab16da_8696b4d3 PS4, Line 92: autocorrelation(chan_imp_resp, &rhh_temp[0], d_chan_imp_length * d_OSR); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f440d14d_13654a14 PS4, Line 93: for (int ii = 0; ii < d_chan_imp_length; ii++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed918ec1_93fcd0a4 PS4, Line 94: rhh[ii] = conj(rhh_temp[ii * d_OSR]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/518bd02a_8699e121 PS4, Line 95: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e676a75_d7bc21d4 PS4, Line 96: mafi(&input[burst_start], BURST_SIZE, chan_imp_resp, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f583c6bf_8cdfb69c PS4, Line 97: d_chan_imp_length * d_OSR, filtered_burst); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e60e322a_8801cada PS4, Line 98: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0cc33a06_9da2ccfa PS4, Line 99: viterbi_detector(filtered_burst, BURST_SIZE, rhh, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e00c80c_dcfd28e7 PS4, Line 100: start_state, stop_states, 2, output); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/860582f1_c8f10c74 PS4, Line 101: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21347fa6_87bfa18e PS4, Line 102: for (int i = 0; i < BURST_SIZE; i++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9fc11e64_f16a8384 PS4, Line 103: output_binary[i] = output[i] * -127; // pre flip bits! trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b185edcb_651a7da8 PS4, Line 104: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/993e19d2_a0596c9c PS4, Line 105: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bdd66a51_13a8a372 PS4, Line 106: void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1388a5db_2d423f0b PS4, Line 107: gmsk_mapper(const unsigned char* input, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5f5cdc8_e76f6f72 PS4, Line 108: int nitems, gr_complex* gmsk_output, gr_complex start_point) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/615f254c_1f465eca PS4, Line 109: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ab5cca1_f45b0ae0 PS4, Line 110: gr_complex j = gr_complex(0.0, 1.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57cbfb1b_817b3267 PS4, Line 111: gmsk_output[0] = start_point; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9468654d_994d1032 PS4, Line 112: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43d2227d_fd2417ae PS4, Line 113: int previous_symbol = 2 * input[0] - 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc9d23f8_d706fb1f PS4, Line 114: int current_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/81fb73dc_ba01226f PS4, Line 115: int encoded_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8942830a_b1a10818 PS4, Line 116: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a75187d_f2ecaa5e PS4, Line 117: for (int i = 1; i < nitems; i++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e316c7a_ace7edbe PS4, Line 118: /* Change bits representation to NRZ */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2fa1df77_66a28b71 PS4, Line 119: current_symbol = 2 * input[i] - 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12e3e2e7_f960220e PS4, Line 120: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a123880d_d6df2340 PS4, Line 121: /* Differentially encode */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d72c75f_aa1eb9ba PS4, Line 122: encoded_symbol = current_symbol * previous_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ab79c15_cb54de21 PS4, Line 123: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d23807d9_1dbdc3a7 PS4, Line 124: /* And do GMSK mapping */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64760df0_7cb4a3b7 PS4, Line 125: gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d35c6d1_b879f3b3 PS4, Line 126: * gmsk_output[i - 1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fdb314c6_ca0a482d PS4, Line 127: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e55c09a_316da7a2 PS4, Line 128: previous_symbol = current_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b271f2f7_c26e20bf PS4, Line 129: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e5ad3e6_9342970f PS4, Line 130: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a505eb63_dc57db37 PS4, Line 131: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ccb94df7_7784398e PS4, Line 132: gr_complex DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/402b9547_07eb640f PS4, Line 133: correlate_sequence(const gr_complex* sequence, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9e7ac012_8979f8ac PS4, Line 134: int length, const gr_complex* input) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fcffeed3_6fbf2f46 PS4, Line 135: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1b2c2041_dde96136 PS4, Line 136: gr_complex result(0.0, 0.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a69ec75b_7faf3bcf PS4, Line 137: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b6d94cf8_fc85e988 PS4, Line 138: for (int ii = 0; ii < length; ii++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d847a59_eeba99e1 PS4, Line 139: result += sequence[ii] * input[ii * d_OSR]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ee9ca3a_11848781 PS4, Line 140: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6115460_5fe58824 PS4, Line 141: return conj(result) / gr_complex(length, 0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ebbc6b5_239a61bd PS4, Line 142: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad3b04cd_afaf612f PS4, Line 143: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71255bb4_85a84c23 PS4, Line 144: /* Computes autocorrelation for positive arguments */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9594f643_54942fec PS4, Line 145: inline void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d83e3b6c_6ddc1d12 PS4, Line 146: autocorrelation(const gr_complex* input, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dda5934f_c9e5ac80 PS4, Line 147: gr_complex* out, int nitems) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b94b8a9d_07e9619d PS4, Line 148: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2163935_ea180579 PS4, Line 149: for (int k = nitems - 1; k >= 0; k--) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a710d40_d0d26583 PS4, Line 150: out[k] = gr_complex(0, 0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f46f2e9e_19368fb4 PS4, Line 151: for (int i = k; i < nitems; i++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a8752573_fb7aef52 PS4, Line 152: out[k] += input[i] * conj(input[i - k]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f3a1701_438aa177 PS4, Line 153: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a95d8620_6f93362f PS4, Line 154: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c9368e4_39b62ece PS4, Line 155: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/490f67e3_c3ccbce3 PS4, Line 156: inline void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a973b964_6142b128 PS4, Line 157: mafi(const gr_complex* input, int nitems, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5d026b8_2b7fa5a3 PS4, Line 158: gr_complex* filter, int filter_length, gr_complex* output) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10c14499_592845d6 PS4, Line 159: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/453eb364_0bc0db0a PS4, Line 160: for (int n = 0; n < nitems; n++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43146a59_38d2c50a PS4, Line 161: int a = n * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3000a5b_2ecf92f0 PS4, Line 162: output[n] = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af939e94_e4cc64d7 PS4, Line 163: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3033d857_bab4a169 PS4, Line 164: for (int ii = 0; ii < filter_length; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2495c795_54d7b29c PS4, Line 165: if ((a + ii) >= nitems * d_OSR) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3c372e2_5c4e238b PS4, Line 166: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/183c889f_1b04c59f PS4, Line 167: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85d79266_36202f3b PS4, Line 168: output[n] += input[a + ii] * filter[ii]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c547dd6c_8aa63573 PS4, Line 169: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1af80842_e2c42fd8 PS4, Line 170: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f2b768a_0cf68e75 PS4, Line 171: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3dd2947b_fb3a5a50 PS4, Line 172: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/650a263b_febc5d48 PS4, Line 173: int get_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, int search_center, int search_start_pos, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/907c7052_136fa1f6 PS4, Line 174: int search_stop_pos, gr_complex *tseq, int tseqlen, float *corr_max) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d7aee50d_6c99da4b PS4, Line 175: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b6f255cd_928dec37 PS4, Line 176: std::vector<gr_complex> correlation_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd4113c0_87299e14 PS4, Line 177: std::vector<float> window_energy_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3318fa9e_98f1da6d PS4, Line 178: std::vector<float> power_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79b65527_93ec6b95 PS4, Line 179: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b59a5a95_322b453f PS4, Line 180: for (int ii = search_start_pos; ii < search_stop_pos; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99458efe_d4248c8f PS4, Line 181: gr_complex correlation = correlate_sequence(tseq, tseqlen, &input[ii]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e0d9b03_f620af04 PS4, Line 182: correlation_buffer.push_back(correlation); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca984adb_0957719b PS4, Line 183: power_buffer.push_back(std::pow(abs(correlation), 2)); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9157521_eddb8a37 PS4, Line 184: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3558f6e_62019a21 PS4, Line 185: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7bdbea70_7528cea2 PS4, Line 186: int strongest_corr_nr = max_element(power_buffer.begin(), power_buffer.end()) - power_buffer.begin(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/844a76b0_1ee5d3a9 PS4, Line 187: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/898dc4bc_0fcec899 PS4, Line 188: /* Compute window energies */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb789162_6bb4bfa2 PS4, Line 189: auto window_energy_start_offset = strongest_corr_nr - 6 * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a98ebc3_82f172f7 PS4, Line 190: window_energy_start_offset = window_energy_start_offset < 0 ? 0 : window_energy_start_offset; //can end up out of range.. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc6db9e0_831f8290 PS4, Line 191: auto window_energy_end_offset = strongest_corr_nr + 6 * d_OSR + d_chan_imp_length * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1a3bff9_a9ceea4e PS4, Line 192: auto iter = power_buffer.begin() + window_energy_start_offset; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/faa5e803_6d2277d5 PS4, Line 193: auto iter_end = power_buffer.begin() + window_energy_end_offset; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/04af2ddf_4a1fbb5f PS4, Line 194: while (iter != iter_end) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/adefe06c_5b2b3dac PS4, Line 195: std::vector<float>::iterator iter_ii = iter; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b6ca7bf_5b3e79dc PS4, Line 196: bool loop_end = false; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7716a428_4ab2f257 PS4, Line 197: float energy = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a15bb25_330981e6 PS4, Line 198: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c779111c_5a9187fe PS4, Line 199: int len = d_chan_imp_length * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/73fc52d0_eb3f2062 PS4, Line 200: for (int ii = 0; ii < len; ii++, iter_ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc24ffce_4a69d6fb PS4, Line 201: if (iter_ii == power_buffer.end()) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8313fd2_e5b845c5 PS4, Line 202: loop_end = true; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/084c0f77_6b9aeae0 PS4, Line 203: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1fa30d7f_a67b5e2b PS4, Line 204: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/463e3c8e_624d444d PS4, Line 205: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b9e6614_f8bfa67c PS4, Line 206: energy += (*iter_ii); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e6b09ef9_92892627 PS4, Line 207: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bde038a1_c1c7b6b4 PS4, Line 208: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a06be917_ca92a07f PS4, Line 209: if (loop_end) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7bcb7da0_373203c3 PS4, Line 210: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f88a84e1_61c575c4 PS4, Line 211: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1d9c448_85584655 PS4, Line 212: window_energy_buffer.push_back(energy); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0109dbc_c827b7a9 PS4, Line 213: iter++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85021aaf_b438300d PS4, Line 214: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11d1ca93_8c746d67 PS4, Line 215: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab4af041_21ebed47 PS4, Line 216: /* Calculate the strongest window number */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0757a648_2a318d2f PS4, Line 217: int strongest_window_nr = window_energy_start_offset + DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f33b7f9c_1f8e949b PS4, Line 218: max_element(window_energy_buffer.begin(), window_energy_buffer.end()) - DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94ef504f_f5773214 PS4, Line 219: window_energy_buffer.begin(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8197595_08aa7abb PS4, Line 220: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38d8e735_0670e50a PS4, Line 221: // auto window_search_start = window_energy_buffer.begin() + strongest_corr_nr - 5* d_OSR; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32a7dd70_00f306e3 PS4, Line 222: // auto window_search_end = window_energy_buffer.begin() + strongest_corr_nr + 10* d_OSR; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3a82500_5966ccf3 PS4, Line 223: // window_search_end = window_search_end >= window_energy_buffer.end() ? window_energy_buffer.end() : window_search_end; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9fa3dc79_07c0f1fc PS4, Line 224: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f59c596b_fe7fdb12 PS4, Line 225: // /* Calculate the strongest window number */ trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30fc7526_1b3aa75a PS4, Line 226: // int strongest_window_nr = max_element(window_search_start, window_search_end /* - d_chan_imp_length * d_OSR*/) - window_energy_buffer.begin(); trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/603772ac_77062f99 PS4, Line 227: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a49763b7_cf689ae0 PS4, Line 228: // if (strongest_window_nr < 0) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c6aae30_e1a93e1e PS4, Line 229: // strongest_window_nr = 0; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0e52aca_0accd3eb PS4, Line 230: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/07c79bb2_6a15f4bd PS4, Line 231: float max_correlation = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb2fcdab_1971f997 PS4, Line 232: for (int ii = 0; ii < d_chan_imp_length * d_OSR; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93f3e1d7_58a2fed8 PS4, Line 233: gr_complex correlation = correlation_buffer[strongest_window_nr + ii]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6486805f_11ab52d9 PS4, Line 234: if (abs(correlation) > max_correlation) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/764e32e5_6edfa6ee PS4, Line 235: max_correlation = abs(correlation); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d121a6b4_6e4a0c72 PS4, Line 236: chan_imp_resp[ii] = correlation; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0abe7783_9fa332d4 PS4, Line 237: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67e2442e_d8c40413 PS4, Line 238: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6bec6fc_42dad16b PS4, Line 239: *corr_max = max_correlation; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7119030c_9e4b2535 PS4, Line 240: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c422d27b_273ae9c4 PS4, Line 241: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/890b3beb_d63ccab7 PS4, Line 242: * Compute first sample position, which corresponds trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77e222e1_e1df7e2e PS4, Line 243: * to the first sample of the impulse response trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/afa06b16_68dce019 PS4, Line 244: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92058759_08b63f79 PS4, Line 245: return search_start_pos + strongest_window_nr - search_center * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3cec35c_68b77fd0 PS4, Line 246: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87ffae4b_348dc6d0 PS4, Line 247: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/544fa58f_357c6623 PS4, Line 248: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3d09015_4f192661 PS4, Line 249: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38b31993_9fed9c4a PS4, Line 250: 3 + 57 + 1 + 26 + 1 + 57 + 3 + 8.25 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c014bb20_d40253f2 PS4, Line 251: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/44378904_67294536 PS4, Line 252: search center = 3 + 57 + 1 + 5 (due to tsc 5+16+5 split) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46541e6b_855637e9 PS4, Line 253: this is +-5 samples around (+5 beginning) of truncated t16 tsc trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6ddf8191_347223d6 PS4, Line 254: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a82c2d43_368e8fc9 PS4, Line 255: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/258aa77c_c3eca987 PS4, Line 256: int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92d7dd18_94e2ecff PS4, Line 257: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02304bbd_53e312d6 PS4, Line 258: const int search_center = TRAIN_POS; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1744411e_3b832e48 PS4, Line 259: const int search_start_pos = (search_center - 5) * d_OSR + 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9ce0568_1222fa8e PS4, Line 260: const int search_stop_pos = (search_center + 5 + d_chan_imp_length) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0707ee07_71d1c8be PS4, Line 261: const auto tseq = &d_norm_training_seq[bcc][TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/746bdd99_9ec01f2c PS4, Line 262: const auto tseqlen = N_TRAIN_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e164d780_df13646a PS4, Line 263: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45570647_77d212e7 PS4, Line 264: corr_max); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ae766ee_7849679d PS4, Line 265: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/422b9b6d_b21ef8d9 PS4, Line 266: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb5880cc_5e721a78 PS4, Line 267: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/473ca09c_28e6b550 PS4, Line 268: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43a60bd4_506e6793 PS4, Line 269: 3 tail | 39 data | 64 tsc | 39 data | 3 tail | 8.25 guard trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98c9e4f3_317af24b PS4, Line 270: start 3+39 - 10 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48d8e020_b9e7b42e PS4, Line 271: end 3+39 + SYNC_SEARCH_RANGE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29828689_b12ba476 PS4, Line 272: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38be869b_f8d9fb80 PS4, Line 273: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b046bd3d_4d04f550 PS4, Line 274: int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e903f28_89b973b6 PS4, Line 275: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88b249e9_e9decb29 PS4, Line 276: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4dcec9d7_03578b80 PS4, Line 277: const int search_start_pos = (search_center - 10) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/24697040_cba628d1 PS4, Line 278: const int search_stop_pos = (search_center + SYNC_SEARCH_RANGE) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b43c10f_a0f4ef73 PS4, Line 279: const auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0df51644_12333994 PS4, Line 280: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a830694_b247e3cf PS4, Line 281: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d790d399_96d74b70 PS4, Line 282: // strongest_window_nr + chan_imp_resp_center + SYNC_POS *d_OSR - 48 * d_OSR - 2 * d_OSR + 2 ; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa94a4db_5707e53e PS4, Line 283: float corr_max; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e342ded_fab3060e PS4, Line 284: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71170beb_ad917078 PS4, Line 285: &corr_max); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9239c59a_5b1f59a2 PS4, Line 286: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68d040d4_8b6edf03 PS4, Line 287: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5884a49_346f984b PS4, Line 288: int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5cc297ca_a9a887fa PS4, Line 289: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01fbc977_e87c844f PS4, Line 290: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3dfb79ae_196a5afb PS4, Line 291: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c020687_10cf8812 PS4, Line 292: const int search_start_pos = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66615407_9bbac1e0 PS4, Line 293: // FIXME: proper end offset trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/779bca7a_b7c171ce PS4, Line 294: const int search_stop_pos = len - (N_SYNC_BITS*8); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06b97b01_522f4732 PS4, Line 295: auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0c2cfd6_ccfd5e51 PS4, Line 296: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/079bcec2_b3c26e87 PS4, Line 297: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65b8e518_3c52613c PS4, Line 298: corr_max); DOS line endings File Transceiver52M/grgsm_vitac/viterbi_detector.cc: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56d4d51e_ef8c4009 PS4, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8fe560ae_76dd7b38 PS4, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d234460_4e8ed78c PS4, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87d26200_73d44aa9 PS4, Line 4: * @author (C) 2009 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2cead01d_f6a18522 PS4, Line 5: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0816211c_5229305c PS4, Line 6: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ffe24d3_e6eb756a PS4, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/821dee9c_aeea5ba8 PS4, Line 8: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8083bdc0_cda4b8bb PS4, Line 9: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08158a2c_74a5cd7b PS4, Line 10: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/731ed5e6_27f686dd PS4, Line 11: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56c69f55_4b59bfb8 PS4, Line 12: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7be29d78_424ac329 PS4, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41b103bf_e46dd35e PS4, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e51f28f0_48ad900d PS4, Line 15: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/20ec1143_570f2a57 PS4, Line 16: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dadba63_df607fd9 PS4, Line 17: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e3c2f5c8_4f37f8e7 PS4, Line 18: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8f58a24_d8f35cff PS4, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2f5e1478_a8e78edf PS4, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7daf910d_8ba4d2ef PS4, Line 20: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89183a25_bff1a5d6 PS4, Line 21: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27affee9_1a1bb5c4 PS4, Line 22: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f6a8b09_a44f9463 PS4, Line 23: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad731030_17387033 PS4, Line 24: * viterbi_detector: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8e97190_3cd4a961 PS4, Line 25: * This part does the detection of received sequnece. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64e4af0b_4c3ad6fb PS4, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc44ca0a_e8c5fe49 PS4, Line 27: * At this moment it gives hard decisions on the output, but trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37c72c2f_a150436d PS4, Line 28: * it was designed with soft decisions in mind. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9836ac85_ee06190a PS4, Line 29: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9e72261_9a4e1103 PS4, Line 30: * SYNTAX: void viterbi_detector( trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d967e54_c05d6eda PS4, Line 31: * const gr_complex * input, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/59373133_5fd5c182 PS4, Line 32: * unsigned int samples_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6db363a7_002314d8 PS4, Line 33: * gr_complex * rhh, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a4ae3bb_0051ce06 PS4, Line 34: * unsigned int start_state, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a1d666d_35af5d3e PS4, Line 35: * const unsigned int * stop_states, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c54ecbf5_91decca6 PS4, Line 36: * unsigned int stops_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21697a02_d9bb4798 PS4, Line 37: * float * output) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/390a3a84_23ac68bd PS4, Line 38: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1ac5832_0d2c9388 PS4, Line 39: * INPUT: input: Complex received signal afted matched filtering. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8217c46d_4d434339 PS4, Line 40: * samples_num: Number of samples in the input table. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/91ee2541_889ee83d PS4, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7530d20d_5f1c87b9 PS4, Line 42: * impulse response. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfef8abc_4aa26ef9 PS4, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bae45e30_43f6aa43 PS4, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfe62b9e_941c9bf2 PS4, Line 45: * indicates start point of the algorithm. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eaee77c1_34126d5b PS4, Line 46: * stop_states: Table with numbers of possible stop states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75ad65d3_cb5440de PS4, Line 47: * stops_num: Number of possible stop states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37d9675f_3a6767b9 PS4, Line 48: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2c61f8e_09d1c424 PS4, Line 49: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfa5f8d4_6f75e9c2 PS4, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9e6e5890_5fa1e65e PS4, Line 51: * -1 for logical "0" and 1 for logical "1" trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/468ec753_5147724c PS4, Line 52: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7d8520c8_6548d0cb PS4, Line 53: * SUB_FUNC: none trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4dae222_3d6ca3c6 PS4, Line 54: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7b4ff77_e410a4fd PS4, Line 55: * TEST(S): Tested with real world normal burst. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec074333_93ac25d7 PS4, Line 56: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4e87a18_9d6fad5f PS4, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d0a180b_85828b4f PS4, Line 58: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e56b086_6e24fe9f PS4, Line 59: #include <cmath> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92f400a2_6a3f66a3 PS4, Line 60: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02960e84_8dd86c76 PS4, Line 61: #define PATHS_NUM (1 << (CHAN_IMP_RESP_LENGTH-1)) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbd30f72_2e60c52a PS4, Line 62: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/020e2acd_61c766ae PS4, Line 63: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86b76e98_50571208 PS4, Line 64: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/963800fe_575461fe PS4, Line 65: float increment[8]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/34678ba2_a5507542 PS4, Line 66: float path_metrics1[16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a350aa2_d05e1dd0 PS4, Line 67: float path_metrics2[16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db359c56_ac0dcf5f PS4, Line 68: float paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6f3ec2c6_1d74cd0e PS4, Line 69: float * new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5d3b31a_e5423068 PS4, Line 70: float * old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f92b65ae_ac60fe54 PS4, Line 71: float * tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f06d9bc_b13d2c74 PS4, Line 72: float trans_table[BURST_SIZE][16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cb62748_beb4c1e6 PS4, Line 73: float pm_candidate1, pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2cf9ca92_e98b61bd PS4, Line 74: bool real_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a7c44e7_9eccf775 PS4, Line 75: float input_symbol_real, input_symbol_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/502b6f3e_db67fa1e PS4, Line 76: unsigned int i, sample_nr; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b70b536e_7f76f8f6 PS4, Line 77: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ae46d00_535624df PS4, Line 78: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb7db3cb_be1a64ac PS4, Line 79: * Setup first path metrics, so only state pointed by start_state is possible. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57b1b8db_cd1fed0a PS4, Line 80: * Start_state metric is equal to zero, the rest is written with some very low value, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57ac451d_bf11d36e PS4, Line 81: * which makes them practically impossible to occur. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54050302_a67d2b77 PS4, Line 82: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/20c7a715_be07398a PS4, Line 83: for(i=0; i<PATHS_NUM; i++){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aad798d1_4b39f08d PS4, Line 84: path_metrics1[i]=(-10e30); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/724f716e_1b18a77b PS4, Line 85: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1a28255_b7d1b9ee PS4, Line 86: path_metrics1[start_state]=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99c68cbf_4e2400c0 PS4, Line 87: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d2dd48c_49db93ea PS4, Line 88: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87056bfd_ec6b04aa PS4, Line 89: * Compute Increment - a table of values which does not change for subsequent input samples. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4d49196_73b8e457 PS4, Line 90: * Increment is table of reference levels for computation of branch metrics: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/daa420be_86b0aa73 PS4, Line 91: * branch metric = (+/-)received_sample (+/-) reference_level trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e46c84dc_533a27ca PS4, Line 92: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8a551db_055437b9 PS4, Line 93: increment[0] = -rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc7481be_61747b87 PS4, Line 94: increment[1] = rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c88f614_8b20f92b PS4, Line 95: increment[2] = -rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce76d52d_1d71da39 PS4, Line 96: increment[3] = rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3474cbe3_d189195b PS4, Line 97: increment[4] = -rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0ec3005_006c9848 PS4, Line 98: increment[5] = rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4be35b6f_158c0d2a PS4, Line 99: increment[6] = -rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70144b3e_eb87167b PS4, Line 100: increment[7] = rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc5f4595_1b839f6e PS4, Line 101: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d590714a_986afe98 PS4, Line 102: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7500442a_affdafb2 PS4, Line 103: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dab2d34e_12cbdaa5 PS4, Line 104: * Computation of path metrics and decisions (Add-Compare-Select). trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86ebdf27_8d9dac16 PS4, Line 105: * It's composed of two parts: one for odd input samples (imaginary numbers) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76678b77_9343af7f PS4, Line 106: * and one for even samples (real numbers). trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/31c72d42_62ff3ff7 PS4, Line 107: * Each part is composed of independent (parallelisable) statements like trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/961052a1_e39fe2fb PS4, Line 108: * this one: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1657e97_9f1acebc PS4, Line 109: * pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42026b79_3f22c273 PS4, Line 110: * pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f7b069a9_3d2d5528 PS4, Line 111: * paths_difference=pm_candidate2-pm_candidate1; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b48b734_bbebe66e PS4, Line 112: * new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0627d7e_241e43f3 PS4, Line 113: * trans_table[sample_nr][1] = paths_difference; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1b9025f2_a79f65a6 PS4, Line 114: * This is very good point for optimisations (SIMD or OpenMP) as it's most time trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fbebc677_5256ada5 PS4, Line 115: * consuming part of this function. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc383698_1608552d PS4, Line 116: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/422a68cd_29125308 PS4, Line 117: sample_nr=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/34f1c758_a4f343f5 PS4, Line 118: old_path_metrics=path_metrics1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/675c20a4_7053c55a PS4, Line 119: new_path_metrics=path_metrics2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a9e3a43_f4b6b29d PS4, Line 120: while(sample_nr<samples_num){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79bad530_d2d1548b PS4, Line 121: //Processing imag states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8bc4f230_2ba634b1 PS4, Line 122: real_imag=1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acc5bcf2_11aeb113 PS4, Line 123: input_symbol_imag = input[sample_nr].imag(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d5e1e45_e21de719 PS4, Line 124: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8258d1fd_2b8c1e00 PS4, Line 125: pm_candidate1 = old_path_metrics[0] +input_symbol_imag -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e877018c_2878d96b PS4, Line 126: pm_candidate2 = old_path_metrics[8] +input_symbol_imag +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e08a056f_66a69d54 PS4, Line 127: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3a6cdb4_851aa741 PS4, Line 128: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b413424a_476439b4 PS4, Line 129: trans_table[sample_nr][0] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52f15693_48270797 PS4, Line 130: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b01a7b6b_a251084e PS4, Line 131: pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae0d07bd_ca5b1e2b PS4, Line 132: pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9fd5b1ba_4c16e1b9 PS4, Line 133: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/04cfc94a_47983f41 PS4, Line 134: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7a33b89_cc877c4d PS4, Line 135: trans_table[sample_nr][1] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd5d4b89_12522b0a PS4, Line 136: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba5d9b0c_ba5f2959 PS4, Line 137: pm_candidate1 = old_path_metrics[1] +input_symbol_imag -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/103dd7f4_f7d2ce17 PS4, Line 138: pm_candidate2 = old_path_metrics[9] +input_symbol_imag +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6adca3cd_9c7ed6d9 PS4, Line 139: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6808edc_ba387ef5 PS4, Line 140: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e874e5c1_13f68b26 PS4, Line 141: trans_table[sample_nr][2] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e80c4b1a_c68a5cd6 PS4, Line 142: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2d3c2c5_784bcd66 PS4, Line 143: pm_candidate1 = old_path_metrics[1] -input_symbol_imag +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/103d925a_f9d20b32 PS4, Line 144: pm_candidate2 = old_path_metrics[9] -input_symbol_imag -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0bad7a57_5c11dcf8 PS4, Line 145: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f5f0487_ebf33396 PS4, Line 146: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c33003a_e7dbcf9f PS4, Line 147: trans_table[sample_nr][3] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d94dbdd_71246adb PS4, Line 148: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30edf5a8_7949cca9 PS4, Line 149: pm_candidate1 = old_path_metrics[2] +input_symbol_imag -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2ce544d_ccea211d PS4, Line 150: pm_candidate2 = old_path_metrics[10] +input_symbol_imag +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7d987b7e_2aed1401 PS4, Line 151: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e24955e9_26cdb98d PS4, Line 152: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7d21a58_306bfacb PS4, Line 153: trans_table[sample_nr][4] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/675e3cc9_fbfe8539 PS4, Line 154: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35571d98_4ac529c5 PS4, Line 155: pm_candidate1 = old_path_metrics[2] -input_symbol_imag +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6907ec07_1298acdb PS4, Line 156: pm_candidate2 = old_path_metrics[10] -input_symbol_imag -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dbf25e3e_5424d992 PS4, Line 157: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9757726_8d762b65 PS4, Line 158: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52feedc0_c39ed54a PS4, Line 159: trans_table[sample_nr][5] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87f941c0_e7c678e2 PS4, Line 160: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26d0bbbf_6be1f70a PS4, Line 161: pm_candidate1 = old_path_metrics[3] +input_symbol_imag -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d7b2a117_00cee004 PS4, Line 162: pm_candidate2 = old_path_metrics[11] +input_symbol_imag +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/524f5c4e_e1c5c19d PS4, Line 163: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1a40313_c4e153ef PS4, Line 164: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/972c2208_aeee7bf9 PS4, Line 165: trans_table[sample_nr][6] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da441680_503b5900 PS4, Line 166: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/666bf8d6_e97ae13a PS4, Line 167: pm_candidate1 = old_path_metrics[3] -input_symbol_imag +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d53e130b_fcb690e1 PS4, Line 168: pm_candidate2 = old_path_metrics[11] -input_symbol_imag -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15670c33_4130d702 PS4, Line 169: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0bbf0c06_72687d00 PS4, Line 170: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf8f1be1_e6fe8f4a PS4, Line 171: trans_table[sample_nr][7] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88d58044_47bddc46 PS4, Line 172: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37a3cb8b_711c2e77 PS4, Line 173: pm_candidate1 = old_path_metrics[4] +input_symbol_imag -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da2bb45e_e46751b7 PS4, Line 174: pm_candidate2 = old_path_metrics[12] +input_symbol_imag +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6de816da_ba4e22a5 PS4, Line 175: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a023d6bc_e60618b3 PS4, Line 176: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e390bf64_d783e6c3 PS4, Line 177: trans_table[sample_nr][8] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/895e0394_47ca22c6 PS4, Line 178: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f95e965b_4ccd1241 PS4, Line 179: pm_candidate1 = old_path_metrics[4] -input_symbol_imag +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c88f4cf1_25740845 PS4, Line 180: pm_candidate2 = old_path_metrics[12] -input_symbol_imag -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3396473f_2a031010 PS4, Line 181: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4942fab5_ff1e87c8 PS4, Line 182: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5bf4135f_604cb684 PS4, Line 183: trans_table[sample_nr][9] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d202b8ac_18cc3692 PS4, Line 184: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d391d31_d9676b17 PS4, Line 185: pm_candidate1 = old_path_metrics[5] +input_symbol_imag -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/375ff81d_dc10b3ad PS4, Line 186: pm_candidate2 = old_path_metrics[13] +input_symbol_imag +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52e0c236_a78e703d PS4, Line 187: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12b86296_c15c3997 PS4, Line 188: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c64d6e8_f87ea148 PS4, Line 189: trans_table[sample_nr][10] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef4ccddc_3de9fdc2 PS4, Line 190: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3142d618_8b91f015 PS4, Line 191: pm_candidate1 = old_path_metrics[5] -input_symbol_imag +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/73bcc1b2_0252ba0a PS4, Line 192: pm_candidate2 = old_path_metrics[13] -input_symbol_imag -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b23c47e7_181f9bca PS4, Line 193: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dbda29c1_492206f7 PS4, Line 194: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58d34ea8_eeb93fb9 PS4, Line 195: trans_table[sample_nr][11] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d11b7a0_6f4a08ab PS4, Line 196: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6116a543_5520f92d PS4, Line 197: pm_candidate1 = old_path_metrics[6] +input_symbol_imag -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/414c2dcf_563b020a PS4, Line 198: pm_candidate2 = old_path_metrics[14] +input_symbol_imag +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12e6ab66_25afe193 PS4, Line 199: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3a98f15a_da53e419 PS4, Line 200: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/16c9f1df_975760f0 PS4, Line 201: trans_table[sample_nr][12] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6975e7bf_5b76e4e4 PS4, Line 202: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/058603d7_e5eab519 PS4, Line 203: pm_candidate1 = old_path_metrics[6] -input_symbol_imag +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ca6aa9c_6c6835d2 PS4, Line 204: pm_candidate2 = old_path_metrics[14] -input_symbol_imag -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/502ea680_4af883ac PS4, Line 205: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70659511_8d192ff1 PS4, Line 206: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9885d0e_717e6ebc PS4, Line 207: trans_table[sample_nr][13] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89b59ef6_c32eb6e0 PS4, Line 208: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c55aa096_69854a48 PS4, Line 209: pm_candidate1 = old_path_metrics[7] +input_symbol_imag -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e2eb67c4_0d0026b0 PS4, Line 210: pm_candidate2 = old_path_metrics[15] +input_symbol_imag +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18cada21_dd9b52b9 PS4, Line 211: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/066f7c3a_85eed9e1 PS4, Line 212: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fafd61ec_be89d0cd PS4, Line 213: trans_table[sample_nr][14] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b65cc3e2_d217fde5 PS4, Line 214: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/deb9b2b5_dd95cc70 PS4, Line 215: pm_candidate1 = old_path_metrics[7] -input_symbol_imag +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66099376_f721add0 PS4, Line 216: pm_candidate2 = old_path_metrics[15] -input_symbol_imag -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66957c21_d0cf2594 PS4, Line 217: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf7d02d5_eea2e018 PS4, Line 218: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b992fae_6598f918 PS4, Line 219: trans_table[sample_nr][15] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a0f4460_5fa7b9db PS4, Line 220: tmp=old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06e5fd00_ba8b1a4f PS4, Line 221: old_path_metrics=new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95312adc_2434b1b4 PS4, Line 222: new_path_metrics=tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c094babb_3a18d4f2 PS4, Line 223: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3300254_f9cc9663 PS4, Line 224: sample_nr++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c98fb83a_3cc0834b PS4, Line 225: if(sample_nr==samples_num) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf1b7ec3_2e0ffb66 PS4, Line 226: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ae79548_c1d72664 PS4, Line 227: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d77e6a2_68d7516f PS4, Line 228: //Processing real states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a37e588_1d0efd4c PS4, Line 229: real_imag=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7f4df06_47b8d13d PS4, Line 230: input_symbol_real = input[sample_nr].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6b24d414_e3e3b877 PS4, Line 231: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b8c6910_88daabc7 PS4, Line 232: pm_candidate1 = old_path_metrics[0] -input_symbol_real -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/047980c8_471edb96 PS4, Line 233: pm_candidate2 = old_path_metrics[8] -input_symbol_real +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a58724b9_6f66faf3 PS4, Line 234: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e751af5_27c62abd PS4, Line 235: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c893e37_5d30e684 PS4, Line 236: trans_table[sample_nr][0] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/580cfee2_51580115 PS4, Line 237: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa0630e2_5201f2f2 PS4, Line 238: pm_candidate1 = old_path_metrics[0] +input_symbol_real +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7f469dd_467c9978 PS4, Line 239: pm_candidate2 = old_path_metrics[8] +input_symbol_real -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18503873_ab0fbcda PS4, Line 240: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27a0ec72_2776959f PS4, Line 241: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/471b9371_8e15118d PS4, Line 242: trans_table[sample_nr][1] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97f2acaf_7a21a6d1 PS4, Line 243: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8fa00802_ec0ac865 PS4, Line 244: pm_candidate1 = old_path_metrics[1] -input_symbol_real -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40ef9704_9a709ecc PS4, Line 245: pm_candidate2 = old_path_metrics[9] -input_symbol_real +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3282cdd9_e328d967 PS4, Line 246: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c7a6f49_797151a3 PS4, Line 247: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba479060_17bf5d60 PS4, Line 248: trans_table[sample_nr][2] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a91140e_0c2ebf1f PS4, Line 249: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/100ce3c7_a4a3eec3 PS4, Line 250: pm_candidate1 = old_path_metrics[1] +input_symbol_real +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ebaec86_6fd31c49 PS4, Line 251: pm_candidate2 = old_path_metrics[9] +input_symbol_real -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4cb2ed66_bc43148f PS4, Line 252: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a514efa1_3a54a07d PS4, Line 253: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a191e10_c1fbd62f PS4, Line 254: trans_table[sample_nr][3] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c21af92b_7b49c39a PS4, Line 255: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db427033_d51d4ea9 PS4, Line 256: pm_candidate1 = old_path_metrics[2] -input_symbol_real -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e77e080f_44350b62 PS4, Line 257: pm_candidate2 = old_path_metrics[10] -input_symbol_real +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ca26ecd_f678e21a PS4, Line 258: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30c14f9c_8394ac7d PS4, Line 259: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec9207f3_cc33fa9e PS4, Line 260: trans_table[sample_nr][4] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c982748a_c5e02d5c PS4, Line 261: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/807e0370_eaa31b8c PS4, Line 262: pm_candidate1 = old_path_metrics[2] +input_symbol_real +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f531d271_431e0bd7 PS4, Line 263: pm_candidate2 = old_path_metrics[10] +input_symbol_real -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7fb550f7_b0030586 PS4, Line 264: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0dda86ef_f11ab5ee PS4, Line 265: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d97365d_d38e5262 PS4, Line 266: trans_table[sample_nr][5] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a21a22ab_e758481d PS4, Line 267: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2be40256_a93f5bf7 PS4, Line 268: pm_candidate1 = old_path_metrics[3] -input_symbol_real -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fa653ab_bd58048f PS4, Line 269: pm_candidate2 = old_path_metrics[11] -input_symbol_real +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/465df447_c8dcd0bd PS4, Line 270: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30e808df_48c772eb PS4, Line 271: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/097d802c_6a6c66c2 PS4, Line 272: trans_table[sample_nr][6] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e5be319_41eb7244 PS4, Line 273: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46ca51a0_7330b51f PS4, Line 274: pm_candidate1 = old_path_metrics[3] +input_symbol_real +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2dc8ccdb_898a5352 PS4, Line 275: pm_candidate2 = old_path_metrics[11] +input_symbol_real -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02608335_796d037e PS4, Line 276: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea264723_7ee12bcc PS4, Line 277: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bb9788fb_93067e59 PS4, Line 278: trans_table[sample_nr][7] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b98f45e3_84945451 PS4, Line 279: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/199721a2_430f43a2 PS4, Line 280: pm_candidate1 = old_path_metrics[4] -input_symbol_real -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86820ebe_a30c02a9 PS4, Line 281: pm_candidate2 = old_path_metrics[12] -input_symbol_real +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d0e102b2_aa4d3c3a PS4, Line 282: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd12bbf6_2b8f3ec6 PS4, Line 283: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74ee60c5_b4f20623 PS4, Line 284: trans_table[sample_nr][8] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9a840e95_7164c327 PS4, Line 285: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a57f4f0_ac5dc6e4 PS4, Line 286: pm_candidate1 = old_path_metrics[4] +input_symbol_real +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63184108_c9898968 PS4, Line 287: pm_candidate2 = old_path_metrics[12] +input_symbol_real -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e6282dcd_db7976c7 PS4, Line 288: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4304731b_8bce71f1 PS4, Line 289: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c3c85f1_7eee63fe PS4, Line 290: trans_table[sample_nr][9] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce44b2b7_efae144a PS4, Line 291: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/edf0653d_08b7c182 PS4, Line 292: pm_candidate1 = old_path_metrics[5] -input_symbol_real -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fd542b8_7e2ba510 PS4, Line 293: pm_candidate2 = old_path_metrics[13] -input_symbol_real +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2fc4d88b_a9cb10f0 PS4, Line 294: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d4037f9_24a85261 PS4, Line 295: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca392bda_5a368484 PS4, Line 296: trans_table[sample_nr][10] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/507b9fbb_4c41caaf PS4, Line 297: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/faf267ac_6c1ec426 PS4, Line 298: pm_candidate1 = old_path_metrics[5] +input_symbol_real +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5cd87f68_811da2db PS4, Line 299: pm_candidate2 = old_path_metrics[13] +input_symbol_real -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6ad26d0d_c45c021f PS4, Line 300: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bdc785f1_f861878c PS4, Line 301: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1564b85e_f8064f81 PS4, Line 302: trans_table[sample_nr][11] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c2de6d6_3df9deb5 PS4, Line 303: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8fe01662_1351133d PS4, Line 304: pm_candidate1 = old_path_metrics[6] -input_symbol_real -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f7247013_6a7bf1a3 PS4, Line 305: pm_candidate2 = old_path_metrics[14] -input_symbol_real +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/872f21eb_a7a5bc07 PS4, Line 306: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c24e9351_d5caa907 PS4, Line 307: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f57cba15_c609b5a8 PS4, Line 308: trans_table[sample_nr][12] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/566d22d7_9ee1fd87 PS4, Line 309: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13f6a38b_bd114f12 PS4, Line 310: pm_candidate1 = old_path_metrics[6] +input_symbol_real +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbff0648_3a6ae213 PS4, Line 311: pm_candidate2 = old_path_metrics[14] +input_symbol_real -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aff6ffd5_a654559f PS4, Line 312: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4fd4b2bc_3357ff3d PS4, Line 313: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7034c89b_9ca049b3 PS4, Line 314: trans_table[sample_nr][13] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfb8aab8_1170e969 PS4, Line 315: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/81becd61_68338b7e PS4, Line 316: pm_candidate1 = old_path_metrics[7] -input_symbol_real -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8203d71b_ff7761a0 PS4, Line 317: pm_candidate2 = old_path_metrics[15] -input_symbol_real +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10de8339_596f0d23 PS4, Line 318: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3629f71_332ae992 PS4, Line 319: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d7695a12_34a99b6e PS4, Line 320: trans_table[sample_nr][14] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3be2eeca_7e438d53 PS4, Line 321: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b10e28c0_7450607e PS4, Line 322: pm_candidate1 = old_path_metrics[7] +input_symbol_real +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5676b8b1_d175984b PS4, Line 323: pm_candidate2 = old_path_metrics[15] +input_symbol_real -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f142a712_f029ad81 PS4, Line 324: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9ecbff9_d0423f36 PS4, Line 325: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/957d10c8_d2327b02 PS4, Line 326: trans_table[sample_nr][15] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a80987d_69bb58d0 PS4, Line 327: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e60461d3_7c05f64d PS4, Line 328: tmp=old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8424a471_893431d2 PS4, Line 329: old_path_metrics=new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61bd7b32_3df610e6 PS4, Line 330: new_path_metrics=tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84de7cef_fde3dc51 PS4, Line 331: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e372bc3f_201b1b38 PS4, Line 332: sample_nr++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03ae49d8_9995729a PS4, Line 333: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc5aa73e_45557851 PS4, Line 334: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3fc34b27_83d6be98 PS4, Line 335: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43e10c00_f492960f PS4, Line 336: * Find the best from the stop states by comparing their path metrics. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc4b4cbc_5693a3e5 PS4, Line 337: * Not every stop state is always possible, so we are searching in trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8551321b_86fb9cba PS4, Line 338: * a subset of them. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6070d76e_a3500e52 PS4, Line 339: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a75be0bd_8bd9e7c5 PS4, Line 340: unsigned int best_stop_state; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c131acce_be8fc95f PS4, Line 341: float stop_state_metric, max_stop_state_metric; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93314785_0e1702a2 PS4, Line 342: best_stop_state = stop_states[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a180e72d_f159087a PS4, Line 343: max_stop_state_metric = old_path_metrics[best_stop_state]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/39064641_eb093212 PS4, Line 344: for(i=1; i< stops_num; i++){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8b3c5ce7_18af9b0b PS4, Line 345: stop_state_metric = old_path_metrics[stop_states[i]]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6bcc4cb_46723fbf PS4, Line 346: if(stop_state_metric > max_stop_state_metric){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6a67c80_59c83de0 PS4, Line 347: max_stop_state_metric = stop_state_metric; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5fe15fd8_2a6025ea PS4, Line 348: best_stop_state = stop_states[i]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/275995aa_5014c393 PS4, Line 349: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/395ae5a8_03eab5de PS4, Line 350: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40200af0_8bc95962 PS4, Line 351: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/44788a75_c6a185c9 PS4, Line 352: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/707dd013_f6d5aeac PS4, Line 353: * This table was generated with hope that it gives a litle speedup during trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a15234b6_8af50d48 PS4, Line 354: * traceback stage. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a79c4e3_72d9f102 PS4, Line 355: * Received bit is related to the number of state in the trellis. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5078de71_39bb479b PS4, Line 356: * I've numbered states so their parity (number of ones) is related trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a44f52a_369d1ff2 PS4, Line 357: * to a received bit. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89e2daef_266200d4 PS4, Line 358: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9aa7cc48_2f72caab PS4, Line 359: static const unsigned int parity_table[PATHS_NUM] = { 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19db3176_3e8fbf74 PS4, Line 360: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb5b4e5a_f29498b6 PS4, Line 361: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01a4ddc0_3ef07ebc PS4, Line 362: * Table of previous states in the trellis diagram. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f83b8e45_8b7aa1b6 PS4, Line 363: * For GMSK modulation every state has two previous states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c327994_35776878 PS4, Line 364: * Example: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7b49e23_97d0d829 PS4, Line 365: * previous_state_nr1 = prev_table[current_state_nr][0] trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f1d798b_19ab1cab PS4, Line 366: * previous_state_nr2 = prev_table[current_state_nr][1] trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b726e212_2ad9c258 PS4, Line 367: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6884f196_c03a4b8c PS4, Line 368: static const unsigned int prev_table[PATHS_NUM][2] = { {0,8}, {0,8}, {1,9}, {1,9}, {2,10}, {2,10}, {3,11}, {3,11}, {4,12}, {4,12}, {5,13}, {5,13}, {6,14}, {6,14}, {7,15}, {7,15}, }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef77d79d_f5d8638f PS4, Line 369: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/766811fc_a43ba370 PS4, Line 370: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74dbe156_6409fcf5 PS4, Line 371: * Traceback and differential decoding of received sequence. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9793aed8_9b5dd6dd PS4, Line 372: * Decisions stored in trans_table are used to restore best path in the trellis. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5680ef8c_d1129e85 PS4, Line 373: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f7b3ce46_98ff7c71 PS4, Line 374: sample_nr=samples_num; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/28658b3e_228b4902 PS4, Line 375: unsigned int state_nr=best_stop_state; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98f4689c_bc9f77e8 PS4, Line 376: unsigned int decision; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f7cbcf4f_0051965e PS4, Line 377: bool out_bit=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93036c95_c5da3687 PS4, Line 378: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5fb7e630_7c16f53e PS4, Line 379: while(sample_nr>0){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75937b33_fbbe14a7 PS4, Line 380: sample_nr--; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b57ec1dd_d9c983b4 PS4, Line 381: decision = (trans_table[sample_nr][state_nr]>0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f4902d9e_189852df PS4, Line 382: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf6295d6_3d050aa7 PS4, Line 383: if(decision != out_bit) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1a15774_535c8097 PS4, Line 384: output[sample_nr]=-trans_table[sample_nr][state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6ece24c1_80db8cc2 PS4, Line 385: else DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ee764878_8a20c2f5 PS4, Line 386: output[sample_nr]=trans_table[sample_nr][state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f66756b_cc3f5ec0 PS4, Line 387: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/224969b6_983df7bc PS4, Line 388: out_bit = out_bit ^ real_imag ^ parity_table[state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23aa4bc7_5f354565 PS4, Line 389: state_nr = prev_table[state_nr][decision]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f55720d7_c5a5c3c8 PS4, Line 390: real_imag = !real_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/729f41cf_13e0dd08 PS4, Line 391: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1538): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1526daff_abdbfe76 PS4, Line 392: } DOS line endings -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 13:14:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-trx[master]: add checkpatch config
by Hoernchen 02 Dec '22

02 Dec '22

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30436 ) Change subject: add checkpatch config ...................................................................... add checkpatch config - do not lint the submodule - do not lint headers, checkpatch does not understand that this is a c++ project and any change to existing headers will cause issues. - also do not do arcane C varargs checks that do not apply to C++ Change-Id: Ie7a9fbd021e12a88db30212240af2332c6cdcb37 --- A .checkpatch.conf 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/36/30436/1 diff --git a/.checkpatch.conf b/.checkpatch.conf new file mode 100644 index 0000000..bc8a511 --- /dev/null +++ b/.checkpatch.conf @@ -0,0 +1,3 @@ +--exclude osmocom-bb/.* +--exclude .*h +--ignore FUNCTION_WITHOUT_ARGS \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie7a9fbd021e12a88db30212240af2332c6cdcb37 Gerrit-Change-Number: 30436 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-trx[master]: ms-trx support
by Jenkins Builder 02 Dec '22

02 Dec '22

Attention is currently required from: Hoernchen, fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 6: (371 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cba96288_9dce0497 PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d1d51b3_c6762930 PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25d37e61_98e172de PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0903a4b_431ca2ba PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/471df77d_e79fc628 PS6, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55699c6f_64f2c2c8 PS6, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f62c4d11_e4febd35 PS6, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b55ad352_2afc71cd PS6, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53d6fdc1_b5c02f4e PS6, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac3d1010_0ec61331 PS6, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81c52564_e5e0c48a PS6, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b149cefc_489b30eb PS6, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32497e3f_da9c54fd PS6, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78de4a78_0bcb92d0 PS6, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b41b3d9_70312b1f PS6, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6db09a32_135c28cc PS6, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ee28079_3fe43447 PS6, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34229a71_2bfd7053 PS6, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d66312e_561fb4d0 PS6, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc127de6_2dd3de18 PS6, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d2163349_ea55f7eb PS6, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d7e0c130_d17324a6 PS6, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d91f638a_bfb75738 PS6, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/657e8298_83727563 PS6, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee2cbfd5_003c31ad PS6, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b1cbbf3_ed75114f PS6, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ab976ad_8c87c642 PS6, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c2f0524c_981751d3 PS6, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1cc71692_1b6dcea2 PS6, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfada22b_e7e35263 PS6, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/65b91c83_1039a837 PS6, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71e0259c_2c230477 PS6, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/905e3e6a_f2743c56 PS6, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d269edf_dab745d8 PS6, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b54fffe1_404dc763 PS6, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4e3c569_cc203e79 PS6, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/52b21967_ddb2ae1a PS6, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd81ccb9_41faed84 PS6, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fefd873_d8350277 PS6, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d54de89_24f31959 PS6, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fbb902f9_3da22c9a PS6, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2055f44b_db08d306 PS6, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75552cde_464cc0b9 PS6, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa2b6488_ec18b9b2 PS6, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0b94cd2_0a40a622 PS6, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc90305b_979893bf PS6, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f70892e3_5b2285b3 PS6, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0975a1b5_633b153c PS6, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0442262b_cd8fb023 PS6, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d83e7237_087a40c2 PS6, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ff51800_779cb767 PS6, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c333eb97_fd6f2308 PS6, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b9736d8b_496b541f PS6, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8accf92_54cd12bc PS6, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/941e737b_68a529f8 PS6, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8317453_b07b36bd PS6, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7db15612_aa8ff5a9 PS6, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f37419f_72cbc78a PS6, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f8b8efd_9c354011 PS6, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/436424e7_354ba92b PS6, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1fae6399_8f8b0988 PS6, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b604ce0a_28dee8c0 PS6, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c6c536f2_63b055c7 PS6, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8de830a1_c0475772 PS6, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0e9bc6c_d6bb958c PS6, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d940f4ac_b68d06b7 PS6, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86a06f6c_e424f89b PS6, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5bd0fd3a_048e384a PS6, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8091cf7_a4acd099 PS6, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3059272_d2a2c781 PS6, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b94ec70_7848e6df PS6, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc8f26de_b5688b1c PS6, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff2a4505_281cd94f PS6, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7a69449_98d7c119 PS6, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f023d650_02928eb2 PS6, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe698eec_222ad3dc PS6, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/388043c8_0b1fcea9 PS6, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f2713fe4_40d1af62 PS6, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9fad722d_71cb2f14 PS6, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b30de08b_01da6ece PS6, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40ba209d_9c566216 PS6, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b351ad4a_eca553b4 PS6, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa73b5b5_a6788cf3 PS6, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1be76719_369715d4 PS6, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3918d545_588be2a5 PS6, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/946fd9f2_ae34a3c8 PS6, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/062369e9_71b3160c PS6, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10dc3333_2daa4407 PS6, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/048d917b_3f8e3fcb PS6, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/feae2ef0_1a38e50f PS6, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7855d565_de164539 PS6, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34472239_f177fea9 PS6, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5eb6bbca_599483f5 PS6, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f967a43e_c788ff5f PS6, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c346b215_fcc2cac3 PS6, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bda0d5c_c74d40a0 PS6, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5cdcec2_9eef7a54 PS6, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7c6b7b83_ffab0fce PS6, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4d43eec_c9399460 PS6, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/491c98b5_2be33eea PS6, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d3dca8f_c4644e30 PS6, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf10dc11_a7e1b06a PS6, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81a2a349_c139c214 PS6, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/489953e6_33e737eb PS6, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e130c9e_13a4c4ec PS6, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/727389fe_7b35f34f PS6, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1e040540_9f77a183 PS6, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9943c310_3a7da131 PS6, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7b11163_699f2c91 PS6, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de238cd4_20cc94f4 PS6, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d7807fa4_fb03f944 PS6, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff6ad63c_74808de8 PS6, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcfa3458_43b4d950 PS6, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a29388ad_1788e1f3 PS6, Line 36: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/039741d2_a086eb7a PS6, Line 36: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79471251_9b612d3a PS6, Line 37: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7af86c10_ee7e81fd PS6, Line 38: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8753d8b_6abb2165 PS6, Line 39: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97d6a01e_ae384ecc PS6, Line 41: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/988d8d3e_e2167834 PS6, Line 42: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c537d30_83adf7d5 PS6, Line 50: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/acd814af_306fa636 PS6, Line 50: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c13b7aa_2fbfe059 PS6, Line 52: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db761f19_6bdae3dc PS6, Line 52: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db4aa390_69a666c1 PS6, Line 52: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b028512_33358adb PS6, Line 58: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62ea9dde_cf3d636d PS6, Line 58: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96177c1f_911dde78 PS6, Line 60: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5c91766_eb48d734 PS6, Line 60: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/971d78a7_13b198bc PS6, Line 60: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b557948a_f30ac127 PS6, Line 66: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b2318bdc_8f299bbd PS6, Line 66: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f2c7570d_c3deecd5 PS6, Line 68: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bc12d860_30f19824 PS6, Line 68: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f2d53df1_fb2afa5f PS6, Line 68: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea8a9ea2_e0f0780a PS6, Line 72: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c82e90b4_ee707673 PS6, Line 72: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7171b97f_37f51c79 PS6, Line 74: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a268b1ac_ae31e369 PS6, Line 74: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/547c9c5c_50aff220 PS6, Line 74: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bc877c8_8f685ca9 PS6, Line 81: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71e27a2a_c9722111 PS6, Line 81: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b7d66e0_e5838a50 PS6, Line 84: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/664e80db_d7230f92 PS6, Line 85: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4103b852_7aee46ed PS6, Line 96: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1483967_ebe9c559 PS6, Line 96: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99e7aa91_424e76f5 PS6, Line 101: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f87ba9a_8b4ab82f PS6, Line 101: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23201d62_4a30a493 PS6, Line 106: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8157c50d_9542c0a3 PS6, Line 106: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/553e8cba_97f11643 PS6, Line 111: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1fbf5dd_bf09ea44 PS6, Line 111: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ac053e4_f0ece2e0 PS6, Line 116: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44166ec1_634d229b PS6, Line 116: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3b7ef81_5de350ae PS6, Line 120: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/242aff6c_77f55443 PS6, Line 120: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9bf9d5c_fcd35f77 PS6, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5618a8b6_30847f3a PS6, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f914c5de_cb8b0fe3 PS6, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc00b7d5_5db13c6b PS6, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7811d0a_5ee6108f PS6, Line 127: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/38c12bb0_81530c27 PS6, Line 127: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/813d72ec_8aa86e08 PS6, Line 129: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/70a3e52e_4b51bd33 PS6, Line 129: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a387b7de_53cbf6a9 PS6, Line 129: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daf22bd4_2fd98762 PS6, Line 130: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/747fbe92_6f0e6fc0 PS6, Line 130: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d76f6f79_93d79e36 PS6, Line 130: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e1c7ca9_443847e6 PS6, Line 134: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e585ab69_5f53030a PS6, Line 135: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5afc2b02_e5150bf7 PS6, Line 135: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c80d1824_efa77a3e PS6, Line 137: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a4eef46_ec1ea710 PS6, Line 148: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01284e7a_22219f64 PS6, Line 155: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7817b604_bcebed8c PS6, Line 161: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb90f315_48195a78 PS6, Line 168: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0051a078_c5bf369a PS6, Line 180: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b618b9a8_0d0e8339 PS6, Line 187: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aad1abc3_bdd74fb2 PS6, Line 187: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6dbee5e7_aa7781df PS6, Line 195: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de6d9810_d533785c PS6, Line 195: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3add248c_eedc16c7 PS6, Line 196: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef03e157_311dac1c PS6, Line 196: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7adb700c_aaba18fe PS6, Line 197: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3bbc5591_6edcd349 PS6, Line 197: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21045e70_7b7eb48d PS6, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/086dc391_6cab7129 PS6, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0adec67f_254f141c PS6, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aabd2f56_f8b80ac1 PS6, Line 33: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6c6a018_7a9bfc73 PS6, Line 33: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24182d19_13056b6c PS6, Line 36: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b410f1a_3b247724 PS6, Line 36: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f06b89c_5f91d244 PS6, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c154b201_8d989127 PS6, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/38e7331b_ac1f1ab4 PS6, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca83a806_66298916 PS6, Line 56: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af7ea9a2_6561c7a7 PS6, Line 56: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0353a206_a9c30767 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/202809e5_1a86b7b3 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/abddab6f_0fc7e581 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa3a44a4_72a5abf9 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6276ade7_abcaaca7 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b5fd2a59_3c67435e PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b98c0b0e_b8563458 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3961ec9_3ff6f817 PS6, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4afc5a8f_a7adefa3 PS6, Line 62: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6964ed18_4e61d606 PS6, Line 62: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/278eacb0_1769ff10 PS6, Line 64: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3922d7b_4f409e42 PS6, Line 64: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb213cdc_37858161 PS6, Line 71: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca7e3485_5750be6a PS6, Line 78: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de9c69dc_1c300a99 PS6, Line 78: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fca66622_4b718eb5 PS6, Line 83: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/266472b2_1e3324e7 PS6, Line 85: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a37d882a_b7148af9 PS6, Line 86: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a414c5bb_6f93e9f5 PS6, Line 88: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8478dc35_784411bf PS6, Line 88: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f55c298_7bf7c2b7 PS6, Line 100: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9b0dc85_2c8f53df PS6, Line 102: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc3860ab_d5d51699 PS6, Line 104: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c40f0a14_ca39503d PS6, Line 109: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ea8efa1_f6ac130f PS6, Line 111: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc2b16e6_4a47f2e6 PS6, Line 111: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bd25a25_68ae29e6 PS6, Line 111: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c4e8034_09926687 PS6, Line 115: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58f8b6f8_80383c15 PS6, Line 115: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0b7bafde_204242b7 PS6, Line 117: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4aeca82a_cffcecde PS6, Line 117: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbacacb9_a07f3e85 PS6, Line 117: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af379881_0ff2f42c PS6, Line 121: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbbc8b69_1765d643 PS6, Line 123: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f77533f_28580f68 PS6, Line 123: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a59a078a_54793ebf PS6, Line 123: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fff1aeaa_408ef5f7 PS6, Line 128: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80436c1e_1a5dad6d PS6, Line 130: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c181b52_8b12fa26 PS6, Line 130: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f3945eb_d87df95d PS6, Line 130: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d5c2e51_94129f59 PS6, Line 138: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/005cfb0d_66b5f930 PS6, Line 138: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9005aee1_17f56946 PS6, Line 140: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62409a4b_174fd0ff PS6, Line 140: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ee783ee_7e4a5cf9 PS6, Line 140: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82d7d841_d5c69cc2 PS6, Line 144: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0660436_b6335c5a PS6, Line 144: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81ef3c13_40fadc43 PS6, Line 146: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59d7ad98_3a0b1081 PS6, Line 146: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97aeb5bc_dc089dd3 PS6, Line 146: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f80cebe_c3cc031d PS6, Line 149: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/700f501b_32456309 PS6, Line 149: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6af43d27_291693e9 PS6, Line 151: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd4af034_d7abce06 PS6, Line 151: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e12eb18e_12646652 PS6, Line 151: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6602e86a_a536fe8f PS6, Line 154: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e6ffefc2_7b9e6e9f PS6, Line 154: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7b1a934_535f375b PS6, Line 156: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe8348c2_564956e3 PS6, Line 156: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0fdba3db_ee18cad9 PS6, Line 156: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/268bc26b_d40fd5c7 PS6, Line 162: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81c97e70_4d1ad1a4 PS6, Line 162: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bccaf7a3_9d9f0b51 PS6, Line 172: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62a8228f_11a3bd67 PS6, Line 173: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/73bf3aa1_242efc97 PS6, Line 174: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54f311ee_221233fd PS6, Line 174: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d73d6868_84e2dd11 PS6, Line 185: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/09b7a19c_06b7925a PS6, Line 185: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9356e2ba_3b6c7b01 PS6, Line 185: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fb79ef1_065b99fc PS6, Line 186: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd2cd2ee_d419d019 PS6, Line 186: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f794cc71_54e14633 PS6, Line 186: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a4af714_15e9dd7b PS6, Line 193: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba7ccaf1_c30e8f13 PS6, Line 194: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d8bc1ea_a89ce24c PS6, Line 194: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbc15084_0d9e00f6 PS6, Line 194: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcd66333_faea158e PS6, Line 197: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6539a9bf_e1bd5b2a PS6, Line 203: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7baefb60_17357e54 PS6, Line 204: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f48f516c_c47457dd PS6, Line 205: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3ee18b1_81e4e074 PS6, Line 207: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c483501e_e4a5f31c PS6, Line 208: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a08fc80a_d458bc4b PS6, Line 221: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e056e28_79d321dc PS6, Line 222: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6091b9f0_4a2a52e4 PS6, Line 225: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5506bacb_6020f7c2 PS6, Line 231: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02c59c0d_b5e7d9c3 PS6, Line 236: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cdd81cc_411cd696 PS6, Line 248: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ffec83e_bab1960c PS6, Line 256: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53dc95d2_c885c716 PS6, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3198fc8e_d2d02d78 PS6, Line 36: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a7cc801_f34d9b2c PS6, Line 37: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fddf8215_6237fdbf PS6, Line 38: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/857063dc_561f5921 PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c9b40fdc_e9a970f1 PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea0ef336_c2733adb PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb9891db_b8e976dd PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76442e29_e5106f47 PS6, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d1edaf1_a8e7f502 PS6, Line 42: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a557da9_abd7772a PS6, Line 44: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/790bfda7_a56da167 PS6, Line 45: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b275fe28_f1dfd835 PS6, Line 46: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/70c11c4c_8e5626e1 PS6, Line 48: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f5da8f5_6c744cb6 PS6, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50a264d5_9ac90d45 PS6, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/608e93bd_6279e4b5 PS6, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db86b22e_8bc13039 PS6, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1fb1de63_aee6fae5 PS6, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/857c6fc6_e21f06c4 PS6, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/785e7c1f_c7f042bb PS6, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7de4eaaa_602b4138 PS6, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ee918e9_cdace659 PS6, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d12c9c2c_e2dffe7e PS6, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23c1391f_fe22a20e PS6, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/acc4e227_81ff7d88 PS6, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec249932_5c4ab4f0 PS6, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c9547f9_e4684820 PS6, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d0c667d9_7d335eb1 PS6, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/effa5f1e_9e501d58 PS6, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97712f84_4bea3aed PS6, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f11ce328_a976616d PS6, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a372a5b5_e7d6b846 PS6, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/91458011_6e2447c9 PS6, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4458cdeb_79630a1f PS6, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/edad5b21_d1a5bb2d PS6, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8327e8d6_4c65d355 PS6, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e26b73d8_d86ac39d PS6, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87ef8401_807c82ad PS6, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b911fc3_aa920070 PS6, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/969e4517_46aaba86 PS6, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c0f38f84_ad73ec0d PS6, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/adb1f7a1_1a954b5e PS6, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/276c1887_ad536667 PS6, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a112886_c435b977 PS6, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/33a086ea_fe66b89d PS6, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/588124db_2abd5448 PS6, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6c5cd05_65f18271 PS6, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/913ba2c0_9880b4d3 PS6, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/919ae3e0_edf6a156 PS6, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/784634db_6d215ada PS6, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e443775_1cea5498 PS6, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8224cb34_43f42bfc PS6, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/954955be_657cf468 PS6, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6738d806_9a6bfd7e PS6, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b58e969c_f22558f0 PS6, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c212a283_a7541cc1 PS6, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b6dc20a2_6f595403 PS6, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2498c61a_8595f999 PS6, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fe50f21_c00270d2 PS6, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f6af5c5_ee458f0c PS6, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e020eccf_bb62aad6 PS6, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc13c022_4fed2ce8 PS6, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7513d6d_e5f6443a PS6, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87e6b7a2_5908b545 PS6, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a79cf13_7523ae2a PS6, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e9948fe_873d13ba PS6, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a2d92878_3657d474 PS6, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4145ce7b_37972418 PS6, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d0a85d5_74d95d07 PS6, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e6fad3c_25b85166 PS6, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3cb30a7d_a4d8dc7c PS6, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a862571e_899e216d PS6, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22ae16cf_d07b8cd9 PS6, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66b9b1a4_1ed5ccb4 PS6, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b591fa6c_649e0009 PS6, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0efd7ab_f0112210 PS6, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e289741c_964a3b42 PS6, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a20381d0_2ced6977 PS6, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/edf8e47d_1a1e30af PS6, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc591742_f8d5e854 PS6, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c3dbf3a_763a599a PS6, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d2308aad_624203f6 PS6, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c492a56_0d578a64 PS6, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1537): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b15b834_c5d08468 PS6, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 12:42:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-trx[master]: ms-trx support
by Hoernchen 02 Dec '22

02 Dec '22

Attention is currently required from: Hoernchen, fixeria, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 to look at the new patch set (#6). Change subject: ms-trx support ...................................................................... ms-trx support This is basically a trxcon that includes a transceiver, and can just be used with existing and future apps supporting the trxcon interface, i.e. mobile or ccch_scan. Supports bladerf and uhd, binaries are automatically built if those libs are detected + the osmocom-bb submodule exists. Currently using hardcoded sched/prios aimed at a setup with working, reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3, not 2, not any other version) Additionally builds test tools used for development: osmo-trx-syncthing* Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 --- M .gitignore M Makefile.am M Transceiver52M/Makefile.am A Transceiver52M/ms/bladerf_specific.h A Transceiver52M/ms/itrq.h A Transceiver52M/ms/l1ctl_server.c A Transceiver52M/ms/l1ctl_server_cb.cpp A Transceiver52M/ms/logging.cpp A Transceiver52M/ms/ms.cpp A Transceiver52M/ms/ms.h A Transceiver52M/ms/ms_rx_burst.h A Transceiver52M/ms/ms_rx_burst_test.cpp A Transceiver52M/ms/ms_rx_lower.cpp A Transceiver52M/ms/ms_upper.cpp A Transceiver52M/ms/ms_upper.h A Transceiver52M/ms/sch.c A Transceiver52M/ms/sch.h A Transceiver52M/ms/uhd_specific.h M configure.ac 19 files changed, 3,470 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in pysim[master]: sysmocom_sja2: simplify and fix op/opc decoder/encoder
by dexter 02 Dec '22

02 Dec '22

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/30435 ) Change subject: sysmocom_sja2: simplify and fix op/opc decoder/encoder ...................................................................... sysmocom_sja2: simplify and fix op/opc decoder/encoder The decoder/encoder of that decodes the EF.xSIM_AUTH_KEY files has an overcomplicated handling for op/and opc. There is a condition that checks if milenage is configured and another one that checks if the string is recognized as OP or OPc. Both is not correct and seems not to work (op and opc is always displayed as "null") The encoder/decoder should focus on the physical file layout and regardless of any other conriguration the OP/OPc field is physically present and should be displayd and presented for editing. Change-Id: I6fa3a07e5e473273498d3f13d4cfa33743b787e1 --- M pySim/sysmocom_sja2.py 1 file changed, 3 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/30435/1 diff --git a/pySim/sysmocom_sja2.py b/pySim/sysmocom_sja2.py index 53e6585..a78318e 100644 --- a/pySim/sysmocom_sja2.py +++ b/pySim/sysmocom_sja2.py @@ -143,12 +143,7 @@ 'algorithm'/Enum(Nibble, milenage=4, comp128v1=1, comp128v2=2, comp128v3=3)) self._construct = Struct('cfg'/CfgByte, 'key'/HexAdapter(Bytes(16)), - 'op'/ If(this.cfg.algorithm == 'milenage' and not this.cfg.use_opc_instead_of_op, - HexAdapter(Bytes(16))), - 'opc' / - If(this.cfg.algorithm == 'milenage' and this.cfg.use_opc_instead_of_op, - HexAdapter(Bytes(16))) - ) + 'op_opc' /HexAdapter(Bytes(16))) class DF_SYSTEM(CardDF): @@ -198,13 +193,7 @@ 'algorithm'/Enum(Nibble, milenage=4, sha1_aka=5, xor=15)) self._construct = Struct('cfg'/CfgByte, 'key'/HexAdapter(Bytes(16)), - 'op' / - If(this.cfg.algorithm == 'milenage' and not this.cfg.use_opc_instead_of_op, - HexAdapter(Bytes(16))), - 'opc' / - If(this.cfg.algorithm == 'milenage' and this.cfg.use_opc_instead_of_op, - HexAdapter(Bytes(16))) - ) + 'op_opc' /HexAdapter(Bytes(16))) class EF_USIM_AUTH_KEY_2G(TransparentEF): @@ -216,13 +205,7 @@ 'algorithm'/Enum(Nibble, milenage=4, comp128v1=1, comp128v2=2, comp128v3=3)) self._construct = Struct('cfg'/CfgByte, 'key'/HexAdapter(Bytes(16)), - 'op' / - If(this.cfg.algorithm == 'milenage' and not this.cfg.use_opc_instead_of_op, - HexAdapter(Bytes(16))), - 'opc' / - If(this.cfg.algorithm == 'milenage' and this.cfg.use_opc_instead_of_op, - HexAdapter(Bytes(16))) - ) + 'op_opc' /HexAdapter(Bytes(16))) class EF_GBA_SK(TransparentEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6fa3a07e5e473273498d3f13d4cfa33743b787e1 Gerrit-Change-Number: 30435 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-trx[master]: ms-trx support
by Jenkins Builder 02 Dec '22

02 Dec '22

Attention is currently required from: fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 5: (371 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1db8dbb0_44b1f63a PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/30ee4e45_6ebbca5d PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e9ae274_4d8e7c51 PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2532f811_414e5bbd PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c9c1c121_f8a02643 PS5, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5f421c8_0ed5277a PS5, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/968aa5d6_9c00d13a PS5, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/52c1d3d9_25245f08 PS5, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bf9117c_d3fdeb44 PS5, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11587610_15587a4d PS5, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06e1c20d_13547e42 PS5, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49328b5c_751da9ad PS5, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/572fd10b_79135d7a PS5, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/90a12f54_bbe43491 PS5, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8a2188c_906af860 PS5, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbe832cd_8e24bb16 PS5, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d0b28c8b_e8ec233e PS5, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b0b8eb4_5b75c15e PS5, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b013167_9649babf PS5, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72c8568b_c9de64c2 PS5, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bafd3eb6_f98b8326 PS5, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/218d72a0_4173f790 PS5, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a5fe04a0_016750f5 PS5, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25a8fcea_abee5289 PS5, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e645578_79ef5ac5 PS5, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ababbeea_c931e2c6 PS5, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36dc0271_6ccf6747 PS5, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03879f09_550a95a8 PS5, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c6d0370b_f4a65d2d PS5, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/117e2823_24cecb7a PS5, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efe36f96_fcb8b89b PS5, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3efd40c_c92c7826 PS5, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/851a57aa_f3b4ee04 PS5, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58bd648b_3ae2236e PS5, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb9ba8b8_a01610d5 PS5, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d399514a_a60e9705 PS5, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/770236dd_389b9904 PS5, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/496f604d_65e08c9f PS5, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1b87d225_9561e365 PS5, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51706849_93806949 PS5, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d81b7e13_976d3b68 PS5, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a4019327_f5233e0c PS5, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2afd99ca_bb3b3645 PS5, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a4a6389_41cd3e9f PS5, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb06b62d_245b3e61 PS5, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19054ec8_249d7770 PS5, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0d512ea_dbc06bd2 PS5, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06476368_77eb48c4 PS5, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/682ed0d5_b72c5c4e PS5, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/be93be05_d44b81e5 PS5, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c6f8a375_01f4f73f PS5, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/550ed6f2_bc691961 PS5, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f22bc2a9_b4704a66 PS5, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9723210e_672d9343 PS5, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1cc5c7e6_ac8f8209 PS5, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f601169_7bf3b14d PS5, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74537a43_6f23f3f2 PS5, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e2f5c277_01584ab7 PS5, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c2db1b09_b69365e9 PS5, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9611073d_0dbfcff2 PS5, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9337b12_ec081468 PS5, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4148c131_9ed248e0 PS5, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f48fa2cb_88dbbf84 PS5, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a2a750a_effb99c8 PS5, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/41ef42e3_34dcab89 PS5, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6e59edee_5860179d PS5, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ce61203_24ff5c4b PS5, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/874357bb_44cd5ca3 PS5, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b45cb4b_57cc16fc PS5, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b025839_cb52215e PS5, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6348252a_86efdd80 PS5, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7228ade_249ed0a1 PS5, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b93f72e9_c5042e2d PS5, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1fefae16_9d664da4 PS5, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e85ec107_46148a9b PS5, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34593d7c_92d269fb PS5, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb008d79_4c5bce76 PS5, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee16de6a_abe812f2 PS5, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ddc54b7_576eeaa1 PS5, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04c815c8_d3d65033 PS5, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d5eb861_8be1231a PS5, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf152a45_40677e10 PS5, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e09d46ec_7465b28d PS5, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/679d5e1a_a86ad697 PS5, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d105ff57_3ce5148a PS5, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfcd7e01_53f9fbe9 PS5, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2018b5d3_13af9aaf PS5, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0df44b48_ff4ab5da PS5, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee87d245_67afcd57 PS5, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02c31869_59af9a57 PS5, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c2f16844_2f6d3577 PS5, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/84635d5d_4e47967b PS5, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ede3335b_4b1a677c PS5, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f25130e_a53c2765 PS5, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/116f275a_83c9a60a PS5, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e44a6093_30f18b92 PS5, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07b6c580_ec6b477e PS5, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39536ede_a28832d7 PS5, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b040b78_ae362a7a PS5, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f82cba64_6dca1ece PS5, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e9b50d9_5c7307e5 PS5, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc887f99_212def38 PS5, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14cfae85_47418d42 PS5, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/45c0ceaf_c7a8ca1b PS5, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02c6c504_f7473fe2 PS5, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c547175d_8f33ed07 PS5, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e12daa0_3e976577 PS5, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9299f624_ed906ce2 PS5, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e76c69d3_b40f720a PS5, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa0e9a7b_297da01a PS5, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eecd9c3c_430cb1a1 PS5, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9450ba55_ac046910 PS5, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7e51d49_c5306b1d PS5, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54e7aec3_0fbf56eb PS5, Line 36: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbe1738d_83bccfb1 PS5, Line 36: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f225ad5_9540fcd8 PS5, Line 37: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c95bc8ee_547bc069 PS5, Line 38: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c9a760a5_e7175182 PS5, Line 39: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/760eb66c_873e4692 PS5, Line 41: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1e7d442_a3c1bc9f PS5, Line 42: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7d6c51d1_0533d05e PS5, Line 50: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81e18105_3bc3f61f PS5, Line 50: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd01c310_9dabb688 PS5, Line 52: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef39ac13_39291631 PS5, Line 52: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce3bbad5_26c5cf01 PS5, Line 52: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6e9022fd_c733801d PS5, Line 58: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ffbfb1b_99c6e037 PS5, Line 58: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c080bca_97d57928 PS5, Line 60: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da46b721_58471d4d PS5, Line 60: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/70611e16_148cda92 PS5, Line 60: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f44127f_16680c52 PS5, Line 66: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d464b584_5861fb0a PS5, Line 66: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61b27a40_8d9a1e61 PS5, Line 68: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79c14c14_28139345 PS5, Line 68: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9a4dd0ce_73364a2b PS5, Line 68: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5dbc7ba_710c70f9 PS5, Line 72: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4aef8df6_9c12ba6f PS5, Line 72: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8e634151_1d549726 PS5, Line 74: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/271da110_959f38f5 PS5, Line 74: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74362a36_84fc294a PS5, Line 74: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ece62726_b1c760b1 PS5, Line 81: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fb4818d2_d2a991d7 PS5, Line 81: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72fb96cc_74cafcc7 PS5, Line 84: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e1c8eb4_0d802b44 PS5, Line 85: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18be9f2e_f774b6c4 PS5, Line 96: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b1ae109d_3930dead PS5, Line 96: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bc9a8451_cb9c64e5 PS5, Line 101: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bfc2d9dc_b0a78b58 PS5, Line 101: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51c21133_c8ec7f21 PS5, Line 106: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c230a01_2c8f9bd6 PS5, Line 106: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a17c87c_c107cc1a PS5, Line 111: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5bfbc535_dd2c1696 PS5, Line 111: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f95d18a_1fe9bd6a PS5, Line 116: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5626cf56_047e624e PS5, Line 116: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3be8df4c_b7531a29 PS5, Line 120: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9033449d_fcf696bd PS5, Line 120: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99259aef_a6e48e15 PS5, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7609fb3a_3bef3122 PS5, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dca0ecb8_f8e4f2b8 PS5, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/857fa8a6_c48722c9 PS5, Line 126: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ed3aaf5c_9289dad9 PS5, Line 127: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4dd9edcf_be12d6ac PS5, Line 127: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ed865534_d50d9af1 PS5, Line 129: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2699685f_2c39170e PS5, Line 129: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca2bd0f7_c5e36677 PS5, Line 129: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4388bf24_84723f84 PS5, Line 130: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fba20bc_8d67b653 PS5, Line 130: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cb41f55_f59b991e PS5, Line 130: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59c9b9d5_b9e6d38a PS5, Line 134: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32e12996_cca4b5a3 PS5, Line 135: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6be1c87_1cb506ed PS5, Line 135: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bf4acbf_d464d529 PS5, Line 137: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9a02be6c_8f96914f PS5, Line 148: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/297b4ddf_7fd74690 PS5, Line 155: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd91910c_e95d16bc PS5, Line 161: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2cd18950_ffd435b7 PS5, Line 168: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42436621_6cfec3d2 PS5, Line 180: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f67910a_7b2e4afb PS5, Line 187: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/333f6965_4e0dc9f9 PS5, Line 187: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78199df0_1ed5914b PS5, Line 195: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba11aafe_1775d336 PS5, Line 195: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5bac7dc_790cd586 PS5, Line 196: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49baf8a2_a3836f96 PS5, Line 196: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0762796e_acc63e8e PS5, Line 197: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c1ebdfa5_069ab464 PS5, Line 197: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a3671b8b_bfa8a720 PS5, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a28829e_0743a45b PS5, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37f88327_c5cfd234 PS5, Line 198: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ec3e54d_f60b40d1 PS5, Line 33: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c676523_f45c2555 PS5, Line 33: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4378adb4_577c5d29 PS5, Line 36: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11ca7333_4b7c20a7 PS5, Line 36: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8de4afa0_e90e97d8 PS5, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd77bbd0_c0fe1342 PS5, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23306f2e_50359168 PS5, Line 48: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ed6a7881_b0171029 PS5, Line 56: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/476c6920_7592133f PS5, Line 56: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b36b4a8_9e5b7a77 PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ad9239b_5631ad7f PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a3ecc843_a733f06a PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ccb25c5_27d9d64c PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7caac0e5_d6f77730 PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3888e4c5_6babd7cc PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/549a5e08_1afa9e84 PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8be87cd5_6645f915 PS5, Line 60: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3a1a23f_bf25aebb PS5, Line 62: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb3571f9_42103fb1 PS5, Line 62: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e5ca996_c998f892 PS5, Line 64: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e3ca29e_051bdc69 PS5, Line 64: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26b96ad3_2484b8c9 PS5, Line 71: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25f0645b_adc4b443 PS5, Line 78: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/518b700f_95282c96 PS5, Line 78: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4026e79_e5f6bd86 PS5, Line 83: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24ed4bb7_ca153821 PS5, Line 85: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dfc540a4_e622f4ca PS5, Line 86: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d80f2e7_93c6d562 PS5, Line 88: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e9bb51c_763f4ce4 PS5, Line 88: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02322bab_09ac27d0 PS5, Line 100: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ddf68a5_603b4239 PS5, Line 102: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28aa546d_8f484a2a PS5, Line 104: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47522a74_20db3d05 PS5, Line 109: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54de7741_018f1afa PS5, Line 111: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2757df8b_3f317be4 PS5, Line 111: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f6a6e13_c6869689 PS5, Line 111: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2629228d_a76f7c0e PS5, Line 115: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de7c390b_c5245ee7 PS5, Line 115: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5138f0d9_1f6278dd PS5, Line 117: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08763be4_50c79a37 PS5, Line 117: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d5e50da_f1bd6437 PS5, Line 117: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ed4d34c_7fbe873b PS5, Line 121: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4445e1a2_6dd0af05 PS5, Line 123: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51366fb9_0a3b4d5a PS5, Line 123: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9a61c0e_d8f4d8c4 PS5, Line 123: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/12351452_e34ca89d PS5, Line 128: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17e3befa_9c48d6a8 PS5, Line 130: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86791907_30894136 PS5, Line 130: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac1c912d_010c84fe PS5, Line 130: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c8aa077_01bac002 PS5, Line 138: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad843c14_eeebf485 PS5, Line 138: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc1bf536_6dd799a3 PS5, Line 140: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51286627_84396b1e PS5, Line 140: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fd901a0_36938d56 PS5, Line 140: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c263844a_9691d3d5 PS5, Line 144: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50f41d89_f2f32512 PS5, Line 144: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5f3a606_432e2657 PS5, Line 146: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f3ba403_814e8c15 PS5, Line 146: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42855d83_b92e38f4 PS5, Line 146: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/540501df_4e5de12f PS5, Line 149: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e05f7c34_62ed3a02 PS5, Line 149: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d719d532_f0f1ecce PS5, Line 151: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49e4ddee_2dd7414d PS5, Line 151: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/012c94e7_c44366a6 PS5, Line 151: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af0a04fe_5ada53a6 PS5, Line 154: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d76c3764_2eaf3424 PS5, Line 154: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54617b2b_01de1889 PS5, Line 156: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3dde495_38b25bd0 PS5, Line 156: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a78ec7ff_f40cda0d PS5, Line 156: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ca10aef_0f349275 PS5, Line 162: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/91981a7f_a90c3252 PS5, Line 162: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e03cfd59_9a80ba92 PS5, Line 172: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6994328_ba82ee68 PS5, Line 173: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/13b159ce_9793d117 PS5, Line 174: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bc6db78_648aaefe PS5, Line 174: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f036ea89_51b91c44 PS5, Line 185: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/84d56499_066d5a0c PS5, Line 185: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4eee4eca_85500944 PS5, Line 185: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/274418e8_8ea0d95b PS5, Line 186: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/91db345a_4bcd5152 PS5, Line 186: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e83d7ebb_9061d270 PS5, Line 186: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9126233d_c66932fa PS5, Line 193: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c19d12c4_1169d3f4 PS5, Line 194: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd27826a_729c1606 PS5, Line 194: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6fad4790_7893f5df PS5, Line 194: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd0d0ed1_61ee9b7d PS5, Line 197: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/edbac8b7_66e6afbb PS5, Line 203: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8acae8bb_a7dc21e2 PS5, Line 204: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27bcaf3b_ab0d559a PS5, Line 205: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eaa29e0d_27a65334 PS5, Line 207: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9bd2cafa_17113896 PS5, Line 208: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efc3363e_575a3591 PS5, Line 221: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/529b69d9_3d21d790 PS5, Line 222: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bc176db_e4488b0d PS5, Line 225: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/325be44e_513a3069 PS5, Line 231: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac8aa3f3_c461eeb5 PS5, Line 236: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/558d55f9_9cfb0507 PS5, Line 248: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dae4bd94_6da19f01 PS5, Line 256: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ab20db8_87a27938 PS5, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51600643_2da67da7 PS5, Line 36: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb8cbb03_9112e6a0 PS5, Line 37: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b89098fd_d31fcf51 PS5, Line 38: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d432776e_2ac07d58 PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7a9cbf4f_cb295e52 PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddf5347a_3eb851b9 PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d02e3356_2afd83f2 PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c0b690c_b37e2f2f PS5, Line 40: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35f9432c_1cb9875a PS5, Line 42: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1469fdd4_54bfa1cc PS5, Line 44: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7718948_463e9197 PS5, Line 45: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5984dd6e_46e66669 PS5, Line 46: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1fec74d9_3324f28c PS5, Line 48: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83d7ec13_f1edf6f0 PS5, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4e5d175_8c0181dc PS5, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e3b3951_72b0b56d PS5, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9353ebe5_a4b59252 PS5, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4209a20f_95280c93 PS5, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc7002e3_aa187332 PS5, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d6b5664_6e8046d2 PS5, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd468a0b_cd300fe0 PS5, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dfd908d7_80afda47 PS5, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c27241b_0201ae25 PS5, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de14c8cd_8348239f PS5, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b5d7c93a_67617f34 PS5, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e077d1a4_4723ecc7 PS5, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b92a056f_8a47f058 PS5, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/863666aa_3d11a290 PS5, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3d1140b_d6405b23 PS5, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ceb0f45d_95a5cad8 PS5, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0177c3bb_e82748ed PS5, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83670202_f71c6641 PS5, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c73b5f9_02c86b5a PS5, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19054522_3995a58f PS5, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0ccf1e62_c650c112 PS5, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcc13b2f_69628742 PS5, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22c2bceb_6a448cc6 PS5, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a2f2c456_cc2b321f PS5, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a62d528_45995bb7 PS5, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a82190d2_f1cac73a PS5, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05d03bb2_a0fe6484 PS5, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5dc41a4_f8a9bf71 PS5, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea5212d3_8e9077b4 PS5, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f9b5d20_914342f8 PS5, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d2af54d3_3feca4de PS5, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55860bc6_5018168d PS5, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54f8903f_8f82bfec PS5, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/281fb68a_feedc529 PS5, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d51acdd4_b80957e2 PS5, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a1f182e_50e73e3d PS5, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1387cc08_cfea3dd7 PS5, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f26ac43_88fa423b PS5, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7139e7ef_b4541438 PS5, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bef414a1_0792f637 PS5, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcba89b4_809dfa06 PS5, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2ceae6f0_05158b04 PS5, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99b27f0e_d55c6cfd PS5, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/93768f7d_985360ca PS5, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/033d6cc6_69669b6c PS5, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e393a06_90ef0c1f PS5, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de19d0e3_0ed2004a PS5, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac0897f5_32a193cf PS5, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42f55603_53e8142a PS5, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5673f29_013b6aab PS5, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cba19fd5_1bc7d521 PS5, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7e7b555_fdfcad3b PS5, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85cdd2fc_3512219f PS5, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04b0a051_dab8721b PS5, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66f499a3_3764d68b PS5, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3cc63b47_bd4ac001 PS5, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f744e07f_bfc717d0 PS5, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f2f41bd4_306436bd PS5, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b532910_d069e1e4 PS5, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32411831_9d318e2c PS5, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a64660d_2a59a031 PS5, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32c5f5e0_0acb7e85 PS5, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/69f15d6c_272acb1a PS5, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db1a0811_6372155b PS5, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4dc2c30_ae29e56e PS5, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2f146ebd_423e1f92 PS5, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59a92d75_4c3d99bb PS5, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1df28b57_6572157d PS5, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b821bdd_f4c389e2 PS5, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1535): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe0fe850_aeb0791a PS5, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 11:24:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-trx[master]: ms-trx support
by Hoernchen 02 Dec '22

02 Dec '22

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 to look at the new patch set (#5). Change subject: ms-trx support ...................................................................... ms-trx support This is basically a trxcon that includes a transceiver, and can just be used with existing and future apps supporting the trxcon interface, i.e. mobile or ccch_scan. Supports bladerf and uhd, binaries are automatically built if those libs are detected + the osmocom-bb submodule exists. Currently using hardcoded sched/prios aimed at a setup with working, reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3, not 2, not any other version) Additionally builds test tools used for development: osmo-trx-syncthing* Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 --- M .gitignore M Makefile.am M Transceiver52M/Makefile.am A Transceiver52M/ms/bladerf_specific.h A Transceiver52M/ms/itrq.h A Transceiver52M/ms/l1ctl_server.c A Transceiver52M/ms/l1ctl_server_cb.cpp A Transceiver52M/ms/logging.cpp A Transceiver52M/ms/ms.cpp A Transceiver52M/ms/ms.h A Transceiver52M/ms/ms_rx_burst.h A Transceiver52M/ms/ms_rx_burst_test.cpp A Transceiver52M/ms/ms_rx_lower.cpp A Transceiver52M/ms/ms_upper.cpp A Transceiver52M/ms/ms_upper.h A Transceiver52M/ms/sch.c A Transceiver52M/ms/sch.h A Transceiver52M/ms/uhd_specific.h M configure.ac 19 files changed, 3,473 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

gerrit-log December 2022