December 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: mobile: integrate GAPK based audio (voice) I/O support

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30337 ) Change subject: mobile: integrate GAPK based audio (voice) I/O support ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 11:18:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ms-trx support

by Hoernchen

Attention is currently required from: fixeria, pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 4: (37 comments) File Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8557aa21_1a4ffec0 PS3, Line 37: osmocom-bb/src/host/trxcon \ > Ack. Most likely he forgot to remove this line. Done File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab495219_3ad23e55 PS3, Line 26: AM_CPPFLAGS > '-I' stuff should be in CPPFLAGS only, it makes no sense to have it in CFLAGS/CXXFLAGS. Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef318324_7f99c032 PS3, Line 77: LIBOSMOCODING_LIBS > Having LIBOSMOCODING_LIBS in COMMON_LDADD makes all osmo-trx-* binaries depend on libosmocoding, whi […] Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7dbf1157_40ebb075 PS3, Line 90: noinst_HEADERS > This should be done conditionally too, but not critical I guess. Done File Transceiver52M/ms/itrq.h: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27a2e661_cd56fde8 PS3, Line 34: /* > weird comment formatting, please make it consistent with the copyright header Done File Transceiver52M/ms/l1ctl_server_cb.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c7497e2_ec2b34dc PS3, Line 65: osmocom_l2 > TODO: make path configurable Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/57fa3766_3292a919 PS3, Line 74: return > so the app keeps running if l1ctl_server_alloc() fails? Done File Transceiver52M/ms/logging.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a2f6a6eb_8ec2be8e PS3, Line 54: loglevel = LOGL_NOTICE > spacing issues Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ed44894c_88a9b155 PS3, Line 57: DTRXC > not used by libtrxcon nor needed Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/278cf1d8_349e019f PS3, Line 64: DTRXD > not used by libtrxcon nor needed Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10a88d01_ee4fa15a PS3, Line 75: .loglevel = LOGL_NOTICE, > spacing issues Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d69f7024_80c92d1a PS3, Line 76: enabled = 0, > why disabled? too nuch unbounded log spam impacts timing. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b6ec8fb5_6b42d5f4 PS3, Line 82: .loglevel = LOGL_NOTICE, > spacing issues Done File Transceiver52M/ms/ms_upper.h: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/925d5d4e_ee890a3f PS3, Line 1: > ws Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b046a98_0c6d47aa PS3, Line 36: trx_if > do you really need/use TRXC/TRXD here? Done File Transceiver52M/ms/ms_upper.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd859f9b_9180321b PS3, Line 61: #include <osmocom/core/gsmtap_util.h> > you're not using GSMTAP API here... Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/499172f8_05f316dc PS3, Line 64: // #include <osmocom/core/application.h> > removeme Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d7e67c3_d3a9ea3a PS3, Line 71: trx_if > do you really need/use TRXC/TRXD here? Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e6956264_e4693cf4 PS3, Line 74: #include <osmocom/bb/l1sched/l1sched.h> > I don't see any l1sched_* API used in this file. Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50ed90bd_c350e3e7 PS3, Line 177: return trash > can you clarify this a bit further? thrash? fcch bursts contain "nothing", but the old trxcon needed "something" to tickle the scheduler. There are only 3 burst types, so explictily listing all of those is fine, even if the new scheduler allows skipping those and the function returns early. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b19fa0c_2a6ef870 PS3, Line 184: RSSI = 10 > why 10? random reasonable value, the SCH burst is only demodulated once in the timekeeping part because doing it twice introduces massive latency spikes comapared to NB that are only handled in the upper layer, so there is no opportunity here to measure anything because only the demodded bits are passed to the upper layer in the SCH case. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbf421e4_47d1aabf PS3, Line 223: timingOffset = (int)round(0); > TODO/FIXME? Done In practice the alignment does not matter because the lower loop continuously tracks and updates it anyway so the only offset available would be the short term offset until it gets updated and reset to 0. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b42d80bc_257ccd2a PS3, Line 238: trx_data_rx_handler > removeme Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7baa8e3_a29f5253 PS3, Line 246: trxcon_phyif_handle_clock_ind > removeme Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a644c068_f9d7149e PS3, Line 304: case trxcon::TRXCON_PHYIF_CMDT_RESET > Better use value-string for that. […] This mostly exists for debugging the order of actions here and should not really be used for anything else. It's just easier to use than signaltap or other custom markers. In practice for general purpose logging trxcon/the l1ctl handler knows what is going on anyway. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/067b8844_59e02d0a PS3, Line 352: set_ta > Shouldn't this be done on receipt of TRXCON_PHYIF_CMDT_RESET instead? Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14fe4b6f_7d7255a9 PS3, Line 357: dbm = -80 > please add a FIXME or TODO, so it's clear that the measurement logic is missing Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/70971d36_b612055b PS3, Line 364: gsm_arfcn2freq10 > careful, this function may return 0xffff In practice we mostly want to use different frequencies anyway, but for current testing and usage we just stick to "a" arfcn and that's it. If wrong arfcns are passed that are not part of the gsm ranges everything is broken anyway... https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dff33073_293e488a PS3, Line 385: assert > OSMO_ASSERT? Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd8bb51d_b634bc66 PS3, Line 425: trxcon > it's not trxcon app anymore but this "is" the global trxcon context used for all trxcon stuff and this is only being used by the "main loop" upper thread doing trxcon things... https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aef3dc97_b8c24196 PS3, Line 429: 3 > pass 0 to avoid confusion, we're not using fn_advance here Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7945fb2f_e09c12db PS3, Line 430: gsmtap = 0; > gsmtap is a pointer, so = NULL Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/98c4b4de_b3d3dfdb PS3, Line 431: 0x1234 > What's this? Why not NULL? Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b0108db_523b8342 PS3, Line 433: trxc > I would avoid using 'trxc' here to avoid confusion with the TRXC protocol. Done File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc9cdab4_377081c8 PS3, Line 330: test -d osmocom-bb > A proper approach would be making this configurable: --enable-ms or --with-ms. Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/619bda41_d8b301b6 PS3, Line 333: AC_MSG_NOTICE(["Enabling ms-trx..."]) > spacing issues Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dfc70a11_6afaee32 PS3, Line 364: doc/manuals/Makefile \ > Ack, it's one of my fixups: https://cgit.osmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 11:17:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm_forward_mncc(): properly mark TCH/H frames

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30401 ) Change subject: mobile: gsm_forward_mncc(): properly mark TCH/H frames ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id3f459bc767ebf31469287fa672893239c5977d9 Gerrit-Change-Number: 30401 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 11:17:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm_forward_mncc(): call mncc_sock_from_cc() directly

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30400 ) Change subject: mobile: gsm_forward_mncc(): call mncc_sock_from_cc() directly ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I29305866e61a0bc3bd082108af6a9ba8ff86bcf2 Gerrit-Change-Number: 30400 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 11:17:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: rework gsm_recv_voice(), add AUDIO_IOH_MNCC_SOCK

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30399 ) Change subject: mobile: rework gsm_recv_voice(), add AUDIO_IOH_MNCC_SOCK ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I406b169963e6654110329d741728fa12c8c8eeec Gerrit-Change-Number: 30399 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 11:17:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: improve function comments in voice.c

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30398 ) Change subject: mobile: improve function comments in voice.c ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0285a07841bdc2568374f9e9cd0214eef1415186 Gerrit-Change-Number: 30398 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 11:16:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: add missing TCH MNCC messages and handle them

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30397 ) Change subject: mobile: add missing TCH MNCC messages and handle them ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I28a1ae1ed504748c33c64c86ca7d57a94c7c7c6d Gerrit-Change-Number: 30397 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 11:16:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in docker-playground[master]: ttcn3-docker-run.sh: Use interface "up" flag, not operstate

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30383 ) Change subject: ttcn3-docker-run.sh: Use interface "up" flag, not operstate ...................................................................... ttcn3-docker-run.sh: Use interface "up" flag, not operstate Don't use the "operstate" sysfs attribute to determine if an interface is "up", use the actual UP-flag (0x01) in the "flags" sysfs attribute. The "operstate" attribute may at least occasionally be "unknown" and remain in that state (causing jenkins jobs to wait indefinitely), while the flags (which we don't look at before this patch) indicates it is "up". This is a fixup to the below commit: commit d2014603a736a17d6b92006b25aa41482365ef3d Author: Harald Welte <laforge(a)osmocom.org> Date: Wed Feb 3 22:05:43 2021 +0100 debian-stretch-titan: Wait for interface to be _up_ not just its existance Change-Id: Ib5c3bbe470ce874217437c2518df5ae07f0d8301 Closes: OS#5803 --- M debian-bullseye-titan/ttcn3-docker-run.sh 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian-bullseye-titan/ttcn3-docker-run.sh b/debian-bullseye-titan/ttcn3-docker-run.sh index c868220..26e291c 100755 --- a/debian-bullseye-titan/ttcn3-docker-run.sh +++ b/debian-bullseye-titan/ttcn3-docker-run.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash if [ $# -lt 2 ]; then echo echo "usage: ttcn3-docker-run SUBDIR SUITE" @@ -18,11 +18,12 @@ pipework --wait -i "$WAIT_FOR_NETDEV" while true; do - if [ ! -f /sys/class/net/${WAIT_FOR_NETDEV}/operstate ]; then + if [ ! -f /sys/class/net/${WAIT_FOR_NETDEV}/flags ]; then exit 23 fi - OPSTATE=$(cat /sys/class/net/${WAIT_FOR_NETDEV}/operstate) - if [ "$OPSTATE" = "up" ]; then + FLAGS=$(cat /sys/class/net/${WAIT_FOR_NETDEV}/flags) + let FLAG_UP=$FLAGS\&1 + if [ "$FLAG_UP" = "1" ]; then break fi echo "Waiting for ${WAIT_FOR_NETDEV} to become operational" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5c3bbe470ce874217437c2518df5ae07f0d8301 Gerrit-Change-Number: 30383 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: fix permissions

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30434 ) Change subject: jobs/osmo-gsm-tester virtual: fix permissions ...................................................................... jobs/osmo-gsm-tester virtual: fix permissions The docker container creates the trial dir and some files inside of it as root, therefore the rm -rf trial-* line fails. Add logic to fix the permissions before attempting to remove old trial-* and when the script exits. Related: OS#5793 Change-Id: I91bd6656f33667f401247721bb34298a6c66fc62 --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 25 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 9a57ead..688da38 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -218,12 +218,35 @@ - timed: "H 22 * * *" builders: - shell: | - # make sure no test results/bin artifacts from a previous run remain - rm -rf trial-* *.tgz *.md5 + # make sure no bin artifacts from a previous run remain + rm -rf *.tgz *.md5 - copy_artifact_all - copy_artifact: repo: osmo-gsm-tester_build-osmocom-bb - shell: | + # Set a trap to fix workspace permissions on exit + fix_permissions() { + docker run --rm \ + -v "$WORKSPACE":/workspace \ + debian:bullseye \ + chmod -R a+rwX /workspace/ + } + fix_permissions_trap() { + set +x + echo + echo "### Clean up ###" + echo + set -x + + trap - EXIT INT TERM 0 + fix_permissions + } + trap fix_permissions_trap EXIT INT TERM 0 + + # Make sure no test results from a previous run remain + fix_permissions + rm -rf trial-* + # Build the docker image rm -rf docker-playground git clone \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I91bd6656f33667f401247721bb34298a6c66fc62 Gerrit-Change-Number: 30434 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: fix permissions

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30434 ) Change subject: jobs/osmo-gsm-tester virtual: fix permissions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I91bd6656f33667f401247721bb34298a6c66fc62 Gerrit-Change-Number: 30434 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Dec 2022 10:51:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022