pespin has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-pcu/+/30608 )
Change subject: Rename gprs_rlcmac_ts_alloc.cpp -> alloc_algo.cpp & create own .h file
......................................................................
Rename gprs_rlcmac_ts_alloc.cpp -> alloc_algo.cpp & create own .h file
First commit towards trying to have alloc algorithm as isolated as
possible from others parts of the code trying to avoid state changes on
data structures.
Change name also because the alloc_algo not only allocated TS, but TFIs
and USFs.
Change-Id: I33a6c178c64a769f05d3880a69c38acb154afa62
---
M debian/copyright
M src/Makefile.am
R src/alloc_algo.cpp
A src/alloc_algo.h
M src/gprs_bssgp_pcu.c
M src/gprs_rlcmac.h
M src/pcu_main.cpp
M src/pcu_vty.c
M tests/alloc/AllocTest.cpp
M tests/app_info/AppInfoTest.cpp
M tests/edge/EdgeTest.cpp
M tests/emu/pcu_emu.cpp
M tests/tbf/TbfTest.cpp
M tests/types/TypesTest.cpp
14 files changed, 58 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/08/30608/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I33a6c178c64a769f05d3880a69c38acb154afa62
Gerrit-Change-Number: 30608
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30608 )
Change subject: Rename gprs_rlcmac_ts_alloc.cpp -> alloc_algo.cpp & create own .h file
......................................................................
Patch Set 2:
(1 comment)
File src/alloc_algo.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1933):
https://gerrit.osmocom.org/c/osmo-pcu/+/30608/comment/c4a256e0_90decdf8
PS2, Line 40: #endif
adding a line without newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I33a6c178c64a769f05d3880a69c38acb154afa62
Gerrit-Change-Number: 30608
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 14 Dec 2022 18:44:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/30608 )
Change subject: Rename gprs_rlcmac_ts_alloc.cpp -> alloc_algo.cpp & create own .h file
......................................................................
Rename gprs_rlcmac_ts_alloc.cpp -> alloc_algo.cpp & create own .h file
First commit towards trying to have alloc algorithm as isolated as
possible from others parts of the code trying to avoid state changes on
data structures.
Change name also because the alloc_algo not only allocated TS, but TFIs
and USFs.
Change-Id: I33a6c178c64a769f05d3880a69c38acb154afa62
---
M debian/copyright
M src/Makefile.am
R src/alloc_algo.cpp
A src/alloc_algo.h
M src/gprs_bssgp_pcu.c
M src/gprs_rlcmac.h
M src/pcu_main.cpp
M src/pcu_vty.c
M tests/alloc/AllocTest.cpp
M tests/app_info/AppInfoTest.cpp
M tests/edge/EdgeTest.cpp
M tests/emu/pcu_emu.cpp
M tests/tbf/TbfTest.cpp
M tests/types/TypesTest.cpp
14 files changed, 58 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/08/30608/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I33a6c178c64a769f05d3880a69c38acb154afa62
Gerrit-Change-Number: 30608
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30608 )
Change subject: Rename gprs_rlcmac_ts_allc.cpp -> s_alloc_algo.cpp & create own .h file
......................................................................
Patch Set 1:
(1 comment)
File src/ts_alloc_algo.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1932):
https://gerrit.osmocom.org/c/osmo-pcu/+/30608/comment/04f0e9e3_6a338112
PS1, Line 40: #endif
adding a line without newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I33a6c178c64a769f05d3880a69c38acb154afa62
Gerrit-Change-Number: 30608
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 14 Dec 2022 18:37:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30607 )
Change subject: properly update osmocom-bb submodule, for real this time..
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I suggest additionally removing the 'branch' from .gitmodules to avoid confusion.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30607
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Icb3ba575cf5235db7e6c03df3d7d45133d535c50
Gerrit-Change-Number: 30607
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Dec 2022 18:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment