December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: pcuif_proto: use define constant to specify nax number of trx

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30585 ) Change subject: pcuif_proto: use define constant to specify nax number of trx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2b12fd562ff867188a37e701bba1ad5de904f9bd Gerrit-Change-Number: 30585 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Dec 2022 15:57:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bts[master]: pcuif_proto: use define constant to specify nax number of trx

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30587 ) Change subject: pcuif_proto: use define constant to specify nax number of trx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5fdd5b9e59865fabd0340650ecb347d52208ebe9 Gerrit-Change-Number: 30587 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Dec 2022 15:56:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: pcuif_proto: use define constant to specify nax number of trx

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30586 ) Change subject: pcuif_proto: use define constant to specify nax number of trx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I25a9233e7be2d7cda8eb45a4cb9dddd3511d03c9 Gerrit-Change-Number: 30586 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Dec 2022 15:56:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ms-trx support

by fixeria

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 22: (1 comment) Patchset: PS20: > make distcheck fails because of a problem in trxcon, my fault: […] Merged, update the submodule to https://cgit.osmocom.org/osmocom-bb/commit/?id=a6d2e1a12b0204f1b1690c423719…. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 22 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Dec 2022 15:55:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix a race condition in TC_chan_rel_conn_fail

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30591 ) Change subject: BSC_Tests: fix a race condition in TC_chan_rel_conn_fail ...................................................................... BSC_Tests: fix a race condition in TC_chan_rel_conn_fail Change-Id: Ic8ee641c19f47442538eaba2b120736bec793c70 Fixes: OS#5823 --- M bsc/BSC_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/30591/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 4753ae9..501b3e9 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1976,6 +1976,10 @@ dt := f_est_dchan('23'O, 23, '00010203040506'O); + /* Sending CONN FAIL IND immediately may trigger a race condition. + * Give the BSC some time to process a new SCCP connection (OS#5823). */ + f_sleep(0.2); + /* simulate CONN FAIL IND */ f_ipa_tx(ts_RSL_CONN_FAIL_IND(dt.rsl_chan_nr, RSL_ERR_RADIO_LINK_FAIL)); /* TODO: different cause values? */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic8ee641c19f47442538eaba2b120736bec793c70 Gerrit-Change-Number: 30591 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-msc[master]: libmsc: check return value of gsm0808_create_ass2()

by daniel

Attention is currently required from: neels, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30582 ) Change subject: libmsc: check return value of gsm0808_create_ass2() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6fd1669f2919034599d99336cf56f25a97afdf7c Gerrit-Change-Number: 30582 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Dec 2022 15:32:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bts[master]: abis: Add a timeout while waiting for connect()

by daniel

Attention is currently required from: pespin, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30588 ) Change subject: abis: Add a timeout while waiting for connect() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm a bit surprised with this approach? Why aren't we setting some sort of connect timeout at socket […] I'm all for it but couldn't find what timeout to set. It didn't sound like SO_SNDTIMEO was really designed wo work with connect according to https://stackoverflow.com/questions/21783599/socket-so-sndtimeo-timout-is-d… The other way that came to mind was add a timerfd that will abort the connect()? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b985d9ee472d5a39bc3da1dce1137ebabe93e85 Gerrit-Change-Number: 30588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Dec 2022 14:40:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci-on-slaves: don't run on ogt

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30590 ) Change subject: jobs/update-osmo-ci-on-slaves: don't run on ogt ...................................................................... jobs/update-osmo-ci-on-slaves: don't run on ogt Don't run this job on the osmo-gsm-tester machines. Right now this job takes quite some time to build various docker images which we don't even need on osmo-gsm-tester. It also uploads osmo-ci.git and osmo-gsm-manuals.git, which don't need to be updated on these if we don't run the osmo-gsm-tester jenkins jobs on them (see previous commit). Also I'm not sure if they really were needed there in the first place - we can look into this when we decide to fix the osmo-gsm-tester jobs. Related: OS#5811 Change-Id: I39d72740d896981f069ad339013c1e1e3d4f3bba --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/30590/1 diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 9174a6f..bc195b5 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -11,8 +11,6 @@ - build3-deb11build-ansible - gtp0-deb10fr - host2-deb11build-ansible - - osmo-gsm-tester-prod - - osmo-gsm-tester-rnd - rpi4-raspbian11build-ansible-1 - rpi4-raspbian11build-ansible-2 - rpi4-raspbian11build-ansible-3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I39d72740d896981f069ad339013c1e1e3d4f3bba Gerrit-Change-Number: 30590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/ogt: disable _run-prod, _run-rnd, _ttcn3

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30589 ) Change subject: jobs/ogt: disable _run-prod, _run-rnd, _ttcn3 ...................................................................... jobs/ogt: disable _run-prod, _run-rnd, _ttcn3 Disable these osmo-gsm-tester jobs, as they have been failing for a long time and we currently won't spend time on fixing them. Change-Id: I8db4fbe2c695e28eb9f7e738c5a848fb0071714a --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/30589/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 688da38..db0a491 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -111,6 +111,7 @@ - job-template: name: 'osmo-gsm-tester_run-{stage}' + disabled: true defaults: runner node: 'osmo-gsm-tester-{stage}' triggers: @@ -186,6 +187,7 @@ # ttcn3 job - job: name: 'osmo-gsm-tester_ttcn3' + disabled: true defaults: runner scm: - 'osmo-gsm-tester-repo' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8db4fbe2c695e28eb9f7e738c5a848fb0071714a Gerrit-Change-Number: 30589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: Get rid of tbf->first_ts

by pespin

Attention is currently required from: laforge, fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/30568 to look at the new patch set (#2). Change subject: Get rid of tbf->first_ts ...................................................................... Get rid of tbf->first_ts There's no big benefit in keeping it stored since it can be quickly found. This makes the tbf data structure simplier and easier to maintain, and discharges the alloc_algorithm functions from an extra step. Change-Id: I5d2f665f648f8637466bfdd3bf7b924cb61ede33 --- M src/bts.cpp M src/encoding.cpp M src/gprs_rlcmac_ts_alloc.cpp M src/pcu_vty_functions.cpp M src/tbf.cpp M src/tbf.h M src/tbf_ul.cpp 7 files changed, 47 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/68/30568/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5d2f665f648f8637466bfdd3bf7b924cb61ede33 Gerrit-Change-Number: 30568 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022