Attention is currently required from: fixeria, pespin.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 23:
(1 comment)
Patchset:
PS20:
> Looks like we both did this at the same time and submitted patches: […]
Where does it even get that old ref from? How does anything work?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 23
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Dec 2022 16:54:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 23:
(1 comment)
Patchset:
PS20:
> But somehow it still fails with the same error. […]
Looks like we both did this at the same time and submitted patches:
https://gerrit.osmocom.org/c/osmo-trx/+/30603https://gerrit.osmocom.org/c/osmo-trx/+/30604
and indeed, according to https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-trx-build/87/INSTR=--wi…, we're building old trxcon:
a4aac5c3554559c2c994609f90b92a9daf6e8a89 osmocom-bb (osmocon_v0.0.0-2798-ga4aac5c3)
It should be a6d2e1a12b0204f1b1690c42371980dd6895f076 instead.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 23
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Dec 2022 16:49:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30603 )
Change subject: contrib/jenkins.sh: dump submodule status before building
......................................................................
contrib/jenkins.sh: dump submodule status before building
Change-Id: I0f9d8f9213fd59605172fac011306c96c39bd5eb
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/03/30603/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 584de07..728aab8 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -101,6 +101,7 @@
set -x
cd "$base"
+git submodule status
autoreconf --install --force
./configure $CONFIG
$MAKE $PARALLEL_MAKE
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30603
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I0f9d8f9213fd59605172fac011306c96c39bd5eb
Gerrit-Change-Number: 30603
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30539 )
Change subject: WIP: vty: Add support for ny1 configuration
......................................................................
Patch Set 4:
(5 comments)
This change is ready for review.
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/9134ef70_55672145
PS1, Line 888: int ny1;
> It's a counter. We use osmo_tdef for counters too. See gsm_network_T_defs. […]
Done
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/fe0dcc6a_e18375a6
PS1, Line 2452: DEFUN_ATTR(cfg_net_ny1, cfg_net_ny1_cmd,
> This should be implemented using osmo_tdef, see "timer " just above.
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/1068cac8_34d453c1
PS1, Line 2469: static void net_init_ny1(int ntype, struct cmd_element *cmd, struct gsm_network *gsm_net)
> No need for this function.
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/2b15bb82_286cf211
PS1, Line 2472: gsm_net->ny1 = GSM_NY1_DEFAULT;
> If you didn't use osmo_tdef, this should be set in the "network" init/alloc function. […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/26cd0944_d9605c17
PS1, Line 2475: DEFUN(show_ny1, show_ny1_cmd,
> This may be not needed when you move to osmo_tdef.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30539
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6318cceb4ebdce50005e39e2e9323c1c8433250a
Gerrit-Change-Number: 30539
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Dec 2022 16:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 22:
(1 comment)
Patchset:
PS20:
> Already happened: https://gerrit.osmocom. […]
But somehow it still fails with the same error. I guess you need to revisit the submodule configuration. It might be still using the old trxcon (a4aac5c3554559c2c994609f90b92a9daf6e8a89). Try adding 'git submodule status' to contrib/jenkins.sh, so that we can see which commit it's actually building.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 22
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Dec 2022 16:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30590 )
Change subject: jobs/update-osmo-ci-on-slaves: don't run on ogt
......................................................................
jobs/update-osmo-ci-on-slaves: don't run on ogt
Don't run this job on the osmo-gsm-tester machines. Right now this job
takes quite some time to build various docker images which we don't even
need on osmo-gsm-tester. It also uploads osmo-ci.git and
osmo-gsm-manuals.git, which don't need to be updated on these if we
don't run the osmo-gsm-tester jenkins jobs on them (see previous
commit). According to Pau they would be needed for
osmo-gsm-tester_ttcn3.
Related: OS#5811
Change-Id: I39d72740d896981f069ad339013c1e1e3d4f3bba
---
M jobs/update-osmo-ci-on-slaves.yml
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml
index 9174a6f..bc195b5 100644
--- a/jobs/update-osmo-ci-on-slaves.yml
+++ b/jobs/update-osmo-ci-on-slaves.yml
@@ -11,8 +11,6 @@
- build3-deb11build-ansible
- gtp0-deb10fr
- host2-deb11build-ansible
- - osmo-gsm-tester-prod
- - osmo-gsm-tester-rnd
- rpi4-raspbian11build-ansible-1
- rpi4-raspbian11build-ansible-2
- rpi4-raspbian11build-ansible-3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30590
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I39d72740d896981f069ad339013c1e1e3d4f3bba
Gerrit-Change-Number: 30590
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged