November 2022 - gerrit-log - lists.osmocom.org

Change in simtrace2[master]: cosmetic: Fix compile-time #error message string typo

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30092 ) Change subject: cosmetic: Fix compile-time #error message string typo ...................................................................... cosmetic: Fix compile-time #error message string typo Change-Id: Ibf304751f8debe8567bed1614e62b60cf33ec092 --- M firmware/libcommon/source/mode_cardemu.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c index 7f52647..a05840e 100644 --- a/firmware/libcommon/source/mode_cardemu.c +++ b/firmware/libcommon/source/mode_cardemu.c @@ -437,7 +437,7 @@ #ifdef DETECT_VCC_BY_ADC #if !defined(VCC_UV_THRESH_1V8) || !defined(VCC_UV_THRESH_3V) -#error "You must define VCC_UV_THRESH_{1V1,3V} if you use ADC VCC detection" +#error "You must define VCC_UV_THRESH_{1V8,3V} if you use ADC VCC detection" #endif static volatile int adc_triggered = 0; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ibf304751f8debe8567bed1614e62b60cf33ec092 Gerrit-Change-Number: 30092 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: cosmetic: Fix compile-time #error message string typo

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30092 ) Change subject: cosmetic: Fix compile-time #error message string typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ibf304751f8debe8567bed1614e62b60cf33ec092 Gerrit-Change-Number: 30092 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:55:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: Fix missing generation of waiting-time-extension in some situations

by laforge

Attention is currently required from: Hoernchen, tsaitgaist. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30093 ) Change subject: Fix missing generation of waiting-time-extension in some situations ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ib4eb964c073192e8f067004625af818ba2caf003 Gerrit-Change-Number: 30093 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tsaitgaist <kredon(a)sysmocom.de> Gerrit-CC: jtavares <jtavares(a)kvh.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: tsaitgaist <kredon(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:48:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: Fix missing generation of waiting-time-extension in some situations

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/30093 ) Change subject: Fix missing generation of waiting-time-extension in some situations ...................................................................... Fix missing generation of waiting-time-extension in some situations In the function set_tpdu_state(), there is a missing transition to WAIT_TX state. This is fine if you are coming from the WAIT_PB state, which has already restarted the waiting timer via card_emu_uart_update_wt(), but if you are coming from the WAIT_RX state, then card_emu_uart_update_wt() is never called and the USART timer is never restarted. (Because the transmitter is left enabled in WAIT_RX, the response is still sent to the modem; it is just the half-wait timeouts that are missing). Change-Id: Ib4eb964c073192e8f067004625af818ba2caf003 --- M firmware/libcommon/source/card_emu.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/93/30093/1 diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index c85b08c..e6907e6 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -775,6 +775,15 @@ /* prepare to extend the waiting time once half of it is reached */ card_emu_uart_update_wt(ch->uart_chan, ch->waiting_time); break; + case TPDU_S_WAIT_TX: + /* If we came from WAIT_RX, disable the receiver and + * enable the transmitter. If we came from WAIT_RX or + * WAIT_PB, reset the waiting time so that we can extend + * waiting time if needed. */ + card_emu_uart_enable(ch->uart_chan, ENABLE_TX); + /* prepare to extend the waiting time once half of it is reached */ + card_emu_uart_update_wt(ch->uart_chan, ch->waiting_time); + break; default: break; } -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ib4eb964c073192e8f067004625af818ba2caf003 Gerrit-Change-Number: 30093 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: cosmetic: Fix compile-time #error message string typo

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/30092 ) Change subject: cosmetic: Fix compile-time #error message string typo ...................................................................... cosmetic: Fix compile-time #error message string typo Change-Id: Ibf304751f8debe8567bed1614e62b60cf33ec092 --- M firmware/libcommon/source/mode_cardemu.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/92/30092/1 diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c index 7f52647..a05840e 100644 --- a/firmware/libcommon/source/mode_cardemu.c +++ b/firmware/libcommon/source/mode_cardemu.c @@ -437,7 +437,7 @@ #ifdef DETECT_VCC_BY_ADC #if !defined(VCC_UV_THRESH_1V8) || !defined(VCC_UV_THRESH_3V) -#error "You must define VCC_UV_THRESH_{1V1,3V} if you use ADC VCC detection" +#error "You must define VCC_UV_THRESH_{1V8,3V} if you use ADC VCC detection" #endif static volatile int adc_triggered = 0; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ibf304751f8debe8567bed1614e62b60cf33ec092 Gerrit-Change-Number: 30092 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: update outdated vty copyright statement

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30090 ) Change subject: update outdated vty copyright statement ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia12a012c229f883286e96a90132adcc5e8c0c5da Gerrit-Change-Number: 30090 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:01:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: update very outdated vty copyright statement

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30091 ) Change subject: update very outdated vty copyright statement ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9bf6466a6b7f3347453a89ab754c372f6afa920d Gerrit-Change-Number: 30091 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:01:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: update horribly outdated copyright statement on VTY

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30089 ) Change subject: update horribly outdated copyright statement on VTY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I26cda7826e9d648ea086bb408293e431a9cac206 Gerrit-Change-Number: 30089 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:00:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: asn1: fix visibility warnings from generated code

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30081 ) Change subject: asn1: fix visibility warnings from generated code ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'm not sure we want to touch the asn files. If at all maybe adding some step to copy them and "sed" them or alike. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If84445ed2e0df604b581684dcf83f8520b7da84c Gerrit-Change-Number: 30081 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 20:59:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: hnbap_common: hnbap_cause_str: handle nothing val

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30087 ) Change subject: hnbap_common: hnbap_cause_str: handle nothing val ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Icab3052e27d1951129e3809e61357ee23c4cb588 Gerrit-Change-Number: 30087 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 20:57:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022