November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: cosmetic: s/trx_log_init()/trxcon_logging_init()/

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30096 ) Change subject: trxcon: cosmetic: s/trx_log_init()/trxcon_logging_init()/ ...................................................................... trxcon: cosmetic: s/trx_log_init()/trxcon_logging_init()/ Change-Id: I65ab1e6d3a3bea65aeb13ab286e33795ba57f1f3 Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/trxcon/logging.h M src/host/trxcon/src/logging.c M src/host/trxcon/src/trxcon_main.c 3 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/30096/1 diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/logging.h b/src/host/trxcon/include/osmocom/bb/trxcon/logging.h index 617e8f1..f8521a0 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/logging.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/logging.h @@ -12,4 +12,4 @@ DSCHD, }; -int trx_log_init(void *tall_ctx, const char *category_mask); +int trxcon_logging_init(void *tall_ctx, const char *category_mask); diff --git a/src/host/trxcon/src/logging.c b/src/host/trxcon/src/logging.c index 5c16ac5..747b1ad 100644 --- a/src/host/trxcon/src/logging.c +++ b/src/host/trxcon/src/logging.c @@ -23,7 +23,7 @@ #include <osmocom/bb/trxcon/logging.h> -static struct log_info_cat trx_log_info_cat[] = { +static struct log_info_cat trxcon_log_info_cat[] = { [DAPP] = { .name = "DAPP", .description = "Application", @@ -68,14 +68,14 @@ }, }; -static const struct log_info trx_log_info = { - .cat = trx_log_info_cat, - .num_cat = ARRAY_SIZE(trx_log_info_cat), +static const struct log_info trxcon_log_info = { + .cat = trxcon_log_info_cat, + .num_cat = ARRAY_SIZE(trxcon_log_info_cat), }; -int trx_log_init(void *tall_ctx, const char *category_mask) +int trxcon_logging_init(void *tall_ctx, const char *category_mask) { - osmo_init_logging2(tall_ctx, &trx_log_info); + osmo_init_logging2(tall_ctx, &trxcon_log_info); if (category_mask) log_parse_category_mask(osmo_stderr_target, category_mask); diff --git a/src/host/trxcon/src/trxcon_main.c b/src/host/trxcon/src/trxcon_main.c index 838bb6a..60e8d6d 100644 --- a/src/host/trxcon/src/trxcon_main.c +++ b/src/host/trxcon/src/trxcon_main.c @@ -560,7 +560,7 @@ osmo_init_ignore_signals(); /* Init logging system */ - trx_log_init(tall_trxcon_ctx, app_data.debug_mask); + trxcon_logging_init(tall_trxcon_ctx, app_data.debug_mask); l1sched_logging_init(DSCH, DSCHD); /* Configure pretty logging */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I65ab1e6d3a3bea65aeb13ab286e33795ba57f1f3 Gerrit-Change-Number: 30096 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: move l1sched_logging_init() from l1sched.h to logging.h

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30097 ) Change subject: trxcon: move l1sched_logging_init() from l1sched.h to logging.h ...................................................................... trxcon: move l1sched_logging_init() from l1sched.h to logging.h Change-Id: I43e21ca8a14445548e1d359bb6f8a3e36cb65bfa Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/include/osmocom/bb/l1sched/logging.h 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/97/30097/1 diff --git a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h index 3eadbbf..3dfafb3 100644 --- a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h +++ b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h @@ -389,7 +389,6 @@ enum gsm_phys_chan_config config, int tn); /* Scheduler management functions */ -void l1sched_logging_init(int log_cat_common, int log_cat_data); struct l1sched_state *l1sched_alloc(void *ctx, const struct l1sched_cfg *cfg, void *priv); void l1sched_reset(struct l1sched_state *sched, bool reset_clock); void l1sched_free(struct l1sched_state *sched); diff --git a/src/host/trxcon/include/osmocom/bb/l1sched/logging.h b/src/host/trxcon/include/osmocom/bb/l1sched/logging.h index d2b80e3..f88fe4c 100644 --- a/src/host/trxcon/include/osmocom/bb/l1sched/logging.h +++ b/src/host/trxcon/include/osmocom/bb/l1sched/logging.h @@ -3,6 +3,8 @@ extern int l1sched_log_cat_common; extern int l1sched_log_cat_data; +void l1sched_logging_init(int log_cat_common, int log_cat_data); + /* Messages using l1sched_state as the context */ #define LOGP_SCHED_CAT(sched, cat, level, fmt, args...) \ LOGP(l1sched_log_cat_##cat, level, "%s" fmt, \ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I43e21ca8a14445548e1d359bb6f8a3e36cb65bfa Gerrit-Change-Number: 30097 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: move trxcon_inst_{alloc,free}() to a separate file

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30098 ) Change subject: trxcon: move trxcon_inst_{alloc,free}() to a separate file ...................................................................... trxcon: move trxcon_inst_{alloc,free}() to a separate file Both functions are going to be part of the upcoming libtrxcon. Change-Id: I98963a1da927581597f7a170239dfb8a87cba842 Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/Makefile.am A src/host/trxcon/src/trxcon_inst.c M src/host/trxcon/src/trxcon_main.c 4 files changed, 83 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/98/30098/1 diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h index fbbd9e6..b8d3150 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h @@ -30,5 +30,5 @@ } l1p; }; -struct trxcon_inst *trxcon_inst_alloc(void *ctx, unsigned int id); +struct trxcon_inst *trxcon_inst_alloc(void *ctx, unsigned int id, uint32_t fn_advance); void trxcon_inst_free(struct trxcon_inst *trxcon); diff --git a/src/host/trxcon/src/Makefile.am b/src/host/trxcon/src/Makefile.am index 1ec4d76..e0dc337 100644 --- a/src/host/trxcon/src/Makefile.am +++ b/src/host/trxcon/src/Makefile.am @@ -43,6 +43,7 @@ trx_if.c \ logging.c \ trxcon_fsm.c \ + trxcon_inst.c \ trxcon_main.c \ $(NULL) diff --git a/src/host/trxcon/src/trxcon_inst.c b/src/host/trxcon/src/trxcon_inst.c new file mode 100644 index 0000000..c3a85da --- /dev/null +++ b/src/host/trxcon/src/trxcon_inst.c @@ -0,0 +1,70 @@ +/* + * OsmocomBB <-> SDR connection bridge + * + * (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * Author: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */ + +#include <stdint.h> + +#include <osmocom/core/fsm.h> +#include <osmocom/core/talloc.h> + +#include <osmocom/bb/trxcon/trxcon.h> +#include <osmocom/bb/trxcon/trxcon_fsm.h> +#include <osmocom/bb/l1sched/l1sched.h> + +struct trxcon_inst *trxcon_inst_alloc(void *ctx, unsigned int id, uint32_t fn_advance) +{ + struct trxcon_inst *trxcon; + struct osmo_fsm_inst *fi; + + fi = osmo_fsm_inst_alloc(&trxcon_fsm_def, ctx, NULL, LOGL_DEBUG, NULL); + OSMO_ASSERT(fi != NULL); + + trxcon = talloc_zero(fi, struct trxcon_inst); + OSMO_ASSERT(trxcon != NULL); + + fi->priv = trxcon; + trxcon->fi = fi; + + osmo_fsm_inst_update_id_f(fi, "%u", id); + trxcon->id = id; + + /* Logging context to be used by both l1ctl and l1sched modules */ + trxcon->log_prefix = talloc_asprintf(trxcon, "%s: ", osmo_fsm_inst_name(fi)); + + /* Init scheduler */ + const struct l1sched_cfg sched_cfg = { + .fn_advance = fn_advance, + .log_prefix = trxcon->log_prefix, + }; + + trxcon->sched = l1sched_alloc(trxcon, &sched_cfg, trxcon); + if (trxcon->sched == NULL) { + trxcon_inst_free(trxcon); + return NULL; + } + + return trxcon; +} + +void trxcon_inst_free(struct trxcon_inst *trxcon) +{ + if (trxcon == NULL || trxcon->fi == NULL) + return; + osmo_fsm_inst_term(trxcon->fi, OSMO_FSM_TERM_REQUEST, NULL); +} diff --git a/src/host/trxcon/src/trxcon_main.c b/src/host/trxcon/src/trxcon_main.c index 60e8d6d..6b0e1fb 100644 --- a/src/host/trxcon/src/trxcon_main.c +++ b/src/host/trxcon/src/trxcon_main.c @@ -336,25 +336,19 @@ return rc; } -struct trxcon_inst *trxcon_inst_alloc(void *ctx, unsigned int id) +static void l1ctl_conn_accept_cb(struct l1ctl_client *l1c) { struct trxcon_inst *trxcon; - struct osmo_fsm_inst *fi; - fi = osmo_fsm_inst_alloc(&trxcon_fsm_def, ctx, NULL, LOGL_DEBUG, NULL); - OSMO_ASSERT(fi != NULL); + trxcon = trxcon_inst_alloc(l1c, l1c->id, app_data.trx_fn_advance); + if (trxcon == NULL) { + l1ctl_client_conn_close(l1c); + return; + } - trxcon = talloc_zero(fi, struct trxcon_inst); - OSMO_ASSERT(trxcon != NULL); - - fi->priv = trxcon; - trxcon->fi = fi; - - osmo_fsm_inst_update_id_f(fi, "%u", id); - trxcon->id = id; - - /* Logging context to be used by both l1ctl and l1sched modules */ - trxcon->log_prefix = talloc_asprintf(trxcon, "%s: ", osmo_fsm_inst_name(fi)); + l1c->log_prefix = talloc_strdup(l1c, trxcon->log_prefix); + l1c->priv = trxcon->fi; + trxcon->l2if = l1c; const struct trx_if_params phyif_params = { .local_host = app_data.trx_bind_ip, @@ -370,45 +364,10 @@ /* Init transceiver interface */ trxcon->phyif = trx_if_open(&phyif_params); if (trxcon->phyif == NULL) { - trxcon_inst_free(trxcon); - return NULL; - } - - /* Init scheduler */ - const struct l1sched_cfg sched_cfg = { - .fn_advance = app_data.trx_fn_advance, - .log_prefix = trxcon->log_prefix, - }; - - trxcon->sched = l1sched_alloc(trxcon, &sched_cfg, trxcon); - if (trxcon->sched == NULL) { - trxcon_inst_free(trxcon); - return NULL; - } - - return trxcon; -} - -void trxcon_inst_free(struct trxcon_inst *trxcon) -{ - if (trxcon == NULL || trxcon->fi == NULL) - return; - osmo_fsm_inst_term(trxcon->fi, OSMO_FSM_TERM_REQUEST, NULL); -} - -static void l1ctl_conn_accept_cb(struct l1ctl_client *l1c) -{ - struct trxcon_inst *trxcon; - - trxcon = trxcon_inst_alloc(l1c, l1c->id); - if (trxcon == NULL) { - l1ctl_client_conn_close(l1c); + /* TRXCON_EV_PHYIF_FAILURE triggers l1ctl_client_conn_close() */ + osmo_fsm_inst_dispatch(trxcon->fi, TRXCON_EV_PHYIF_FAILURE, NULL); return; } - - l1c->log_prefix = talloc_strdup(l1c, trxcon->log_prefix); - l1c->priv = trxcon->fi; - trxcon->l2if = l1c; } static void l1ctl_conn_close_cb(struct l1ctl_client *l1c) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I98963a1da927581597f7a170239dfb8a87cba842 Gerrit-Change-Number: 30098 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: cosmetic: rename trxcon.c to trxcon_main.c

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30095 ) Change subject: trxcon: cosmetic: rename trxcon.c to trxcon_main.c ...................................................................... trxcon: cosmetic: rename trxcon.c to trxcon_main.c Change-Id: Idc5f4217dd31b5bdcb364600f7b97d1f60e1ab6f Related: OS#5599 --- M src/host/trxcon/src/Makefile.am R src/host/trxcon/src/trxcon_main.c 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/95/30095/1 diff --git a/src/host/trxcon/src/Makefile.am b/src/host/trxcon/src/Makefile.am index 3af004d..1ec4d76 100644 --- a/src/host/trxcon/src/Makefile.am +++ b/src/host/trxcon/src/Makefile.am @@ -43,7 +43,7 @@ trx_if.c \ logging.c \ trxcon_fsm.c \ - trxcon.c \ + trxcon_main.c \ $(NULL) trxcon_LDADD = \ diff --git a/src/host/trxcon/src/trxcon.c b/src/host/trxcon/src/trxcon_main.c similarity index 100% rename from src/host/trxcon/src/trxcon.c rename to src/host/trxcon/src/trxcon_main.c -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idc5f4217dd31b5bdcb364600f7b97d1f60e1ab6f Gerrit-Change-Number: 30095 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: asn1: fix visibility warnings from generated code

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30081 ) Change subject: asn1: fix visibility warnings from generated code ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm not sure we want to touch the asn files. […] The asn1 files were already modified quite a bit to make asn1c digest them at all. look at the git commit log of the asn1 subdirectory and you'll find commits like 355d9513c0359ec10de79cc12b6e8a2d4e81e8d8 "Rewrite to avoid information object classes". So there's no difference here, other than it's 'just' warnings. What I'm more worried about is that I don't have deep enough ASN.1 and various encoding rules knowledge if this kind of change really doesn't affect the binary encoding/decoding. Only encoding/decoding tests with a reasonably sized body of binary messages would make us notice that, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If84445ed2e0df604b581684dcf83f8520b7da84c Gerrit-Change-Number: 30081 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 22:00:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: move-asn1-header-files: error for wrong asn1c

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30080 ) Change subject: move-asn1-header-files: error for wrong asn1c ...................................................................... move-asn1-header-files: error for wrong asn1c Add a helpful error message if the user doesn't have the expected asn1c version installed. Link to a new wiki page that explains which branch one needs to build. Without this patch, it just complains that HNBAP_Criticality.h can't be moved. Change-Id: I11980bf868055bccc05c5338ea330b70022cd874 --- M move-asn1-header-files.sh 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/move-asn1-header-files.sh b/move-asn1-header-files.sh index ec94e24..7c996b2 100755 --- a/move-asn1-header-files.sh +++ b/move-asn1-header-files.sh @@ -12,6 +12,22 @@ include_subdir="$1" shift +# Abort if any of the header files are missing +for i in "$@"; do + if ! [ -e "$i" ]; then + echo + echo "ERROR: file '$i' has not been generated by asn1c!" + echo + echo "Are you using the Osmocom asn1c fork with the" \ + "ASN1C_PREFIX feature?" + echo + echo "More information:" + echo "https://osmocom.org/projects/osmohnbgw/wiki/Generate_sources_from_ASN1_files" + echo + exit 1 + fi +done + include_dir="$base_dir/include/$include_subdir" mkdir -p "$include_dir" echo "$PWD/*.h --> $include_dir" -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I11980bf868055bccc05c5338ea330b70022cd874 Gerrit-Change-Number: 30080 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: move-asn1-header-files: error for wrong asn1c

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30080 ) Change subject: move-asn1-header-files: error for wrong asn1c ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I11980bf868055bccc05c5338ea330b70022cd874 Gerrit-Change-Number: 30080 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:56:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: update very outdated vty copyright statement

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30091 ) Change subject: update very outdated vty copyright statement ...................................................................... update very outdated vty copyright statement Change-Id: I9bf6466a6b7f3347453a89ab754c372f6afa920d --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index c85f1c4..91db7be 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -614,7 +614,9 @@ .copyright = "Copyright (C) 2008-2018 Harald Welte, Holger Freyther\r\n" "Contributions by Daniel Willmann, Jan Lübbe, Stefan Schmidt\r\n" - "Dieter Spaar, Andreas Eversberg, Sylvain Munaut, Neels Hofmeyr\r\n\r\n" + "Dieter Spaar, Andreas Eversberg, Sylvain Munaut, Neels Hofmeyr\r\n" + "Copyright (C) 2013-2022 sysmocom - s.f.m.c. GmbH\r\n" + "\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" "This is free software: you are free to change and redistribute it.\r\n" "There is NO WARRANTY, to the extent permitted by law.\r\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9bf6466a6b7f3347453a89ab754c372f6afa920d Gerrit-Change-Number: 30091 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: update horribly outdated copyright statement on VTY

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30089 ) Change subject: update horribly outdated copyright statement on VTY ...................................................................... update horribly outdated copyright statement on VTY Change-Id: I26cda7826e9d648ea086bb408293e431a9cac206 --- M src/pcu_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/pcu_vty.c b/src/pcu_vty.c index 6b33e29..244a58a 100644 --- a/src/pcu_vty.c +++ b/src/pcu_vty.c @@ -1241,8 +1241,8 @@ } static const char pcu_copyright[] = - "Copyright (C) 2012 by Ivan Kluchnikov <kluchnikovi(a)gmail.com> and \r\n" - " Andreas Eversberg <jolly(a)eversberg.eu>\r\n" + "Copyright (C) 2012-2013 by Ivan Kluchnikov and Andreas Eversberg\r\n" + "Copyright (C) 2013-2022 by sysmocom - s.f.m.c. GmbH\r\n" "License GNU GPL version 2 or later\r\n" "This is free software: you are free to change and redistribute it.\r\n" "There is NO WARRANTY, to the extent permitted by law.\r\n"; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I26cda7826e9d648ea086bb408293e431a9cac206 Gerrit-Change-Number: 30089 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: update outdated vty copyright statement

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30090 ) Change subject: update outdated vty copyright statement ...................................................................... update outdated vty copyright statement Change-Id: Ia12a012c229f883286e96a90132adcc5e8c0c5da --- M src/common/vty.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/common/vty.c b/src/common/vty.c index 38448b1..a33d719 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -149,7 +149,8 @@ } static const char osmobts_copyright[] = - "Copyright (C) 2010, 2011 by Harald Welte, Andreas Eversberg and On-Waves\r\n" + "Copyright (C) 2010-2011 by Harald Welte, Andreas Eversberg and On-Waves\r\n" + "Copyright (C) 2011-2022 by sysmocom - s.f.m.c. GmbH\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" "This is free software: you are free to change and redistribute it.\r\n" "There is NO WARRANTY, to the extent permitted by law.\r\n"; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia12a012c229f883286e96a90132adcc5e8c0c5da Gerrit-Change-Number: 30090 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022