November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: update very outdated vty copyright statement

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30091 ) Change subject: update very outdated vty copyright statement ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9bf6466a6b7f3347453a89ab754c372f6afa920d Gerrit-Change-Number: 30091 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Nov 2022 18:59:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: update horribly outdated copyright statement on VTY

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30089 ) Change subject: update horribly outdated copyright statement on VTY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I26cda7826e9d648ea086bb408293e431a9cac206 Gerrit-Change-Number: 30089 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 11 Nov 2022 18:59:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: api doc: explain heartbeat handling in rx_msg_cb

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30046 ) Change subject: api doc: explain heartbeat handling in rx_msg_cb ...................................................................... api doc: explain heartbeat handling in rx_msg_cb Related: SYS#5599 Change-Id: I3849060d703494ea43773c0208203f1fc206067f --- M include/osmocom/pfcp/pfcp_endpoint.h 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/pfcp/pfcp_endpoint.h b/include/osmocom/pfcp/pfcp_endpoint.h index d0ed113..7158582 100644 --- a/include/osmocom/pfcp/pfcp_endpoint.h +++ b/include/osmocom/pfcp/pfcp_endpoint.h @@ -69,7 +69,10 @@ osmo_pfcp_endpoint_cb set_msg_ctx_cb; /* Callback to receive a single incoming PFCP message from a remote peer, already decoded. See also the doc for - * osmo_pfcp_endpoint_cb. */ + * osmo_pfcp_endpoint_cb. + * All incoming messages are passed to this callback, including Heartbeat Request and Heartbeat Response + * messages. However, responding to heartbeat is already done in osmo_pfcp_endpoint_handle_rx() before + * rx_msg_cb() is invoked: a callback implementation can safely ignore Heartbeat Request messages. */ osmo_pfcp_endpoint_cb rx_msg_cb; /* Custom timer definitions to use, if any. Relevant timers are: OSMO_PFCP_TIMER_N1, OSMO_PFCP_TIMER_T1, -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I3849060d703494ea43773c0208203f1fc206067f Gerrit-Change-Number: 30046 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: api doc: explain heartbeat handling in rx_msg_cb

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30046 ) Change subject: api doc: explain heartbeat handling in rx_msg_cb ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: good enough for a comment -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I3849060d703494ea43773c0208203f1fc206067f Gerrit-Change-Number: 30046 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 18:59:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: update very outdated vty copyright statement

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30091 ) Change subject: update very outdated vty copyright statement ...................................................................... update very outdated vty copyright statement Change-Id: I9bf6466a6b7f3347453a89ab754c372f6afa920d --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/30091/1 diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index dd8e696..22b423c 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -614,7 +614,9 @@ .copyright = "Copyright (C) 2008-2018 Harald Welte, Holger Freyther\r\n" "Contributions by Daniel Willmann, Jan Lübbe, Stefan Schmidt\r\n" - "Dieter Spaar, Andreas Eversberg, Sylvain Munaut, Neels Hofmeyr\r\n\r\n" + "Dieter Spaar, Andreas Eversberg, Sylvain Munaut, Neels Hofmeyr\r\n" + "Copyright (C) 2013-2022 sysmocom - s.f.m.c. GmbH\r\n" + "\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" "This is free software: you are free to change and redistribute it.\r\n" "There is NO WARRANTY, to the extent permitted by law.\r\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9bf6466a6b7f3347453a89ab754c372f6afa920d Gerrit-Change-Number: 30091 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: update outdated vty copyright statement

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/30090 ) Change subject: update outdated vty copyright statement ...................................................................... update outdated vty copyright statement Change-Id: Ia12a012c229f883286e96a90132adcc5e8c0c5da --- M src/common/vty.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/30090/1 diff --git a/src/common/vty.c b/src/common/vty.c index 38448b1..a33d719 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -149,7 +149,8 @@ } static const char osmobts_copyright[] = - "Copyright (C) 2010, 2011 by Harald Welte, Andreas Eversberg and On-Waves\r\n" + "Copyright (C) 2010-2011 by Harald Welte, Andreas Eversberg and On-Waves\r\n" + "Copyright (C) 2011-2022 by sysmocom - s.f.m.c. GmbH\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" "This is free software: you are free to change and redistribute it.\r\n" "There is NO WARRANTY, to the extent permitted by law.\r\n"; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia12a012c229f883286e96a90132adcc5e8c0c5da Gerrit-Change-Number: 30090 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: update horribly outdated copyright statement on VTY

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30089 ) Change subject: update horribly outdated copyright statement on VTY ...................................................................... update horribly outdated copyright statement on VTY Change-Id: I26cda7826e9d648ea086bb408293e431a9cac206 --- M src/pcu_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/89/30089/1 diff --git a/src/pcu_vty.c b/src/pcu_vty.c index 6b33e29..244a58a 100644 --- a/src/pcu_vty.c +++ b/src/pcu_vty.c @@ -1241,8 +1241,8 @@ } static const char pcu_copyright[] = - "Copyright (C) 2012 by Ivan Kluchnikov <kluchnikovi(a)gmail.com> and \r\n" - " Andreas Eversberg <jolly(a)eversberg.eu>\r\n" + "Copyright (C) 2012-2013 by Ivan Kluchnikov and Andreas Eversberg\r\n" + "Copyright (C) 2013-2022 by sysmocom - s.f.m.c. GmbH\r\n" "License GNU GPL version 2 or later\r\n" "This is free software: you are free to change and redistribute it.\r\n" "There is NO WARRANTY, to the extent permitted by law.\r\n"; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I26cda7826e9d648ea086bb408293e431a9cac206 Gerrit-Change-Number: 30089 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: move-asn1-header-files: error for wrong asn1c

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-iuh/+/30080 ) Change subject: move-asn1-header-files: error for wrong asn1c ...................................................................... move-asn1-header-files: error for wrong asn1c Add a helpful error message if the user doesn't have the expected asn1c version installed. Link to a new wiki page that explains which branch one needs to build. Without this patch, it just complains that HNBAP_Criticality.h can't be moved. Change-Id: I11980bf868055bccc05c5338ea330b70022cd874 --- M move-asn1-header-files.sh 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/80/30080/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I11980bf868055bccc05c5338ea330b70022cd874 Gerrit-Change-Number: 30080 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: asn1tostruct: fix defines getting redefined

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30088 ) Change subject: asn1tostruct: fix defines getting redefined ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: this is a draft, the places where the defines get used still need to be adjusted. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I2ecae6789899952d1dc5691ab76907abeaa71c12 Gerrit-Change-Number: 30088 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 16:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-iuh[master]: hnbap_common: hnbap_cause_str: handle nothing val

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30087 ) Change subject: hnbap_common: hnbap_cause_str: handle nothing val ...................................................................... hnbap_common: hnbap_cause_str: handle nothing val Fix for: ../../../src/osmo-iuh/src/hnbap_common.c:85:9: error: enumeration value ‘HNBAP_Cause_PR_NOTHING’ not handled in switch [-Werror=switch] Change-Id: Icab3052e27d1951129e3809e61357ee23c4cb588 --- M src/hnbap_common.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/87/30087/1 diff --git a/src/hnbap_common.c b/src/hnbap_common.c index be7d570..67cc30c 100644 --- a/src/hnbap_common.c +++ b/src/hnbap_common.c @@ -103,6 +103,9 @@ get_value_string(hnbap_cause_misc_vals, cause->choice.misc)); break; + case HNBAP_Cause_PR_NOTHING: + snprintf(buf, sizeof(buf), "NOTHING"); + break; } return buf; } -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Icab3052e27d1951129e3809e61357ee23c4cb588 Gerrit-Change-Number: 30087 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022