November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-trx[master]: Add realtime scheduling and set priority in service file

by msuraev

Attention is currently required from: laforge, pespin, fixeria, msuraev. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30042 to look at the new patch set (#4). Change subject: Add realtime scheduling and set priority in service file ...................................................................... Add realtime scheduling and set priority in service file This sets highest realtime priority among all Osmocom services. Related: OS#5687 Change-Id: Id74acf201d4388493f0eeb38909641c662551164 --- M contrib/systemd/osmo-trx-ipc.service M contrib/systemd/osmo-trx-lms.service M contrib/systemd/osmo-trx-uhd.service M contrib/systemd/osmo-trx-usrp1.service 4 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/42/30042/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30042 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id74acf201d4388493f0eeb38909641c662551164 Gerrit-Change-Number: 30042 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-trx[master]: Add realtime scheduling and set priority in service file

by msuraev

Attention is currently required from: laforge, pespin, fixeria, msuraev. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30042 to look at the new patch set (#3). Change subject: Add realtime scheduling and set priority in service file ...................................................................... Add realtime scheduling and set priority in service file This sets highest realtime priority among all Osmocom services. Related: OS#5687 Change-Id: Id74acf201d4388493f0eeb38909641c662551164 --- M contrib/systemd/osmo-trx-ipc.service M contrib/systemd/osmo-trx-lms.service M contrib/systemd/osmo-trx-uhd.service M contrib/systemd/osmo-trx-usrp1.service 4 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/42/30042/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30042 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id74acf201d4388493f0eeb38909641c662551164 Gerrit-Change-Number: 30042 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by lynxis lazus

Attention is currently required from: neels, fixeria, pespin, lynxis lazus. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 to look at the new patch set (#16). Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Add BTS setup ramping to prevent BSC overloading Prevent BSC overloading in the event of too many BTS try to connect. E.g. a network outage between the BSC and BTS. The BSC will accept incoming OML connection, but will delay sending any BSC originated messages. Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/bts.h A include/osmocom/bsc/bts_setup_ramp.h M include/osmocom/bsc/gsm_data.h M include/osmocom/bsc/nm_common_fsm.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c A src/osmo-bsc/bts_setup_ramp.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/net_init.c M src/osmo-bsc/nm_bb_transc_fsm.c M src/osmo-bsc/nm_bts_fsm.c M src/osmo-bsc/nm_bts_sm_fsm.c M src/osmo-bsc/nm_channel_fsm.c M src/osmo-bsc/nm_common_fsm.c M src/osmo-bsc/nm_gprs_cell_fsm.c M src/osmo-bsc/nm_gprs_nse_fsm.c M src/osmo-bsc/nm_gprs_nsvc_fsm.c M src/osmo-bsc/nm_rcarrier_fsm.c M src/osmo-bsc/osmo_bsc_main.c M tests/osmo-bsc.vty 23 files changed, 603 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/29788/16 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by laforge

Attention is currently required from: neels, fixeria, pespin, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 15: (4 comments) File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/e7235419_98adc791 PS4, Line 98: && net->bts_setup_ramp.step_size > 0 > Not addressed. Ack https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/1b8ffa98_c313ee44 PS4, Line 101: net->bts_setup_ramp.active > The point is to use the API here so that if you/anyone changes the API implementtion you don't need […] Ack https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/0c6aa072_4c9dd25d PS4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list); > Comment was not added. The Linux kernel llist API has always worked in the way that you cannot llist_del() a llist_entry that was never added to a list via llist_add(). I don't really see why this is suddently becoming a problem. It's simply not safe. Just like you cannot unlock a pthread mutex that was never initialized, or whatever other API or interface you can come up with where you cannot undo something you never did in the first place. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/2b5d26c5_77307955 PS15, Line 74: net->bts_setup_ramp.count >= net->bts_setup_ramp.step_size) > This line needs to be aligned to the opening brace, otherwise it looks like the block's body. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Nov 2022 11:01:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-sccp[master]: tests: fix old-style function definition

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/30078 ) Change subject: tests: fix old-style function definition ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I wonder how this passed jenkins in https://gerrit.osmocom.org/c/libosmo-sccp/+/29989... […] -> https://gerrit.osmocom.org/c/libosmo-sccp/+/30079/1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/30078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iccc942f9f25fb091045d906eb8be658b54c58529 Gerrit-Change-Number: 30078 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 11 Nov 2022 09:19:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-sccp[master]: contrib/jenkins.sh: add missing 'make check'

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/30079 ) Change subject: contrib/jenkins.sh: add missing 'make check' ...................................................................... contrib/jenkins.sh: add missing 'make check' Change-Id: I09b7e2223d19c9e055ecddf3b2690cdea26b9be7 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/79/30079/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 78bd53a..db92357 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -50,6 +50,7 @@ autoreconf --install --force ./configure --enable-sanitize --enable-werror --enable-external-tests $CONFIG $MAKE $PARALLEL_MAKE +$MAKE $PARALLEL_MAKE check || cat-testlogs.sh DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/30079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I09b7e2223d19c9e055ecddf3b2690cdea26b9be7 Gerrit-Change-Number: 30079 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmo-sccp[master]: tests: fix old-style function definition

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/30078 ) Change subject: tests: fix old-style function definition ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I wonder how this passed jenkins in https://gerrit.osmocom.org/c/libosmo-sccp/+/29989... but I don't see it currently. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/30078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iccc942f9f25fb091045d906eb8be658b54c58529 Gerrit-Change-Number: 30078 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 09:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-sccp[master]: tests: fix old-style function definition

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/30078 ) Change subject: tests: fix old-style function definition ...................................................................... tests: fix old-style function definition Fix for: xua_test.c:575:6: error: old-style function definition [-Werror=old-style-definition] Change-Id: Iccc942f9f25fb091045d906eb8be658b54c58529 --- M tests/vty/ss7_asp_vty_test.c M tests/xua/xua_test.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/78/30078/1 diff --git a/tests/vty/ss7_asp_vty_test.c b/tests/vty/ss7_asp_vty_test.c index 4ee0f7f..80ce3ec 100644 --- a/tests/vty/ss7_asp_vty_test.c +++ b/tests/vty/ss7_asp_vty_test.c @@ -41,7 +41,7 @@ const struct log_info log_info = { }; -static void print_help() +static void print_help(void) { printf( "options:\n" " -h --help this text\n" diff --git a/tests/xua/xua_test.c b/tests/xua/xua_test.c index abf2fae..6b4eef5 100644 --- a/tests/xua/xua_test.c +++ b/tests/xua/xua_test.c @@ -572,7 +572,7 @@ talloc_free(xua); } -void test_sccp_addr_cmp() +static void test_sccp_addr_cmp(void) { int ai; int bi; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/30078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iccc942f9f25fb091045d906eb8be658b54c58529 Gerrit-Change-Number: 30078 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-hnodeb[master]: configure: don't turn some warnings into errors

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Looks like we should abandon this one because Ie30d8024ee2ad48073dd8be2e02856b6ce1a6b0b has already been merged by Pau back in January 2022. Interestingly enough, Gerrit does not show "merge conflict" nor "conflicts with". -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I783035fcded73f9c3938c4110ccb84eddc36a274 Gerrit-Change-Number: 26213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 09:10:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-hnodeb[master]: configure: don't turn some warnings into errors

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Abandoned has been merged as https://gerrit.osmocom.org/c/osmo-hnodeb/+/26884 apparently -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I783035fcded73f9c3938c4110ccb84eddc36a274 Gerrit-Change-Number: 26213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022