Attention is currently required from: neels.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/30230
to look at the new patch set (#2).
Change subject: VTY: rename 'nft' to 'tunmap'
......................................................................
VTY: rename 'nft' to 'tunmap'
So far the config nodes were named after the implementation:
"GTP kernel module" = "gtp" and
"netfilter" = "nft"
We found that this is confusing, since both are related to handling GTP.
Rename "nft" to "tunmap"; a previous patch already renamed "gtp" to
"tunend".
Keep a hidden "nft" VTY cmd as backwards compat alias.
Related: SYS#6192
Change-Id: Ia3c5224dd3b5f5c9437bbdec997d02176818cc97
---
M contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
M contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
M doc/examples/osmo-upf/osmo-upf-mockup.cfg
M src/osmo-upf/up_gtp_action.c
M src/osmo-upf/upf_nft.c
M src/osmo-upf/upf_vty.c
M tests/upf.vty
7 files changed, 41 insertions(+), 28 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/30/30230/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30230
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ia3c5224dd3b5f5c9437bbdec997d02176818cc97
Gerrit-Change-Number: 30230
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/30229
to look at the new patch set (#2).
Change subject: VTY: rename 'gtp' to 'tunend'
......................................................................
VTY: rename 'gtp' to 'tunend'
So far the config nodes were named after the implementation:
"GTP kernel module" = "gtp" and
"netfilter" = "nft"
We found that this is confusing, since both are related to handling GTP.
Rename "gtp" to "tunend"; a subsequent patch will rename "nft" to
"tunmap".
Keep a hidden "gtp" VTY cmd as backwards compat alias.
In log output, also print "tunend" instead of "endecaps"
(up_gtp_action_to_str_buf()).
Related: SYS#6192
Change-Id: I49ac7b1f8b5b74f586edfed1dfb29f9af55a521b
---
M contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
M contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
M doc/examples/osmo-upf/osmo-upf-create-dev.cfg
M doc/examples/osmo-upf/osmo-upf-mockup.cfg
M include/osmocom/upf/upf.h
M src/osmo-upf/up_gtp_action.c
M src/osmo-upf/upf.c
M src/osmo-upf/upf_gtp.c
M src/osmo-upf/upf_vty.c
M tests/upf.vty
10 files changed, 65 insertions(+), 57 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/29/30229/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30229
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I49ac7b1f8b5b74f586edfed1dfb29f9af55a521b
Gerrit-Change-Number: 30229
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30226 )
Change subject: Add explicit link check to osmo_stream_srv_create()
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
Patchset:
PS5:
I don't think this kind of APIs should be checking that the object is properly passed. If at all, put an OSMO_ASSERT there.
Checking for null pointer passed without asserting only makes sense in the free() function.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30226
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: If494eac5dcce6c5ae30e928b92e57067d5681a42
Gerrit-Change-Number: 30226
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Nov 2022 21:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30226 )
Change subject: Add explicit link check to osmo_stream_srv_create()
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30226
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: If494eac5dcce6c5ae30e928b92e57067d5681a42
Gerrit-Change-Number: 30226
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Nov 2022 21:30:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment