November 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: osmux: Introduce API osmux_xfrm_input_set_name()

by pespin

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 to look at the new patch set (#3). Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ...................................................................... osmux: Introduce API osmux_xfrm_input_set_name() This will be used internally by osmux code to print more meaningful lines. Related: SYS#6161 Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 --- M include/osmocom/netif/osmux.h M src/osmux_input.c M tests/osmux/osmux_test.c M tests/osmux/osmux_test.ok 4 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/10/30210/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Support recreating lost RTP packets at start of the batch

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/30197 to look at the new patch set (#4). Change subject: osmux: Support recreating lost RTP packets at start of the batch ...................................................................... osmux: Support recreating lost RTP packets at start of the batch Previously, if RTP jumps were detected in the incoming RTP stream and osmux state for that circuit was to start the next batch, the hole would not been filled during queueing time and instead the encoder would have set the M bit in the osmuxhdr to announce a sync point. For small holes (eg less than the batch factor) it makes sense to start filling the batch with crafted RTP packets in order to avoid the encoder later on setting the M bit and hence avoid the peer receiving the Osmux frame having to start a new syncrhonization point. Related: SYS#6161 Change-Id: I9596501adf5b7b91983618c92c7b1792ee9461a3 --- M src/osmux_input.c M tests/osmux/osmux_test.c M tests/osmux/osmux_test.ok 3 files changed, 626 insertions(+), 426 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/97/30197/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9596501adf5b7b91983618c92c7b1792ee9461a3 Gerrit-Change-Number: 30197 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Improve logging of osmux_xfrm_input

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/30211 to look at the new patch set (#3). Change subject: osmux: Improve logging of osmux_xfrm_input ...................................................................... osmux: Improve logging of osmux_xfrm_input This allows easily identifying and following state and lifecycle of CIDs when looking at logs. Related: SYS#6161 Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016 --- M src/osmux_input.c M tests/osmux/osmux_test.ok 2 files changed, 272 insertions(+), 232 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/11/30211/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016 Gerrit-Change-Number: 30211 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Split tbf_fsm as tbf_{ul,dl}_fsm

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30220 ) Change subject: Split tbf_fsm as tbf_{ul,dl}_fsm ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I879af3f4b3e330687d498cd59f5f4933d6ca56f0 Gerrit-Change-Number: 30220 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 18 Nov 2022 16:27:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Obey current batch_size restrictions when creating forged RTP ...

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30174 ) Change subject: osmux: Obey current batch_size restrictions when creating forged RTP packets to fill holes ...................................................................... Patch Set 3: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30174/comment/014c6c92_d7a7f432 PS3, Line 448: diff = cur_seq - last_seq; > Are there some restrictions on cur_seq and last_seq size? Otherwise if cur_seq == UINT16_MAX and las […] See comments in https://gerrit.osmocom.org/c/libosmo-netif/+/30148 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4ea435bfb2490a375ad3e5068ee926e48b53cf5c Gerrit-Change-Number: 30174 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 16:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Introduce API osmux_xfrm_input_set_name()

by msuraev

Attention is currently required from: osmith, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 ) Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ...................................................................... Patch Set 2: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/f86cb4e8_390ba57a PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); > Max: You are mixing stuff here. […] If there's some deployed software which is hard to update and modify than the issues which makes updates and modification harder should be resolved in that software using separate patch. I don't see what this has to do with libosmo-netif. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Obey current batch_size restrictions when creating forged RTP ...

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30174 ) Change subject: osmux: Obey current batch_size restrictions when creating forged RTP packets to fill holes ...................................................................... Patch Set 3: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30174/comment/3592aa48_82b84955 PS3, Line 448: diff = cur_seq - last_seq; Are there some restrictions on cur_seq and last_seq size? Otherwise if cur_seq == UINT16_MAX and last_seq == 1 for example than the diff won't fit into int16_t. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4ea435bfb2490a375ad3e5068ee926e48b53cf5c Gerrit-Change-Number: 30174 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:52:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30195 ) Change subject: osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I561fb836989d31f43a15b193ed9bec4103ea0f2b Gerrit-Change-Number: 30195 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:50:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Use better rationale when limiting amount of lost & forged RTP...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30194 ) Change subject: osmux: Use better rationale when limiting amount of lost & forged RTP incoming packets ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4ea700dbbf469498befc939a844324259bbe332a Gerrit-Change-Number: 30194 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:50:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30196 ) Change subject: osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts ...................................................................... Patch Set 3: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30196/comment/c09138df_fae8a92d PS3, Line 156: ((state->circuit->last_transmitted_rtp_seq + 1) & 0xffff) != rtp_seqnum; > Where does magic 0xffff comes from? sequence numbers are uint16_t in RTP. I'm just doing the wraparound there, since last_transmitted_rtp_seq is an int (in order to e able to mark it with -1 to indicate unset). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I05b1eae400cb60d1f4e927f853619d5ff470163f Gerrit-Change-Number: 30196 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:47:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022