November 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: osmux: Use better rationale when limiting amount of lost & forged RTP...

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30194 ) Change subject: osmux: Use better rationale when limiting amount of lost & forged RTP incoming packets ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4ea700dbbf469498befc939a844324259bbe332a Gerrit-Change-Number: 30194 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:46:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Introduce API osmux_xfrm_input_set_name()

by pespin

Attention is currently required from: osmith, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 ) Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ...................................................................... Patch Set 2: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/1157848b_ba86996f PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); > how about using a simple counter instead of using pointers? then we wouldn't need the sed replacemen […] Max: You are mixing stuff here. One thing is the deployed software which may be difficult to upgrade/modify, and the other is the libosmo-netif implementation in use. Since this seems to be causing rejection for this patch I can then simply totally drop the pointer and allocate an empty string, or do as osmith suggests, though I don't find it as useful for debuggin purposes as having an address pointer. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:45:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30196 ) Change subject: osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts ...................................................................... Patch Set 3: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30196/comment/961ab8f7_8218b8b9 PS3, Line 156: ((state->circuit->last_transmitted_rtp_seq + 1) & 0xffff) != rtp_seqnum; Where does magic 0xffff comes from? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I05b1eae400cb60d1f4e927f853619d5ff470163f Gerrit-Change-Number: 30196 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:45:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30195 ) Change subject: osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I561fb836989d31f43a15b193ed9bec4103ea0f2b Gerrit-Change-Number: 30195 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:41:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Support recreating lost RTP packets at start of the batch

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30197 ) Change subject: osmux: Support recreating lost RTP packets at start of the batch ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: typo in commit message: th M -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9596501adf5b7b91983618c92c7b1792ee9461a3 Gerrit-Change-Number: 30197 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:40:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: tests/osmux: Add extra asserts to validate osmux header is pulled cor...

by osmith

Attention is currently required from: pespin, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30222 ) Change subject: tests/osmux: Add extra asserts to validate osmux header is pulled correctly ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie2ccc22c53c33025c477236166ea97972c21ec3e Gerrit-Change-Number: 30222 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:38:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Improve logging of osmux_xfrm_input

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30211 ) Change subject: osmux: Improve logging of osmux_xfrm_input ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016 Gerrit-Change-Number: 30211 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: tbf_fsm: Move osmo_fsm_inst fi out of struct tbf_fsm_ctx

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30216 ) Change subject: tbf_fsm: Move osmo_fsm_inst fi out of struct tbf_fsm_ctx ...................................................................... Patch Set 2: (1 comment) File src/tbf.h: https://gerrit.osmocom.org/c/osmo-pcu/+/30216/comment/fcf20b82_5d57f633 PS1, Line 260: state_fi > But this is one is the main tbf_fsm, right? Both ul_ass_fsm and dl_ass_fsm are supplementary ones, A […] It's not the "main" tbf, it's the "state" tbf as its name indicates. I can rename "state_fsm" as "state_fsm_ctx" if you want, in a separate follow-up commit. Why allocating the context dynamically if it can be allocated as part of the tbf struct? there's no need for that. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I03e691ccf6a94431caa55653349158f5b85db017 Gerrit-Change-Number: 30216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:36:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Introduce API osmux_xfrm_input_set_name()

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 ) Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ...................................................................... Patch Set 2: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/232d0e96_d17fe216 PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); > To identify the different links by default without the user having to add a name (hence being able t […] how about using a simple counter instead of using pointers? then we wouldn't need the sed replacement -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:36:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Introduce API osmux_xfrm_input_set_name()

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 ) Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ...................................................................... Patch Set 2: (2 comments) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/4735816d_38cd765d PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); > To identify the different links by default without the user having to add a name (hence being able t […] That seems backwards to me. If old users want to identify links they could simply switch to using new API. And if they don't than it's pointless to carry workarounds to cater to that use-case. File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/6e1f9050_fec02f63 PS2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output: > Yeah, backward compatibility is though ;) This is not the case though - backward compatibility is when we keep old behavior for old API while adding new API. If we change behavior of old API to try to emulate the use of new API to the point that we have to rely on workarounds to keep unit tests from failing - it only adds unnecessary confusion. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:34:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022