October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: rcv_resource_request(): Update meas before allocating and assigning n...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29912 ) Change subject: rcv_resource_request(): Update meas before allocating and assigning new UL TBF ...................................................................... rcv_resource_request(): Update meas before allocating and assigning new UL TBF Those power params are applied in the Pkt Ul Ass sent to the MS. In practice it doesn't matter much because the Pkt Ul Ass message is created later asynchronously by the scheduler (event CREATE_RLCMAC_MSG). Still it's much cleaner applying the information before allocating the UL-TBF, since that's an extra independent step. Change-Id: I63133aa42dcf27a86437b1bc8dc83c30d6718028 --- M src/pdch.cpp M tests/tbf/TbfTest.err 2 files changed, 20 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/12/29912/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index 46df0d5..a40f501 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -753,6 +753,10 @@ ms_set_egprs_ms_class(ms, egprs_ms_class); } + /* get measurements */ + get_meas(meas, request); + ms_update_l1_meas(ms, meas); + ul_tbf = tbf_alloc_ul_pacch(bts, ms, trx_no()); if (!ul_tbf) { handle_tbf_reject(bts, ms, trx_no(), ts_no); @@ -772,10 +776,6 @@ ul_tbf->control_ts = ts_no; /* schedule uplink assignment */ osmo_fsm_inst_dispatch(ul_tbf->ul_ass_fsm.fi, TBF_UL_ASS_EV_SCHED_ASS, NULL); - - /* get measurements */ - get_meas(meas, request); - ms_update_l1_meas(ul_tbf->ms(), meas); return_unref: ms_unref(ms); return; diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index c12bd3c..564cafd 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -2346,6 +2346,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 Modifying MS object, TLLI = 0xf1223344, MS class 0 -> 1 +MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: CS-1 -> CS-2 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0,) ********** UL-TBF starts here ********** MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0,) Allocating UL TBF TBF{NEW}: Allocated @@ -2372,7 +2373,6 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: CS-1 -> CS-2 UL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654270 + 13 = 2654283 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) start Packet Uplink Assignment (PACCH) @@ -2523,6 +2523,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 Modifying MS object, TLLI = 0xf1223344, MS class 0 -> 1 +MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: CS-1 -> CS-2 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0,) ********** UL-TBF starts here ********** MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0,) Allocating UL TBF TBF{NEW}: Allocated @@ -2549,7 +2550,6 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: CS-1 -> CS-2 UL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654270 + 13 = 2654283 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) start Packet Uplink Assignment (PACCH) @@ -2698,6 +2698,7 @@ PDCH(bts=0,trx=0,ts=7) FN=2654270 PKT RESOURCE REQ: MS requests UL TBF throguh SBA Modifying MS object, TLLI = 0xf1223344, TA 220 -> 7 Modifying MS object, TLLI = 0xf1223344, MS class 0 -> 1 +MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: CS-1 -> CS-2 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0,) ********** UL-TBF starts here ********** MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0,) Allocating UL TBF TBF{NEW}: Allocated @@ -2724,7 +2725,6 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -MS(TLLI=0xf1223344, IMSI=, TA=7, 1/0, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: CS-1 -> CS-2 UL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654270 + 13 = 2654283 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN) start Packet Uplink Assignment (PACCH) @@ -3888,6 +3888,7 @@ Modifying MS object, TLLI = 0xf1223344, MS class 0 -> 1 Modifying MS object, TLLI = 0xf1223344, EGPRS MS class 0 -> 1 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) ********** UL-TBF starts here ********** MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Allocating UL TBF TBF{NEW}: Allocated @@ -3916,7 +3917,6 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 UL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654270 + 13 = 2654283 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) start Packet Uplink Assignment (PACCH) @@ -3999,6 +3999,7 @@ Modifying MS object, TLLI = 0xf1223344, MS class 0 -> 1 Modifying MS object, TLLI = 0xf1223344, EGPRS MS class 0 -> 1 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) ********** UL-TBF starts here ********** MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Allocating UL TBF TBF{NEW}: Allocated @@ -4027,7 +4028,6 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 UL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654270 + 13 = 2654283 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) start Packet Uplink Assignment (PACCH) @@ -6950,6 +6950,7 @@ Modifying MS object, TLLI = 0xf1223344, MS class 0 -> 1 Modifying MS object, TLLI = 0xf1223344, EGPRS MS class 0 -> 1 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) ********** UL-TBF starts here ********** MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Allocating UL TBF TBF{NEW}: Allocated @@ -6978,7 +6979,6 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 UL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654270 + 13 = 2654283 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) start Packet Uplink Assignment (PACCH) @@ -7147,6 +7147,7 @@ Modifying MS object, TLLI = 0xf1223344, MS class 0 -> 1 Modifying MS object, TLLI = 0xf1223344, EGPRS MS class 0 -> 1 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) ********** UL-TBF starts here ********** MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Allocating UL TBF TBF{NEW}: Allocated @@ -7175,7 +7176,6 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 UL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654270 + 13 = 2654283 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) start Packet Uplink Assignment (PACCH) @@ -7572,6 +7572,7 @@ Modifying MS object, TLLI = 0xf1223344, MS class 0 -> 1 Modifying MS object, TLLI = 0xf1223344, EGPRS MS class 0 -> 1 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) ********** UL-TBF starts here ********** MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1,) Allocating UL TBF TBF{NEW}: Allocated @@ -7600,7 +7601,6 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -MS(TLLI=0xf1223344, IMSI=, TA=7, 1/1, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 UL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654270 + 13 = 2654283 TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=ASSIGN EGPRS) start Packet Uplink Assignment (PACCH) @@ -8913,6 +8913,7 @@ Modifying MS object, TLLI = 0xffeeddcc, MS class 0 -> 11 Modifying MS object, TLLI = 0xffeeddcc, EGPRS MS class 0 -> 11 MS(TLLI=0xffeeddcc, IMSI=, TA=7, 11/11,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xffeeddcc, IMSI=, TA=7, 11/11,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xffeeddcc, IMSI=, TA=7, 11/11,) ********** UL-TBF starts here ********** MS(TLLI=0xffeeddcc, IMSI=, TA=7, 11/11,) Allocating UL TBF TBF{NEW}: Allocated @@ -8941,7 +8942,6 @@ TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -MS(TLLI=0xffeeddcc, IMSI=, TA=7, 11/11, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 UL_ASS_TBF(UL-TFI_0){SEND_ASS}: Received Event CREATE_RLCMAC_MSG PDCH(bts=0,trx=0,ts=7) POLL scheduled at FN 2654218 + 13 = 2654231 TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN EGPRS) start Packet Uplink Assignment (PACCH) @@ -8959,6 +8959,7 @@ Modifying MS object, TLLI = 0xffeeddcd, MS class 0 -> 11 Modifying MS object, TLLI = 0xffeeddcd, EGPRS MS class 0 -> 11 MS(TLLI=0xffeeddcd, IMSI=, TA=7, 11/11,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xffeeddcd, IMSI=, TA=7, 11/11,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xffeeddcd, IMSI=, TA=7, 11/11,) ********** UL-TBF starts here ********** MS(TLLI=0xffeeddcd, IMSI=, TA=7, 11/11,) Allocating UL TBF TBF{NEW}: Allocated @@ -8987,7 +8988,6 @@ TBF(TFI=1 TLLI=0xffeeddcd DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_1){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_1){NONE}: state_chg to SEND_ASS -MS(TLLI=0xffeeddcd, IMSI=, TA=7, 11/11, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 PDCH(bts=0,trx=0,ts=7) Expiring FN=56 but previous FN=2654231 is still reserved! PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN EGPRS) TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=ASSIGN EGPRS) poll timeout for FN=2654231, TS=7 (curr FN 56) @@ -9012,6 +9012,7 @@ Modifying MS object, TLLI = 0xffeeddce, MS class 0 -> 11 Modifying MS object, TLLI = 0xffeeddce, EGPRS MS class 0 -> 11 MS(TLLI=0xffeeddce, IMSI=, TA=7, 11/11,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xffeeddce, IMSI=, TA=7, 11/11,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xffeeddce, IMSI=, TA=7, 11/11,) ********** UL-TBF starts here ********** MS(TLLI=0xffeeddce, IMSI=, TA=7, 11/11,) Allocating UL TBF TBF{NEW}: Allocated @@ -9040,7 +9041,6 @@ TBF(TFI=2 TLLI=0xffeeddce DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_2){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_2){NONE}: state_chg to SEND_ASS -MS(TLLI=0xffeeddce, IMSI=, TA=7, 11/11, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 PDCH(bts=0,trx=0,ts=7) Expiring FN=60 but previous FN=2654231 is still reserved! PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(TFI=1 TLLI=0xffeeddcd DIR=UL STATE=ASSIGN EGPRS) TBF(TFI=1 TLLI=0xffeeddcd DIR=UL STATE=ASSIGN EGPRS) poll timeout for FN=2654231, TS=7 (curr FN 60) @@ -9065,6 +9065,7 @@ Modifying MS object, TLLI = 0xffeeddcf, MS class 0 -> 11 Modifying MS object, TLLI = 0xffeeddcf, EGPRS MS class 0 -> 11 MS(TLLI=0xffeeddcf, IMSI=, TA=7, 11/11,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xffeeddcf, IMSI=, TA=7, 11/11,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xffeeddcf, IMSI=, TA=7, 11/11,) ********** UL-TBF starts here ********** MS(TLLI=0xffeeddcf, IMSI=, TA=7, 11/11,) Allocating UL TBF TBF{NEW}: Allocated @@ -9093,7 +9094,6 @@ TBF(TFI=3 TLLI=0xffeeddcf DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_3){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_3){NONE}: state_chg to SEND_ASS -MS(TLLI=0xffeeddcf, IMSI=, TA=7, 11/11, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 PDCH(bts=0,trx=0,ts=7) Expiring FN=65 but previous FN=2654231 is still reserved! PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(TFI=2 TLLI=0xffeeddce DIR=UL STATE=ASSIGN EGPRS) TBF(TFI=2 TLLI=0xffeeddce DIR=UL STATE=ASSIGN EGPRS) poll timeout for FN=2654231, TS=7 (curr FN 65) @@ -9118,6 +9118,7 @@ Modifying MS object, TLLI = 0xffeeddd0, MS class 0 -> 11 Modifying MS object, TLLI = 0xffeeddd0, EGPRS MS class 0 -> 11 MS(TLLI=0xffeeddd0, IMSI=, TA=7, 11/11,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xffeeddd0, IMSI=, TA=7, 11/11,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xffeeddd0, IMSI=, TA=7, 11/11,) ********** UL-TBF starts here ********** MS(TLLI=0xffeeddd0, IMSI=, TA=7, 11/11,) Allocating UL TBF TBF{NEW}: Allocated @@ -9146,7 +9147,6 @@ TBF(TFI=4 TLLI=0xffeeddd0 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_4){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_4){NONE}: state_chg to SEND_ASS -MS(TLLI=0xffeeddd0, IMSI=, TA=7, 11/11, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 PDCH(bts=0,trx=0,ts=7) Expiring FN=69 but previous FN=2654231 is still reserved! PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(TFI=3 TLLI=0xffeeddcf DIR=UL STATE=ASSIGN EGPRS) TBF(TFI=3 TLLI=0xffeeddcf DIR=UL STATE=ASSIGN EGPRS) poll timeout for FN=2654231, TS=7 (curr FN 69) @@ -9171,6 +9171,7 @@ Modifying MS object, TLLI = 0xffeeddd1, MS class 0 -> 11 Modifying MS object, TLLI = 0xffeeddd1, EGPRS MS class 0 -> 11 MS(TLLI=0xffeeddd1, IMSI=, TA=7, 11/11,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xffeeddd1, IMSI=, TA=7, 11/11,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xffeeddd1, IMSI=, TA=7, 11/11,) ********** UL-TBF starts here ********** MS(TLLI=0xffeeddd1, IMSI=, TA=7, 11/11,) Allocating UL TBF TBF{NEW}: Allocated @@ -9199,7 +9200,6 @@ TBF(TFI=5 TLLI=0xffeeddd1 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_5){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_5){NONE}: state_chg to SEND_ASS -MS(TLLI=0xffeeddd1, IMSI=, TA=7, 11/11, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 PDCH(bts=0,trx=0,ts=7) Expiring FN=73 but previous FN=2654231 is still reserved! PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(TFI=4 TLLI=0xffeeddd0 DIR=UL STATE=ASSIGN EGPRS) TBF(TFI=4 TLLI=0xffeeddd0 DIR=UL STATE=ASSIGN EGPRS) poll timeout for FN=2654231, TS=7 (curr FN 73) @@ -9224,6 +9224,7 @@ Modifying MS object, TLLI = 0xffeeddd2, MS class 0 -> 11 Modifying MS object, TLLI = 0xffeeddd2, EGPRS MS class 0 -> 11 MS(TLLI=0xffeeddd2, IMSI=, TA=7, 11/11,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xffeeddd2, IMSI=, TA=7, 11/11,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xffeeddd2, IMSI=, TA=7, 11/11,) ********** UL-TBF starts here ********** MS(TLLI=0xffeeddd2, IMSI=, TA=7, 11/11,) Allocating UL TBF TBF{NEW}: Allocated @@ -9252,7 +9253,6 @@ TBF(TFI=6 TLLI=0xffeeddd2 DIR=UL STATE=ASSIGN EGPRS) change control TS 7 -> 7 until assignment is complete. UL_ASS_TBF(UL-TFI_6){NONE}: Received Event SCHED_ASS UL_ASS_TBF(UL-TFI_6){NONE}: state_chg to SEND_ASS -MS(TLLI=0xffeeddd2, IMSI=, TA=7, 11/11, UL) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 PDCH(bts=0,trx=0,ts=7) Expiring FN=78 but previous FN=2654231 is still reserved! PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(TFI=5 TLLI=0xffeeddd1 DIR=UL STATE=ASSIGN EGPRS) TBF(TFI=5 TLLI=0xffeeddd1 DIR=UL STATE=ASSIGN EGPRS) poll timeout for FN=2654231, TS=7 (curr FN 78) @@ -9277,6 +9277,7 @@ Modifying MS object, TLLI = 0xffeeddd3, MS class 0 -> 11 Modifying MS object, TLLI = 0xffeeddd3, EGPRS MS class 0 -> 11 MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Enabled EGPRS, mode EGPRS +MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Link quality 12dB (old 12dB) left window [-256, 6], modifying uplink CS level: MCS-1 -> MCS-2 MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) ********** UL-TBF starts here ********** MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Allocating UL TBF TBF{NEW}: Allocated -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I63133aa42dcf27a86437b1bc8dc83c30d6718028 Gerrit-Change-Number: 29912 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: pcuif_proto: cosmetic: add constant PCU_IF_NUM_NSVC and replace magic...

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29901 ) Change subject: pcuif_proto: cosmetic: add constant PCU_IF_NUM_NSVC and replace magic numbers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic94dadd3374c6db9323baca83b6b07b89e96768c Gerrit-Change-Number: 29901 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 14:05:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: be more clear about vendor specif RSL extension

by osmith

Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29888 ) Change subject: abis_rsl: be more clear about vendor specif RSL extension ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id27662e208ca8ac0a48851583c11fbacf85f988c Gerrit-Change-Number: 29888 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 14:05:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmux: Fix null ptr dereference sending UL data before the remote is ...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29908 ) Change subject: osmux: Fix null ptr dereference sending UL data before the remote is configured ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5d7971c0ed9b22d35d8965af54031a43c6388762 Gerrit-Change-Number: 29908 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 14:03:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cosmetic: pcu: Fix typo in several comments

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29909 ) Change subject: cosmetic: pcu: Fix typo in several comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29909 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a2419514582cb9efd8df126bf449711f78586fe Gerrit-Change-Number: 29909 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 14:01:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: rcv_resource_request(): Validate expected message before MS lookup & ...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29910 ) Change subject: rcv_resource_request(): Validate expected message before MS lookup & allocation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/29910/comment/2874e882_f52092ab PS2, Line 9: if in -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4be8858230a2eebdb33260093d082a005cb9fcd4 Gerrit-Change-Number: 29910 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 14:00:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: encoding: Use MT_PACKET_UPLINK_ASSIGNMENT define instead of hardcoded...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29911 ) Change subject: encoding: Use MT_PACKET_UPLINK_ASSIGNMENT define instead of hardcoded value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I05b39d3183fdf741d648a15ff803d20e324443af Gerrit-Change-Number: 29911 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 13:55:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: encoding: Use MT_PACKET_UPLINK_ASSIGNMENT define instead of hardcoded...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29911 ) Change subject: encoding: Use MT_PACKET_UPLINK_ASSIGNMENT define instead of hardcoded value ...................................................................... encoding: Use MT_PACKET_UPLINK_ASSIGNMENT define instead of hardcoded value Change-Id: I05b39d3183fdf741d648a15ff803d20e324443af --- M src/encoding.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/11/29911/1 diff --git a/src/encoding.cpp b/src/encoding.cpp index 278da72..74b80c1 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -605,7 +605,7 @@ /* See 3GPP TS 44.060, section 11.2.29 */ pua = &block->u.Packet_Uplink_Assignment; - pua->MESSAGE_TYPE = 0x0a; // Packet Uplink Assignment + pua->MESSAGE_TYPE = MT_PACKET_UPLINK_ASSIGNMENT; // Packet Uplink Assignment pua->PAGE_MODE = 0x00; // Normal Paging /* TLLI or Global (UL/DL) TFI */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I05b39d3183fdf741d648a15ff803d20e324443af Gerrit-Change-Number: 29911 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: rcv_resource_request(): Validate expected message before MS lookup & ...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29910 ) Change subject: rcv_resource_request(): Validate expected message before MS lookup & allocation ...................................................................... rcv_resource_request(): Validate expected message before MS lookup & allocation There's no sense if doing the lookup and allocation if the message is not expected, it will be unrefed (freed) afterwards anyway. Moreover, this way we avoid doing stuff for the WIP code paths which act on different request ID than TLLI. Change-Id: I4be8858230a2eebdb33260093d082a005cb9fcd4 --- M src/pdch.cpp 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/10/29910/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index 56cc958..46df0d5 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -647,10 +647,16 @@ struct gprs_rlcmac_sba *sba; int rc; struct gprs_rlcmac_bts *bts = trx->bts; + struct pdch_ulc_node *item; + + if (!(item = pdch_ulc_get_node(ulc, fn))) { + LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "FN=%u PKT RESOURCE REQ: " + "UL block not reserved\n", fn); + return; + } if (request->ID.UnionType) { struct gprs_rlcmac_ul_tbf *ul_tbf = NULL; - struct pdch_ulc_node *item; uint32_t tlli = request->ID.u.TLLI; GprsMs *ms = bts_ms_by_tlli(bts, tlli, GSM_RESERVED_TMSI); @@ -662,12 +668,6 @@ /* Keep the ms, even if it gets idle temporarily */ ms_ref(ms); - if (!(item = pdch_ulc_get_node(ulc, fn))) { - LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "FN=%u PKT RESOURCE REQ: " - "UL block not reserved\n", fn); - goto return_unref; - } - switch (item->type) { case PDCH_ULC_NODE_TBF_USF: /* Is it actually valid for an MS to send a PKT Res Req during USF? */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4be8858230a2eebdb33260093d082a005cb9fcd4 Gerrit-Change-Number: 29910 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Delay ImmAss(PCH, PktDlAss) if waiting for PKT_CTRL_ACK answering UL_...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29905 ) Change subject: Delay ImmAss(PCH, PktDlAss) if waiting for PKT_CTRL_ACK answering UL_ACK_NACK (FinACK=1) ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/29905/comment/e5bfa03c_1bfbe5f1 PS2, Line 388: something is wrong > The logging in he correct path is done through usual FSM event logging. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7a30db9cc7dae70e04054f1a4dba004bd1780d4a Gerrit-Change-Number: 29905 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 13:15:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022