October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: tbf_fsm: Identify several events as Dl-TBF only

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29917 ) Change subject: tbf_fsm: Identify several events as Dl-TBF only ...................................................................... tbf_fsm: Identify several events as Dl-TBF only This will help in the future when splitting tbf_fsm into different FSMs for UL-TBF and DL-TBF, since only some of the events and staes are shared. That means we can keep a single state and event enum, but the FSMs can be implemented separately in different files, easing a lot extending and understanding the logic. Change-Id: Id97f0d532d2d7ab2791a35c1f836d7c8da050124 --- M src/tbf_fsm.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/17/29917/1 diff --git a/src/tbf_fsm.c b/src/tbf_fsm.c index f019214..9118fd7 100644 --- a/src/tbf_fsm.c +++ b/src/tbf_fsm.c @@ -202,6 +202,7 @@ switch (event) { case TBF_EV_DL_ACKNACK_MISS: + OSMO_ASSERT(tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF); /* DL TBF: we missed a DL ACK/NACK. If we started assignment * over CCCH and never received any DL ACK/NACK yet, it means we * don't even know if the MS successfuly received the Imm Ass on @@ -223,6 +224,7 @@ tbf_fsm_state_chg(fi, TBF_ST_FINISHED); break; case TBF_EV_FINAL_ACK_RECVD: + OSMO_ASSERT(tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF); /* We received Final Ack (DL ACK/NACK) from MS. move to WAIT_RELEASE, we wait there for release or re-use the TBF in case we receive more DL data to tx */ @@ -249,8 +251,10 @@ switch (event) { case TBF_EV_DL_ACKNACK_MISS: + OSMO_ASSERT(tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF); break; case TBF_EV_FINAL_ACK_RECVD: + OSMO_ASSERT(tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF); /* We received Final Ack (DL ACK/NACK) from MS. move to WAIT_RELEASE, we wait there for release or re-use the TBF in case we receive more DL data to tx */ @@ -314,6 +318,7 @@ struct tbf_fsm_ctx *ctx = (struct tbf_fsm_ctx *)fi->priv; switch (event) { case TBF_EV_FINAL_ACK_RECVD: + OSMO_ASSERT(tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF); /* ignore, duplicate ACK, we already know about since we are in WAIT_RELEASE */ break; case TBF_EV_MAX_N3101: @@ -351,8 +356,10 @@ static void st_releasing(struct osmo_fsm_inst *fi, uint32_t event, void *data) { + struct tbf_fsm_ctx *ctx = (struct tbf_fsm_ctx *)fi->priv; switch (event) { case TBF_EV_DL_ACKNACK_MISS: + OSMO_ASSERT(tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF); /* Ignore, we don't care about missed DL ACK/NACK poll timeouts * anymore, we are already releasing the TBF */ break; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id97f0d532d2d7ab2791a35c1f836d7c8da050124 Gerrit-Change-Number: 29917 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by lynxis lazus

Attention is currently required from: neels, pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 6: (4 comments) Patchset: PS6: Maybe somebody else should take care of this commit. File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/3f44f1a6_46700c27 PS4, Line 2661: vty_out(vty, " bts-setup-ramp limit %d window %d%s", > This line needs updating. Done File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/32181d94_93e9d5e2 PS4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list); > maybe add a comment here that you are initializing the list so that it can be llist_deleted() later […] exactly why we want to have a well defined value for empty llist_entries. File src/osmo-bsc/nm_bts_sm_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/725e8d1f_e9485332 PS4, Line 102: static void configure_loop(struct gsm_bts_sm *site_mgr) > This is wrong. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 16:24:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by lynxis lazus

Attention is currently required from: neels, fixeria, lynxis lazus. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 to look at the new patch set (#6). Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Add BTS setup ramping to prevent BSC overloading Prevent BSC overloading in the event of too many BTS try to connect. E.g. a network outage between the BSC and BTS. The BSC will accept incoming OML connection, but will delay sending any BSC originated messages. Depends: Id010ade76de83ccf428f2d18e9f85bcce1d1ea2c (libosmocore) Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d --- M include/osmocom/bsc/bts.h A include/osmocom/bsc/bts_setup_ramp.h M include/osmocom/bsc/gsm_data.h M include/osmocom/bsc/nm_common_fsm.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c A src/osmo-bsc/bts_setup_ramp.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/net_init.c M src/osmo-bsc/nm_bb_transc_fsm.c M src/osmo-bsc/nm_bts_fsm.c M src/osmo-bsc/nm_bts_sm_fsm.c M src/osmo-bsc/nm_channel_fsm.c M src/osmo-bsc/nm_common_fsm.c M src/osmo-bsc/nm_gprs_cell_fsm.c M src/osmo-bsc/nm_gprs_nse_fsm.c M src/osmo-bsc/nm_gprs_nsvc_fsm.c M src/osmo-bsc/nm_rcarrier_fsm.c M src/osmo-bsc/osmo_bsc_main.c 21 files changed, 591 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/29788/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: bsc_vty: training_sequence_code: add missing doc string

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29785 ) Change subject: bsc_vty: training_sequence_code: add missing doc string ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib16e8537e252f6462ef1a90f5eb80572db4b96bb Gerrit-Change-Number: 29785 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: bsc_vty: training_sequence_code: add missing doc string

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29785 ) Change subject: bsc_vty: training_sequence_code: add missing doc string ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'll drop it. It seems I've modified the wrong vty command, but no idea which ones I found broken when testing things. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib16e8537e252f6462ef1a90f5eb80572db4b96bb Gerrit-Change-Number: 29785 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 16:19:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by lynxis lazus

Attention is currently required from: neels, fixeria, lynxis lazus. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 to look at the new patch set (#5). Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Add BTS setup ramping to prevent BSC overloading Prevent BSC overloading in the event of too many BTS try to connect. E.g. a network outage between the BSC and BTS. The BSC will accept incoming OML connection, but will delay sending any BSC originated messages. Depends: Id010ade76de83ccf428f2d18e9f85bcce1d1ea2c (libosmocore) Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d --- M include/osmocom/bsc/bts.h A include/osmocom/bsc/bts_setup_ramp.h M include/osmocom/bsc/gsm_data.h M include/osmocom/bsc/nm_common_fsm.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c A src/osmo-bsc/bts_setup_ramp.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/net_init.c M src/osmo-bsc/nm_bb_transc_fsm.c M src/osmo-bsc/nm_bts_fsm.c M src/osmo-bsc/nm_bts_sm_fsm.c M src/osmo-bsc/nm_channel_fsm.c M src/osmo-bsc/nm_common_fsm.c M src/osmo-bsc/nm_gprs_cell_fsm.c M src/osmo-bsc/nm_gprs_nse_fsm.c M src/osmo-bsc/nm_gprs_nsvc_fsm.c M src/osmo-bsc/nm_rcarrier_fsm.c M src/osmo-bsc/osmo_bsc_main.c 21 files changed, 595 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/29788/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Replace tbf->establish_dl_tbf_on_pacch() refactoring GprsMs functions

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29916 ) Change subject: Replace tbf->establish_dl_tbf_on_pacch() refactoring GprsMs functions ...................................................................... Replace tbf->establish_dl_tbf_on_pacch() refactoring GprsMs functions ms_new_dl_tbf_assignment() is split into 2 functions, one to allocate+assign on PACCH and another one for PCH. This makes a lot clearer the aim of each caller of the function. Once this is done, it becomes obvious tbf->establish_dl_tbf_on_pacch() is basically doing the same as ms_new_dl_tbf_assigned_on_pacch() so drop it. Change-Id: I610210e3120c962d91ce8ff94c66161e086761ba --- M src/gprs_ms.c M src/gprs_ms.h M src/pdch.cpp M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_fsm.c M tests/tbf/TbfTest.err 8 files changed, 92 insertions(+), 106 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/16/29916/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 37071e4..90e8289 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -1056,39 +1056,46 @@ } -/* This should be called only when MS is reachable, see ms_is_reachable_for_dl_ass(). */ -int ms_new_dl_tbf_assignment(struct GprsMs *ms) +/* A new DL-TBF is allocated and assigned through PACCH using "tbf". + * "tbf" may be either a UL-TBF or a DL-TBF. + * Note: This should be called only when MS is reachable, see ms_is_reachable_for_dl_ass(). + */ +int ms_new_dl_tbf_assigned_on_pacch(struct GprsMs *ms, struct gprs_rlcmac_tbf *tbf) { - bool ss; - int8_t use_trx; - struct gprs_rlcmac_ul_tbf *ul_tbf; + OSMO_ASSERT(tbf); + const int8_t trx_no = tbf_get_trx(tbf)->trx_no; + const bool single_slot = false; struct gprs_rlcmac_dl_tbf *dl_tbf; - ul_tbf = ms_ul_tbf(ms); - - if (ul_tbf) { - use_trx = tbf_get_trx((struct gprs_rlcmac_tbf *)ul_tbf)->trx_no; - ss = false; - } else { - use_trx = -1; - ss = true; /* PCH assignment only allows one timeslot */ + dl_tbf = dl_tbf_alloc(ms->bts, ms, trx_no, single_slot); + if (!dl_tbf) { + LOGPMS(ms, DTBF, LOGL_NOTICE, "No PDCH resource\n"); + return -EBUSY; } - /* set number of downlink slots according to multislot class */ - dl_tbf = dl_tbf_alloc(ms->bts, ms, use_trx, ss); + LOGPTBFDL(dl_tbf, LOGL_DEBUG, "[DOWNLINK] START (PACCH)\n"); + dl_tbf_trigger_ass_on_pacch(dl_tbf, tbf); + return 0; +} + +/* A new DL-TBF is allocated and assigned through PCH. + * Note: This should be called only when MS is reachable, see ms_is_reachable_for_dl_ass(). + */ +int ms_new_dl_tbf_assigned_on_pch(struct GprsMs *ms) +{ + const int8_t trx_no = -1; + const bool single_slot = true; + struct gprs_rlcmac_dl_tbf *dl_tbf; + + dl_tbf = dl_tbf_alloc(ms->bts, ms, trx_no, single_slot); if (!dl_tbf) { LOGPMS(ms, DTBF, LOGL_NOTICE, "No PDCH resource\n"); return -EBUSY; } - LOGPTBFDL(dl_tbf, LOGL_DEBUG, "[DOWNLINK] START\n"); - - /* Trigger the assignment now. */ - if (ul_tbf) - dl_tbf_trigger_ass_on_pacch(dl_tbf, ul_tbf_as_tbf(ul_tbf)); - else - dl_tbf_trigger_ass_on_pch(dl_tbf); + LOGPTBFDL(dl_tbf, LOGL_DEBUG, "[DOWNLINK] START (PCH)\n"); + dl_tbf_trigger_ass_on_pch(dl_tbf); return 0; } @@ -1113,14 +1120,18 @@ if (dl_tbf) { if (tbf_state(dl_tbf_as_tbf_const(dl_tbf)) == TBF_ST_WAIT_RELEASE) { LOGPTBFDL(dl_tbf, LOGL_DEBUG, "in WAIT RELEASE state (T3193), so reuse TBF\n"); - tbf_establish_dl_tbf_on_pacch(dl_tbf_as_tbf(dl_tbf)); + rc = ms_new_dl_tbf_assigned_on_pacch(ms, dl_tbf_as_tbf(dl_tbf)); } } else { /* Check if we can create a DL TBF to start sending the enqueued * data. Otherwise it will be triggered later when it is reachable * again. */ - if (ms_is_reachable_for_dl_ass(ms)) - rc = ms_new_dl_tbf_assignment(ms); + if (ms_is_reachable_for_dl_ass(ms)) { + if (ms_ul_tbf(ms)) + rc = ms_new_dl_tbf_assigned_on_pacch(ms, ul_tbf_as_tbf(ms_ul_tbf(ms))); + else + rc = ms_new_dl_tbf_assigned_on_pch(ms); + } } return rc; } diff --git a/src/gprs_ms.h b/src/gprs_ms.h index b9a1386..8014f26 100644 --- a/src/gprs_ms.h +++ b/src/gprs_ms.h @@ -144,7 +144,8 @@ bool ms_nacc_rts(const struct GprsMs *ms); struct msgb *ms_nacc_create_rlcmac_msg(struct GprsMs *ms, struct gprs_rlcmac_tbf *tbf, uint32_t fn, uint8_t ts); -int ms_new_dl_tbf_assignment(struct GprsMs *ms); +int ms_new_dl_tbf_assigned_on_pacch(struct GprsMs *ms, struct gprs_rlcmac_tbf *tbf); +int ms_new_dl_tbf_assigned_on_pch(struct GprsMs *ms); int ms_append_llc_dl_data(struct GprsMs *ms, uint16_t pdu_delay_csec, const uint8_t *data, uint16_t len); static inline bool ms_is_idle(const struct GprsMs *ms) diff --git a/src/pdch.cpp b/src/pdch.cpp index 1df8db8..ad521e3 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -421,7 +421,7 @@ * TBF might have been released while the UL TBF has been * established */ if (ms_need_dl_tbf(new_tbf->ms())) - new_tbf->establish_dl_tbf_on_pacch(); + ms_new_dl_tbf_assigned_on_pacch(new_tbf->ms(), new_tbf); return; case PDCH_ULC_POLL_DL_ASS: diff --git a/src/tbf.cpp b/src/tbf.cpp index 4bf4ce8..d855083 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -688,26 +688,6 @@ return 0; } -int gprs_rlcmac_tbf::establish_dl_tbf_on_pacch() -{ - struct gprs_rlcmac_dl_tbf *new_tbf = NULL; - - bts_do_rate_ctr_inc(bts, CTR_TBF_REUSED); - - new_tbf = dl_tbf_alloc(bts, ms(), - this->trx->trx_no, false); - - if (!new_tbf) { - LOGP(DTBF, LOGL_NOTICE, "No PDCH resource\n"); - return -1; - } - - LOGPTBF(this, LOGL_DEBUG, "Trigger downlink assignment on PACCH\n"); - dl_tbf_trigger_ass_on_pacch(new_tbf, this); - - return 0; -} - const char *tbf_name(const gprs_rlcmac_tbf *tbf) { return tbf ? tbf->name() : "(no TBF)"; @@ -951,11 +931,6 @@ return buf; } -int tbf_establish_dl_tbf_on_pacch(struct gprs_rlcmac_tbf *tbf) -{ - return tbf->establish_dl_tbf_on_pacch(); -} - struct gprs_rlcmac_trx *tbf_get_trx(struct gprs_rlcmac_tbf *tbf) { return tbf->trx; diff --git a/src/tbf.h b/src/tbf.h index 09de188..65b131e 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -148,7 +148,6 @@ bool tbf_is_control_ts(const struct gprs_rlcmac_tbf *tbf, uint8_t ts); bool tbf_can_upgrade_to_multislot(const struct gprs_rlcmac_tbf *tbf); int tbf_update(struct gprs_rlcmac_tbf *tbf); -int tbf_establish_dl_tbf_on_pacch(struct gprs_rlcmac_tbf *tbf); struct gprs_rlcmac_trx *tbf_get_trx(struct gprs_rlcmac_tbf *tbf); void tbf_stop_timers(struct gprs_rlcmac_tbf *tbf, const char *reason); #ifdef __cplusplus @@ -190,7 +189,6 @@ void t_stop(enum tbf_timers t, const char *reason); void t_start(enum tbf_timers t, int T, const char *reason, bool force, const char *file, unsigned line); - int establish_dl_tbf_on_pacch(); int check_polling(uint32_t fn, uint8_t ts, uint32_t *poll_fn, unsigned int *rrbp) const; diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 0e6b922..c63af58 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -973,6 +973,7 @@ int gprs_rlcmac_dl_tbf::rcvd_dl_final_ack() { uint16_t received; + int rc = 0; osmo_fsm_inst_dispatch(this->state_fsm.fi, TBF_EV_FINAL_ACK_RECVD, NULL); @@ -986,9 +987,9 @@ /* check for LLC PDU in the LLC Queue */ if (llc_queue_size(llc_queue()) > 0) /* we have more data so we will re-use this tbf */ - establish_dl_tbf_on_pacch(); + rc = ms_new_dl_tbf_assigned_on_pacch(ms(), dl_tbf_as_tbf(this)); - return 0; + return rc; } int gprs_rlcmac_dl_tbf::rcvd_dl_ack(bool final_ack, unsigned first_bsn, diff --git a/src/tbf_fsm.c b/src/tbf_fsm.c index eeccd6b..f019214 100644 --- a/src/tbf_fsm.c +++ b/src/tbf_fsm.c @@ -276,7 +276,7 @@ * back to packet-idle mode then we can assign the DL TBF on PCH * now. */ if (!new_ul_tbf_requested && ms_need_dl_tbf(ms)) - ms_new_dl_tbf_assignment(ms); + ms_new_dl_tbf_assigned_on_pch(ms); ms_unref(ms); break; case TBF_EV_MAX_N3103: diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 564cafd..bde7940 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -140,7 +140,7 @@ TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0, DL) Attaching DL TBF: TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) Trigger downlink assignment on PACCH +TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) [DOWNLINK] START (PACCH) TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) exists DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Received Event SCHED_ASS DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Event SCHED_ASS not permitted @@ -253,7 +253,7 @@ TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xffeeddcc, IMSI=, TA=0, 45/0, DL) Attaching DL TBF: TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) Trigger downlink assignment on PACCH +TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) [DOWNLINK] START (PACCH) TBF(TFI=1 TLLI=0xffeeddcc DIR=DL STATE=NEW) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT_RELEASE) exists DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Received Event SCHED_ASS DL_ASS_TBF(DL-TFI_0){WAIT_ACK}: Event SCHED_ASS not permitted @@ -660,7 +660,7 @@ TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000000, IMSI=001001000000000, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000000) TBF(DL-TFI_0){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=0 TLLI=0xc0000000 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -690,7 +690,7 @@ TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000001, IMSI=001001000000001, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=NEW) -TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000001) TBF(DL-TFI_1){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=1 TLLI=0xc0000001 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -720,7 +720,7 @@ TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000002, IMSI=001001000000002, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=NEW) -TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000002) TBF(DL-TFI_2){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=2 TLLI=0xc0000002 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -750,7 +750,7 @@ TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000003, IMSI=001001000000003, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=NEW) -TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000003) TBF(DL-TFI_3){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=3 TLLI=0xc0000003 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -780,7 +780,7 @@ TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000004, IMSI=001001000000004, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=NEW) -TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000004) TBF(DL-TFI_4){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=4 TLLI=0xc0000004 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -810,7 +810,7 @@ TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000005, IMSI=001001000000005, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=NEW) -TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000005) TBF(DL-TFI_5){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=5 TLLI=0xc0000005 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -840,7 +840,7 @@ TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000006, IMSI=001001000000006, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=NEW) -TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000006) TBF(DL-TFI_6){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=6 TLLI=0xc0000006 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -870,7 +870,7 @@ TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000007, IMSI=001001000000007, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=NEW) -TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000007) TBF(DL-TFI_7){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=7 TLLI=0xc0000007 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -900,7 +900,7 @@ TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000008, IMSI=001001000000008, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=NEW) -TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000008) TBF(DL-TFI_8){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=8 TLLI=0xc0000008 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -930,7 +930,7 @@ TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000009, IMSI=001001000000009, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=NEW) -TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000009) TBF(DL-TFI_9){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=9 TLLI=0xc0000009 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -960,7 +960,7 @@ TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000000a, IMSI=001001000000010, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=NEW) -TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000010) TBF(DL-TFI_10){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=10 TLLI=0xc000000a DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -990,7 +990,7 @@ TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000000b, IMSI=001001000000011, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=NEW) -TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000011) TBF(DL-TFI_11){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=11 TLLI=0xc000000b DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1020,7 +1020,7 @@ TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000000c, IMSI=001001000000012, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=NEW) -TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000012) TBF(DL-TFI_12){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=12 TLLI=0xc000000c DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1050,7 +1050,7 @@ TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000000d, IMSI=001001000000013, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=NEW) -TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000013) TBF(DL-TFI_13){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=13 TLLI=0xc000000d DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1080,7 +1080,7 @@ TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000000e, IMSI=001001000000014, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=NEW) -TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000014) TBF(DL-TFI_14){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=14 TLLI=0xc000000e DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1110,7 +1110,7 @@ TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000000f, IMSI=001001000000015, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=NEW) -TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000015) TBF(DL-TFI_15){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=15 TLLI=0xc000000f DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1140,7 +1140,7 @@ TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000010, IMSI=001001000000016, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=NEW) -TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000016) TBF(DL-TFI_16){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=16 TLLI=0xc0000010 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1170,7 +1170,7 @@ TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000011, IMSI=001001000000017, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=NEW) -TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000017) TBF(DL-TFI_17){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=17 TLLI=0xc0000011 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1200,7 +1200,7 @@ TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000012, IMSI=001001000000018, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=NEW) -TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000018) TBF(DL-TFI_18){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=18 TLLI=0xc0000012 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1230,7 +1230,7 @@ TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000013, IMSI=001001000000019, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=NEW) -TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000019) TBF(DL-TFI_19){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=19 TLLI=0xc0000013 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1260,7 +1260,7 @@ TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000014, IMSI=001001000000020, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=NEW) -TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000020) TBF(DL-TFI_20){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=20 TLLI=0xc0000014 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1290,7 +1290,7 @@ TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000015, IMSI=001001000000021, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=NEW) -TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000021) TBF(DL-TFI_21){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=21 TLLI=0xc0000015 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1320,7 +1320,7 @@ TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000016, IMSI=001001000000022, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=NEW) -TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000022) TBF(DL-TFI_22){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=22 TLLI=0xc0000016 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1350,7 +1350,7 @@ TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000017, IMSI=001001000000023, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=NEW) -TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000023) TBF(DL-TFI_23){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=23 TLLI=0xc0000017 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1380,7 +1380,7 @@ TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000018, IMSI=001001000000024, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=NEW) -TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000024) TBF(DL-TFI_24){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=24 TLLI=0xc0000018 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1410,7 +1410,7 @@ TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0000019, IMSI=001001000000025, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=NEW) -TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000025) TBF(DL-TFI_25){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=25 TLLI=0xc0000019 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1440,7 +1440,7 @@ TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000001a, IMSI=001001000000026, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=NEW) -TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000026) TBF(DL-TFI_26){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=26 TLLI=0xc000001a DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1470,7 +1470,7 @@ TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000001b, IMSI=001001000000027, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=NEW) -TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000027) TBF(DL-TFI_27){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=27 TLLI=0xc000001b DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1500,7 +1500,7 @@ TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000001c, IMSI=001001000000028, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=NEW) -TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000028) TBF(DL-TFI_28){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=28 TLLI=0xc000001c DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1530,7 +1530,7 @@ TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000001d, IMSI=001001000000029, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=NEW) -TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000029) TBF(DL-TFI_29){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=29 TLLI=0xc000001d DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1560,7 +1560,7 @@ TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000001e, IMSI=001001000000030, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=NEW) -TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000030) TBF(DL-TFI_30){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=30 TLLI=0xc000001e DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1590,7 +1590,7 @@ TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc000001f, IMSI=001001000000031, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=NEW) -TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000000031) TBF(DL-TFI_31){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=31 TLLI=0xc000001f DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1705,7 +1705,7 @@ TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0123456, IMSI=001001000123456, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000123456) TBF(DL-TFI_0){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1742,7 +1742,7 @@ TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0123456, IMSI=001001000123456, TA=0, 45/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) MS(TLLI=0xc0123456, IMSI=001001000123456, TA=0, 45/0, DL) Cancel scheduled MS release -TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001000123456) TBF(DL-TFI_0){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=0 TLLI=0xc0123456 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -1950,7 +1950,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Setting Control TS 7 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 80, dl_slots = 80 MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 0/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=0011223344) TBF(DL-TFI_0){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -2051,7 +2051,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Setting Control TS 7 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 80, dl_slots = 80 MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS @@ -2153,7 +2153,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Setting Control TS 7 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 80, dl_slots = 80 MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS @@ -2423,7 +2423,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Setting Control TS 7 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 80, dl_slots = 80 MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS @@ -2600,7 +2600,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Setting Control TS 7 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 80, dl_slots = 80 MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS @@ -2775,7 +2775,7 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Setting Control TS 7 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 80, dl_slots = 80 MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS @@ -3500,7 +3500,7 @@ TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=NEW) Setting Control TS 7 TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 80, dl_slots = 80 MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/0, UL DL) Attaching DL TBF: TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE) Trigger downlink assignment on PACCH +TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=NEW) [DOWNLINK] START (PACCH) TBF(TFI=1 TLLI=0xf1223344 DIR=DL STATE=NEW) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=WAIT_RELEASE) exists DL_ASS_TBF(DL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(DL-TFI_0){NONE}: state_chg to SEND_ASS @@ -3767,7 +3767,7 @@ TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=NEW) Setting Control TS 4 TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=NEW) Allocated: trx = 0, ul_slots = 10, dl_slots = 10 MS(TLLI=0xc0006789, IMSI=001001123456789, TA=220, 45/0,) Attaching DL TBF: TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=NEW) -TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=NEW) [DOWNLINK] START +TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=NEW) [DOWNLINK] START (PCH) TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=NEW) Send downlink assignment on PCH, no TBF exist (IMSI=001001123456789) TBF(DL-TFI_0){NEW}: Received Event ASSIGN_ADD_CCCH TBF(TFI=0 TLLI=0xc0006789 DIR=DL STATE=NEW) set ass. type CCCH [prev CCCH:0, PACCH:0] @@ -3970,7 +3970,7 @@ MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/1, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) setting EGPRS DL window size to 64, base(64) slots(1) ws_pdch(0) ws(64) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS @@ -4204,7 +4204,7 @@ MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/1, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) setting EGPRS DL window size to 64, base(64) slots(1) ws_pdch(0) ws(64) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS @@ -7055,7 +7055,7 @@ MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/1, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) setting EGPRS DL window size to 64, base(64) slots(1) ws_pdch(0) ws(64) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS @@ -7241,7 +7241,7 @@ MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/1, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) setting EGPRS DL window size to 64, base(64) slots(1) ws_pdch(0) ws(64) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS @@ -8150,7 +8150,7 @@ MS(TLLI=0xf1223344, IMSI=0011223344, TA=7, 1/1, UL) Attaching DL TBF: TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) setting EGPRS DL window size to 192, base(128) slots(1) ws_pdch(64) ws(192) -TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START +TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) [DOWNLINK] START (PACCH) TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=NEW EGPRS) Send downlink assignment on PACCH, because TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) exists DL_ASS_TBF(UL-TFI_0){NONE}: Received Event SCHED_ASS DL_ASS_TBF(UL-TFI_0){NONE}: state_chg to SEND_ASS -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I610210e3120c962d91ce8ff94c66161e086761ba Gerrit-Change-Number: 29916 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: fsm: add ignore_invalid_event_mask bit-mask

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29907 ) Change subject: fsm: add ignore_invalid_event_mask bit-mask ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > IMHO this causes even more difficulties to understand FSM code (both the FSM implementation and user […] I find it very difficult to write empty events in many states (both in the in_event_mask and within the state function). Or having proxy functions which checks if the fsm might be in the right state to emit a signal. Those log lines also confuses the user as we've seen in redmine tickets (e.g. sgsn, ns layer). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id010ade76de83ccf428f2d18e9f85bcce1d1ea2c Gerrit-Change-Number: 29907 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 16:00:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Rename function tbf_dl_request_dl_ack() -> dl_tbf_request_dl_ack()

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/29915 ) Change subject: Rename function tbf_dl_request_dl_ack() -> dl_tbf_request_dl_ack() ...................................................................... Rename function tbf_dl_request_dl_ack() -> dl_tbf_request_dl_ack() Use the dl_tbf prefix which is usually used to easily distinguish from "ul_tbf" specific APIs and "tbf" generic (parent class) APIs. Change-Id: Ibf6ae20da99866af5f2b6e12184f3145d1fc0bbf --- M src/gprs_ms.c M src/tbf_dl.cpp M src/tbf_dl.h 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/15/29915/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6ae20da99866af5f2b6e12184f3145d1fc0bbf Gerrit-Change-Number: 29915 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Rename function tbf_dl_request_dl_ack() -> dl_tbf_request_dl_ack()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29915 ) Change subject: Rename function tbf_dl_request_dl_ack() -> dl_tbf_request_dl_ack() ...................................................................... Rename function tbf_dl_request_dl_ack() -> dl_tbf_request_dl_ack() Use the dl_tbf prefix which is usually used to easily distinguish from "ul_tbf" specific APIs and "tbf" generic (parent class) APIs. Change-Id: Ibf6ae20da99866af5f2b6e12184f3145d1fc0bbf --- M src/gprs_ms.c M src/tbf_dl.cpp M src/tbf_dl.h 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/15/29915/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index c072b0a..37071e4 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -99,7 +99,7 @@ LOGPTBFDL(dl_tbf, LOGL_DEBUG, "LLC receive timeout, requesting DL ACK\n"); - tbf_dl_request_dl_ack(dl_tbf); + dl_tbf_request_dl_ack(dl_tbf); } static int ms_talloc_destructor(struct GprsMs *ms); diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 856dae6..0e6b922 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -1027,7 +1027,7 @@ m_dl_ack_requested = true; } -void tbf_dl_request_dl_ack(struct gprs_rlcmac_dl_tbf *dl_tbf) { +void dl_tbf_request_dl_ack(struct gprs_rlcmac_dl_tbf *dl_tbf) { dl_tbf->request_dl_ack(); } diff --git a/src/tbf_dl.h b/src/tbf_dl.h index ba5d582..bfe9068 100644 --- a/src/tbf_dl.h +++ b/src/tbf_dl.h @@ -139,7 +139,7 @@ void dl_tbf_trigger_ass_on_pacch(struct gprs_rlcmac_dl_tbf *tbf, struct gprs_rlcmac_tbf *old_tbf); void dl_tbf_trigger_ass_on_pch(struct gprs_rlcmac_dl_tbf *tbf); -void tbf_dl_request_dl_ack(struct gprs_rlcmac_dl_tbf *tbf); +void dl_tbf_request_dl_ack(struct gprs_rlcmac_dl_tbf *tbf); static inline struct gprs_rlcmac_tbf *dl_tbf_as_tbf(struct gprs_rlcmac_dl_tbf *dl_tbf) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf6ae20da99866af5f2b6e12184f3145d1fc0bbf Gerrit-Change-Number: 29915 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022