October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: tbf_ul_ack_fsm: get ul_tbf base class only when needed

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29899 ) Change subject: tbf_ul_ack_fsm: get ul_tbf base class only when needed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I788eae58248fa21732efe802344aa3c0c5031b5a Gerrit-Change-Number: 29899 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 12:26:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Rename as_{dl,ul}_tbf -> tbf_as_{dl,ul}_tbf

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29895 ) Change subject: Rename as_{dl,ul}_tbf -> tbf_as_{dl,ul}_tbf ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I225568fe2cb5236817cdd9609354c24c66723606 Gerrit-Change-Number: 29895 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 12:20:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Fix mess with struct tbf types passed to LOGPTBF macro

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29894 ) Change subject: Fix mess with struct tbf types passed to LOGPTBF macro ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7e4489ad4b93c9c8442213947e53c10b61fdc5e9 Gerrit-Change-Number: 29894 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 12:18:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: tbf_dl: Make dl_tbf_alloc API available in C code

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29889 ) Change subject: tbf_dl: Make dl_tbf_alloc API available in C code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib586894bc5834c33d38d23b7194f6dfadf9bc375 Gerrit-Change-Number: 29889 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Oct 2022 12:13:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmux: Fix null ptr dereference sending UL data before the remote is ...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29908 ) Change subject: osmux: Fix null ptr dereference sending UL data before the remote is configured ...................................................................... osmux: Fix null ptr dereference sending UL data before the remote is configured Related: SYS#6161 Change-Id: I5d7971c0ed9b22d35d8965af54031a43c6388762 --- M src/common/osmux.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/08/29908/1 diff --git a/src/common/osmux.c b/src/common/osmux.c index 3f137e5..acf3a1d 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -493,6 +493,10 @@ rtph = (struct rtp_hdr *)msgb_data(msg); rtph->marker = marker; + /* Avoid using the osmux.in if not yet connected. */ + if (!lchan_osmux_connected(lchan)) + return -1; + while ((rc = osmux_xfrm_input(lchan->abis_ip.osmux.in, msg, lchan->abis_ip.osmux.remote_cid)) > 0) { /* batch full, build and deliver it */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5d7971c0ed9b22d35d8965af54031a43c6388762 Gerrit-Change-Number: 29908 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ul_tbf_finished_pkt_dl_ass_pch

by pespin

Attention is currently required from: osmith. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29906 to look at the new patch set (#2). Change subject: pcu: Introduce test TC_ul_tbf_finished_pkt_dl_ass_pch ...................................................................... pcu: Introduce test TC_ul_tbf_finished_pkt_dl_ass_pch Related: OS#5700 Change-Id: Id99b048e7c305fe616bb54437313a1e45449ff57 --- M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn M pcu/expected-results.xml 3 files changed, 63 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/29906/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id99b048e7c305fe616bb54437313a1e45449ff57 Gerrit-Change-Number: 29906 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by pespin

Attention is currently required from: neels, fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 4: Code-Review-1 (6 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/344bdb1d_c166f141 PS4, Line 2661: vty_out(vty, " bts-setup-ramp limit %d window %d%s", This line needs updating. File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/225ce6fd_513954e4 PS4, Line 86: { 0, NULL }, unaligned https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/cf3c4202_ae4bba1b PS4, Line 201: INIT_LLIST_HEAD(&bts->bts_setup_ramp.list); maybe add a comment here that you are initializing the list so that it can be llist_deleted() later on even if it has not been added to any list. File src/osmo-bsc/nm_bts_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/7566fa90_04245a66 PS1, Line 92: struct gsm_bts *bts, > You could check all the other configure_loop() functions and use the same format as in all of them ; […] Actually, I see now that you are changing the formatting of this line for now reason, so leave it was it was. File src/osmo-bsc/nm_bts_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/087a9eef_ba389864 PS4, Line 401: .ignore_invalid_events = As mentioned I don't think this is needed. We can discuss it further. File src/osmo-bsc/nm_bts_sm_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/2d9d782d_37e97cfd PS4, Line 102: static void configure_loop(struct gsm_bts_sm *site_mgr) This is wrong. You are not adding the param "bool allow_opstart" to this function which should allow the opstart to be sent only under OFFLINE state, not in DEPENDENCY. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 28 Oct 2022 10:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by pespin

Attention is currently required from: neels, fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 4: (2 comments) File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/8ba653ee_75e66ea9 PS1, Line 345: case NM_EV_RAMP_GO: > I've implemented it together with a libosmocore (ignore_invalid_event_mask). […] I don't see why you'd need to add it in all FSM states. If the object is ENABLED that means the configuration already went one and hence how it is possible that the outside code send this event to allow start of configuration? File src/osmo-bsc/nm_bts_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/496f7252_60093b0c PS1, Line 92: struct gsm_bts *bts, > IMHO this is fine. last example of 6.2) looks the same. […] You could check all the other configure_loop() functions and use the same format as in all of them ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 28 Oct 2022 10:40:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: fsm: add ignore_invalid_event_mask bit-mask

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29907 ) Change subject: fsm: add ignore_invalid_event_mask bit-mask ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: IMHO this causes even more difficulties to understand FSM code (both the FSM implementation and users of the FSM) by having to look at yet another place for flow of events. I think it's totally fine having to add the possible events on each state, it helps understanding what may be possible by readers who look at it. Logging incorrect events sent at a given point is also good, because it allows learning that some scenarios are also possible and need to be taken into account. So my opinion right now is that I see no need for this change. Other feel free to provide their own opinion on the topic. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id010ade76de83ccf428f2d18e9f85bcce1d1ea2c Gerrit-Change-Number: 29907 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 28 Oct 2022 10:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-mgw in Raspbian_11/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-mgw failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 454s] update-alternatives: using /usr/share/man/man7/bash-builtins.7.gz to provide /usr/share/man/man7/builtins.7.gz (builtins.7.gz) in auto mode [ 455s] [454/479] installing build-essential-12.9 [ 455s] [455/479] installing python3-blockdiag-2.0.1+dfsg-1 [ 457s] [456/479] installing texlive-xetex-2020.20210202-3 [ 461s] [457/479] installing dblatex-0.3.12py3-1 [ 463s] [458/479] installing systemd-247.3-7+rpi1+deb11u1 [ 466s] Created symlink /etc/systemd/system/getty.target.wants/getty(a)tty1.service -> /lib/systemd/system/getty@.service. [ 466s] Created symlink /etc/systemd/system/multi-user.target.wants/remote-fs.target -> /lib/systemd/system/remote-fs.target. [ 466s] Created symlink /etc/systemd/system/sysinit.target.wants/systemd-pstore.service -> /lib/systemd/system/systemd-pstore.service. [ 466s] Initializing machine ID from D-Bus machine ID. [ 467s] [459/479] installing systemd-sysv-247.3-7+rpi1+deb11u1 [ 468s] [460/479] installing python3-nwdiag-2.0.0+dfsg-1 [ 469s] [461/479] installing texlive-formats-extra-2020.20210202-3 [ 470s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/texlive-formats-extra.deb' (size=4711156) member 'data.tar': lzma error: compressed data is corrupt [ 470s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 470s] dpkg: error processing archive .init_b_cache/texlive-formats-extra.deb (--install): [ 470s] cannot copy extracted data for './usr/share/doc/texlive-doc/fonts/mxedruli/mxeddoc.pdf' to '/usr/share/doc/texlive-doc/fonts/mxedruli/mxeddoc.pdf.dpkg-new': unexpected end of file or stream [ 470s] Errors were encountered while processing: [ 470s] .init_b_cache/texlive-formats-extra.deb [ 470s] exit ... [ 470s] ### VM INTERACTION START ### [ 471s] Failed to write wtmp record, ignoring: Read-only file system [ 471s] Failed to write utmp record: Read-only file system [ 471s] Powering off. [ 471s] [ 406.317199] reboot: Power down [ 471s] ### VM INTERACTION END ### [ 471s] [ 471s] armbuild02 failed "build osmo-mgw_1.10.0.105.9ac9.202210280052.dsc" at Fri Oct 28 05:39:05 UTC 2022. [ 471s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022