Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email )

Change subject: asp: Rename and clarify asp_id field ......................................................................

Patch Set 1:

(1 comment)

File src/xua_asp_fsm.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006/comment/e0b8c081_87bf43... : PS1, Line 219: xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp->asp_id);

the commit message only talks about renaming the field, but here the logic is changed to not send th […]

I'm already explaining it in the commit msg: "and using this same value when sending our own ASP Identifier during ASPUP. This was not causing a problem since actually we have no real way to set asp_id_present on our own in ASP mode yet, so no local ASP Identifier is ever being transmitted."

It makes more sense to do it here, because this commit is not omly a "rename" commit but a "clarify and rename" commit, and both need to go together since 2 different uses were entangled in the same field.