Attention is currently required from: canghaiwuhen.

fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email )

Change subject: Related: OS#6922 Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ......................................................................

Patch Set 1:

(4 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/c6c411a7_3a11cc9a?usp... : PS1, Line 7: Related: OS#6922 This should go below or above the `Change-Id` line, not here.

File src/sgsn/gprs_sm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/7892495d_fe27ee45?usp... : PS1, Line 210: ANTIGRAVITY PATCH: True Echo. What does this mean?

https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/8c74248f_21001559?usp... : PS1, Line 219: if (qos_len > sizeof(default_qos)) ```suggestion else if (qos_len > sizeof(default_qos)) ```

https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/9ffadd97_72c398ca?usp... : PS1, Line 340: tp->lv[OSMO_IE_GSM_REQ_QOS].len ```suggestion pdp->req_qos_len = TLVP_LEN(tp, OSMO_IE_GSM_REQ_QOS); ```