Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38336?usp=email ) Change subject: testenv: requirements: find programs in /usr/sbin ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File _testenv/testenv/requirements.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38336/comment/48adaaf2_9322… : PS1, Line 40: if not shutil.which(program): You probably want to move this code block as a helper function at some point. No rush though. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38336?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibbccba013ac38415ef46467f97bef846b848cf39 Gerrit-Change-Number: 38336 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 14:46:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes