Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27722 )
Change subject: osmo-bts-trx: rx_tchh_fn(): use a lookup table for FACCH/H ......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bts-trx/sched_lchan_tchh.c:
https://gerrit.osmocom.org/c/osmo-bts/+/27722/comment/e4415baf_66b40148 PS1, Line 85: int fn_is_odd = (((bi->fn + 26 - 10) % 26) >> 2) & 1;
I am not a big fan of this kind of functions, sorry. This statement: […]
It may be self explaining to you after having read the specs, I can tell you it's not safe explaining to me, at least without further investigation. Having fn_is_facch() is self explanatory. Just sharing my view here.
-
pespin