Attention is currently required from: fixeria, laforge, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email )
Change subject: manuals: add section about the SGs interface. ......................................................................
Patch Set 2:
(8 comments)
File doc/manuals/chapters/running.adoc:
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/a037315a_b956a4a5 PS1, Line 78: see section <<sgs>>
missing dot at the end of sentence
Done
File doc/manuals/chapters/sgs.adoc:
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/83f29025_38b439ef PS1, Line 4: SGs/SGsAP
The interface is called SGs. The application layer protocol for it is SGsAP. […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/e171c93d_a0f533e9 PS1, Line 5: It's
Its (not it is)
Done
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/cfb3ca28_94bbe224 PS1, Line 5: LTE/EPC
you used "2G (GERAN)" before, then here it would make sense to use the same format e.g. […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/c23f7cbe_8ae98588 PS1, Line 31: ts5, ts6-2, ts7, ts11, ts14, ts15
cosmetic: use ` text ` for `highlighting`
Done
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/250a3f51_773352b6 PS1, Line 44: In case multiple instances of OsmoMSC run in parallel, it is advised to use a : different vlr-name for each instance
you might want to add that they of course need to be bound to different IP addresses. […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/82cf4c4f_5dabfcfb PS1, Line 50: show sgs-connections
cosmetic: use ` text ` for `highlighting`
Done
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/b24dab01_3efe3f9b PS1, Line 51: OsmoMSC
missing dot
Done
-
dexter