Attention is currently required from: lynxis lazus, matanp, neels.

fixeria has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email )

Change subject: vlr: Stop silent call before deduping subscribers ......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:

I tried to solve the problem more elegantly, but making the VLR aware to the concept of silent calls […]

It feels architecturally wrong to get the VLR involved in the MSC specific procedures, like the silent call. Moreover, the VLR code is also going to be used by osmo-sgsn at some point, and changes like this one will likely make the integration harder. I am not against merging this fix as a workaround, but ideally we should look for a more fundamental approach.

Neels: Maybe you have any ideas?

P.S. Would be nice to have a bug reproducer in TTCN-3 and/or in form of a unit test.