Attention is currently required from: neels, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323 ) Change subject: cnpool: allow separate cs7 for IuPS and IuCS ...................................................................... Patch Set 8: Code-Review+1 (2 comments) File include/osmocom/hnbgw/hnbgw.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323/comment/715a8070_694fca97 PS8, Line 87: DECLARE_HASHTABLE(hnbgw_context_map_by_conn_id, 6); maybe add a comment what's going to be added in here (struct hnbgw_cnlink?). https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323/comment/fc066f56_0b15aa32 PS8, Line 133: if (!cnlink->hnbgw_sccp_user) can this really happen? Is it expected to happen? I find it confusing when seeing all these checks when learning a code base because I then don't know if it is expected from the author that the cnlink will have no sccp_user at times, or it's simply over-protecting code. If this should not happen, in general I'd go for OSMO_ASSERT, to avoid confusing others. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iea1824f1c586723d989c80a909bae16bd2866e08 Gerrit-Change-Number: 32323 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 09:06:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment