Attention is currently required from: neels, msuraev.

Patch set 8:Code-Review +1

View Change

2 comments:

• File include/osmocom/hnbgw/hnbgw.h:

  • Patch Set #8, Line 87: DECLARE_HASHTABLE(hnbgw_context_map_by_conn_id, 6);

    maybe add a comment what's going to be added in here (struct hnbgw_cnlink?).

  • Patch Set #8, Line 133: if (!cnlink->hnbgw_sccp_user)

    can this really happen? Is it expected to happen? I find it confusing when seeing all these checks when learning a code base because I then don't know if it is expected from the author that the cnlink will have no sccp_user at times, or it's simply over-protecting code.

    If this should not happen, in general I'd go for OSMO_ASSERT, to avoid confusing others.

To view, visit change 32323. To unsubscribe, or for help writing mail filters, visit settings.