Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/32341
)
Change subject: ms: Drop setting (egprs_)ms_class during bts_alloc_ms()
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
looks like once omitted by accident, otherwise LGTM
File src/tbf_dl.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/32341/comment/1024dbb4_df7363f3
PS2, Line 220: ms = bts_alloc_ms(bts);
is it not needed to set ms_class and egprs_ms_class here?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32341
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I36f07dc389f7abe205fc4bcddbde93735f5d5cfc
Gerrit-Change-Number: 32341
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Apr 2023 11:12:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment