Attention is currently required from: iedemam.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31617 )
Change subject: utils: fix incorrect string checks in meas_db_insert() ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Good catch, apologies for the miss. […]
No worries, it's absolutely normal and we all make mistakes.
File src/utils/meas_db.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31617/comment/8b5c6a0b_ab216ab6 PS1, Line 97: if (mfm->imsi[0] != '\0')
The original checks before my refactor were using strlen(). […]
Let's see what the others think. If people find `strlen()` more readable, I can amend the patch. The compiler would optimize `strlen()` out anyway.