Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31610 )
Change subject: vty: msc / codec-list: forbid duplicate entries ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/88cd6589_2e15ea0e PS1, Line 2730: || argv[i][1] != 'r'
not mine, just moving code around.
yeah well, but while moving the code around you can move it using the proper indentation ;)
https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/a161117f_2ea8f314 PS1, Line 2740: if (strncmp("hr", argv[i], 2) == 0)
still just moving code
Ok fine. How can you submit an extra patch fixing all those weird things I pointed out?
-
pespin