Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email ) Change subject: coverity CID#216830 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/37995/comment/97cc6a0b_fb38c8c2… : PS1, Line 443: par_datalen = 0; this indicates a formatting error, I would definitely stop parsing at this point instead of "reinterpreting" the packet. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 Gerrit-Change-Number: 37995 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 09:06:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes