Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28744 ) Change subject: trxcon: make l1sched logging configurable, append trxcon->fi prefix ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Yes, this is useful when trxcon has multiple L1CTL connections (ttcn3-bts-test will be using this soon) and thus multiple schedulers printing logging messages. We definitely need some way to distinguish them. Though, calling a function for each logging message may be an overkill. I think we can simply set a 'const char *prefix' to osmo_fsm_inst_name(trxcon->fi) without having the fsm state. What do you think? File src/host/trxcon/src/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/2f0759b6_cff50f3d PS2, Line 185: #if 0 Because no logging context is available here: neither sched, nor lchan. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I26da1a506b02502a3a6a887533c35fb09c13c429 Gerrit-Change-Number: 28744 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Jul 2022 11:55:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment