osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29794 )

Change subject: jenkins-gerrit: add note for build fails/pkgs pass ......................................................................

jenkins-gerrit: add note for build fails/pkgs pass

One might be wondering what happened if the build job failed, but building the binary packages succeeded. Since we run 'make check' in all cases. Add this short explanation:

The build job(s) failed, but deb/rpm jobs passed. We don't enable external/vty tests when building packages, so maybe those failed. Check the logs.

Related: OS#2385 Change-Id: I70027ec970a220c3ddfa766302faec7bd8752118 --- M scripts/jenkins-gerrit/pipeline_summary.py 1 file changed, 8 insertions(+), 0 deletions(-)

Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified

diff --git a/scripts/jenkins-gerrit/pipeline_summary.py b/scripts/jenkins-gerrit/pipeline_summary.py index a47ab7c..95ae821 100755 --- a/scripts/jenkins-gerrit/pipeline_summary.py +++ b/scripts/jenkins-gerrit/pipeline_summary.py @@ -156,6 +156,14 @@ summary += f"{len(jobs['passed'])} passed:\n" summary += get_jobs_list_str(jobs["passed"])

+ if "build" in pipeline and "deb" in pipeline and "rpm" in pipeline and \ + not pipeline["build"]["passed"] and pipeline["deb"]["passed"] \ + and pipeline["rpm"]["passed"]: + summary += "\n" + summary += "The build job(s) failed, but deb/rpm jobs passed.\n" + summary += "We don't enable external/vty tests when building\n" + summary += "packages, so maybe those failed. Check the logs.\n" + if "lint" in pipeline and not pipeline["lint"]["passed"]: summary += "\n" summary += "Please fix the linting errors. More information:\n"